From unknown Tue Jun 17 20:13:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6498 <6498@debbugs.gnu.org> To: bug#6498 <6498@debbugs.gnu.org> Subject: Status: 24.0.50; [PATCH] Document return value of `make-comint(-in-buffer)' Reply-To: bug#6498 <6498@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:13:40 +0000 retitle 6498 24.0.50; [PATCH] Document return value of `make-comint(-in-buf= fer)' reassign 6498 emacs submitter 6498 =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec severity 6498 normal tag 6498 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 23 09:34:22 2010 Received: (at submit) by debbugs.gnu.org; 23 Jun 2010 13:34:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORQ5u-0001LN-Gs for submit@debbugs.gnu.org; Wed, 23 Jun 2010 09:34:22 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORQ5l-0001LG-41 for submit@debbugs.gnu.org; Wed, 23 Jun 2010 09:34:21 -0400 Received: from lists.gnu.org ([199.232.76.165]:36917) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ORQ5b-0005zP-DF for submit@debbugs.gnu.org; Wed, 23 Jun 2010 09:34:03 -0400 Received: from [140.186.70.92] (port=32772 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORQ5Y-00023H-Bu for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2010 09:34:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ORQ5S-0007U9-Ji for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2010 09:33:56 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:43218) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORQ5S-0007Tv-Et for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2010 09:33:54 -0400 Received: by fg-out-1718.google.com with SMTP id 22so1333823fge.12 for ; Wed, 23 Jun 2010 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:mime-version:content-type; bh=eLdwPTmtEf/m1sBm73Qr/G6AM3+UiwEcHXrBuUaYKjQ=; b=CQ44E5HDFxP8gK9/fFsZubPZ5rxVDiLxYSGP9Sil9bC6iIk7LAYmekh8BrDKOJM5Cj tVE4GZ7LKAFZEPyCvWoOMpOY+qL7vY/q/ekwu4hMLa2gaVnCf9oHkM0b9ihkRSd0zqqA WuqiENghQP5QxZUUClYO5szBBSQeB+qT/5btA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; b=NVj6Gm6FMf3OZq+VsvA8cM9ZqD5EKruBrziLag9X3H4MBIxPY0aipWAuJuzIU/wuo1 r24fWJKYx6TBaLHnng5Tfi0szlRu854gp50FSBaP/wImw0OEabYvtYSeTSnLP0kKG7Zq elKyTYdUcjHFnrmSrDVfR93RPRpLaWDs1e2yI= Received: by 10.87.47.6 with SMTP id z6mr12801432fgj.13.1277300029057; Wed, 23 Jun 2010 06:33:49 -0700 (PDT) Received: from localhost ([88.103.132.186]) by mx.google.com with ESMTPS id z10sm13217159fka.31.2010.06.23.06.33.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 23 Jun 2010 06:33:47 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: bug-gnu-emacs@gnu.org Subject: 24.0.50; [PATCH] Document return value of `make-comint(-in-buffer)' Date: Wed, 23 Jun 2010 15:32:58 +0200 Message-ID: <87zkylnab9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tags: patch Return value of these functions is important and should be documented. Patch attached. =C5=A0t=C4=9Bp=C3=A1n --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-Document-return-value-of-make-comint-in-buffer.patch Content-Transfer-Encoding: quoted-printable >From 53b595979732841171de59168f0365b7beb7da56 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?=3DC5=3DA0t=3DC4=3D9Bp=3DC3=3DA1n=3D20N=3DC4=3D9Bmec?=3D = Date: Wed, 23 Jun 2010 15:22:33 +0200 Subject: [PATCH] Document return value of `make-comint(-in-buffer)'. The return value is important (i.e. not some internal "implementation detail") and existing code depends on it (e.g. `run-scheme' and similar). --- lisp/ChangeLog | 5 +++++ lisp/comint.el | 8 ++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index bbdfa9c..0fda5ac 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2010-06-23 =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec (tiny c= hange) + + * comint.el (make-comint, make-comint-in-buffer): Mention return + value in the docstrings. + 2010-06-22 Glenn Morris =20 * textmodes/texinfmt.el (texinfo-format-region) diff --git a/lisp/comint.el b/lisp/comint.el index b097baa..da354f8 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -701,7 +701,9 @@ (defun make-comint-in-buffer (name buffer program &opti= onal startfile &rest swit STARTFILE is the name of a file, whose contents are sent to the process as its initial input. =20 -If PROGRAM is a string, any more args are arguments to PROGRAM." +If PROGRAM is a string, any more args are arguments to PROGRAM. + +Return the (possibly newly created) process buffer." (or (fboundp 'start-file-process) (error "Multi-processing is not supported for this system")) (setq buffer (get-buffer-create (or buffer (concat "*" name "*")))) @@ -725,7 +727,9 @@ (defun make-comint (name program &optional startfile &r= est switches) STARTFILE is the name of a file, whose contents are sent to the process as its initial input. =20 -If PROGRAM is a string, any more args are arguments to PROGRAM." +If PROGRAM is a string, any more args are arguments to PROGRAM. + +Return the (possibly newly created) process buffer." (apply #'make-comint-in-buffer name nil program startfile switches)) =20 ;;;###autoload --=20 1.7.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 02:44:15 2010 Received: (at 6498-done) by debbugs.gnu.org; 24 Jun 2010 06:44:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORgAZ-00088K-H7 for submit@debbugs.gnu.org; Thu, 24 Jun 2010 02:44:15 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORgAX-00088D-Gh for 6498-done@debbugs.gnu.org; Thu, 24 Jun 2010 02:44:13 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1ORgAR-0007cI-6G; Thu, 24 Jun 2010 02:44:07 -0400 To: 6498-done@debbugs.gnu.org Subject: Re: bug#6498: 24.0.50; [PATCH] Document return value of `make-comint(-in-buffer)' References: <87zkylnab9.fsf@gmail.com> From: Glenn Morris X-Spook: Merlin Blowpipe Area 51 rs9512c pink noise afsatcom X-Ran: (0OYV}vd(QRTUe$>fC3?{AHC.|^r7#fGlbgh@Y18o}hbK;%^MpEyeNO6{n'd7bb.dFYns6 X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 24 Jun 2010 02:44:06 -0400 In-Reply-To: <87zkylnab9.fsf@gmail.com> (=?utf-8?B?IsWgdMSbcMOhbiBOxJtt?= =?utf-8?B?ZWMiJ3M=?= message of "Wed\, 23 Jun 2010 15\:32\:58 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 6498-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Thanks; applied. Note that typically only the first sentence (and possibly first paragraph) of a doc string use the imperative, so I changed that aspect. See "Documentation Tips" in the Elisp manual. You have several tiny changes in Emacs now, and they do add up. We should really get a copyright assignment or disclaimer before installing any more. The process is straightforward and starts with a simple form to fill out. May I email it to you? From unknown Tue Jun 17 20:13:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 22 Jul 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator