From unknown Thu Aug 14 21:44:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64977 <64977@debbugs.gnu.org> To: bug#64977 <64977@debbugs.gnu.org> Subject: Status: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly Reply-To: bug#64977 <64977@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:44:41 +0000 retitle 64977 29.1; `auth-source-macos-keychain-search' handles :user key i= ncorrectly reassign 64977 emacs submitter 64977 LdBeth severity 64977 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 31 11:47:32 2023 Received: (at submit) by debbugs.gnu.org; 31 Jul 2023 15:47:32 +0000 Received: from localhost ([127.0.0.1]:53303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQV7K-0003UR-VE for submit@debbugs.gnu.org; Mon, 31 Jul 2023 11:47:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQV7F-0003U6-Je for submit@debbugs.gnu.org; Mon, 31 Jul 2023 11:47:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQV74-0008Na-AX for bug-gnu-emacs@gnu.org; Mon, 31 Jul 2023 11:47:14 -0400 Received: from out162-62-57-137.mail.qq.com ([162.62.57.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQV6y-0000pd-V2 for bug-gnu-emacs@gnu.org; Mon, 31 Jul 2023 11:47:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1690818415; bh=IlhZp10kkb+DD7cpjgFtFb17fJm3sGk/aBHRhCSiLnw=; h=Date:From:To:Subject; b=p0Y0urrPjiUniF05SajpQqoGLuQmu0CV2+PcrTGpKOiVG9LAT1aREZsBapdAhB+oj Gx+pWQ7rSWN7dl1hELzrKJLIz69iGpawWYDtK7kg2KSPgKAtL0xo+MPZR2ts4MyoeF +bQAQBKwpjkzHD+q6spucER52uRa1Uv1fHgkmwTo= Received: from Costume-Party.local ([131.204.254.102]) by newxmesmtplogicsvrszb6-0.qq.com (NewEsmtp) with SMTP id BB4120C7; Mon, 31 Jul 2023 23:46:52 +0800 X-QQ-mid: xmsmtpt1690818412tbf357rx8 Message-ID: X-QQ-XMAILINFO: NBrlLnjHQiaZrpn68d3np8aVDRq07YjgSwNumFUA6GkDCkmuVo5q17CSDJpRV5 aHod0HxiGBgAA+qqJ51Vwm0Oo6RAR7BKzaSTpRVZBHCEey/r9oiH2KGDQir/pgOrQZxqcYjLwM6+ hBPAycJFzNO5UcQOkYCB4G2c2/6y14cUSkMvvVkSRKzY64rFZMGNCIuvtP/tQNxMf6DmWiItVAgP ogdbQTpF+0eQnsccf1rqXZTxYdlMhmyOXWH9ShZeqsq1UDCDrlDU8dFoBDy6hfePo+200BYTLUzo N2WBMBEcYI+AMsFqLlQa4PKI6olrdrhGHAVE8cXllmvx/AnmDXhYXov7dkMY8gsef5b4QBECmsUb Mvi1yUwDtcYZpzwQGnrxFEIGhmUO+yUQMF3vHAnZAFNE4vQ7wBcEnaDl5OdzWJPyshxf4oGR0SaE 8ka/pxVFA37Z1ESEHOuf6vpyn7F5q8q/PWeujwp6OC4MV59HlQeLEUZjYXRdAr5vGihzHRZM10JR xU5RzJr4k37WGC+lx7IC761gVPBfioJXF+gKTyLKVwy3+wAjV3kOZf+h8K1XQEy7doyfYygPl65w S27GvErNChDq/fYNrIklzXivhhKA0zRbRnBAvGVR0qPh5+4nkBHt6wWdV8mTUWr/YfN4yVnaoUsN rHKdTva/3qaX2xsKOrjrU1pK82+VV//Bxy06xmFCZ2XQhPEK430+LeF8W22EZmIWNG7zR1EoJ5QN ZILslje5za2QtMeAJtnWxjhDRAplFTQPCZbAigaOsdXYWbDih84fn+bJoC9z7rL0fCYjrJsfonJi +lHahlQ2E/Mntq5a0pm0R5S9RWspZzxWsFniajNObti55nG24Gadugnp+wvvLRk+vmVn1wGIew7Z SF3tBLhhf09Uaw/1i8Jejf7hQkRyHVodjmfneVw3tJQ6o4t1GcRxcXtnKfvzXH91NWbO0NDu6VMb /Sz1AZRTM= X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= Received: by Costume-Party.local (Postfix, from userid 501) id AFA6D20567ED8E; Mon, 31 Jul 2023 10:46:49 -0500 (CDT) Date: Mon, 31 Jul 2023 10:46:49 -0500 X-OQ-MSGID: From: LdBeth To: bug-gnu-emacs@gnu.org Subject: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-apple-darwin21.6.0) MULE/6.0 (HANACHIRUSATO) X-Face: %[!P\u/BKFRGn_9h9|yO"ho?C0ej^LmM}WMb-`Jfj8OsS^^AKmHYGlD@^|7SEA3UzOGPFbB"OFczY?'\JtJ\lR'@&Y5j; s8{$&|3D>^i.U4l2h?1qpD.+{[$~j]vBeHZf^|BGyL8{/`4 X-Attribution: ldb MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: pass client-ip=162.62.57.137; envelope-from=andpuke@foxmail.com; helo=out162-62-57-137.mail.qq.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Right after switched from 28.2, my config that uses `auth-source.el' to retrieve IRC password from macOS keychain stopped working. Here is the backtrace, apparently there is a function in the chain forget to handle the :user provided as a list when searching. Debugger entered--Lisp error: (wrong-type-argument stringp ("ldb")) call-process("/usr/bin/security" nil t nil "find-internet-password" "-g" "-s" "irc.libera.chat" "-a" ("ldb") "-r" "\"irc\"") apply(call-process "/usr/bin/security" nil t nil ("find-internet-password" "-g" "-s" "irc.libera.chat" "-a" ("ldb") "-r" "\"irc\"")) auth-source-macos-keychain-search-items("default" macos-keychain-internet 5000 "irc.libera.chat" "\"irc\"" :type macos-keychain-internet :require (:secret) :user ("ldb") :require (:secret)) apply(auth-source-macos-keychain-search-items "default" macos-keychain-internet 5000 "irc.libera.chat" "\"irc\"" (:type macos-keychain-internet :require (:secret) :user ("ldb") :require (:secret))) auth-source-macos-keychain-search(:backend # :type macos-keychain-internet :max 5000 :require (:secret) :create nil :delete nil :user ("ldb") :host ("irc.libera.chat") :port ("irc") :require (:secret) :max 5000) apply(auth-source-macos-keychain-search :backend # :type macos-keychain-internet :max 5000 :require (:secret) :create nil :delete nil (:user ("ldb") :host ("irc.libera.chat") :port ("irc") :require (:secret) :max 5000)) auth-source-search-backends((# #) (:user ("ldb") :host ("irc.libera.chat") :port ("irc") :require (:secret) :max 5000) 5000 nil nil (:secret)) auth-source-search(:user ("ldb") :host ("irc.libera.chat") :port ("irc") :require (:secret) :max 5000) apply(auth-source-search (:user ("ldb") :host ("irc.libera.chat") :port ("irc") :require (:secret) :max 5000)) erc--auth-source-search(:user ("ldb") :host ("irc.libera.chat") :port ("irc") :require (:secret)) apply(erc--auth-source-search (:user ("ldb") :host ("irc.libera.chat") :port ("irc") :require (:secret))) erc-auth-source-search(:user "ldb") erc--compute-server-password(nil "ldb") erc-determine-parameters("irc.libera.chat" "6697" "ldb" "unknown" "user" nil) erc-open("irc.libera.chat" "6697" "ldb" "unknown" t nil nil nil nil nil "user" nil) erc-tls(:server "irc.libera.chat" :port "6697") #f(compiled-function (&rest _) #)((push-button :args nil :value #("Libera Chat" 0 11 (face font-lock-keyword-face)) :help-echo "Start ERC." :action #f(compiled-function (&rest _) #) :mouse-face highlight :follow-link "\15" :button-overlay # :from # :to #) nil) widget-apply((push-button :args nil :value #("Libera Chat" 0 11 (face font-lock-keyword-face)) :help-echo "Start ERC." :action #f(compiled-function (&rest _) #) :mouse-face highlight :follow-link "\15" :button-overlay # :from # :to #) :action nil) widget-apply-action((push-button :args nil :value #("Libera Chat" 0 11 (face font-lock-keyword-face)) :help-echo "Start ERC." :action #f(compiled-function (&rest _) #) :mouse-face highlight :follow-link "\15" :button-overlay # :from # :to #) nil) widget-button-press(165) funcall-interactively(widget-button-press 165) call-interactively(widget-button-press nil nil) command-execute(widget-button-press) In GNU Emacs 29.1 (build 1, x86_64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6.8 (Build 21G725)) of 2023-07-31 built on Costume-Party.localWindowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.6.8 Configured using: 'configure --with-small-ja-dic CPPFLAGS=-I/opt/pkg/include LDFLAGS=-L/opt/pkg/lib' Configured features: ACL GMP GNUTLS JPEG JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t erc-networks-mode: t recentf-mode: t vertico-mode: t filladapt-mode: t global-page-break-lines-mode: t which-key-mode: t global-paren-face-mode: t override-global-mode: t ctrlf-mode: t ctrlf-local-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package-jump hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package-jump /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package-ensure hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package-ensure /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package-core hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package-core /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package-delight hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package-delight /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package-diminish hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package-diminish /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package-bind-key hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package-bind-key /Users/ldbeth/.emacs.d/elpa/bind-key-20230203.2004/bind-key hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/bind-key /Users/ldbeth/.emacs.d/elpa/use-package-20230426.2324/use-package-lint hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/use-package/use-package-lint /Users/ldbeth/.emacs.d/elpa/flim-20230205.1423/sasl hides /Users/ldbeth/Downloads/emacs-29.1/nextstep/Emacs.app/Contents/Resources/lisp/net/sasl Features: (shadow mel-q-ccl ccl flyspell ispell modb-standard elmo-sendlog elmo-internal elmo-rss elmo-maildir utf-7 elmo-imap4 time-stamp mime-diff lsdb wl-fldmgr wl-template wl-demo wl-thread wl-action wl wl-draft wl-folder elmo-nntp elmo-filter wl-summary wl-refile wl-message wl-mime mime-play filename wl-e21 wl-highlight elmo-mime mmelmo-buffer mmelmo-imap mmimap mmbuffer mmgeneric wl-address wl-util wl-vars wl-version elmo-net elmo-cache elmo-map elmo-dop modb-generic elmo-flag elmo-localdir elmo elmo-signal elmo-msgdb modb modb-entity elmo-date elmo-util elmo-vars elmo-version mime-edit mime-image mime-view mime-conf calist invisible inv-23 mime-setup mail-mime-setup semi-setup advice semi-def mime-parse mime luna eword-encode eword-decode mel path-util pces pces-e20 pces-20 mime-def alist mcs-e20 mcs-20 mcharset std11 pccl pccl-20 broken static apel-ver product timezone emacsbug message yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader sendmail shortdoc bug-reference jka-compr mwim help-fns radix-tree cl-print debug backtrace find-func cus-start cus-load rx orderless vertico-directory erc-list erc-menu erc-join erc-ring erc-pcomplete pcomplete comint ansi-osc ansi-color ring erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc format-spec erc-backend erc-networks erc-common erc-compat erc-loaddefs mail-utils gnutls network-stream url-http url-gw nsm url-auth textsec uni-scripts mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr idna-mapping uni-confusable textsec-check url-queue url-cache shr pixel-fill kinsoku url-file puny svg dom newst-plainview newst-ticker newst-reader newst-backend iso8601 xml time-date recentf tree-widget vc-git diff-mode vc-dispatcher bookmark text-property-search pp disp-table wid-edit cl-extra help-mode edmacro kmacro vertico compat compat-29 filladapt page-break-lines which-key ctrlf thingatpt hl-line dim-paren tecoline spacemacs-buffer spacemacs-light-theme spacemacs-dark-theme spacemacs-theme-autoloads core-autoloads bind-key easy-mmode info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 356680 134770) (symbols 48 22848 15) (strings 32 86294 9713) (string-bytes 1 5357679) (vectors 16 41941) (vector-slots 8 739161 117204) (floats 8 406 749) (intervals 56 13370 879) (buffers 976 32)) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 02 09:23:04 2023 Received: (at 64977) by debbugs.gnu.org; 2 Aug 2023 13:23:04 +0000 Received: from localhost ([127.0.0.1]:49210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRBod-0005VV-NO for submit@debbugs.gnu.org; Wed, 02 Aug 2023 09:23:04 -0400 Received: from mail-108-mta185.mxroute.com ([136.175.108.185]:38801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRBoZ-0005UF-B4 for 64977@debbugs.gnu.org; Wed, 02 Aug 2023 09:23:02 -0400 Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta185.mxroute.com (ZoneMTA) with ESMTPSA id 189b66a725200023b6.001 for <64977@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 02 Aug 2023 13:22:56 +0000 X-Zone-Loop: b82d317cf4de7c435c2b2a4e4423047d4026c3b02891 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4eKsq62Vsud7YrHzdO66bA0rdCdnNvmWhqbPrjaXqVw=; b=P0HioET9ivF6+NWugeDO8KMUZv GtgksgsJ4HwzgvW48tN1k88WGnMYz0vmCbBSeExIDln72S4GSqGwWc0VpeAgcWXs53zbrkR2jta4I Gjl538fi8U5rUEbnfO2+xRIkekRDXskcpvXtILwaxetoL/bVCzt3Zp9zi6IbBtPoFbFT3n381hhoF IpWnMhTaQqBtpWom49sFVC7hmAL6fIz0ihCblvGWlIGn6JaLK3zBHN8BTS6mBhirskB78mHkGNWEr pOlA1vbcN89tWgcjDceVzvtbYIhlf1PjSlG3thAbGhm+3rtXLS5HrZvdv/ZDoe+EJYodL9rj7V8Ag X0C5fjeQ==; From: "J.P." To: LdBeth Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: (LdBeth's message of "Mon, 31 Jul 2023 10:46:49 -0500") References: Date: Wed, 02 Aug 2023 06:22:51 -0700 Message-ID: <87v8dx7f4k.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64977 Cc: 64977@debbugs.gnu.org, emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi LdBeth, LdBeth writes: > Right after switched from 28.2, my config that uses `auth-source.el' > to retrieve IRC password from macOS keychain stopped working. A few comments to the extent this concerns ERC. (Feel free to ignore.) In case you haven't noticed, ERC got pickier in 5.5 regarding the auth-source back ends it supports. Quoting from "(erc) auth-source": See "(auth)Top" for general info on setting up various backends, but keep in mind that some of these may not be compatible. Those currently supported are netrc, plstore, json, secrets, and pass. The recommended move for folks in your situation is to specify your own query function. See "(erc) auth-source functions". As for changing `auth-source-macos-keychain-search-items', that's above my pay grade, but offering up a patch may be your best bet. And if by chance you're keen on seeing ERC adopt macos-keychain as an official back end, additional requirements likely apply. I say that because the back ends comprising our current selection all provide a common set of capabilities, namely, those needed to adapt IRC semantics to a generalized secrets store. The auth-source side is somewhat spelled out in the doc string for `auth-source-search', but ERC derives its idea of the interface mostly from the behavior of the reference back end, netrc. If interested, see test/lisp/erc/erc-services-tests.el and the latter half of test/lisp/auth-source-pass-tests.el for all the particulars. Thanks, J.P. P.S. If replying to this, please Cc. emacs-erc@gnu.org. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 08 18:20:55 2023 Received: (at 64977) by debbugs.gnu.org; 8 Aug 2023 22:20:55 +0000 Received: from localhost ([127.0.0.1]:37867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTV4Q-0000V3-NB for submit@debbugs.gnu.org; Tue, 08 Aug 2023 18:20:55 -0400 Received: from out162-62-57-49.mail.qq.com ([162.62.57.49]:40413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTV4K-0000UU-2d for 64977@debbugs.gnu.org; Tue, 08 Aug 2023 18:20:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1691533238; bh=gudAGdJWKVJiB7ytgSkFQIZhwYk7qidrJSO0+JK+mc0=; h=Date:From:To:Subject; b=muQBJkddIRjEZ9H3GEqkmAYdUEUeq11w9AMg4FWZfmIKoYiED1laP22ZzTezS6C57 fGIyv6X8w+ZzifyydWdkz01oRJHAihq2jHV1cBB9ttNMJ1RK8Fxyn4J9m9mp1d2lrX phlaFCiBVapDiW23Hv0zKiMe2R2EF/uzKKAxc4qQ= Received: from 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net ([68.117.253.195]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id 522A3AC8; Wed, 09 Aug 2023 06:20:34 +0800 X-QQ-mid: xmsmtpt1691533234tgdow3urv Message-ID: X-QQ-XMAILINFO: OKKHiI6c9SH3rpBmR6UgsgjOpZJzQzJM3EkIfY2IJwn4U5CAmCGKVLQi0UB8lT /hsallIGbqlzskNgZ+V0/PHomn8VMnknwke4n6ioaknlngp94rZYQbEjArf5ggS7HjyW3fyIq9XZ GTDABM6vZNj+I2Rd0pdqGMSFJBLEVAh67iP/qDFSme+E+eTXDAa3rLXU+0ueBNhyNT23z2ij2YXD rtsLCZtJQbzUVvRq80ShaHHuiFCFFwkj7talX7T42f8kDPDdQMTkT1MIhM0/tLJsBY8Hzqc3fK2y k6Vg7fLV3eGKrSuEdH1UlkSa0HKy6XydNfwWnyUpzenXPabmnIDePbJZoi/Fey+tqqK1ede0LeZv 2hY6SOStiXPEvR5w5SRbSDH1ERDaef/0j2hPhgwcsPK0hufeP8dfqgDV6IZQkM3QfhtREfhq2XU5 K9q2b+Xa+ckaZEsyzojCmrFmD9HsJekvDGLPr80bIo153nTwbic8c/6mENTK4gFudgun+aa9W443 HUtuQ8aApuugxUvdirSipVvdJf3rIVpbdcYhQScojBC2wA7meIUaj/tWAuXiURVfDt2u45WaBNdy 8SSwJokNpqM+Dbas7Dq7GuvMReCYC8lE70+zwrnyz/dfQvRFKYlnBSSCtiRvTvi3PwbVzCprN3/8 QrcqlvDHr5xA+Q++4yVRpzOrLpkbFFCfs+V7nXZcmgRXzQuqQiGiA/5V+g9f5Gs5YnvTJAvSZM56 Iy9qnlUV9VAMf9B4L0K8QqD/PXAfuA3oWqeEZYzr1C/khpy/wqD/39Solqc8/HL+G4i1L3LUMNdX +SIZLN9hfGCogiHBQivPVXmqwR0xgrGjSfMZGWf7aqLMdMuYngVikmDP7b/zRQXnZbIvSqMk9All QzFGigwm5g3XHDPfaNIE2iggz6a8u5bzEY+KXZwVKS/7Uao1mcbx7Lvr8zOIFK3g== X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= Received: by 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net (Postfix, from userid 501) id 853BA2056BF026; Tue, 8 Aug 2023 17:20:32 -0500 (CDT) Date: Tue, 08 Aug 2023 17:20:32 -0500 X-OQ-MSGID: From: LdBeth To: 64977@debbugs.gnu.org Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-apple-darwin20.6.0) MULE/6.0 (HANACHIRUSATO) X-Face: %[!P\u/BKFRGn_9h9|yO"ho?C0ej^LmM}WMb-`Jfj8OsS^^AKmHYGlD@^|7SEA3UzOGPFbB"OFczY?'\JtJ\lR'@&Y5j; s8{$&|3D>^i.U4l2h?1qpD.+{[$~j]vBeHZf^|BGyL8{/`4 X-Attribution: ldb MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Tue_Aug__8_17:20:32_2023-1" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Finally I get some time looking at this issue. I think the bug is caused by `auth-source-macos-keychain-search-items' forget the fact that :users can be a list of string instead of a string. The `auth-source-macos-keychain-search-items' also did not handle the protocol argument correctly. The `security' command needs the "-r" argument to be a string of 4 characters. This is also fixed in [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.57.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [162.62.57.49 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 64977 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Finally I get some time looking at this issue. I think the bug is caused by `auth-source-macos-keychain-search-items' forget the fact that :users can be a list of string instead of a string. The `auth-source-macos-keychain-search-items' also did not handle the protocol argument correctly. The `security' command needs the "-r" argument to be a string of 4 characters. This is also fixed in [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.57.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [162.62.57.49 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --Multipart_Tue_Aug__8_17:20:32_2023-1 Content-Type: text/plain; charset=US-ASCII Finally I get some time looking at this issue. I think the bug is caused by `auth-source-macos-keychain-search-items' forget the fact that :users can be a list of string instead of a string. The `auth-source-macos-keychain-search-items' also did not handle the protocol argument correctly. The `security' command needs the "-r" argument to be a string of 4 characters. This is also fixed in the patch attached. Best wishes, ldb --Multipart_Tue_Aug__8_17:20:32_2023-1 Content-Type: text/plain; name="patch"; charset=US-ASCII Content-Disposition: attachment; filename="patch" Content-Transfer-Encoding: base64 LS0tIGF1dGgtc291cmNlLmVsLm9sZAkyMDIzLTA4LTA4IDE2OjM3OjQxLjAwMDAwMDAwMCAtMDUw MAorKysgYXV0aC1zb3VyY2UuZWwJMjAyMy0wOC0wOCAxNzowODoyMy4wMDAwMDAwMDAgLTA1MDAK QEAgLTE5NTgsMjAgKzE5NTgsMjMgQEAKICAgICAgICAgIChob3N0cyAoaWYgKGFuZCBob3N0cyAo bGlzdHAgaG9zdHMpKSBob3N0cyBgKCxob3N0cykpKQogICAgICAgICAgKHBvcnRzIChwbGlzdC1n ZXQgc3BlYyA6cG9ydCkpCiAgICAgICAgICAocG9ydHMgKGlmIChhbmQgcG9ydHMgKGxpc3RwIHBv cnRzKSkgcG9ydHMgYCgscG9ydHMpKSkKKyAgICAgICAgICh1c2VycyAocGxpc3QtZ2V0IHNwZWMg OnVzZXIpKQorICAgICAgICAgKHVzZXJzIChpZiAoYW5kIHVzZXJzIChsaXN0cCB1c2VycykpIHVz ZXJzIGAoLHVzZXJzKSkpCiAgICAgICAgICA7OyBMb29wIHRocm91Z2ggYWxsIGNvbWJpbmF0aW9u cyBvZiBob3N0L3BvcnQgYW5kIHBhc3MgZWFjaCBvZiB0aGVzZSB0bwogICAgICAgICAgOzsgYXV0 aC1zb3VyY2UtbWFjb3Mta2V5Y2hhaW4tc2VhcmNoLWl0ZW1zCiAgICAgICAgICAoaXRlbXMgKGNh dGNoICdtYXRjaAogICAgICAgICAgICAgICAgICAgKGRvbGlzdCAoaG9zdCBob3N0cykKICAgICAg ICAgICAgICAgICAgICAgKGRvbGlzdCAocG9ydCBwb3J0cykKLSAgICAgICAgICAgICAgICAgICAg ICAobGV0KiAoKHBvcnQgKGlmIHBvcnQgKGZvcm1hdCAiJVMiIHBvcnQpKSkKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGl0ZW1zIChhcHBseSAjJ2F1dGgtc291cmNlLW1hY29zLWtleWNo YWluLXNlYXJjaC1pdGVtcwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbGwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0eXBl Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWF4Ci0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaG9zdCBwb3J0Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VhcmNoLXNwZWMpKSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICh3aGVuIGl0ZW1zCi0gICAgICAgICAgICAgICAgICAgICAgICAgICh0 aHJvdyAnbWF0Y2ggaXRlbXMpKSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgKGRvbGlzdCAo dXNlciB1c2VycykKKyAgICAgICAgICAgICAgICAgICAgICAgIChsZXQgKChpdGVtcyAoYXBwbHkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIydhdXRoLXNvdXJjZS1tYWNv cy1rZXljaGFpbi1zZWFyY2gtaXRlbXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29sbAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0eXBlCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1heAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBob3N0IHBvcnQgdXNlcgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzZWFyY2gtc3BlYykpKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAod2hlbiBpdGVtcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICh0aHJvdyAnbWF0 Y2ggaXRlbXMpKSkpKSkpKQogCiAgICAgICAgICA7OyBlbnN1cmUgZWFjaCBpdGVtIGhhcyBlYWNo IGtleSBpbiBgcmV0dXJuZWQta2V5cycKICAgICAgICAgIChpdGVtcyAobWFwY2FyIChsYW1iZGEg KHBsaXN0KQpAQCAtMjAwMyw4ICsyMDA2LDkgQEAKICAgICAgICAgICAgICAgICAgICAgIGNvbGxl Y3QgdmFyKSkKICAgICAgJ3V0Zi04KSkpCiAKLShjbC1kZWZ1biBhdXRoLXNvdXJjZS1tYWNvcy1r ZXljaGFpbi1zZWFyY2gtaXRlbXMgKGNvbGwgX3R5cGUgX21heCBob3N0IHBvcnQKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZrZXkgbGFiZWwgdHlw ZSB1c2VyCisoY2wtZGVmdW4gYXV0aC1zb3VyY2UtbWFjb3Mta2V5Y2hhaW4tc2VhcmNoLWl0ZW1z IChjb2xsIF90eXBlIF9tYXgKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaG9zdCBwb3J0IHVzZXIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICZrZXkgbGFiZWwgdHlwZQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmFsbG93LW90aGVyLWtleXMp CiAgIChsZXQqICgoa2V5Y2hhaW4tZ2VuZXJpYyAoZXEgdHlwZSAnbWFjb3Mta2V5Y2hhaW4tZ2Vu ZXJpYykpCiAgICAgICAgICAoYXJncyBgKCwoaWYga2V5Y2hhaW4tZ2VuZXJpYwpAQCAtMjAyMiw0 NyArMjAyNiw0NyBAQAogICAgICh3aGVuIHBvcnQKICAgICAgIChpZiBrZXljaGFpbi1nZW5lcmlj CiAgICAgICAgICAgKHNldHEgYXJncyAoYXBwZW5kIGFyZ3MgKGxpc3QgIi1zIiBwb3J0KSkpCi0g ICAgICAgIChzZXRxIGFyZ3MgKGFwcGVuZCBhcmdzIChsaXN0Ci0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoaWYgKHN0cmluZy1tYXRjaCAiWzAtOV0rIiBwb3J0KSAiLVAiICItciIp Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwb3J0KSkpKSkKLQotICAgICAgKHVu bGVzcyAoZXF1YWwgY29sbCAiZGVmYXVsdCIpCi0gICAgICAgIChzZXRxIGFyZ3MgKGFwcGVuZCBh cmdzIChsaXN0IGNvbGwpKSkpCi0KLSAgICAgICh3aXRoLXRlbXAtYnVmZmVyCi0gICAgICAgIChh cHBseSAjJ2NhbGwtcHJvY2VzcyAiL3Vzci9iaW4vc2VjdXJpdHkiIG5pbCB0IG5pbCBhcmdzKQot ICAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQotICAgICAgICAod2hpbGUgKG5vdCAoZW9i cCkpCi0gICAgICAgICAgKGNvbmQKLSAgICAgICAgICAgKChsb29raW5nLWF0ICJecGFzc3dvcmQ6 IFxcKD86MHhbMC05QS1GXStcXCk/ICpcIlxcKC4rXFwpXCIiKQotICAgICAgICAgICAgKHNldHEg cmV0IChhdXRoLXNvdXJjZS1tYWNvcy1rZXljaGFpbi1yZXN1bHQtYXBwZW5kCi0gICAgICAgICAg ICAgICAgICAgICAgIHJldAotICAgICAgICAgICAgICAgICAgICAgICBrZXljaGFpbi1nZW5lcmlj Ci0gICAgICAgICAgICAgICAgICAgICAgICJzZWNyZXQiCi0gICAgICAgICAgICAgICAgICAgICAg IChsZXQgKCh2IChhdXRoLXNvdXJjZS0tZGVjb2RlLW9jdGFsLXN0cmluZwotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKG1hdGNoLXN0cmluZyAxKSkpKQotICAgICAgICAgICAgICAg ICAgICAgICAgIChsYW1iZGEgKCkgdikpKSkpCi0gICAgICAgICAgIDs7IFRPRE86IGNoZWNrIGlm IHRoaXMgaXMgcmVhbGx5IHRoZSBsYWJlbAotICAgICAgICAgICA7OyBtYXRjaCAweDAwMDAwMDA3 IDxibG9iPj0iQXBwbGVJRCIKLSAgICAgICAgICAgKChsb29raW5nLWF0Ci0gICAgICAgICAgICAg Il5bIF0rMHgwMDAwMDAwNyA8YmxvYj49XFwoPzoweFswLTlBLUZdK1xcKT8gKlwiXFwoLitcXClc IiIpCi0gICAgICAgICAgICAoc2V0cSByZXQgKGF1dGgtc291cmNlLW1hY29zLWtleWNoYWluLXJl c3VsdC1hcHBlbmQKLSAgICAgICAgICAgICAgICAgICAgICAgcmV0Ci0gICAgICAgICAgICAgICAg ICAgICAgIGtleWNoYWluLWdlbmVyaWMKLSAgICAgICAgICAgICAgICAgICAgICAgImxhYmVsIgot ICAgICAgICAgICAgICAgICAgICAgICAoYXV0aC1zb3VyY2UtLWRlY29kZS1vY3RhbC1zdHJpbmcg KG1hdGNoLXN0cmluZyAxKSkpKSkKLSAgICAgICAgICAgOzsgbWF0Y2ggImNydHIiPHVpbnQzMj49 ImFhcGwiCi0gICAgICAgICAgIDs7IG1hdGNoICJzdmNlIjxibG9iPj0iQXBwbGVJRCIKLSAgICAg ICAgICAgKChsb29raW5nLWF0Ci0gICAgICAgICAgICAgIl5bIF0rXCJcXChbYS16XStcXClcIlte PV0rPVxcKD86MHhbMC05QS1GXStcXCk/ICpcIlxcKC4rXFwpXCIiKQotICAgICAgICAgICAgKHNl dHEgcmV0IChhdXRoLXNvdXJjZS1tYWNvcy1rZXljaGFpbi1yZXN1bHQtYXBwZW5kCi0gICAgICAg ICAgICAgICAgICAgICAgIHJldAotICAgICAgICAgICAgICAgICAgICAgICBrZXljaGFpbi1nZW5l cmljCi0gICAgICAgICAgICAgICAgICAgICAgIChhdXRoLXNvdXJjZS0tZGVjb2RlLW9jdGFsLXN0 cmluZyAobWF0Y2gtc3RyaW5nIDEpKQotICAgICAgICAgICAgICAgICAgICAgICAoYXV0aC1zb3Vy Y2UtLWRlY29kZS1vY3RhbC1zdHJpbmcgKG1hdGNoLXN0cmluZyAyKSkpKSkpCi0gICAgICAgICAg KGZvcndhcmQtbGluZSkpKQotICAgICAgOzsgcmV0dXJuIGByZXQnIGlmZiBpdCBoYXMgdGhlIDpz ZWNyZXQga2V5Ci0gICAgICAoYW5kIChwbGlzdC1nZXQgcmV0IDpzZWNyZXQpIChsaXN0IHJldCkp KSkKKyAgICAgICAgKHNldHEgYXJncyAoYXBwZW5kIGFyZ3MgKGlmIChzdHJpbmctbWF0Y2ggIlsw LTldKyIgcG9ydCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0ICIt UCIgcG9ydCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCAiLXIiIChm b3JtYXQgIiUtNHMiIHBvcnQpKSkpKSkpCisKKyAgICAodW5sZXNzIChlcXVhbCBjb2xsICJkZWZh dWx0IikKKyAgICAgIChzZXRxIGFyZ3MgKGFwcGVuZCBhcmdzIChsaXN0IGNvbGwpKSkpCisKKyAg ICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgKGFwcGx5ICMnY2FsbC1wcm9jZXNzICIvdXNyL2Jp bi9zZWN1cml0eSIgbmlsIHQgbmlsIGFyZ3MpCisgICAgICAoZ290by1jaGFyIChwb2ludC1taW4p KQorICAgICAgKHdoaWxlIChub3QgKGVvYnApKQorICAgICAgICAoY29uZAorICAgICAgICAgKChs b29raW5nLWF0ICJecGFzc3dvcmQ6IFxcKD86MHhbMC05QS1GXStcXCk/ICpcIlxcKC4rXFwpXCIi KQorICAgICAgICAgIChzZXRxIHJldCAoYXV0aC1zb3VyY2UtbWFjb3Mta2V5Y2hhaW4tcmVzdWx0 LWFwcGVuZAorICAgICAgICAgICAgICAgICAgICAgcmV0CisgICAgICAgICAgICAgICAgICAgICBr ZXljaGFpbi1nZW5lcmljCisgICAgICAgICAgICAgICAgICAgICAic2VjcmV0IgorICAgICAgICAg ICAgICAgICAgICAgKGxldCAoKHYgKGF1dGgtc291cmNlLS1kZWNvZGUtb2N0YWwtc3RyaW5nCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1hdGNoLXN0cmluZyAxKSkpKQorICAgICAg ICAgICAgICAgICAgICAgICAobGFtYmRhICgpIHYpKSkpKQorICAgICAgICAgOzsgVE9ETzogY2hl Y2sgaWYgdGhpcyBpcyByZWFsbHkgdGhlIGxhYmVsCisgICAgICAgICA7OyBtYXRjaCAweDAwMDAw MDA3IDxibG9iPj0iQXBwbGVJRCIKKyAgICAgICAgICgobG9va2luZy1hdAorICAgICAgICAgICAi XlsgXSsweDAwMDAwMDA3IDxibG9iPj1cXCg/OjB4WzAtOUEtRl0rXFwpPyAqXCJcXCguK1xcKVwi IikKKyAgICAgICAgICAoc2V0cSByZXQgKGF1dGgtc291cmNlLW1hY29zLWtleWNoYWluLXJlc3Vs dC1hcHBlbmQKKyAgICAgICAgICAgICAgICAgICAgIHJldAorICAgICAgICAgICAgICAgICAgICAg a2V5Y2hhaW4tZ2VuZXJpYworICAgICAgICAgICAgICAgICAgICAgImxhYmVsIgorICAgICAgICAg ICAgICAgICAgICAgKGF1dGgtc291cmNlLS1kZWNvZGUtb2N0YWwtc3RyaW5nIChtYXRjaC1zdHJp bmcgMSkpKSkpCisgICAgICAgICA7OyBtYXRjaCAiY3J0ciI8dWludDMyPj0iYWFwbCIKKyAgICAg ICAgIDs7IG1hdGNoICJzdmNlIjxibG9iPj0iQXBwbGVJRCIKKyAgICAgICAgICgobG9va2luZy1h dAorICAgICAgICAgICAiXlsgXStcIlxcKFthLXpdK1xcKVwiW149XSs9XFwoPzoweFswLTlBLUZd K1xcKT8gKlwiXFwoLitcXClcIiIpCisgICAgICAgICAgKHNldHEgcmV0IChhdXRoLXNvdXJjZS1t YWNvcy1rZXljaGFpbi1yZXN1bHQtYXBwZW5kCisgICAgICAgICAgICAgICAgICAgICByZXQKKyAg ICAgICAgICAgICAgICAgICAgIGtleWNoYWluLWdlbmVyaWMKKyAgICAgICAgICAgICAgICAgICAg IChhdXRoLXNvdXJjZS0tZGVjb2RlLW9jdGFsLXN0cmluZyAobWF0Y2gtc3RyaW5nIDEpKQorICAg ICAgICAgICAgICAgICAgICAgKGF1dGgtc291cmNlLS1kZWNvZGUtb2N0YWwtc3RyaW5nIChtYXRj aC1zdHJpbmcgMikpKSkpKQorICAgICAgICAoZm9yd2FyZC1saW5lKSkpCisgICAgOzsgcmV0dXJu IGByZXQnIGlmZiBpdCBoYXMgdGhlIDpzZWNyZXQga2V5CisgICAgKGFuZCAocGxpc3QtZ2V0IHJl dCA6c2VjcmV0KSAobGlzdCByZXQpKSkpCiAKIChkZWZ1biBhdXRoLXNvdXJjZS1tYWNvcy1rZXlj aGFpbi1yZXN1bHQtYXBwZW5kIChyZXN1bHQgZ2VuZXJpYyBrIHYpCiAgIChwdXNoIHYgcmVzdWx0 KQo= --Multipart_Tue_Aug__8_17:20:32_2023-1-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 02:54:37 2023 Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 06:54:37 +0000 Received: from localhost ([127.0.0.1]:48557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiWD-0003mJ-C2 for submit@debbugs.gnu.org; Sat, 12 Aug 2023 02:54:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiWA-0003lx-RP for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 02:54:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUiW5-0006gt-3H; Sat, 12 Aug 2023 02:54:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Plza07YR9mLoj693ZXFZ9Kj+0v7oLSc20SEDrwdENm4=; b=SPGP5vmJ+ojs MJm2mygCKbRtak/XpScc9KSYwnZT6MXAQgSaa8ixFSyq9CbupDHNX6NaDjhEecSVNuqVWEDK2ennN cztC7cT5c2y1ea5tdgO2BY+GcRq8j6NE/pz8BDEX9HjuaJrDB/jpoy0Mmd2V8UqxAPaX+ukH5oj8t mnquhvojHZNKlpcIAvylLXsgwQE22mlK9hu1ZNhKlZwMHdaUEA7zU+EWrth2M7C+UpTv2fzKcTSPo lfN5aua8pZVtu7j0pppXorKFYonN9dba9pprghOE/eQq5e6lOXIS+EVHCCo3y7x+IPJsz3rVDsWS4 7w3pJOiAkbjD/gHyf1USUA==; Date: Sat, 12 Aug 2023 09:55:00 +0300 Message-Id: <831qg8g37f.fsf@gnu.org> From: Eli Zaretskii To: LdBeth , Michael Albinus In-Reply-To: (message from LdBeth on Tue, 08 Aug 2023 17:20:32 -0500) Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64977 Cc: 64977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 08 Aug 2023 17:20:32 -0500 > From: LdBeth > > Finally I get some time looking at this issue. > > I think the bug is caused by `auth-source-macos-keychain-search-items' > forget the fact that :users can be a list of string instead of a string. > > The `auth-source-macos-keychain-search-items' also did > not handle the protocol argument correctly. The `security' command > needs the "-r" argument to be a string of 4 characters. This is also > fixed in the patch attached. Michael, any comments to the problem and the patch? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 07:40:10 2023 Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 11:40:10 +0000 Received: from localhost ([127.0.0.1]:48829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUmyY-00025A-Fg for submit@debbugs.gnu.org; Sat, 12 Aug 2023 07:40:10 -0400 Received: from mout.gmx.net ([212.227.17.22]:51059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUmyW-00024p-98 for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 07:40:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691840398; x=1692445198; i=michael.albinus@gmx.de; bh=wZ8iiYsfJ1wPJnNqRlXZmKD8LJEkm0jMY+moShVk+h8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=tC+1llopkh/+hKTsyNNwJ5eSVf7c0xo4JO6Ugb8fJ5fVfMp2LltZV/io9Tf5wZhBecxX8yz egZNW1fuWoKbKufyqMg2X0f6cBqMuH/ffVwsASAmrHFf1A9IYrawgRDkOrakPgoGLG5cJVAhu ShSD2+RsWSL1ezXCJBWrh9wPd/iKySVsqgu6bfooxvu49l7N+12pxptdpLKnFs7crvU51I/9F uLZ8Ug/Od0xTlrYHJPvNdW1nAUt+ITEy7krZ9E7poPQwSXsX4rY4yjHCgMriz/SzojjcUQQUO 9WkpRwd6qbZGPCCmPRkzMieuw7KkzoHxMmqETq28oA4LqHCpTuyQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mwwdf-1pb2co39Bb-00yRX4; Sat, 12 Aug 2023 13:39:57 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: <831qg8g37f.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Aug 2023 09:55:00 +0300") References: <831qg8g37f.fsf@gnu.org> Date: Sat, 12 Aug 2023 13:39:56 +0200 Message-ID: <87leegqyk3.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:AYhkHYhgog3Y0aTJYTyuN74CQ3yLIMrfF3VFACj5OkpdlJBGKhd 89zc36NAhzX2YGogbIC/BjQTIqH3dPhmNSx+OpN90ITwJoMEV3rxx8cm4qfYVbZQjMKWoYy wq7EkP/EXo2zeDZrGmJnmd/w6uF6+rMpyEeVgm44J2IHX45o3zHHDcCdn3++/5uoCJrY7BL IqQAxay5oOh60guXJAt8Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rB011vaJPYk=;iTWqVc0x3i+lYo9fncnzKA9Q/u+ y/LIJaDkhpAiLHPR/TkG7UoRbz88PAFEwCmo5VCQothwHQ4eNOZrJRW3MJFVDwvLQWrcOzbvk QRMfpdai+OXa0hCaQlTHbyZrDzYbyHr0bN2Yf6GcccYLm6fafu9ssRJ3obmQzEvZCHHgfibH9 1bb5i2nBnh4kOoEMVKbN/TUIFoNtpXpJsnGBQNUQxbPJYWmcWG+oJvS3J2jogSN9FUdYG/Oqs kG0uUamxM+0nHwZtZYH2FCkuegZfUE/JMyH/DQtWDhPNTCT9Xp3GgMcd152hRcxt/nk3E43tD OpkRR0AsM2UeKU9emDwYL2Bn/ipOiUWWDZqciyF5D68jqJSmlWlGt5XL1RXPteKO+Ol9jOOsx c0z5PBLfRglj8w+x/MNtm3yILoe4KQHiR7NYwC430d2QBQ1+loX6RzfyN/bHLsT9tqIi70Ozs aTt3ijKwD9MofyDpn7m/b99vr8qdaT29VdsnsfbzR+MJfiWaI2bH04SiCcpcyxSoifECxB3jU MKmDjNOaDYCGE6C0d/cauFwzpZvxa3iQ6ZcqN4QNT1APvUXd2csvixBli882qceWPzxlOjgRO rxtiwnzMW+yGXy09rhld+EWqGiztRFwf5v/6E2Kf9xYhFVAQD2lO1+7xKT4mLLu5KEsVqiyBa tyoT/5Z3OEopns1RiJwUImzgCuu9vSIBprwFI8nikxj3qDeG2vpcNtqdXD5ixpT0gTqy6JyMC zPcOep0Z6K1bJlD+ZbXiViDoKny6LXeZnZV1KYpTjEYU+p7M12KRI+wRJRORcpeR0sNoPBOvW lknH8W3J4SoRozUbDDpTVBMbMkqq2nE8SrqpGboAG28dUTvT4cjIRXZxMMzuhrKDWFxGMGH+J PNrJfd5K5G/mcE6X/kH5kqPoaCajUOx/toUlfCDmEFWumzhLcF1xb0e3XwjNRiXoHHjrcjYkv LhdXzz4dFTliDul85tJ/vVL9SrU= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64977 Cc: LdBeth , 64977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, >> Finally I get some time looking at this issue. >> >> I think the bug is caused by `auth-source-macos-keychain-search-items' >> forget the fact that :users can be a list of string instead of a string= . >> >> The `auth-source-macos-keychain-search-items' also did >> not handle the protocol argument correctly. The `security' command >> needs the "-r" argument to be a string of 4 characters. This is also >> fixed in the patch attached. > > Michael, any comments to the problem and the patch? The change in :user seems to be OK. I cannot comment the change in :port, because I don't use macOS, and cannot test anything. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 09:00:49 2023 Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 13:00:49 +0000 Received: from localhost ([127.0.0.1]:48876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUoEa-0004RX-RO for submit@debbugs.gnu.org; Sat, 12 Aug 2023 09:00:49 -0400 Received: from out203-205-251-82.mail.qq.com ([203.205.251.82]:37150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUoEU-0004RC-MY for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 09:00:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1691844927; bh=Iz3tIH/Z9qfDRaQhjYZ2c81UqytozXgJQik+WVWRJM4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Ettwjj2EGhQBCFE+TNMNpDk/3jsUAqA9F8WQC08El/YbNwAWEyhCB4Fr+WqqwRiCj tYrGw2jylXdaqr2qyDh+polg2tjVNgvngqrQM6s1Dt3aOa927Mgc/aMbB1QUZa7WuL qjyKcFafAy5EKAVmEhdl07Lu71EgYqe6kY7X50UI= Received: from 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net ([68.117.253.195]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id DD704C64; Sat, 12 Aug 2023 20:55:23 +0800 X-QQ-mid: xmsmtpt1691844923tpz7uu178 Message-ID: X-QQ-XMAILINFO: N3l5ASPewLWq5dfP1gcHpukblXPKGQNy8sr/KkDGlNAP3lWpIqCB4Cproa0Fyt QSiGeiushU1pP75AKZWLf9EP7sBznMwyAacH90zCPvRTrm25+6YzhXYr/mugJK8DCAKLZepaCE2X R/BG9+VItJOOYz7GDbrrnFM/e4hbo9EPbaINhlBM7tYfI/TL1g3NITBe9fSeJ1XNooa4o/9DCjjn lUQZs46XvKdGFHKbvQDjTADqJVsEZyG6DimU6h6JNJzrQ+7TVq9Kj9M4uCM5p3IuKk+5dsFCOrVz 7SlFH+MmJgodpUCFqlb8RyzGC2PRYGXPaTVpcfvySQ7fIsIv/buRtL2vreIOw9Vqsb+wcf8SYp76 barRBw/vfJBDI3Mqi+GlZRrV17Cq/DszmjGgS47DQHfYi3DKc5MNdivvf31WoSf0xwjA8vXplWzX SEgR1wUJmlw1BXa/NjNsq3jDRHUb3styHjTvhbTRxmAbZXp/9E7Ku/EJySmrlngjY6cnIOJoRUzo pimRdOeVoioLeKqjveg72/kydzA5bA4Ygi8gexpNFJCG5Yj5PlRlckx53LZLzm2zDf1jAQYamc0Y XBXdas+ZXB3jsN+bQAd1J7r0yc3Efki8DYX9YFA/1egTPeqnJQvvaUKnhG7pyfYGfeD4kZXAL7vN U4d9NEdLiy2tfIiF+dyfusaqLk+eFR4+5I5dAfNEMvo5SrOXG1LUWklrvJ/D94VRV+EYpjZVPle2 H41mZMTUtILOUTsKTQ2C8amqivufKP6Wqih+6iyeAZAzhFdjYj3vCJUj5XbdZilBSkRKDoAFFQEs hcMQ7YoX1Nk2tkuI7aVQpl4DQ/u51O6KcAZDzn7hsDlOtJLxCSEY55E5GxTxG1uaA54qMRNPyUG1 /WKO6FE8bAZphObm1HWuh360cPnv1jO4IkweUkhdrSJGqKnOk0KnIZGkCvRBi/DEzs9NT+mwwj X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= Received: by 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net (Postfix, from userid 501) id EED2D2056E3CEF; Sat, 12 Aug 2023 07:55:21 -0500 (CDT) Date: Sat, 12 Aug 2023 07:55:21 -0500 X-OQ-MSGID: From: LdBeth To: Michael Albinus Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: <87leegqyk3.fsf@gmx.de> References: <831qg8g37f.fsf@gnu.org> <87leegqyk3.fsf@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-apple-darwin20.6.0) MULE/6.0 (HANACHIRUSATO) X-Face: %[!P\u/BKFRGn_9h9|yO"ho?C0ej^LmM}WMb-`Jfj8OsS^^AKmHYGlD@^|7SEA3UzOGPFbB"OFczY?'\JtJ\lR'@&Y5j; s8{$&|3D>^i.U4l2h?1qpD.+{[$~j]vBeHZf^|BGyL8{/`4 X-Attribution: ldb MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From man security(1): -r protocol Specify protocol (optional four-character SecProtocolType, e.g. "http", "ftp ") https://www.unix.com/man-page/osx/1/security/ Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 64977 Cc: Eli Zaretskii , 64977@debbugs.gnu.org, LdBeth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From man security(1): -r protocol Specify protocol (optional four-character SecProtocolType, e.g. "http", "ftp ") https://www.unix.com/man-page/osx/1/security/ Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.251.82 listed in list.dnswl.org] 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager =46rom man security(1): -r protocol Specify protocol (optional four-character SecProtocolTy= pe, e.g. "http", "ftp ") https://www.unix.com/man-page/osx/1/security/ To test this function, first add password using: $ security add-internet-password -s irc.libera.chat -a ldb -r 'irc ' -w 'pa= sswd' In emacs, use something like (auth-source-search :user "ldb" :port "irc") should about to retrieve the password. ldb >>>>> In <87leegqyk3.fsf@gmx.de>=20 >>>>> Michael Albinus wrote: > Eli Zaretskii writes: > Hi Eli, >>> Finally I get some time looking at this issue. >>> >>> I think the bug is caused by `auth-source-macos-keychain-search-items' >>> forget the fact that :users can be a list of string instead of a string. >>> >>> The `auth-source-macos-keychain-search-items' also did >>> not handle the protocol argument correctly. The `security' command >>> needs the "-r" argument to be a string of 4 characters. This is also >>> fixed in the patch attached. >> >> Michael, any comments to the problem and the patch? > The change in :user seems to be OK. I cannot comment the change in > :port, because I don't use macOS, and cannot test anything. > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 09:14:26 2023 Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 13:14:26 +0000 Received: from localhost ([127.0.0.1]:48880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUoRm-0004lp-HE for submit@debbugs.gnu.org; Sat, 12 Aug 2023 09:14:26 -0400 Received: from mout.gmx.net ([212.227.15.18]:42397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUoRh-0004lZ-V5 for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 09:14:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691846052; x=1692450852; i=michael.albinus@gmx.de; bh=YfOINpyQlu7fsSmUy1zFi5UNW2sqKvLs5eWAbcGkYhk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=mhQVMThtc3uDsfnqeRZLhgP+TT7S2l1lNJ8oW3OFXZw0rRpDlM+5XrubMsCeIC7UE6Bm2QA r+5KHa4Imt3hyZEp6UML2MnCmhPc9B/m7s+rwd/TouAODUF4nAEo63C+oos1TlIHq1XBjdVhS TMcPQxnQEm6qWcke23T3cNJgxaOjDj87Dg3Jw+iGS4VMVZ4pQtGl+ptneUs0uUon0Ro+o4yc5 7KZqb7hemAO5J+ID00uW1mHptSXRrDZh7B1uEJyugF/kJX8dVYci8zLvpQF+ttdBh+lVBGpkK EfFGdAgYCb0uXcEPLRcXoyRvPdL9hrEvt29/salryYzpNyv+W17g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhD6W-1pqXwn3pzO-00eKWw; Sat, 12 Aug 2023 15:14:12 +0200 From: Michael Albinus To: LdBeth Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: (LdBeth's message of "Sat, 12 Aug 2023 07:55:21 -0500") References: <831qg8g37f.fsf@gnu.org> <87leegqyk3.fsf@gmx.de> Date: Sat, 12 Aug 2023 15:14:10 +0200 Message-ID: <87wmy0z9lp.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:XhE7An4ZumDQSHqh7teO3gpagvkEtTYaVeUX0IXo+rnIxJexT5s VYJ9BaKFmjwvyysKlc8ovsGqRM5z2ljre4Sjm/HvXEX1JRfW4EfyyXD5T34/ORdYB9MnMcL o1IlFvBJotAmHb6RM7exhGPeAXbnp0RlMkuW914FxVz8O+M35C7fuTy9/CyDZYzc5cFGttV dHtT3BaQecEe+k0ruxS7w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:mMIc4j2UgCw=;w5liYgRSSRfQ7opLOtn/5KusnqI YVsAY8zVB2R1S6CQyCPpLD/3vhK4m9L4QhbFatb7coFe5J3nRoXKbrhxGakv6LN7+Fidl0fQ3 qQ9RRWQ7sBu2Vx+41r2kw5KV4EoRlWfdXz7ZIcLzwHRybct+vf4H98BbQUhwz92vAv5CpDL0H e2hce3tp1YtHB/g05AlJ2PY3P5sC8ezlbPMVv6hAA+4m04Ix5Uzow30lg2P0grbBigA3OjBIM N54x75lffOHCdcWBOhFs5RABaZt//nG/fjchrkkOfxVHem46IjkPrwm6/fWDNxG2liaETjIgV 2gHB/9cKsYdceZDSKaxPyuDXayXIWEKs1MhLRrnzhELsnOkk8cXxCp/qF0Dvp/6/aevrVohEG tAjF3ghLdyAj+5QaccJ8DDu4XtiRnBrIvxyBBzIk0WlAZouDklpyHTbMKFb53QHnbtOHrEugc 5Q08Mx0Stqf9wFs4Gc5w4u96RdG8I0NZbCMJsTzf3CeRmt0X6TrdB1haplFMASXBYcuTRPWXy qsYECIMTEasdZ2sPNHQGF6+uDDF3UkgSe9xRIOgWShgRSMgZGV8K/fkjaU1elvlHzWHwd7Tjg TyQgQmKv5eTAS0RomJzVcQHyBGaQ0mh8bbJUnKiKs+nSZlafyRAxviVKwPy3tBTX4yvE4bOGx 0rGFctAZ/bPJyrREEpH1sIi6vNtqGM2cSqS+L/zJgj3rK6mtqr8YUUv0HCVcbcObWV8IM6CWq dN/EcbFvsZRv5XMezIoKJHf0yMEEqd+m8mvhriXBdQWi29ewunDbNz8znddDTJuoSHrbjyMDF Fg28kEd6tJ90B5iJbyiTJQCBbY6rLWcWny0M8D+A4doGgQ8J0CAgKnM/zDGRkrn3sOWb0GVYn n6qnC68mG113KG9RqEd/d0sCm48DVxryDmLhqmvJWD/VZd2gmQN4Wev725Jvd+ZLndlf0opj3 UDiYMaXGSSeLnDHwOudUWzBPe8g= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64977 Cc: Eli Zaretskii , 64977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) LdBeth writes: Hi, > To test this function, first add password using: > > $ security add-internet-password -s irc.libera.chat -a ldb -r 'irc ' -w 'passwd' > > In emacs, use something like > > (auth-source-search :user "ldb" :port "irc") > > should about to retrieve the password. Thanbks. Do you believe it is possible to add corresponding tests to auth-source-tests.el, like we have for the netrc and secrets backends? > ldb Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 11:49:16 2023 Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 15:49:16 +0000 Received: from localhost ([127.0.0.1]:56674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUqrc-0000En-6s for submit@debbugs.gnu.org; Sat, 12 Aug 2023 11:49:16 -0400 Received: from out162-62-57-87.mail.qq.com ([162.62.57.87]:50867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUqrY-0000EK-BK for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 11:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1691855344; bh=fMia3PzJFra3AZ2tOTnMvupumO3yKrHavOv6pQ6hRf0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=q36t8kx0OHICzQlAUgAG8ZZP4/QAPWkBjJZ82wjtbB/7peO+fyQG9yXuVeZBBy0Ve ZrKstDfBe55aec7eg9NDzPXx7I8HfrksgSqJ3Hy0u/9UxlBmeKfiQvH0cAQL3AWdgs Hb55tv58Dg2VtMflEnIvGaaBSvZO4OxymXoTb4hY= Received: from 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net ([68.117.253.195]) by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP id A25AE837; Sat, 12 Aug 2023 23:40:37 +0800 X-QQ-mid: xmsmtpt1691854837tn9gs68rx Message-ID: X-QQ-XMAILINFO: MpvVxjO9l39xWuUlXdCLbgDCH6Y5XytpdJE6QKepBHJ94niWB26Pk4J2LQhGKv kpIKDTmnrysdoBJbv6sVUhneE+jQQ649qfeFB6QXjQgiLAnEzAHwwCRLybMJ7V3T/OfTDRianhm/ j2nEHgQ8Zov0kWneJ6b+aYftrQHXSyBnWeO0oDjzxfB9/EHER7jHXhG6bMXckw7huYGDiBXO8H/Y QfAnFY10MU8F6ElMWSAdLiAO6Dvt/KYi/aC6A5uuIPLv89LkrDxuSCm6NmOSPO2WIUVsEYgCRLs8 ut10IzNbYhduhzAiAHKmDRJ9bsCzHcB0TmKfUBY+eWfmixRUH+IouTPX17eFFiC0F/rssCZjf6l5 LO277h0gsLwFziUWA2zz4iiNkQjkNNbaoee9JT8nrB3gvCWSg7Yi+iPI/z2Ld54GrPJQSP3ucbvK zwSiOraew3Hy39SkGIYw7JjNBgTaezJrAluH4FXQj6ag7/SX7EwUjyE/8bZZAPbNhNQefrmKkA7B nxaFOjG+JIOXlTlygnBVzI++48SZMLr1icJUxOAxMuUlFtZXo84TEpa2LmSgholWveQgi7mv37V0 PjuxSYHpINMchv/dc2fSVvEwoCBvbNlstci+1rjYYe+bWv+6a95U7iHaD8cRIx87QKyMLqbvfOpI ONGT2rXguhZOeUuMYGivPI+PjE9bcaczmMC3CQQxCWCvt+/j6TufZUrwJjszoP4in9LCdWMjZyR1 qO3r16e11VHT/+8TDlWc4pSGTlqH372xVLwNg9r/OQFOkmGA4OvV/piH73LwqoqvMxD195WPzUyg g+f3BmfgMbaFEC/m4EpezK7fvoTI3tnmpVajN0ztJ7uOTurvGkPiSw0OjUt6UpBHR7FWqJ6xMdjG JLhvsuUwNjITyES6NlpEytq48ESEaDOkJ/Ye8poBhbgkKiicCZMCZbl6TC6xkNYNcm6v25fWP6Nh En/Uubwck= X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= Received: by 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net (Postfix, from userid 501) id B23242056E935E; Sat, 12 Aug 2023 10:40:36 -0500 (CDT) Date: Sat, 12 Aug 2023 10:40:36 -0500 X-OQ-MSGID: From: LdBeth To: Michael Albinus Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: <87wmy0z9lp.fsf@gmx.de> References: <831qg8g37f.fsf@gnu.org> <87leegqyk3.fsf@gmx.de> <87wmy0z9lp.fsf@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-apple-darwin20.6.0) MULE/6.0 (HANACHIRUSATO) X-Face: %[!P\u/BKFRGn_9h9|yO"ho?C0ej^LmM}WMb-`Jfj8OsS^^AKmHYGlD@^|7SEA3UzOGPFbB"OFczY?'\JtJ\lR'@&Y5j; s8{$&|3D>^i.U4l2h?1qpD.+{[$~j]vBeHZf^|BGyL8{/`4 X-Attribution: ldb MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I think it is possible to use cl-left to redefine `auth-source-macos-keychain-search-items' to avoid calling external security command and just check the argument passed to `call-process'. Something like: Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.57.87 listed in list.dnswl.org] 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 64977 Cc: LdBeth , 64977@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I think it is possible to use cl-left to redefine `auth-source-macos-keychain-search-items' to avoid calling external security command and just check the argument passed to `call-process'. Something like: Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.57.87 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager I think it is possible to use cl-left to redefine `auth-source-macos-keychain-search-items' to avoid calling external security command and just check the argument passed to `call-process'. Something like: (cl-letf (((symbol-function 'call-process) (lambda (&rest r) (print r)))) (auth-source-search :user "ldb" :port "irc")) ("/usr/bin/security" nil t nil "find-internet-password" "-g" "-a" "ldb" "-r" "irc ") ("/usr/bin/security" nil t nil "find-generic-password" "-g" "-a" "ldb" "-s" "irc") ldb >>>>> In <87wmy0z9lp.fsf@gmx.de> >>>>> Michael Albinus wrote: > LdBeth writes: > Hi, >> To test this function, first add password using: >> >> $ security add-internet-password -s irc.libera.chat -a ldb -r 'irc ' -w 'passwd' >> >> In emacs, use something like >> >> (auth-source-search :user "ldb" :port "irc") >> >> should about to retrieve the password. > Thanbks. > Do you believe it is possible to add corresponding tests to > auth-source-tests.el, like we have for the netrc and secrets backends? >> ldb > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 12:03:18 2023 Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 16:03:18 +0000 Received: from localhost ([127.0.0.1]:56696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUr5B-0000fj-Mb for submit@debbugs.gnu.org; Sat, 12 Aug 2023 12:03:17 -0400 Received: from mout.gmx.net ([212.227.17.20]:59553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUr57-0000fP-4z for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 12:03:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691856180; x=1692460980; i=michael.albinus@gmx.de; bh=ZOqnQ7ipUqyJryMCjTjd0fZ8lHOouRoITeca6BOVgb8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Q7ejM7VubO1djlMzZnqlrzMrLMwZLzwzqdOKgNiXJVTAc1lo0rCODXjrR8CWRwhGFv10NN+ M0wNaRDkq8ddrUbUtPZfGDvSCfGOA03MGt3DSkB3WE+LcasYJbSE+QQnAbZERXBJSMKWR5s9i lweUBZaTqFyA5N0BFCFEZTO3Y0By+2DpdIPV7dlxG+C4iCWi0GYmxEcaWrG+t4kW/atlC2zI/ qJa2KhEM2k0ysLn3jXH0ApUp2YImSFjCB9sSU7OGAPyxWSsY3c+zPxwmzqCZziziqFNJAFwnC RIYFFKS6i9stViuBuRcb3rPeDnb+U9JeWzu//pL0Zv2M7ShjPQsw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0Fxf-1pXgDD29FX-00xMRK; Sat, 12 Aug 2023 18:03:00 +0200 From: Michael Albinus To: LdBeth Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: (LdBeth's message of "Sat, 12 Aug 2023 10:40:36 -0500") References: <831qg8g37f.fsf@gnu.org> <87leegqyk3.fsf@gmx.de> <87wmy0z9lp.fsf@gmx.de> Date: Sat, 12 Aug 2023 18:02:59 +0200 Message-ID: <87r0o8z1sc.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:lSF/00mlohSsh3sLnru3IaOUBZTk2zauv2bqugWKRnKkPUKP+o5 sUZPN3QHwM0jQlia4e8JKFp29Z4VDz5t/QAmcAzWgJn6lc1h0KM8d3+L/U6LQ4v/mY5Dka0 wtmsjdCst3JceaaTegfzjw8g82hUrpXTux8YcddJCrT+RXjdRYC0VQME3ejQGjGbM7CsjrN 0j+Yz8dT7rSPgpQkTnbGg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:cT+HRtuftZY=;jcZ4P7VjLXJ4XcrnSo8+kWMl+lt OluekNkhEWG8H912WgV+ZRg2dzW7MiUUqSgL1okHRE+Vq+EeesQkj6Y/cu0qXCAGDSzoPDao5 DVpDt9qNWoik65xY3tgf/U8xY8ShILTuWPoGS3E3kgZA0aeGe9obvAC8mzJGLbcawpCIkt8du dFFbq3Ode0vinSrqNFUBrnc+w9h2Wuj4NGKjKcRPKbDkbUkOtEfkBrxlad1ZDGsZGTx8z6FZS f9vrwVYn859uHR9h/q+GPZbbtUd14PZZqR3HIM4zdyveEE/EnHDi7+tIYRZmn3cgFQRwXBGfX s2FrCHtEIEv6Cl323Lq3aLDkX/25vIdeaNuFIPzLPCH3cbgixlA7HslsjnIlMyoeuUZM8fh6U Sa6KjFwiJ/s+fqGly1MP7oQtzXIcNeiuQN7psqxOMuMYKYV/Gws/Ae02GsrBgNP5oHPuHSucE ApgAhmZI5pfqc8WAc/7WYNOuokzXaZgk2YDVZPQOZyKo/tnDeql3/u9QkdMFs34UKVl4tZeut VEQMjqGbKU0sSSDECQdoRGJs5+GmfeKs7EAgBXTyp900Q89vL7/FU+JnmG5JiBcfVUIkpDf77 2ubqYUtNU+neKI+j2t3B6V/vasOJ31+BoDsb0DgaqPNBzWAkbEFCu5LLZ1eZKLWRS8vgUdHQA pmUnyQS2VjolnybdZyqU5hpE21KV2thm9oy5oVx2Y2OF73ZUB6iF4BI/CGmq2eY11os4f7tkB HVZURhSQ3iDTjrlR1hXF38qvowqTCq3tLcx4GBlYedlWbTROwTKZFr9+B3JEV/jMKG/bvJbUa 2VKujxnuJwLM5206TUZtXF2bHjRo8kpCIKHbPAbIEHRE9Izifi71grFu9efDrT375FuItoSlE Bjd0GuTyIwGV72JhqGSxtqHQkCwAa71nGk0v9sq+3bsFrAUkQI76UfkuSp3bORGnEO3I60fVn BVziQE/cyIo4QBeWq81ZwU36Mg0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64977 Cc: Eli Zaretskii , 64977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) LdBeth writes: Hi, > I think it is possible to use cl-left to redefine > `auth-source-macos-keychain-search-items' to avoid calling external > security command and just check the argument passed to > `call-process'. > > Something like: > > (cl-letf (((symbol-function 'call-process) (lambda (&rest r) (print r)))) > (auth-source-search :user "ldb" :port "irc")) > > ("/usr/bin/security" nil t nil "find-internet-password" "-g" "-a" "ldb" "-r" "irc ") > > ("/usr/bin/security" nil t nil "find-generic-password" "-g" "-a" "ldb" "-s" "irc") Yes, like this. And in the lambda function, you could check the expected arguments of the "/usr/bin/security" call by `should' and friends. Would you like to add such test(s)? This would give us more confidence that nothing is or will be broken, because people using macOS would test this by default when running "make check", even if they don't care the macOS keychain. > ldb Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 15:07:59 2023 Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 19:08:00 +0000 Received: from localhost ([127.0.0.1]:57488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUtxv-0000EL-6Z for submit@debbugs.gnu.org; Sat, 12 Aug 2023 15:07:59 -0400 Received: from out203-205-221-242.mail.qq.com ([203.205.221.242]:39117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUtxo-0000Dz-7l for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 15:07:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1691866958; bh=vlRrpxAJlQvztQBKUSU0DVzE3JVofBZInhZS7Rc6V9Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=cJXHb35D64k/lOSah5O0GIqMqRBI4cYgbZfcR4RD6vi8SAte/OX0uddl/gL8/uZ99 D8ttzSZ3iiEVCDvZ6Gmfya7uJECc6mnTn9zduke7mvqH6OuoRbDbXKOhE6rP8vcp3c iLTin8vqyNwoGNLuHWMo1QgoTK/9lSV8c8Kj46/k= Received: from 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net ([68.117.253.195]) by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP id A33DACD; Sun, 13 Aug 2023 03:02:35 +0800 X-QQ-mid: xmsmtpt1691866955tqv3s7iuk Message-ID: X-QQ-XMAILINFO: NpFTlkqgAwztQPIY+owxCfLaOHtQVUerlQo3x6fhOm2cQp5zCfktk3UhSvJAs7 FVSVuTi4ydbFql21AxMxqovHNbBvSP09oDduB7TmxmtViQ/6rq0oeDK5Z0tTCzwjXJ3btK5e9uxQ oIIhS/6cA6NL61Z7ctigaGBHIbztphtHWS247bfokJ1cweAdckSKvu7LshkJ94Gv1WLLVCjd5+6F J5aF7EfNYMSr5VfS9QOgHZqd2Hnt2JonfIUSaasLRUCLDo4V/XdldSfeKBN1LdCjwequiLalsXtC i1XHhzPR4QYCGcJ7s62rtCV5uhE8wEqhB5sA0dc+2VwsJJhCt38rSTLhd7VpMIz5mEZ/mRSL4IUQ faR7ZN7aUSwROrUBF+9HCz3qj4K3RbU3Yke5U3EmMjROo0uaXl1HZo+ySgjDj4iLdO/xXmWMsT2z SKCPCxbGd3ZOgbwyizRNhtIX/cKw24Fhsj8mQcMIzDH/em52Xtb5+sPB/qS13NzOuf0BfSh/zghe 9mpbrt2kIhxV8cTq6Jkld+TSbJ1ebbW6I/7YBm6SknMLhtjDDcLpXied/vntJX492C/yl+g5sAJP fZRBzDfGUrENjF9UQuqtLey38+4fQzxzGw02BCmaJmZjlkfUZvYwxX0nzA3h0idMp96xfI/jgrVy 3PV0yNcCqoG+5HqJhTSAb41YOGGSibSiYASLb1IVdX+iRbFBiBwU9RNNx6VoxRs1VqLaczci1icn ioDPNdKh8OvuM5RwdBsN70UEmcNy27lu85qOb1CB484FWcdwp8ztBN8wuOdbl1urP4FB7iUrnnFl jP/dt5mHma+sOgXtfdCdmaLRd8I0TayYAda+3hQJjLJQSlPhP89K1WqUiOiz8MW2jG8Hcm117L+2 Yh29/xAWx32Erfb2oW8jzBu6LSALtK1F2KXy3RqJO0LsM6yRp62Ma5kQZcEDWZa5Hr44FreLSPtD NZpMiBuoE= X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= Received: by 172-12-5-160.lightspeed.sgnwmi.sbcglobal.net (Postfix, from userid 501) id F0C4F2056EB75B; Sat, 12 Aug 2023 14:02:33 -0500 (CDT) Date: Sat, 12 Aug 2023 14:02:33 -0500 X-OQ-MSGID: From: LdBeth To: Michael Albinus Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: <87r0o8z1sc.fsf@gmx.de> References: <831qg8g37f.fsf@gnu.org> <87leegqyk3.fsf@gmx.de> <87wmy0z9lp.fsf@gmx.de> <87r0o8z1sc.fsf@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-apple-darwin20.6.0) MULE/6.0 (HANACHIRUSATO) X-Face: %[!P\u/BKFRGn_9h9|yO"ho?C0ej^LmM}WMb-`Jfj8OsS^^AKmHYGlD@^|7SEA3UzOGPFbB"OFczY?'\JtJ\lR'@&Y5j; s8{$&|3D>^i.U4l2h?1qpD.+{[$~j]vBeHZf^|BGyL8{/`4 X-Attribution: ldb MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Sat_Aug_12_14:02:33_2023-1" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Sure. I have made the test. I also found a issue not covered in my previous patch, that if the protocol is longer than 4 characters it should be truncated. Please have a look at them. ldb --- auth-source.el.old 2023-08-08 16:37:41.000000000 -0500 +++ auth-source.el 2023-08-08 17:08:23.000000000 -0500 @@ -1958,20 +1958,23 @@ (hosts (if (and hosts (listp hosts)) hosts `(,hosts))) (ports [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.242 listed in list.dnswl.org] 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 64977 Cc: LdBeth , 64977@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Sure. I have made the test. I also found a issue not covered in my previous patch, that if the protocol is longer than 4 characters it should be truncated. Please have a look at them. ldb --- auth-source.el.old 2023-08-08 16:37:41.000000000 -0500 +++ auth-source.el 2023-08-08 17:08:23.000000000 -0500 @@ -1958,20 +1958,23 @@ (hosts (if (and hosts (listp hosts)) hosts `(,hosts))) (ports [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.242 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andpuke[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --Multipart_Sat_Aug_12_14:02:33_2023-1 Content-Type: text/plain; charset=US-ASCII Sure. I have made the test. I also found a issue not covered in my previous patch, that if the protocol is longer than 4 characters it should be truncated. Please have a look at them. ldb --Multipart_Sat_Aug_12_14:02:33_2023-1 Content-Type: text/plain; name="patch1"; charset=US-ASCII Content-Disposition: attachment; filename="patch1" Content-Transfer-Encoding: 7bit --- auth-source.el.old 2023-08-08 16:37:41.000000000 -0500 +++ auth-source.el 2023-08-08 17:08:23.000000000 -0500 @@ -1958,20 +1958,23 @@ (hosts (if (and hosts (listp hosts)) hosts `(,hosts))) (ports (plist-get spec :port)) (ports (if (and ports (listp ports)) ports `(,ports))) + (users (plist-get spec :user)) + (users (if (and users (listp users)) users `(,users))) ;; Loop through all combinations of host/port and pass each of these to ;; auth-source-macos-keychain-search-items (items (catch 'match (dolist (host hosts) (dolist (port ports) - (let* ((port (if port (format "%S" port))) - (items (apply #'auth-source-macos-keychain-search-items - coll - type - max - host port - search-spec))) - (when items - (throw 'match items))))))) + (dolist (user users) + (let ((items (apply + #'auth-source-macos-keychain-search-items + coll + type + max + host port user + search-spec))) + (when items + (throw 'match items)))))))) ;; ensure each item has each key in `returned-keys' (items (mapcar (lambda (plist) @@ -2003,8 +2006,9 @@ collect var)) 'utf-8))) -(cl-defun auth-source-macos-keychain-search-items (coll _type _max host port - &key label type user +(cl-defun auth-source-macos-keychain-search-items (coll _type _max + host port user + &key label type &allow-other-keys) (let* ((keychain-generic (eq type 'macos-keychain-generic)) (args `(,(if keychain-generic @@ -2022,47 +2026,49 @@ (when port (if keychain-generic (setq args (append args (list "-s" port))) - (setq args (append args (list - (if (string-match "[0-9]+" port) "-P" "-r") - port))))) - - (unless (equal coll "default") - (setq args (append args (list coll)))) - - (with-temp-buffer - (apply #'call-process "/usr/bin/security" nil t nil args) - (goto-char (point-min)) - (while (not (eobp)) - (cond - ((looking-at "^password: \\(?:0x[0-9A-F]+\\)? *\"\\(.+\\)\"") - (setq ret (auth-source-macos-keychain-result-append - ret - keychain-generic - "secret" - (let ((v (auth-source--decode-octal-string - (match-string 1)))) - (lambda () v))))) - ;; TODO: check if this is really the label - ;; match 0x00000007 ="AppleID" - ((looking-at - "^[ ]+0x00000007 =\\(?:0x[0-9A-F]+\\)? *\"\\(.+\\)\"") - (setq ret (auth-source-macos-keychain-result-append - ret - keychain-generic - "label" - (auth-source--decode-octal-string (match-string 1))))) - ;; match "crtr"="aapl" - ;; match "svce"="AppleID" - ((looking-at - "^[ ]+\"\\([a-z]+\\)\"[^=]+=\\(?:0x[0-9A-F]+\\)? *\"\\(.+\\)\"") - (setq ret (auth-source-macos-keychain-result-append - ret - keychain-generic - (auth-source--decode-octal-string (match-string 1)) - (auth-source--decode-octal-string (match-string 2)))))) - (forward-line))) - ;; return `ret' iff it has the :secret key - (and (plist-get ret :secret) (list ret)))) + (setq args (append args (if (string-match "[0-9]+" port) + (list "-P" port) + (list "-r" (substring + (format "%-4s" port) + 0 4))))))) + + (unless (equal coll "default") + (setq args (append args (list coll)))) + + (with-temp-buffer + (apply #'call-process "/usr/bin/security" nil t nil args) + (goto-char (point-min)) + (while (not (eobp)) + (cond + ((looking-at "^password: \\(?:0x[0-9A-F]+\\)? *\"\\(.+\\)\"") + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "secret" + (let ((v (auth-source--decode-octal-string + (match-string 1)))) + (lambda () v))))) + ;; TODO: check if this is really the label + ;; match 0x00000007 ="AppleID" + ((looking-at + "^[ ]+0x00000007 =\\(?:0x[0-9A-F]+\\)? *\"\\(.+\\)\"") + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "label" + (auth-source--decode-octal-string (match-string 1))))) + ;; match "crtr"="aapl" + ;; match "svce"="AppleID" + ((looking-at + "^[ ]+\"\\([a-z]+\\)\"[^=]+=\\(?:0x[0-9A-F]+\\)? *\"\\(.+\\)\"") + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + (auth-source--decode-octal-string (match-string 1)) + (auth-source--decode-octal-string (match-string 2)))))) + (forward-line))) + ;; return `ret' iff it has the :secret key + (and (plist-get ret :secret) (list ret)))) (defun auth-source-macos-keychain-result-append (result generic k v) (push v result) --Multipart_Sat_Aug_12_14:02:33_2023-1 Content-Type: text/plain; charset=US-ASCII --Multipart_Sat_Aug_12_14:02:33_2023-1 Content-Type: text/plain; name="patch2"; charset=US-ASCII Content-Disposition: attachment; filename="patch2" Content-Transfer-Encoding: 7bit --- auth-source-tests.el.old 2023-08-12 12:55:52.000000000 -0500 +++ auth-source-tests.el 2023-08-12 13:58:28.000000000 -0500 @@ -435,5 +435,25 @@ '((("machine" . "XM") ("login" . "XL") ("password" . "XP")) (("machine" . "YM") ("login" . "YL") ("password" . "YP"))))))) +(ert-deftest test-macos-keychain-search () + "Test if the constructed command line arglist is correct." + (let ((auth-sources '(macos-keychain-internet macos-keychain-generic))) + ;; Redefine `call-process' to check command line arguments. + (cl-letf (((symbol-function 'call-process) + (lambda (_program _infile _destination _display + &rest args) + ;; Arguments must be all strings + (should (cl-every #'stringp args)) + ;; Argument number should be even + (should (cl-evenp (length args))) + (should (cond ((string= (car args) "find-internet-password") + (let ((protocol (cl-member "-r" args :test #'string=))) + (if protocol + (= 4 (length (cadr protocol))) + t))) + ((string= (car args) "find-generic-password") + t)))))) + (auth-source-search :user '("a" "b") :host '("example.org") :port '("irc" "ftp" "https"))))) + (provide 'auth-source-tests) ;;; auth-source-tests.el ends here --Multipart_Sat_Aug_12_14:02:33_2023-1 Content-Type: text/plain; charset=US-ASCII >>>>> In <87r0o8z1sc.fsf@gmx.de> >>>>> Michael Albinus wrote: > LdBeth writes: > Hi, >> I think it is possible to use cl-left to redefine >> `auth-source-macos-keychain-search-items' to avoid calling external >> security command and just check the argument passed to >> `call-process'. >> >> Something like: >> >> (cl-letf (((symbol-function 'call-process) (lambda (&rest r) (print r)))) >> (auth-source-search :user "ldb" :port "irc")) >> >> ("/usr/bin/security" nil t nil "find-internet-password" "-g" "-a" "ldb" "-r" "irc ") >> >> ("/usr/bin/security" nil t nil "find-generic-password" "-g" "-a" "ldb" "-s" "irc") > Yes, like this. And in the lambda function, you could check the expected > arguments of the "/usr/bin/security" call by `should' and friends. > Would you like to add such test(s)? This would give us more confidence > that nothing is or will be broken, because people using macOS would test > this by default when running "make check", even if they don't care the > macOS keychain. >> ldb > Best regards, Michael. --Multipart_Sat_Aug_12_14:02:33_2023-1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 13 12:35:02 2023 Received: (at 64977-done) by debbugs.gnu.org; 13 Aug 2023 16:35:03 +0000 Received: from localhost ([127.0.0.1]:60156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVE3S-0006If-Lp for submit@debbugs.gnu.org; Sun, 13 Aug 2023 12:35:02 -0400 Received: from mout.gmx.net ([212.227.15.15]:49365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVE3Q-0006I5-Fl for 64977-done@debbugs.gnu.org; Sun, 13 Aug 2023 12:35:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691944488; x=1692549288; i=michael.albinus@gmx.de; bh=ak4U7NbF1kzYUMjoy22bbGcdCK0Vk3tw5kcCbaliuMI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=lH713dHvliJotmRAXcM4fgPMpKdnIPLZB5qViKb9vXxPhCpf/VZ2XpJVYLcJgf+xHRcdRXl JYSo8gJM8TiyoV6g2Z9imKVWLHI21UjekKJp3P14ZjMlq3/O8E/73CLFamXo15OrstsQ/F0Lc k2QWNOauICD5/8aenuM3suyOvcylEkel280rlwYDlZp8DBVzbcvOVrOc0w/cQOsomkhxYJleW L5qMukFQ5aRuMIDet6nHAWRVAOI3SJ/HeqvQFBQBdO5OlV4TZv1gFUkm9Pqa/FvjcMjbXhjyn I1J8af37wC+VsSxLfJXmG3nKo8jylR1EolKSCYiZIdCHt3S4b7ZA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MsYqv-1pcicV2uGR-00u4xa; Sun, 13 Aug 2023 18:34:48 +0200 From: Michael Albinus To: LdBeth Subject: Re: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly In-Reply-To: (LdBeth's message of "Sat, 12 Aug 2023 14:02:33 -0500") References: <831qg8g37f.fsf@gnu.org> <87leegqyk3.fsf@gmx.de> <87wmy0z9lp.fsf@gmx.de> <87r0o8z1sc.fsf@gmx.de> Date: Sun, 13 Aug 2023 18:34:47 +0200 Message-ID: <87jztyyk7s.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:iNj8ft21pf84L1RKGt6/4xBgnGpGdKRtujL0riYT8F/Tr0XNeul LfIMx23Pf9G5I7fpakfXJYjkKzIaXhZO5bFnzblj2u+zlHmlWJy/I6lQpJuUVQEI/7uqAJt 6YR9ZyQ03bVhfWfi4ENPlmF41++whrc+Z61mx0PJf0d/2ixib23slvP8fsX6BWk+aQAMhST hCyeeq31SgBLtgAA/soGg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:WEMYfbh7j3k=;vXXN1eMQ+Kjw7S4unrfsKy/lG2S kSvW56eeWhBqaiwJXBZrKLnIXjPkPVDmjc6UADYOSqaNuYXX5HAzC/V6shcH8OjoZrrxa2seP yCY5RUpHNa7YwO6mRXyvu87FaOA3/5Ve5bNsalj6ZPnhClUXzs/JgxrB4VGc1UZqnnRFOVhkZ 0pDy4/T92dxQBFyxFY5bGGCZU+wKHmwA8Q/m56jnGraFrlFgcYoukhEmgk6vSuAJv0vBGv4xJ iRmJFBaxksFZIoODWSfH+QqgBEOVawnN0Qt3p8jkDHBjcNxxQ7CAcyCyGaqZVF+PjcbDk+/dI 92QkinHKI5c26djpRKtASOtCK7z9HubgNUaxQ4NCW7Nfd4MMl9A8jO4b85ZPeqNj7ggGuuCea vvxP6/vDkfEbkvT2qf5UDWLx1cv6LQFuW+4aWVKA3nfLQPffkEoeSPG9JEgR6Dpk5p2/BQS4n x3cO2LHIv5OXmRQk3RGBd/DV1Cjwd2bGF7oX59lffLWrvsTl2vLdw4H2ax3aUdRcSNCqZ2BV8 dDuJ8/b2mCSKLrz+WshOQUMj7eWKyZDc4Rr/5Q+NLToywMPSI3cQQmKjWeHmRl7U4MfFIrbAP br+sEoEtEVUQjt6LaIgY/SNsY7wbNsEjTyNME4VAYaUGrqJA6F44dXRuG4ES3VEp2sbuLQoyo lOR/Phwt8hZ0UC9oH993Mw+VDKFz3SIApoNnKcL1ROFWAxs/2pg0gYnUon9sMuPRkyQ5UDIf7 UEPk3QjlNANQkRdmNhlYjHp1E0a9NpakIdTwhrq9FcyKxEGtk5uH3VxQo/GMkhqlIm2VZvioB 6Gmt2EgowVOxTJm0x24FBrHRSi5uJnA2CBE98AqqGvyCh85Bf6B4pKtK+7ZgPC6bHzvGO/dAa Qa1aQ9lVf5qDpBkiWUNiHFl2cR09n7nTDavFSz8kHHQW6biHwvjlhpRmfp+dCFWA8WuLRdki3 76H/U8HD1HqwJMO+Ct1KwhRoOKg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64977-done Cc: Eli Zaretskii , 64977-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Version: 30.1 LdBeth writes: Hi, > Sure. I have made the test. I also found a issue not covered in my > previous patch, that if the protocol is longer than 4 characters it > should be truncated. Please have a look at them. Thanks, I've pushed your patches to master. Closing the bug. > ldb Best regards, Michael. From unknown Thu Aug 14 21:44:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 11 Sep 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator