Subject: Re: bug#64945: [PATCH] gnu: opencv: Add descriptors for xfeatures2d.

From: Ludovic Courtès <[email-masked]>
Date: Sun, 17 Sep 2023 15:18:44 +0200

Hi,

Ricardo Wurmus <[email-masked]> skribis:

> * gnu/packages/image-processing.scm (opencv)[native-inputs]: Add boost and vgg
> descriptors.
> [arguments]: Place descriptor files in expected locations; do not disable
> xfeatures2d feature.

I’m not familiar with OpenCV but on the surface it LGTM.  Minor nits:

> +             (substitute* "../opencv-contrib/modules/xfeatures2d/CMakeLists.txt"
> +               (("download_(boost|vgg)_descriptors") "#"))

Maybe add a comment above like “;; Disable downloads of Boost and VGG.”.

> +             (for-each (lambda (file)
> +                         (chmod file #o644))

Maybe use ‘make-file-writable’.

Thank you.  :-)

Ludo’.