Subject: Re: bug#64945: [PATCH] gnu: opencv: Add descriptors for xfeatures2d.

From: Ricardo Wurmus <[email-masked]>
Date: Sun, 24 Sep 2023 21:19:42 +0200

Ludovic Courtès <[email-masked]> writes:

> Hi,
>
> Ricardo Wurmus <[email-masked]> skribis:
>
>> * gnu/packages/image-processing.scm (opencv)[native-inputs]: Add boost and vgg
>> descriptors.
>> [arguments]: Place descriptor files in expected locations; do not disable
>> xfeatures2d feature.
>
> I’m not familiar with OpenCV but on the surface it LGTM.  Minor nits:
>
>> +             (substitute* "../opencv-contrib/modules/xfeatures2d/CMakeLists.txt"
>> +               (("download_(boost|vgg)_descriptors") "#"))
>
> Maybe add a comment above like “;; Disable downloads of Boost and VGG.”.
>
>> +             (for-each (lambda (file)
>> +                         (chmod file #o644))
>
> Maybe use ‘make-file-writable’.

Thanks, I made these changes and pushed it with commit
be5bec47f7942a5e4d2a30eadd9a6fa4c715e88b.

-- 
Ricardo