GNU bug report logs - #64925
[PATCH] gnu: renpy: fix image reference paths.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64925 in the body.
You can then email your comments to 64925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: renpy: fix image reference paths.
Date: Fri, 28 Jul 2023 18:42:43 -0600

[Message part 1 (text/plain, inline)]

Guix,

The current version of renpy has errors when generating a basic project 
due to a substitution in the `drop-game-from-paths` phase that changes 
too much. Attached is a patch that fixes this problem.

I do not know if there is a related bug report.

Thanks.

-- 
-Jesse Gibbons

[0001-gnu-renpy-fix-image-reference-paths.patch (text/x-patch, attachment)]

Message #8 received at 64925 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 64925 <at> debbugs.gnu.org
Subject: re: [PATCH] gnu: renpy: fix image reference paths.
Date: Sat, 29 Jul 2023 07:37:06 -0600

[Message part 1 (text/plain, inline)]

The previous patch sent has an artifact from my development. Attached is 
a newer, better patch.

-- 
-Jesse Gibbons

[0001-gnu-renpy-fix-image-reference-paths.patch (text/x-patch, attachment)]

Message #11 received at 64925 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>, 64925 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: renpy: fix image reference paths.
Date: Sat, 29 Jul 2023 16:32:31 +0200

Am Freitag, dem 28.07.2023 um 18:42 -0600 schrieb Jesse Gibbons:
> Guix,
> 
> The current version of renpy has errors when generating a basic
> project due to a substitution in the `drop-game-from-paths` phase
> that changes too much. Attached is a patch that fixes this problem.
Could you do a comparison of 'tree' when invoked on a game created with
unpatched renpy vs. patched renpy?

Cheers

Message #14 received at 64925 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 64925 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: renpy: fix image reference paths.
Date: Sat, 29 Jul 2023 10:25:48 -0600

I should probably point out that I did my research when producing this 
patch and made not of it in the IRC. I would have removed the 
drop-game-from-paths phase if that didn't result in a similar error to 
the one reported from renpy before the patch is applied to guix.

-- 
-Jesse Gibbons

Message #17 received at 64925 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 64925 <at> debbugs.gnu.org
Subject: Fwd: [PATCH] gnu: renpy: fix image reference paths.
Date: Sat, 29 Jul 2023 10:39:22 -0600

[Message part 1 (text/plain, inline)]

I have not been able to verify that this was sent other than that my 
mail client says it was. I sent a follow-up that I can verify actually 
was received and should make more sense after reading this.



-------- Forwarded Message --------
Subject: 	Re: [PATCH] gnu: renpy: fix image reference paths.
Date: 	Sat, 29 Jul 2023 10:12:11 -0600
From: 	Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 	Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 
64925 <at> debbugs.gnu.org




On 7/29/23 08:32, Liliana Marie Prikler wrote:
> Am Freitag, dem 28.07.2023 um 18:42 -0600 schrieb Jesse Gibbons:
>> Guix,
>>
>> The current version of renpy has errors when generating a basic
>> project due to a substitution in the `drop-game-from-paths` phase
>> that changes too much. Attached is a patch that fixes this problem.
> Could you do a comparison of 'tree' when invoked on a game created with
> unpatched renpy vs. patched renpy?

Is this to prove that the patch fixes a problem? Ok.

`guix time-machine --commit=3bb3fddb5c6e79056172e5858cdc0ee0b6b8cfaa -- 
shell --pure renpy -- renpy-launcher`

The launcher window pops up. I click "create new project" and call it 
"vanilla". I go with all the defaults. It reports an error in the 
attached screenshot.


In a clone of the repository, I check out 
3bb3fddb5c6e79056172e5858cdc0ee0b6b8cfaa and apply the most recent 
patch. I also make sure the last line of 
gnu/packages/game-development.scm is renpy.

`guix shell --pure -f gnu/packages/game-development.scm -- renpy-launcher`

A window pops up. I click "create new project" and call it "chocolate". 
I go with all the defaults. The window does not report an error.

In the directory I set renpy to put all the projects, I run
`diff --recursive chocolate/ vanilla/ | tee generated-dir-differences.diff`

The output is attached. Is there anything else you want me to do before 
you accept the patch?

-- 
-Jesse Gibbons

[Message part 2 (text/html, inline)]

[dq85HK56yxQNVrH8.jpg (image/jpeg, inline)]

[generated-dir-differences.diff (text/x-patch, attachment)]

Message #22 received at 64925-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>, 64925-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: renpy: fix image reference paths.
Date: Sun, 30 Jul 2023 07:56:26 +0200

Am Samstag, dem 29.07.2023 um 10:12 -0600 schrieb Jesse Gibbons:
> Is there anything else you want me to do before you accept the patch?
Nope.  I've run some own checks as well, edited the commit message and
pushed it.

Thanks

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.