GNU bug report logs - #64909
[PATCH] * gnu/packages/game-development.scm (godot) [arguments, inputs]: use system brotli

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: TakeV <takev <at> disroot.org>
Subject: bug#64909: closed (Re: [bug#64909] [PATCH vREVISION] gnu: godot:
 Use system brotli)
Date: Sat, 05 Aug 2023 12:38:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#64909: [PATCH] * gnu/packages/game-development.scm (godot) [arguments, inputs]: use system brotli

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 64909 <at> debbugs.gnu.org.

-- 
64909: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64909
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: TakeV <takev <at> disroot.org>, 64909-done <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#64909] [PATCH vREVISION] gnu: godot: Use system brotli
Date: Sat, 05 Aug 2023 14:37:18 +0200

Am Sonntag, dem 30.07.2023 um 08:57 +0200 schrieb Liliana Marie
Prikler:
> Am Donnerstag, dem 27.07.2023 um 21:26 -0700 schrieb TakeV:
> > * gnu/packages/game-development.scm (godot) [arguments,inputs]: use
> > system brotli
> > ---
> 
> In case someone else wants to push this, the proper message (minus
> leading spaces and missing sign-off) would be:
> 
>     gnu: godot: Use system brotli.
>     
>     * gnu/packages/game-development.scm (godot)[source]: Do not
> preserve brotli.
>     [arguments]<#:scons-flags>: Add “builtin_brotli=no”.
>     [inputs]: Add brotli.
> 
> Otherwise, I'm queuing this for Saturday.
queue.pop (this);

Cheers

[Message part 3 (message/rfc822, inline)]

From: TakeV <takev <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: TakeV <takev <at> disroot.org>
Subject: [PATCH] * gnu/packages/game-development.scm (godot) [arguments,
 inputs]: use system brotli
Date: Thu, 27 Jul 2023 19:54:23 -0700

I noticed this todo could be resolved, since the merge was built and
deployed upstream. 

---
 gnu/packages/game-development.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 127cbac127..84bbd68cce 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -2017,10 +2017,6 @@ (define-public godot
                               "assimp"
                               "astcenc"
                               "basis_universal"
-                              ;; TODO: Can unbundle once
-                              ;; <https://github.com/godotengine/godot/pull/79101>
-                              ;; is merged
-                              "brotli"
                               ;; Godot needs ca-certificates.crt, but that is
                               ;; not available in build environment
                               "certs"
@@ -2067,6 +2063,7 @@ (define-public godot
                         "use_volk=no"
                         ;; Avoid using many of the bundled libs.
                         ;; Note: These options can be found in the SConstruct file.
+                        "builtin_brotli=no"
                         "builtin_embree=no"
                         "builtin_enet=no"
                         "builtin_freetype=no"
@@ -2193,6 +2190,7 @@ (define-public godot
      (list pkg-config))
     (inputs
      (list alsa-lib
+           brotli
            dbus
            embree
            enet

base-commit: 35c8d631d2bd63c64e863b5509f29fdcb7f856e6
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.