From unknown Thu Jun 19 14:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64909] [PATCH] * gnu/packages/game-development.scm (godot) [arguments, inputs]: use system brotli Resent-From: TakeV Original-Sender: "Debbugs-submit" Resent-CC: liliana.prikler@gmail.com, iyzsong@envs.net, guix-patches@gnu.org Resent-Date: Fri, 28 Jul 2023 02:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64909@debbugs.gnu.org Cc: TakeV , Liliana Marie Prikler , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Liliana Marie Prikler , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by submit@debbugs.gnu.org id=B.16905130782694 (code B ref -1); Fri, 28 Jul 2023 02:58:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jul 2023 02:57:58 +0000 Received: from localhost ([127.0.0.1]:43345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPDfx-0000hO-Tq for submit@debbugs.gnu.org; Thu, 27 Jul 2023 22:57:58 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPDfw-0000hB-49 for submit@debbugs.gnu.org; Thu, 27 Jul 2023 22:57:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPDfq-0003NT-GE for guix-patches@gnu.org; Thu, 27 Jul 2023 22:57:50 -0400 Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPDfo-0006KT-5Y for guix-patches@gnu.org; Thu, 27 Jul 2023 22:57:50 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id EF5D141615; Fri, 28 Jul 2023 04:57:43 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T1Czk8gQ9Sx4; Fri, 28 Jul 2023 04:57:42 +0200 (CEST) From: TakeV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1690513062; bh=c3LcO7HoJCygcW/l1C5U8tulXGANzj0T73ZGSgGt4FQ=; h=From:To:Cc:Subject:Date; b=AAM9pBWWjTjlsAuLjedIPzv2cTjTs8VZJO3FeLpfB//2HYSJ5g6tEkupLpW9MVpoO Hv29eDSpwghKmT64unhNaQk5omxK2g34TyLsRlRikdgLr28W/tCEIm4wiXYSUhnD1P F9lpvcAKtCWTFnFATMYXdl8wS332+Hn7zsBw2hOrPB4wEK7AKuA27xeGtHXSw7a+/j rYS3Vtyny/y/gzH/bZvrOn0eKkHUT9W59ozZOs5ZGtESXo13vrDlbkm6yaHuw7AMCU 31AaBkfLo8NYJXW0vXle8K188PiaYMcAkckus9vm/Ugs5Dl5ZIwniq6psFyLLOWOyF 8zfs3OlH863SA== Date: Thu, 27 Jul 2023 19:54:23 -0700 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=takev@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) I noticed this todo could be resolved, since the merge was built and deployed upstream. --- gnu/packages/game-development.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 127cbac127..84bbd68cce 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -2017,10 +2017,6 @@ (define-public godot "assimp" "astcenc" "basis_universal" - ;; TODO: Can unbundle once - ;; - ;; is merged - "brotli" ;; Godot needs ca-certificates.crt, but that is ;; not available in build environment "certs" @@ -2067,6 +2063,7 @@ (define-public godot "use_volk=no" ;; Avoid using many of the bundled libs. ;; Note: These options can be found in the SConstruct file. + "builtin_brotli=no" "builtin_embree=no" "builtin_enet=no" "builtin_freetype=no" @@ -2193,6 +2190,7 @@ (define-public godot (list pkg-config)) (inputs (list alsa-lib + brotli dbus embree enet base-commit: 35c8d631d2bd63c64e863b5509f29fdcb7f856e6 -- 2.41.0 From unknown Thu Jun 19 14:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64909] [PATCH vREVISION] gnu: godot: Use system brotli References: In-Reply-To: Resent-From: TakeV Original-Sender: "Debbugs-submit" Resent-CC: liliana.prikler@gmail.com, iyzsong@envs.net, guix-patches@gnu.org Resent-Date: Fri, 28 Jul 2023 04:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64909@debbugs.gnu.org Cc: TakeV , Liliana Marie Prikler , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-Debbugs-Original-Xcc: Liliana Marie Prikler , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 64909-submit@debbugs.gnu.org id=B64909.169051846711198 (code B ref 64909); Fri, 28 Jul 2023 04:28:02 +0000 Received: (at 64909) by debbugs.gnu.org; 28 Jul 2023 04:27:47 +0000 Received: from localhost ([127.0.0.1]:43427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPF4t-0002uY-E0 for submit@debbugs.gnu.org; Fri, 28 Jul 2023 00:27:47 -0400 Received: from knopi.disroot.org ([178.21.23.139]:53512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPF4q-0002uM-7Z for 64909@debbugs.gnu.org; Fri, 28 Jul 2023 00:27:45 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id ADF8A4118A; Fri, 28 Jul 2023 06:27:39 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oEr9PWEyJTNh; Fri, 28 Jul 2023 06:27:38 +0200 (CEST) From: TakeV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1690518458; bh=jRSws4j4msgDgHPw9vo/gDCG3qJ19hXpGVJ6HSIXD1I=; h=From:To:Cc:Subject:Date; b=KB/kiVbH6qQMIa9HyMTZtm83MtJwR6Imsy25zzQpD2gLbcX3ymhklwZO2qWED3laB HJWyVmcUzoGAEA6CAfKY5no+Vpb3AgxnpSmIBPiahkkpLqEQ8MX122sXHLf6z1WNjM JF9P93o+hnTyMVGMHlnBO/0Di6vZx4Ys1QwZWoimTEXUQltnEdIzcxdAMUqfS36FT2 1Rbtj3+at1gjUX7byzHPREJwpbGib8qD/3IMMi4+8DjOvmsYRtkf1Y9e/Vll+C3WAS hBFr09LVBFTfRTlXFMKAP14IHJElb1NfVZoFnnmteXlNVNpaqHfWmThAkhjFqQKW3N ju5Dpls/DpPUA== Date: Thu, 27 Jul 2023 21:26:37 -0700 Message-ID: <2ff9cfb9e606cd4c359e980fcb5d2a47cb2a9279.1690518397.git.takev@disroot.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/game-development.scm (godot) [arguments,inputs]: use system brotli --- gnu/packages/game-development.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 127cbac127..84bbd68cce 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -2017,10 +2017,6 @@ (define-public godot "assimp" "astcenc" "basis_universal" - ;; TODO: Can unbundle once - ;; - ;; is merged - "brotli" ;; Godot needs ca-certificates.crt, but that is ;; not available in build environment "certs" @@ -2067,6 +2063,7 @@ (define-public godot "use_volk=no" ;; Avoid using many of the bundled libs. ;; Note: These options can be found in the SConstruct file. + "builtin_brotli=no" "builtin_embree=no" "builtin_enet=no" "builtin_freetype=no" @@ -2193,6 +2190,7 @@ (define-public godot (list pkg-config)) (inputs (list alsa-lib + brotli dbus embree enet base-commit: 35c8d631d2bd63c64e863b5509f29fdcb7f856e6 -- 2.41.0 From unknown Thu Jun 19 14:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64909] [PATCH vREVISION] gnu: godot: Use system brotli Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 Jul 2023 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: TakeV , 64909@debbugs.gnu.org Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 64909-submit@debbugs.gnu.org id=B64909.1690700280875 (code B ref 64909); Sun, 30 Jul 2023 06:58:02 +0000 Received: (at 64909) by debbugs.gnu.org; 30 Jul 2023 06:58:00 +0000 Received: from localhost ([127.0.0.1]:49252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ0NM-0000E2-KQ for submit@debbugs.gnu.org; Sun, 30 Jul 2023 02:58:00 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:47263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ0NK-0000Dp-Q2 for 64909@debbugs.gnu.org; Sun, 30 Jul 2023 02:57:59 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5217ad95029so4563479a12.2 for <64909@debbugs.gnu.org>; Sat, 29 Jul 2023 23:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690700272; x=1691305072; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=C6eqKL1nedL3BDTC/7VMSAgqM1cKRwPrjctDzU66uqk=; b=M0aGzPVo7LwWDJR713Q6/HvMZI5Jtn1YeJFzul5ELB+7A2ISGy9tzfbz35vhrio1s7 FOp8DqNPRP5UjAQMt7VDCTBykKuZIBJ2+dLvqzMyUlpoAQuQ/rE1++vfzs+iIe4Vn2Cy v1ExXp3+7/ZMO6Go/CE9z1+Tks/6Fozi8hFx3R3JOEz2elREKNK9dQ3+Q+mfRqneIt30 zs7qGe0j/I4YjgyQrfRmZtD939cTBF7XEpbJrNxY+AZ2pwjPK8gB7R7PUOGTR5pdhYhL P+aZKrNnDWf3fXZC4sXR3eql4KlscX6rybm+2/m9E80dyV2g/paaw6pEZS+Uuvkd2Zif WRwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690700272; x=1691305072; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C6eqKL1nedL3BDTC/7VMSAgqM1cKRwPrjctDzU66uqk=; b=kLAGfs9vo7DT8dHf6kwoLc87yV3Eh1oQBdkER+M2mAAxciPcC3y/KqlV8P7EDjek+v Vi+gj9K+R3mvFCx3rAknPEHy3EHOWGappFQhJLElXQyiUUm/5wu7/1/tFIzR43DaaUMK wB96ubqFSQlpvjzxBrge291JJsoSCi1eQDrRhkF3+j+yg7LpV9vOzBQhIc9eTInuNLT6 56NDnY832Bzf29b/jYvkYWB+Xq1qkfV6BDI+BJbJPdbeDdtdKDT4QFFyEsh5LSAC69FC 5neG/fmWiC27viL2mAvhPz+YjyAdqrys063MQFe5ELNp3ovdIHPozIqUnYbGpJXbJ0/U bLew== X-Gm-Message-State: ABy/qLaHbut103bmxo6SeAOgoNjSOldPG4aL2bMjeUZS2h/uV2xCBnCZ C39og8zOKAtDH+vW0pCNGQc= X-Google-Smtp-Source: APBJJlE9DZ60aJC839RXYIY/ckRy0vnkdumw18HlOC6f5UPGA2flkPqapwU5rS8Dj6aj2rcNhCg1Iw== X-Received: by 2002:aa7:d903:0:b0:522:23e8:2c69 with SMTP id a3-20020aa7d903000000b0052223e82c69mr5900333edr.27.1690700272504; Sat, 29 Jul 2023 23:57:52 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id c5-20020aa7d605000000b0051de20c59d7sm3698997edr.15.2023.07.29.23.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jul 2023 23:57:52 -0700 (PDT) Message-ID: <59fd7e1c23ad6c0f868073633d30a249b29a6792.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 30 Jul 2023 08:57:51 +0200 In-Reply-To: <2ff9cfb9e606cd4c359e980fcb5d2a47cb2a9279.1690518397.git.takev@disroot.org> References: <2ff9cfb9e606cd4c359e980fcb5d2a47cb2a9279.1690518397.git.takev@disroot.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 27.07.2023 um 21:26 -0700 schrieb TakeV: > * gnu/packages/game-development.scm (godot) [arguments,inputs]: use > system brotli > --- In case someone else wants to push this, the proper message (minus leading spaces and missing sign-off) would be: gnu: godot: Use system brotli. =20 * gnu/packages/game-development.scm (godot)[source]: Do not preserve br= otli. [arguments]<#:scons-flags>: Add =E2=80=9Cbuiltin_brotli=3Dno=E2=80=9D. [inputs]: Add brotli. Otherwise, I'm queuing this for Saturday. Cheers From unknown Thu Jun 19 14:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64909] [PATCH vREVISION] gnu: godot: Use system brotli. References: In-Reply-To: Resent-From: TakeV Original-Sender: "Debbugs-submit" Resent-CC: liliana.prikler@gmail.com, iyzsong@envs.net, guix-patches@gnu.org Resent-Date: Tue, 01 Aug 2023 01:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64909@debbugs.gnu.org Cc: TakeV , Liliana Marie Prikler , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-Debbugs-Original-Xcc: Liliana Marie Prikler , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 64909-submit@debbugs.gnu.org id=B64909.169085343413532 (code B ref 64909); Tue, 01 Aug 2023 01:31:02 +0000 Received: (at 64909) by debbugs.gnu.org; 1 Aug 2023 01:30:34 +0000 Received: from localhost ([127.0.0.1]:46901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQeDZ-0003WC-Ny for submit@debbugs.gnu.org; Mon, 31 Jul 2023 21:30:33 -0400 Received: from knopi.disroot.org ([178.21.23.139]:38490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQeDX-0003W0-HS for 64909@debbugs.gnu.org; Mon, 31 Jul 2023 21:30:32 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 20B0441BC1; Tue, 1 Aug 2023 03:30:27 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OZd0MrVEPV_i; Tue, 1 Aug 2023 03:30:25 +0200 (CEST) From: TakeV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1690853425; bh=+gIA1uAB9AUOKKFxp8r01/ZkdLL/StMSJorTfzFv8Zw=; h=From:To:Cc:Subject:Date; b=jSmZEfnSzpnOZLh4R98Bb/IcRK/2LIXw1POe42CG0s4aOCzV4Gu937u7x63MTfLAi 3JkYSYPrRDdeL/JTUSjXjeo0+3kxUxb1yCXcpn0VwLu746bt6DGMc9eaDxpwfjCqS+ ONHhLBq6mjBQ3dG6nF5s2Vfp6hRC7iLaUobOcq9gmAtzryH2A6fIqb5b51vRcWcE3R RXhhwYYeX6WJVQlG01n+IQmftatQ6OCVnEOsczUllJYoFhhk26eg+SyY9+6xo1kzSs Rwx9DYJ6C65x/jL4i+nN3WRs/yC7CUFDIjIHxQ1+HPHsrdyG5knTTk6BmD4Cu8/LXo YztaJ7rmFJrMg== Date: Mon, 31 Jul 2023 18:29:14 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Updated the commit. * gnu/packages/game-development.scm (godot)[source]: Do not preserve brotli. [arguments]<#:scons-flags>: Add “builtin_brotli=no”. [inputs]: Add brotli. --- gnu/packages/game-development.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index f4b1a1e1e3..5771b7530f 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -2017,10 +2017,6 @@ (define-public godot "assimp" "astcenc" "basis_universal" - ;; TODO: Can unbundle once - ;; - ;; is merged - "brotli" ;; Godot needs ca-certificates.crt, but that is ;; not available in build environment "certs" @@ -2067,6 +2063,7 @@ (define-public godot "use_volk=no" ;; Avoid using many of the bundled libs. ;; Note: These options can be found in the SConstruct file. + "builtin_brotli=no" "builtin_embree=no" "builtin_enet=no" "builtin_freetype=no" @@ -2193,6 +2190,7 @@ (define-public godot (list pkg-config)) (inputs (list alsa-lib + brotli dbus embree enet base-commit: 39fbc041f92489ec30075a85937c8a38723752dc -- 2.41.0 From unknown Thu Jun 19 14:25:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: TakeV Subject: bug#64909: closed (Re: [bug#64909] [PATCH vREVISION] gnu: godot: Use system brotli) Message-ID: References: <9d69bfba3f741d8eff3af012ce81e4e904d98223.camel@gmail.com> X-Gnu-PR-Message: they-closed 64909 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 64909@debbugs.gnu.org Date: Sat, 05 Aug 2023 12:38:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1691239082-18692-1" This is a multi-part message in MIME format... ------------=_1691239082-18692-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64909: [PATCH] * gnu/packages/game-development.scm (godot) [arguments, inp= uts]: use system brotli which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64909@debbugs.gnu.org. --=20 64909: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64909 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1691239082-18692-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64909-done) by debbugs.gnu.org; 5 Aug 2023 12:37:29 +0000 Received: from localhost ([127.0.0.1]:56048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSGXA-0004qj-NW for submit@debbugs.gnu.org; Sat, 05 Aug 2023 08:37:28 -0400 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:55718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSGX8-0004qW-Jd for 64909-done@debbugs.gnu.org; Sat, 05 Aug 2023 08:37:27 -0400 Received: by mail-ed1-x541.google.com with SMTP id 4fb4d7f45d1cf-5221c6a2d3dso3923883a12.3 for <64909-done@debbugs.gnu.org>; Sat, 05 Aug 2023 05:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691239041; x=1691843841; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=JnzaYX+w81jFAgFcqld0EdvBeINyieVkWWjZEpKdo+g=; b=r6a132Tg59y8ogmcWrOmBj0M4fySZp6rTQ3ceuq0RobZzFkPk/ZYu61G55D0HBUNmx SXSrpcoZKBhtAEwYmnPPF1xHDcGs6fwoGOvAa8I6829YpTVETdZBXIaNxORnscO0Oggr zQslo6ks3AeZEentR74HXM58aU0U5QmycA5Zj58HxLI+rGUimoVwdiIlZG6dygLbs5eJ 2U34+sKW9LwCGT+LLdmLsR79xnmUXwsILXztDEqNobL4SH8+LDqI15SR7Pq5d+HgU8KV lsLOij5OmCJbI30Zdx3khFGl3KB1KEWTVawEdAqzMW5MWX5O3UY1QjWRzE3D12Tk/fgN lVvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691239041; x=1691843841; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JnzaYX+w81jFAgFcqld0EdvBeINyieVkWWjZEpKdo+g=; b=DxQ94Bsj7VlACNYDUB8qYkH6Aa0kMNWKkkNzb0h87L1x2b6wmdy1jJ6u62Qxcw2SGm 1v3BqaSJ2Ylc0fpz6F/sHTos3FTpsN2SSIoC9mvtszZMKHFc6NP/p2F5N2kLDnTxhZT6 kgYS0st1x7c8Cx2aX1mTi6Zi1sQgmuUCrpbNkxcXImVWzJHr+oRmFxVBqnDvOS5FKlLR LXTFPQWEv2o3SqNR5dgcfjZ8r6ouGV0tXDsjGOCW7veseVF46IZ1y+oDILruZ+8xlrkz XYob9pIjbTAgdr+QU9X5Yqcr/Nb076W1hyPYY5CzYyPbjup4toy7/bfAjHiQ95UPqso5 CKgg== X-Gm-Message-State: AOJu0YyMCPPyyojK3d7HyoTrRKrdNsLebNNtRbcep7O4gn60asYDxXpX xGxMbLw6K/Yjfz8rb8wQhOM= X-Google-Smtp-Source: AGHT+IGiphv7pOwC3/fmvZB2B+twq0k+9v2mo2xZ3XbqU0JZej+rC3+iFLKkClehC6WmhByuXflm1w== X-Received: by 2002:aa7:d159:0:b0:522:3855:7ec5 with SMTP id r25-20020aa7d159000000b0052238557ec5mr3828647edo.10.1691239040696; Sat, 05 Aug 2023 05:37:20 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p12-20020aa7d30c000000b00522ce914f51sm2587933edq.67.2023.08.05.05.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Aug 2023 05:37:19 -0700 (PDT) Message-ID: <9d69bfba3f741d8eff3af012ce81e4e904d98223.camel@gmail.com> Subject: Re: [bug#64909] [PATCH vREVISION] gnu: godot: Use system brotli From: Liliana Marie Prikler To: TakeV , 64909-done@debbugs.gnu.org Date: Sat, 05 Aug 2023 14:37:18 +0200 In-Reply-To: <59fd7e1c23ad6c0f868073633d30a249b29a6792.camel@gmail.com> References: <2ff9cfb9e606cd4c359e980fcb5d2a47cb2a9279.1690518397.git.takev@disroot.org> <59fd7e1c23ad6c0f868073633d30a249b29a6792.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64909-done Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 30.07.2023 um 08:57 +0200 schrieb Liliana Marie Prikler: > Am Donnerstag, dem 27.07.2023 um 21:26 -0700 schrieb TakeV: > > * gnu/packages/game-development.scm (godot) [arguments,inputs]: use > > system brotli > > --- >=20 > In case someone else wants to push this, the proper message (minus > leading spaces and missing sign-off) would be: >=20 > =C2=A0=C2=A0=C2=A0 gnu: godot: Use system brotli. > =C2=A0=C2=A0=C2=A0=20 > =C2=A0=C2=A0=C2=A0 * gnu/packages/game-development.scm (godot)[source]: D= o not > preserve brotli. > =C2=A0=C2=A0=C2=A0 [arguments]<#:scons-flags>: Add =E2=80=9Cbuiltin_brotl= i=3Dno=E2=80=9D. > =C2=A0=C2=A0=C2=A0 [inputs]: Add brotli. >=20 > Otherwise, I'm queuing this for Saturday. queue.pop (this); Cheers ------------=_1691239082-18692-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jul 2023 02:57:58 +0000 Received: from localhost ([127.0.0.1]:43345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPDfx-0000hO-Tq for submit@debbugs.gnu.org; Thu, 27 Jul 2023 22:57:58 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPDfw-0000hB-49 for submit@debbugs.gnu.org; Thu, 27 Jul 2023 22:57:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPDfq-0003NT-GE for guix-patches@gnu.org; Thu, 27 Jul 2023 22:57:50 -0400 Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPDfo-0006KT-5Y for guix-patches@gnu.org; Thu, 27 Jul 2023 22:57:50 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id EF5D141615; Fri, 28 Jul 2023 04:57:43 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T1Czk8gQ9Sx4; Fri, 28 Jul 2023 04:57:42 +0200 (CEST) From: TakeV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1690513062; bh=c3LcO7HoJCygcW/l1C5U8tulXGANzj0T73ZGSgGt4FQ=; h=From:To:Cc:Subject:Date; b=AAM9pBWWjTjlsAuLjedIPzv2cTjTs8VZJO3FeLpfB//2HYSJ5g6tEkupLpW9MVpoO Hv29eDSpwghKmT64unhNaQk5omxK2g34TyLsRlRikdgLr28W/tCEIm4wiXYSUhnD1P F9lpvcAKtCWTFnFATMYXdl8wS332+Hn7zsBw2hOrPB4wEK7AKuA27xeGtHXSw7a+/j rYS3Vtyny/y/gzH/bZvrOn0eKkHUT9W59ozZOs5ZGtESXo13vrDlbkm6yaHuw7AMCU 31AaBkfLo8NYJXW0vXle8K188PiaYMcAkckus9vm/Ugs5Dl5ZIwniq6psFyLLOWOyF 8zfs3OlH863SA== To: guix-patches@gnu.org Subject: [PATCH] * gnu/packages/game-development.scm (godot) [arguments, inputs]: use system brotli Date: Thu, 27 Jul 2023 19:54:23 -0700 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , 宋文武 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=takev@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: TakeV X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) I noticed this todo could be resolved, since the merge was built and deployed upstream. --- gnu/packages/game-development.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 127cbac127..84bbd68cce 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -2017,10 +2017,6 @@ (define-public godot "assimp" "astcenc" "basis_universal" - ;; TODO: Can unbundle once - ;; - ;; is merged - "brotli" ;; Godot needs ca-certificates.crt, but that is ;; not available in build environment "certs" @@ -2067,6 +2063,7 @@ (define-public godot "use_volk=no" ;; Avoid using many of the bundled libs. ;; Note: These options can be found in the SConstruct file. + "builtin_brotli=no" "builtin_embree=no" "builtin_enet=no" "builtin_freetype=no" @@ -2193,6 +2190,7 @@ (define-public godot (list pkg-config)) (inputs (list alsa-lib + brotli dbus embree enet base-commit: 35c8d631d2bd63c64e863b5509f29fdcb7f856e6 -- 2.41.0 ------------=_1691239082-18692-1--