From unknown Sun Aug 10 16:46:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6489: vc-annotate-show-changeset-diff-revision-at-line does not work correctly for git Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2010 01:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6489@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12771692978647 (code B ref -1); Tue, 22 Jun 2010 01:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jun 2010 01:14:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQs4m-0002FQ-Ak for submit@debbugs.gnu.org; Mon, 21 Jun 2010 21:14:56 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQs4j-0002FL-FX for submit@debbugs.gnu.org; Mon, 21 Jun 2010 21:14:53 -0400 Received: from lists.gnu.org ([199.232.76.165]:49367) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OQs4f-0004pY-1g for submit@debbugs.gnu.org; Mon, 21 Jun 2010 21:14:49 -0400 Received: from [199.232.76.173] (port=45234 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQs4d-0007Hj-Hx for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:47 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OQs4c-0004pS-Ah for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=AWL autolearn=ham version=3.1.0 Received: from fencepost.gnu.org ([140.186.70.10]:44018) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OQs4c-0004pN-1D for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:46 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OQs4b-00030y-6d for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:45 -0400 From: Dan Nicolaescu Date: Mon, 21 Jun 2010 21:14:44 -0400 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.5 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) vc-annotate-show-changeset-diff-revision-at-line does not work correctly for git, it does not show the correct changeset diff. vc-annotate-show-changeset-diff-revision-at-line calls vc-annotate-show-diff-revision-at-line-internal which calls (vc-call-backend vc-annotate-backend 'previous-revision fname rev) and that will return the SHA1 for the previous commit that changed fname. That's not what we want for a changeset diff. From unknown Sun Aug 10 16:46:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Dan Nicolaescu Subject: bug#6489: closed (Re: bug#6489: vc-annotate-show-changeset-diff-revision-at-line does not work correctly for git) Message-ID: References: X-Gnu-PR-Message: they-closed 6489 X-Gnu-PR-Package: emacs Reply-To: 6489@debbugs.gnu.org Date: Thu, 24 Jun 2010 18:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1277404322-22276-1" This is a multi-part message in MIME format... ------------=_1277404322-22276-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6489: vc-annotate-show-changeset-diff-revision-at-line does not work corre= ctly for git which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6489@debbugs.gnu.org. --=20 6489: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6489 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1277404322-22276-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6489-done) by debbugs.gnu.org; 24 Jun 2010 18:31:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORrD9-0005n1-Ii for submit@debbugs.gnu.org; Thu, 24 Jun 2010 14:31:39 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORrD7-0005mw-3Q for 6489-done@debbugs.gnu.org; Thu, 24 Jun 2010 14:31:37 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1ORrD2-00040a-Uo for 6489-done@debbugs.gnu.org; Thu, 24 Jun 2010 14:31:32 -0400 To: 6489-done@debbugs.gnu.org Subject: Re: bug#6489: vc-annotate-show-changeset-diff-revision-at-line does not work correctly for git References: From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Thu, 24 Jun 2010 14:31:32 -0400 In-Reply-To: (Dan Nicolaescu's message of "Mon\, 21 Jun 2010 21\:14\:44 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6489-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Fixed in emacs-23 branch. ------------=_1277404322-22276-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jun 2010 01:14:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQs4m-0002FQ-Ak for submit@debbugs.gnu.org; Mon, 21 Jun 2010 21:14:56 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQs4j-0002FL-FX for submit@debbugs.gnu.org; Mon, 21 Jun 2010 21:14:53 -0400 Received: from lists.gnu.org ([199.232.76.165]:49367) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OQs4f-0004pY-1g for submit@debbugs.gnu.org; Mon, 21 Jun 2010 21:14:49 -0400 Received: from [199.232.76.173] (port=45234 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQs4d-0007Hj-Hx for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:47 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OQs4c-0004pS-Ah for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=AWL autolearn=ham version=3.1.0 Received: from fencepost.gnu.org ([140.186.70.10]:44018) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OQs4c-0004pN-1D for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:46 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OQs4b-00030y-6d for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 21:14:45 -0400 To: bug-gnu-emacs@gnu.org Subject: vc-annotate-show-changeset-diff-revision-at-line does not work correctly for git From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Mon, 21 Jun 2010 21:14:44 -0400 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) vc-annotate-show-changeset-diff-revision-at-line does not work correctly for git, it does not show the correct changeset diff. vc-annotate-show-changeset-diff-revision-at-line calls vc-annotate-show-diff-revision-at-line-internal which calls (vc-call-backend vc-annotate-backend 'previous-revision fname rev) and that will return the SHA1 for the previous commit that changed fname. That's not what we want for a changeset diff. ------------=_1277404322-22276-1--