GNU bug report logs - #64874
[PATCH] guix: tuned-package: Use target on cross-compile.

Previous Next

Full log

Message #8 received at 64874 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Jean-Pierre De Jesus DIAZ via Guix-patches via <guix-patches <at> gnu.org>,
 64874 <at> debbugs.gnu.org
Cc: dev <at> jpoiret.xyz, me <at> tobias.gr, othacehe <at> gnu.org, ludo <at> gnu.org,
 mail <at> cbaines.net, Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>,
 rekado <at> elephly.net
Subject: Re: [bug#64874] [PATCH] guix: tuned-package: Use target on
 cross-compile.
Date: Wed, 16 Aug 2023 18:51:36 +0200

Hi,

Thanks for the patch.


On Wed, 26 Jul 2023 at 17:37, Jean-Pierre De Jesus DIAZ via Guix-patches via <guix-patches <at> gnu.org> wrote:
> * guix/transformations.scm (tuned-package): Use either bag-target if
>   available or bag-system to select the CPU architecture of the package
>   that is going to be tuned.  This enables the tuning of cross-compiled
>   packages.
>
> Signed-off-by: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
> ---
>  guix/transformations.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/transformations.scm b/guix/transformations.scm
> index 92d9c89c0e..76d0208bf1 100644
> --- a/guix/transformations.scm
> +++ b/guix/transformations.scm
> @@ -510,8 +510,9 @@ (define (lower* . args)
>      ;; leading to an obscure build error, check whether the compiler is known
>      ;; to support MICRO-ARCHITECTURE.  If not, bail out.
>      (let* ((lowered      (apply lower args))
> -           (architecture (match (string-tokenize (bag-system lowered)
> -                                                 %not-hyphen)
> +           (target (or (bag-target lowered)
> +                       (bag-system lowered)))
> +           (architecture (match (string-tokenize target %not-hyphen)

Ludo, WDYT?

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.