GNU bug report logs - #64874
[PATCH] guix: tuned-package: Use target on cross-compile.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64874: closed ([PATCH] guix: tuned-package: Use target on
 cross-compile.)
Date: Sun, 17 Sep 2023 13:09:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 17 Sep 2023 15:08:17 +0200
with message-id <87v8c9x7zy.fsf_-_ <at> gnu.org>
and subject line Re: bug#64874: [PATCH] guix: tuned-package: Use target on cross-compile.
has caused the debbugs.gnu.org bug report #64874,
regarding [PATCH] guix: tuned-package: Use target on cross-compile.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64874: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64874
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
To: guix-patches <at> gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Subject: [PATCH] guix: tuned-package: Use target on cross-compile.
Date: Wed, 26 Jul 2023 17:37:29 +0200

* guix/transformations.scm (tuned-package): Use either bag-target if
  available or bag-system to select the CPU architecture of the package
  that is going to be tuned.  This enables the tuning of cross-compiled
  packages.

Signed-off-by: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
---
 guix/transformations.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/transformations.scm b/guix/transformations.scm
index 92d9c89c0e..76d0208bf1 100644
--- a/guix/transformations.scm
+++ b/guix/transformations.scm
@@ -510,8 +510,9 @@ (define (lower* . args)
     ;; leading to an obscure build error, check whether the compiler is known
     ;; to support MICRO-ARCHITECTURE.  If not, bail out.
     (let* ((lowered      (apply lower args))
-           (architecture (match (string-tokenize (bag-system lowered)
-                                                 %not-hyphen)
+           (target (or (bag-target lowered)
+                       (bag-system lowered)))
+           (architecture (match (string-tokenize target %not-hyphen)
                            ((arch _ ...) arch)))
            (compiler     (any (match-lambda
                                 ((label (? package? p) . _)

base-commit: cf9904bcc8dd03e73675475bb4d8746dc434e415
-- 
2.34.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: dev <at> jpoiret.xyz, me <at> tobias.gr, othacehe <at> gnu.org, mail <at> cbaines.net,
 Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>, rekado <at> elephly.net,
 64874-done <at> debbugs.gnu.org
Subject: Re: bug#64874: [PATCH] guix: tuned-package: Use target on
 cross-compile.
Date: Sun, 17 Sep 2023 15:08:17 +0200

Hi,

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

[...]

>> Ludo, WDYT?
>
> LGTM, thanks for the heads-up!

I went ahead and applied it.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.