GNU bug report logs - #64874
[PATCH] guix: tuned-package: Use target on cross-compile.

Previous Next

Full log

Message #14 received at 64874 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 64874 <at> debbugs.gnu.org, dev <at> jpoiret.xyz, mail <at> cbaines.net, othacehe <at> gnu.org,
 me <at> tobias.gr, Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>,
 rekado <at> elephly.net
Subject: Re: bug#64874: [PATCH] guix: tuned-package: Use target on
 cross-compile.
Date: Wed, 16 Aug 2023 23:54:01 +0200

Hi,

Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

> On Wed, 26 Jul 2023 at 17:37, Jean-Pierre De Jesus DIAZ via Guix-patches via <guix-patches <at> gnu.org> wrote:
>> * guix/transformations.scm (tuned-package): Use either bag-target if
>>   available or bag-system to select the CPU architecture of the package
>>   that is going to be tuned.  This enables the tuning of cross-compiled
>>   packages.
>>
>> Signed-off-by: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
>> ---
>>  guix/transformations.scm | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/guix/transformations.scm b/guix/transformations.scm
>> index 92d9c89c0e..76d0208bf1 100644
>> --- a/guix/transformations.scm
>> +++ b/guix/transformations.scm
>> @@ -510,8 +510,9 @@ (define (lower* . args)
>>      ;; leading to an obscure build error, check whether the compiler is known
>>      ;; to support MICRO-ARCHITECTURE.  If not, bail out.
>>      (let* ((lowered      (apply lower args))
>> -           (architecture (match (string-tokenize (bag-system lowered)
>> -                                                 %not-hyphen)
>> +           (target (or (bag-target lowered)
>> +                       (bag-system lowered)))
>> +           (architecture (match (string-tokenize target %not-hyphen)
>
> Ludo, WDYT?

LGTM, thanks for the heads-up!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.