From unknown Mon Aug 11 21:12:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6487 <6487@debbugs.gnu.org> To: bug#6487 <6487@debbugs.gnu.org> Subject: Status: using vc-annotate-find-revision-at-line for renamed/removed files Reply-To: bug#6487 <6487@debbugs.gnu.org> Date: Tue, 12 Aug 2025 04:12:48 +0000 retitle 6487 using vc-annotate-find-revision-at-line for renamed/removed fi= les reassign 6487 emacs submitter 6487 Dan Nicolaescu severity 6487 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 21 16:41:37 2010 Received: (at submit) by debbugs.gnu.org; 21 Jun 2010 20:41:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQnoH-0007J9-Iw for submit@debbugs.gnu.org; Mon, 21 Jun 2010 16:41:37 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQnoF-0007J2-90 for submit@debbugs.gnu.org; Mon, 21 Jun 2010 16:41:35 -0400 Received: from lists.gnu.org ([199.232.76.165]:50345) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OQnoB-0000mH-24 for submit@debbugs.gnu.org; Mon, 21 Jun 2010 16:41:31 -0400 Received: from [199.232.76.173] (port=40471 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQnoA-00020F-Jk for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 16:41:30 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OQno9-0000mB-MN for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 16:41:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=AWL autolearn=ham version=3.1.0 Received: from fencepost.gnu.org ([140.186.70.10]:56320) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OQno9-0000m7-G4 for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 16:41:29 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OQno9-0001iK-CL for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2010 16:41:29 -0400 To: bug-gnu-emacs@gnu.org Subject: using vc-annotate-find-revision-at-line for renamed/removed files From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Mon, 21 Jun 2010 16:41:29 -0400 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) vc-annotate for git and mercurial shows the original file name for a change, even if the file has been renamed meanwhile. Using `vc-annotate-find-revision-at-line' on such a line in the annotate does not work vc-annotate-find-revision-at-line calls vc-find-revision for a file that does not exist anymore. vc-find-revision in turn does a: (vc-call find-revision file revision outbuf) but given that the file does not exist anymore, no VC backend claims the file, so the vc-call fails vc-annotate-find-revision-at-line knows what VC backend it needs to call, so it could pass it as an optional argument to vc-find-revision. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 21 20:33:58 2010 Received: (at 6487) by debbugs.gnu.org; 22 Jun 2010 00:33:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQrR7-0001kW-Qg for submit@debbugs.gnu.org; Mon, 21 Jun 2010 20:33:58 -0400 Received: from smtp-03.vtx.ch ([194.38.175.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQrR5-0001kR-N2 for 6487@debbugs.gnu.org; Mon, 21 Jun 2010 20:33:56 -0400 Received: from ceviche.home (dyn.83-228-208-118.dsl.vtx.ch [83.228.208.118]) by smtp-03.vtx.ch (VTX Services SA) with ESMTP id BBE4A296DCF; Tue, 22 Jun 2010 02:33:51 +0200 (CEST) Received: by ceviche.home (Postfix, from userid 20848) id E55D966E08; Tue, 22 Jun 2010 02:33:51 +0200 (CEST) From: Stefan Monnier To: Dan Nicolaescu Subject: Re: bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files Message-ID: References: Date: Tue, 22 Jun 2010 02:33:51 +0200 In-Reply-To: (Dan Nicolaescu's message of "Mon, 21 Jun 2010 16:41:29 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 6487 Cc: 6487@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) > vc-annotate-find-revision-at-line knows what VC backend it needs to > call, so it could pass it as an optional argument to vc-find-revision. Indeed, vc-call relies on `vc-backend' which we usually should try to avoid calling (since usually the context already tells us which backend to use and using another one would actually be an error). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 21 22:55:25 2010 Received: (at 6487) by debbugs.gnu.org; 22 Jun 2010 02:55:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQte0-0002ri-Rn for submit@debbugs.gnu.org; Mon, 21 Jun 2010 22:55:24 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQtdy-0002rd-5A for 6487@debbugs.gnu.org; Mon, 21 Jun 2010 22:55:23 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OQtdu-0005gh-PE; Mon, 21 Jun 2010 22:55:18 -0400 To: Stefan Monnier Subject: Re: bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files References: From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Mon, 21 Jun 2010 22:55:18 -0400 In-Reply-To: (Stefan Monnier's message of "Tue\, 22 Jun 2010 02\:33\:51 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6487 Cc: 6487@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Stefan Monnier writes: >> vc-annotate-find-revision-at-line knows what VC backend it needs to >> call, so it could pass it as an optional argument to vc-find-revision. > > Indeed, vc-call relies on `vc-backend' which we usually should try to > avoid calling (since usually the context already tells us which backend > to use and using another one would actually be an error). vc-annotate has the same problem when called from vc-annotate-warp-revision. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 14:31:23 2010 Received: (at 6487-done) by debbugs.gnu.org; 24 Jun 2010 18:31:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORrCs-0005mo-UB for submit@debbugs.gnu.org; Thu, 24 Jun 2010 14:31:23 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORrCq-0005mi-3k for 6487-done@debbugs.gnu.org; Thu, 24 Jun 2010 14:31:20 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1ORrCl-00040R-LS for 6487-done@debbugs.gnu.org; Thu, 24 Jun 2010 14:31:15 -0400 To: 6487-done@debbugs.gnu.org Subject: Re: bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files References: From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Thu, 24 Jun 2010 14:31:15 -0400 In-Reply-To: (Dan Nicolaescu's message of "Mon\, 21 Jun 2010 16\:41\:29 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6487-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Fixed in emacs-23 branch. From unknown Mon Aug 11 21:12:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 23 Jul 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator