GNU bug report logs - #6487
using vc-annotate-find-revision-at-line for renamed/removed files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6487 in the body.
You can then email your comments to 6487 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: using vc-annotate-find-revision-at-line for renamed/removed files
Date: Mon, 21 Jun 2010 16:41:29 -0400

vc-annotate for git and mercurial shows the original file name for a
change, even if the file has been renamed meanwhile.
Using `vc-annotate-find-revision-at-line' on such a line in the annotate does not work

vc-annotate-find-revision-at-line calls vc-find-revision for a file
that does not exist anymore.
vc-find-revision in turn does a:
(vc-call find-revision file revision outbuf)
but given that the file does not exist anymore, no VC backend claims
the file, so the vc-call fails

vc-annotate-find-revision-at-line knows what VC backend it needs to
call, so it could pass it as an optional argument to vc-find-revision.

Message #6 received at 6487 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 6487 <at> debbugs.gnu.org
Subject: Re: bug#6487: using vc-annotate-find-revision-at-line for
	renamed/removed files
Date: Tue, 22 Jun 2010 02:33:51 +0200

> vc-annotate-find-revision-at-line knows what VC backend it needs to
> call, so it could pass it as an optional argument to vc-find-revision.

Indeed, vc-call relies on `vc-backend' which we usually should try to
avoid calling (since usually the context already tells us which backend
to use and using another one would actually be an error).


        Stefan

Message #9 received at 6487 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6487 <at> debbugs.gnu.org
Subject: Re: bug#6487: using vc-annotate-find-revision-at-line for
	renamed/removed files
Date: Mon, 21 Jun 2010 22:55:18 -0400

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> vc-annotate-find-revision-at-line knows what VC backend it needs to
>> call, so it could pass it as an optional argument to vc-find-revision.
>
> Indeed, vc-call relies on `vc-backend' which we usually should try to
> avoid calling (since usually the context already tells us which backend
> to use and using another one would actually be an error).

vc-annotate has the same problem when called from vc-annotate-warp-revision.

Message #14 received at 6487-done <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: 6487-done <at> debbugs.gnu.org
Subject: Re: bug#6487: using vc-annotate-find-revision-at-line for
	renamed/removed files
Date: Thu, 24 Jun 2010 14:31:15 -0400

Fixed in emacs-23 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.