From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: Karl Hallsby Original-Sender: "Debbugs-submit" Resent-CC: mail@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Tue, 25 Jul 2023 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64861@debbugs.gnu.org Cc: Karl Hallsby , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.169030834231949 (code B ref -1); Tue, 25 Jul 2023 18:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jul 2023 18:05:42 +0000 Received: from localhost ([127.0.0.1]:46920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOMPl-0008JF-IR for submit@debbugs.gnu.org; Tue, 25 Jul 2023 14:05:41 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOMPj-0008J2-Hm for submit@debbugs.gnu.org; Tue, 25 Jul 2023 14:05:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOMPc-00059a-BS for guix-patches@gnu.org; Tue, 25 Jul 2023 14:05:33 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOMPa-0001aU-KJ for guix-patches@gnu.org; Tue, 25 Jul 2023 14:05:32 -0400 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-76c4890a220so166872885a.3 for ; Tue, 25 Jul 2023 11:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1690308328; x=1690913128; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Us5bBGdVGqarFjcvlUCXkJvAX9reMuPbZJ8HYWet8+g=; b=RhXJvGQM2jRRwbybvbUf6qPOwoDi20FH5ARmvKHm8NSUrchs4twihStMptbjB6smwj Xr+s2Mf2wwVnhliJoadDER58tDBi7YBvaaqr/kJ+7s89J5eu4QJR1wPKjpwG5xZmaeYR O+vlHN6oWJtte+jkGuzijy1egJy6mxg+I9QDU3kY88wyTZd4Cuw1WwkGKOXb8kSz1/Kj XSflh8oW/lZE/k6xdkiRfQ6J5CevS783kLFehPbj+SF2MAnm3I2oJ84FEvMGdSBwkANe QOGSi49OnbzEqrS0CglgXacFYsh5xwFpYcT+ONsh0LItpdJx+HQp8pa35TogySKjAJNZ 6pZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690308328; x=1690913128; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Us5bBGdVGqarFjcvlUCXkJvAX9reMuPbZJ8HYWet8+g=; b=hIvUNP6UJ5+UEmPtr1CJH3ob2T41ZX2ngM7cVGbt2C/rIvp3uGGlz2aM9npgOu2xtt Eh2dn5ZWYR2T1muNiyc7UXNXBNHoVzivjcq1dgSsMcM5OVBj3H9XWhpaphfPIbR68pWf NnlGEiGL2+r+BXkWqO1SO3k3HYs4TqaCCoVrTSRGnEr2si9pzyHSAg/ERWk9FY7NCEyb SfuiOdjgsN19SBmTcy/8VBaRm3jStUi/Op9aTyVA4Are0v07yW4jrpd1Rxo6csdYPxkl i+qQg+ScZRnncsq7EqfHzIo8GFG40JRHZBhhKE/l7pXX/Oj16y1ztzi0JcpKrEWO47td vR+Q== X-Gm-Message-State: ABy/qLa/WKtXN3dVA9nCbBVpZv0YtwzSJKMWXjvq6HZCU7UjzJxNT+oo F7EzBpWi3hhJjqtnNA6NazlQGBYqYrOQdE3ipgnIpA== X-Google-Smtp-Source: APBJJlFPL65ipNtupeeOTbJrTtH7T2S+XrgBb7iNnCehS9wRuc2kCVPw9s+5sQHfeBfS8KsM7h08Hg== X-Received: by 2002:a05:620a:2a01:b0:765:5982:81da with SMTP id o1-20020a05620a2a0100b00765598281damr4662589qkp.47.1690308328387; Tue, 25 Jul 2023 11:05:28 -0700 (PDT) Received: from Karl-Desktop.raven (1459483-v115.1145-static.batvilaa.metronetinc.net. [192.69.181.148]) by smtp.gmail.com with ESMTPSA id g28-20020a05620a13dc00b0076730d0b0b9sm3832433qkl.14.2023.07.25.11.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 11:05:27 -0700 (PDT) From: Karl Hallsby Date: Tue, 25 Jul 2023 13:04:43 -0500 Message-Id: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=karl@hallsby.com; helo=mail-qk1-x72e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * guix/lint.scm (new check): Run lint check warning user if the provided package uses guix as a propagated-input. Passing guix as a propagated-input is problematic when users install a package into their profiles. This can cause the guix propagated by the package to be used in preference of the real one in $HOME/.config/. It was first noticed on IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and reproduced with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#054737. --- guix/lint.scm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/guix/lint.scm b/guix/lint.scm index d173563e51..5fae34ca22 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -575,6 +575,16 @@ (define (check-input-labels package) (inputs ,package-inputs) (propagated-inputs ,package-propagated-inputs)))) +(define (check-guix-propagated-inputs package) + (if (and (not (null? (package-propagated-inputs package))) + (not (memq (@ (gnu packages package-management) guix) + (package-propagated-inputs package)))) + (list + (make-warning package + (G_ "are you sure guix should be a propagated-input?") + #:field 'propagated-inputs)) + '())) + (define (report-wrap-program-error package wrapper-name) "Warn that \"bash-minimal\" is missing from 'inputs', while WRAPPER-NAME requires it." @@ -1884,6 +1894,10 @@ (define %local-checkers (name 'input-labels) (description "Identify input labels that do not match package names") (check check-input-labels)) + (lint-checker + (name 'warn-guix-propagated-inputs) + (description "Emit warning if guix package is propagated-input") + (check check-guix-propagated-inputs)) (lint-checker (name 'wrapper-inputs) (description "Make sure 'wrap-program' can finds its interpreter.") base-commit: 9ff1e7652a407b88a3eeeab6a67261f6fee40807 -- 2.40.1 From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 Jul 2023 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Karl Hallsby Cc: 64861@debbugs.gnu.org Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.16903097961628 (code B ref 64861); Tue, 25 Jul 2023 18:30:02 +0000 Received: (at 64861) by debbugs.gnu.org; 25 Jul 2023 18:29:56 +0000 Received: from localhost ([127.0.0.1]:46940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOMnD-0000QC-QZ for submit@debbugs.gnu.org; Tue, 25 Jul 2023 14:29:56 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:35679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOMnB-0000Q2-4g for 64861@debbugs.gnu.org; Tue, 25 Jul 2023 14:29:54 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id BC62127BBE2; Tue, 25 Jul 2023 19:29:51 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 87cd695e; Tue, 25 Jul 2023 18:29:49 +0000 (UTC) References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines Date: Tue, 25 Jul 2023 19:26:01 +0100 In-reply-to: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> Message-ID: <87pm4f7skl.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Karl Hallsby writes: > * guix/lint.scm (new check): Run lint check warning user if the provided > package uses guix as a propagated-input. > > Passing guix as a propagated-input is problematic when users install a pa= ckage > into their profiles. This can cause the guix propagated by the package to= be > used in preference of the real one in $HOME/.config/. It was first notice= d on > IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and reprod= uced > with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#05= 4737. > --- > guix/lint.scm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) I'm not sure this lint warning is helpful as in both cases mentioned in the IRC links you provided (guile-imanifest and guix-data-service), these packages provide Guile modules that depend on Guix, and therefore the guix package is expected in their propagated inputs. If you remove guix or make it a input instead of a propagated input, then this breaks using the package, for example, with this change: modified gnu/packages/guile-xyz.scm @@ -2098,8 +2098,10 @@ (define-public guile-imanifest (build-system guile-build-system) (native-inputs (list guile-3.0)) + (inputs + (list guix)) (propagated-inputs - (list guile-readline guile-colorized guix)) + (list guile-readline guile-colorized)) (home-page "https://sr.ht/~brown121407/guile-imanifest") (synopsis "Interactive Guix manifests") (description "This package provides functions to generate Guix man= ifests Using guile-imanifest breaks: =E2=86=92 ./pre-inst-env guix environment --pure --ad-hoc guile guile-ima= nifest -- guile -c "(use-modules (imanifest))" Backtrace: ... ice-9/boot-9.scm:3330:6: In procedure resolve-interface: no code for module (guix profiles) I think some other approach is needed to avoid people having problems with the guix package appearing in their users profile. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmTAFJpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XchPw/+IlvgRWwEQFH8HzbVdE1XmUYRQ94BsCu8 3QCq406XzvVdUXO94rmy4jqtEqQgZk9AR63Qa0dj8mx6YaNvWo/Hf0pyb2FihnID g/Hu7M6jrI6sx0MUXJ0jRNRUDZgO2U4PrxokHtRzs8jsPOmTeuNSSWS1+lHwoQt5 1jk3vD4HxZ3dH5oKCdYOZ61WpOsL+0IUSI9vFsRh3mYF6I+tsQMBIY7WN9iOOCpy YAaChBiNXuR3MpgWvi6f3QZCcrBv6DdQitmvP1YJqxazuNXOOa5mv5bId+fZ/yF1 Gs0hKk4rd7aDagspEKjcvzqbMWAcAAVnII08Y8w0I1hm9GxrbDEDRv70aZy410Tb fuGVcBzOsLHJqiKGcvoh7MPoz29JmKrg1mu83Sd4UFL3vluLwtoSq35xHaYVtkzJ Krr4p/FPgag39r80fZaDSWSQwzR+jEufCiEkOhVXKvvg2EqQeqUj4Fu0D26srDbd oArse7NwoGHEv2s8qaB4o0u7vl0OxFq46qO++Xuf4/Zh3c90re2RYJofehIRNuY7 fIcpqiG7KT5IId7LbQsFVyP3yaLz2mbfzpqMYOBYp9hOrM92PSLDDP2vwQwF4DV+ 0a4N/v/54+/hMH2MBL87EFFjL8qEMRojRTRhb1NlDF7/SQ0y7YYHef2PpI/3Sjta Qq4dCatz01c= =P4R2 -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: "Karl G. Hallsby" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 Jul 2023 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 64861@debbugs.gnu.org Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.16903108013223 (code B ref 64861); Tue, 25 Jul 2023 18:47:02 +0000 Received: (at 64861) by debbugs.gnu.org; 25 Jul 2023 18:46:41 +0000 Received: from localhost ([127.0.0.1]:46962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qON3Q-0000pv-En for submit@debbugs.gnu.org; Tue, 25 Jul 2023 14:46:40 -0400 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]:52734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qON3N-0000ph-So for 64861@debbugs.gnu.org; Tue, 25 Jul 2023 14:46:38 -0400 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3a38953c928so4101398b6e.1 for <64861@debbugs.gnu.org>; Tue, 25 Jul 2023 11:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1690310792; x=1690915592; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=WYSxOWVAvhjMcvL9br6gtfPi3bKC6S0z8KRrj0JoRAo=; b=ArQ86fNFL4xyRa7M5J5i6+qA0d5IFu1+Kk099D0puKOGdgK607xNO/+KtBOkv0tfE5 I6NhVBNEG9nTt2h+uFcX/18oUpM0UwtD25Ti1pcVySP4wDWq5bUb7L2UTaCN1TByz+Cu 19FEetSJOF8VicDcELvR/AhZ/8qZwEqTi6jLNxcuW9gc6z0hhrVQ6tJ1iKI+X4GaXGjV rB17VG7tYddjLBunhocB9Y7Jgwko0gs1MnNyhSsbsd9t/mi15pB616hhYf3md1y6tuaE ernE4gdQQ+7jbwP7efVIe+p95aLde6Z2guqQ8qmZHBSoipceLS0jvsoM85qTyxufneqk BWdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690310792; x=1690915592; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WYSxOWVAvhjMcvL9br6gtfPi3bKC6S0z8KRrj0JoRAo=; b=CnM3rY0iZs8Pp4fCdK8/57tkB1OAn3Gd23+/tjaR8IfoTcFY+yFNpIKGc5yC8KNSDo D85mk/a7CeUu6Kodd0hHnN0WXc/9r7BP+en9R1G3mgXWQTXOMxZoW1lUTwSVBsZz54sc Q7W1hoghWD5C7zl9KN3PQztnwwSmN8ufQTuw7Ezx12MTjlf6zkUkqFvtIoC+CYbmh0z2 Eh2VWtx/TxWI5efBu407GEOitULUkb/I9/I48B//KjuTlz4Vw3weGJdWp6WISsVmoPt5 PIhZZ4hXzfgR1TrPvTIgamz+REnOKrTn2dc1OJThFog4102tfs7IXhUJmwHqP6sL4RJY iqYA== X-Gm-Message-State: ABy/qLZXHxrmQEglNa9vfGeru8ThRkoWTEf+J7ySCmmoyYzCQZ6j6ss7 qK6sE146YfeTE/WQCkYrN934q13zJhzdAvL3XsgGoA== X-Google-Smtp-Source: APBJJlG/JASfHjo81DC8CLISa0PfO8mhS+agvW4IeteZy5Tc/p6AmqcV+lzbrf/twRLJooDZ7Yyj8Q== X-Received: by 2002:a05:6808:1594:b0:3a5:a82f:2cd with SMTP id t20-20020a056808159400b003a5a82f02cdmr11539604oiw.8.1690310791782; Tue, 25 Jul 2023 11:46:31 -0700 (PDT) Received: from localhost (1459483-v115.1145-static.batvilaa.metronetinc.net. [192.69.181.148]) by smtp.gmail.com with ESMTPSA id s14-20020a0cb30e000000b006238b37fb05sm4567450qve.119.2023.07.25.11.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 11:46:31 -0700 (PDT) References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> User-agent: mu4e 1.10.3; emacs 28.2 From: "Karl G. Hallsby" Date: Tue, 25 Jul 2023 13:41:55 -0500 In-reply-to: <87pm4f7skl.fsf@cbaines.net> Message-ID: <874jlr96d5.fsf@hallsby.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Christopher Baines writes: > [[PGP Signed Part:Undecided]] > > Karl Hallsby writes: > >> * guix/lint.scm (new check): Run lint check warning user if the provided >> package uses guix as a propagated-input. >> >> Passing guix as a propagated-input is problematic when users install a p= ackage >> into their profiles. This can cause the guix propagated by the package t= o be >> used in preference of the real one in $HOME/.config/. It was first notic= ed on >> IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and repro= duced >> with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#0= 54737. >> --- >> guix/lint.scm | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) > > I'm not sure this lint warning is helpful as in both cases mentioned in > the IRC links you provided (guile-imanifest and guix-data-service), > these packages provide Guile modules that depend on Guix, and therefore > the guix package is expected in their propagated inputs. > > If you remove guix or make it a input instead of a propagated input, > then this breaks using the package, for example, with this change: > > modified gnu/packages/guile-xyz.scm > @@ -2098,8 +2098,10 @@ (define-public guile-imanifest > (build-system guile-build-system) > (native-inputs > (list guile-3.0)) > + (inputs > + (list guix)) > (propagated-inputs > - (list guile-readline guile-colorized guix)) > + (list guile-readline guile-colorized)) > (home-page "https://sr.ht/~brown121407/guile-imanifest") > (synopsis "Interactive Guix manifests") > (description "This package provides functions to generate Guix m= anifests > > Using guile-imanifest breaks: > > =E2=86=92 ./pre-inst-env guix environment --pure --ad-hoc guile guile-i= manifest -- guile -c "(use-modules (imanifest))" > Backtrace: > ... > > ice-9/boot-9.scm:3330:6: In procedure resolve-interface: > no code for module (guix profiles) > > > I think some other approach is needed to avoid people having problems > with the guix package appearing in their users profile. > > [[End of PGP Signed Part]] That makes sense. Though, this lint is just a warning, so if nothing else, it should make people think if guix really needs to be propagated. If this lint is not the solution, then a way to mark packages that are not recommended to be installed like this would be nice. From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Aug 2023 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Karl Hallsby , 64861@debbugs.gnu.org Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.169256510227170 (code B ref 64861); Sun, 20 Aug 2023 20:59:01 +0000 Received: (at 64861) by debbugs.gnu.org; 20 Aug 2023 20:58:22 +0000 Received: from localhost ([127.0.0.1]:54936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXpV8-00074A-84 for submit@debbugs.gnu.org; Sun, 20 Aug 2023 16:58:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXpV6-00073x-GR for 64861@debbugs.gnu.org; Sun, 20 Aug 2023 16:58:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXpUz-0001qa-9C; Sun, 20 Aug 2023 16:58:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=+wktX6Zzw3ytO20Q3kNzbxWxzGuh9JD8Efkv6XAVcd8=; b=DvVj1Nd7BlILW45sBE6H /xuyAx5iEn7V/1DFplee1cSj8NvaBDfj9W7Pb+QY+P8fRN/J4DfTbu+VQuji6IxV30pJL3Tpdxm7H 73MOgVfexFqHV9m2SFoXRwTah7GnksDtDH1eaQomPTYpUr+8+dC5ZYlaYR/vXmzcSjcbbQTM76CA/ 65Yrd4oRBzeiz12M075HiWQk4fZqaUh8q7YeSf+Vq7nO8B1EG+MNpGWGotYhicsQdSsmEoHjYa1V3 6W9+xtRrwW1x0EnIZguxK0FunZc3hN7aVTM+iGaLMXBapn9r9a0bHLPR56mB8aJppeHusweKkl5iI AaeWVZs4gE9j2A==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> Date: Sun, 20 Aug 2023 22:58:10 +0200 In-Reply-To: <87pm4f7skl.fsf@cbaines.net> (Christopher Baines's message of "Tue, 25 Jul 2023 19:26:01 +0100") Message-ID: <87fs4dqvml.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christopher Baines skribis: > Using guile-imanifest breaks: > > =E2=86=92 ./pre-inst-env guix environment --pure --ad-hoc guile guile-i= manifest -- guile -c "(use-modules (imanifest))" > Backtrace: > ... > > ice-9/boot-9.scm:3330:6: In procedure resolve-interface: > no code for module (guix profiles) Maybe =E2=80=98guile-imanifest=E2=80=99 should be made a Guix extension, wh= ich Guix searches for in $GUIX_EXTENSIONS_PATH? An example of that is =E2=80=98guix-modules=E2=80=99. Ludo=E2=80=99. From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Sep 2023 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines Cc: Karl Hallsby , 64861@debbugs.gnu.org Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.16940999528329 (code B ref 64861); Thu, 07 Sep 2023 15:20:02 +0000 Received: (at 64861) by debbugs.gnu.org; 7 Sep 2023 15:19:12 +0000 Received: from localhost ([127.0.0.1]:40977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGml-0002AG-Ho for submit@debbugs.gnu.org; Thu, 07 Sep 2023 11:19:11 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:40318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeGmb-00028t-MV for 64861@debbugs.gnu.org; Thu, 07 Sep 2023 11:19:02 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-31c3f574ef8so199197f8f.1 for <64861@debbugs.gnu.org>; Thu, 07 Sep 2023 08:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694099934; x=1694704734; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mQrGfRJDEOaj0RZO7CNjwG/UMQGCG1S2vLErrEszL/A=; b=rLDuoNVq2w1q+uuCgRV1zbl0J7qf4PVarGo7qScroefeR/Uoe2505yEJDJXea1clhs HqvzZRc6a5RgfD2Wh0n/Te5TBsDEZqeNtcOnZRlkhOczBNKLqoXifBS0A4fX81sdeOPg 4SAy43AMyHCWTbt/WMxP54W+daqQ4zka2qBP/mV/6YKhJ6aiY7LnlRh/4gvHPw2oUEfn YoFQTAoPjtswHS7SCkwESohWLbHjiRs+ooZdvL8dxRiqpgu1w4HkNLb7NpBG1OBze6h2 ztHWD/29lZV2U/5UXgAnO8kHjDteNDWWj3z5oKD9bc54igYBaks+b2Sz2bvQgFdOPgQA wTOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694099934; x=1694704734; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQrGfRJDEOaj0RZO7CNjwG/UMQGCG1S2vLErrEszL/A=; b=R42Hc5JHAFugcJPvkbQ7tiwhEqhniMw5IOnniAy2xKWYcGhYBKy3P5OKmc4F2RwpQK M6XJVPJhqfsrtbO4rqOBKHwq1O7I3cagqNd1fuz0EPecQFt97xNgyp1lmG3dAewLu9ME SpKF+1UAfZkxuqRlpsGanQ/r0us4rcpeuKKQjizpFZ+x0X331eVO1I5ragKo0+xU7gvZ N/GY7YD+tee9XSkUEzTlguIrrgtRYsV3kodUJODK5MyhUGjZ06f68ybw897d2d11F/Eh ve5lLQAO/Xu4nbaxmqbIPU+w8W8BZkYoNExBNilLeNpX/nJGGCLWLPqIJE+UrQ/YNoFu 1M0g== X-Gm-Message-State: AOJu0YzM7YPs24aOWl+6yU6KHZWEBuK2ss5ut3eoLZoDPL5u2jGT473b zygPy4lNmM6gJUGLRmUTv7ru1y5HcQo= X-Google-Smtp-Source: AGHT+IHwJeeEyBdHPbJxMjDtK2tKgCuba1/LnKeqRX6NoYLfx6SCO3xXBq3DJZVi/4KsvrvdAoOyCQ== X-Received: by 2002:adf:f291:0:b0:316:ef5f:7d8f with SMTP id k17-20020adff291000000b00316ef5f7d8fmr14578904wro.3.1694099934151; Thu, 07 Sep 2023 08:18:54 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id cc11-20020a5d5c0b000000b0031f34a395e7sm17301385wrb.45.2023.09.07.08.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 08:18:53 -0700 (PDT) From: Simon Tournier In-Reply-To: <87fs4dqvml.fsf_-_@gnu.org> References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> <87fs4dqvml.fsf_-_@gnu.org> Date: Thu, 07 Sep 2023 16:22:14 +0200 Message-ID: <87bkeekqqx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Sun, 20 Aug 2023 at 22:58, Ludovic Court=C3=A8s wrote: > Maybe =E2=80=98guile-imanifest=E2=80=99 should be made a Guix extension, = which Guix > searches for in $GUIX_EXTENSIONS_PATH? And probably renamed =E2=80=99guix-imanifest=E2=80=99? Back to the submission, I think that the propagation of the package guix means something is wrong. From my point of view, there is two cases: 1. The package uses the stable library API and thus it makes sense to rely on the package =E2=80=99guix=E2=80=99. That=E2=80=99s the case fo= r =E2=80=99gwl=E2=80=99, =E2=80=99guix-data-service=E2=80=99 for example. 2. The aim of package is to collaborate with the current Guix and thus there is no point to have the package =E2=80=99guix=E2=80=99 as inputs.= Instead, the package must rely on GUIX_EXTENSIONS_PATH. That=E2=80=99s the case= for =E2=80=99guix-modules=E2=80=99 or =E2=80=99guile-imanifest=E2=80=99 (so= that needs a fix ;-)) Therefore, I think this new checker makes sense. WDYT? About #1, IMHO, this is expected: --8<---------------cut here---------------start------------->8--- $ guix shell -C gwl -- guix --version guix shell: error: guix: command not found (define-public gwl (inputs [...] (list guix --8<---------------cut here---------------end--------------->8--- and this is not expected: --8<---------------cut here---------------start------------->8--- $ guix shell -C guix-data-service -- guix --version guix (GNU Guix) 1.4.0-10.4dfdd82 Copyright (C) 2023 the Guix authors License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. (define-public guix-data-service [...] (propagated-inputs (list guix --8<---------------cut here---------------end--------------->8--- Cheers, simon From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: "Karl G. Hallsby" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Jan 2025 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64861@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines , Karl Hallsby , Simon Tournier Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.173663251127512 (code B ref 64861); Sat, 11 Jan 2025 21:56:02 +0000 Received: (at 64861) by debbugs.gnu.org; 11 Jan 2025 21:55:11 +0000 Received: from localhost ([127.0.0.1]:45191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWjRn-000790-H7 for submit@debbugs.gnu.org; Sat, 11 Jan 2025 16:55:11 -0500 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]:59810) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tWjRl-00077v-6f for 64861@debbugs.gnu.org; Sat, 11 Jan 2025 16:55:09 -0500 Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-84f1ea04c64so203143239f.3 for <64861@debbugs.gnu.org>; Sat, 11 Jan 2025 13:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1736632503; x=1737237303; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=o5pzWc6NwSmr54idXvJ+CuCYtecVRn/ajI3sRHWDgiM=; b=CrXq0huOGQYT+IrmQ3DfCv24PpMP71l3iK36lhsip/ufbOtVGtXhO52EFa/Dzdf9x3 uCZSBmSghE9TJGMSD+iU0LtdRmwycia+vUqHkP6x/5oGcnK5S3hMk4yWhs1OjwgAKLUg evuTevRvm0gXFY1wuQXZC4Ec+94zo9h8f8sLWItsAVw6F7GSx2LCier92UVsc/061pXc prN2TCcyqgdzhWO30CDOFt2OpTdKQSl7xwks+BBwOZN3I/Id68ou7cOD4GzzSbOOBBI9 egCNSExc0YOfD7usvGQ6RveM8Un/XLG29dtdUCx89s+lIl4ynatJbvuP4PZCRm0v3n/9 TAkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736632503; x=1737237303; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o5pzWc6NwSmr54idXvJ+CuCYtecVRn/ajI3sRHWDgiM=; b=sX8ii84lxbRyjVOd4rPfVHjYqWUp+lcW6T2QtJ/stpJYsYmoOqNoaxOLj29SdDwi4v f8BrTTz6NLsUJsXqkI++PHvK59eWMi4wd7j2+DUrRZyJlPQEXycU/kMoldK2OnV++J5A xTHQpfEH5QZtlkp7n+JQ4C06mpbgVSU+J2wGbrBh+LrYYYFGKeFBHYkFWGrK4jQbEdzS thAEbvDgYEdPSLfbgnje7bI9g7mTj6tX9hmva3g7KiBof6GRTZhu/VLa20E3eRp2yo3f nPjslPwmkEJe8FjveSqqW2RLJywCWIZnusjcawEsGzDTRm3vaChtzq+MCtlLhKfXLxRe x4Yw== X-Gm-Message-State: AOJu0YztTy8jvpmk1YNTcdBCUgQIJbwmVPqkS9lRK9n6JQCLksaOSEZT fe9R7rj64uV0YXPv4tPDFXLVObFpx0QRJTjRQPF0I1ztFcmbCn34trqE49SmTJCqjD6COkaOXqW 4NA== X-Gm-Gg: ASbGncu+dFjN/WY1X7+1F1c/HK+k2MWjTAJU2nMTTeyK7HF6ygTC3/V+nI5d05Z1hyZ flGoXu5x3snCnPXFSC2jdbKyexKWk9zK9O5+WfJD1Puta58tRK8E9TfrDbxb3dmy1NhkvBc9QCt 0WnONMidkmNjOXDO/7EZfu8/HybY+7cfDyTdJRd4YDmBwuzlRH9qh9cVqznX9J4u6LmTAkYhUeQ 2NeeIyCneg6RLt5ry9eiURyi+N1j7qQiZErscCHswPcseIybg== X-Google-Smtp-Source: AGHT+IH5/Qqi1qCU/f2bV8+W4Sz1veGDKWfCnMmAPG94uC+PskvMBG99bHkj7VKKl4D3gVVAbIq/Cg== X-Received: by 2002:a05:6e02:1706:b0:3ce:6975:b668 with SMTP id e9e14a558f8ab-3ce6975b7fdmr13070925ab.6.1736632503060; Sat, 11 Jan 2025 13:55:03 -0800 (PST) Received: from localhost ([207.237.222.72]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea1b717d59sm1758415173.97.2025.01.11.13.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 13:55:01 -0800 (PST) From: "Karl G. Hallsby" In-Reply-To: <87bkeekqqx.fsf@gmail.com> (Simon Tournier's message of "Thu, 07 Sep 2023 16:22:14 +0200") References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> <87fs4dqvml.fsf_-_@gnu.org> <87bkeekqqx.fsf@gmail.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Sat, 11 Jan 2025 15:54:59 -0600 Message-ID: <875xmlnhho.fsf@u.northwestern.edu> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all, What is the state of this patch's proposal? Is this warning check for guix in propagated-inputs something we still want to warn about? I know we have not talked about it in a while. I am going through all of my contributions to Guix & Guix-based projects and closing/merging/resolving them. -- Raven Hallsby From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Jan 2025 08:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Karl G. Hallsby" Cc: Christopher Baines , 64861@debbugs.gnu.org, Simon Tournier Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.17370148682228 (code B ref 64861); Thu, 16 Jan 2025 08:08:02 +0000 Received: (at 64861) by debbugs.gnu.org; 16 Jan 2025 08:07:48 +0000 Received: from localhost ([127.0.0.1]:59885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYKuq-0000Zs-DC for submit@debbugs.gnu.org; Thu, 16 Jan 2025 03:07:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48224) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYKuo-0000Za-7J for 64861@debbugs.gnu.org; Thu, 16 Jan 2025 03:07:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYKui-000140-MN; Thu, 16 Jan 2025 03:07:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=AeVf1+YWhnfTFASOgjBAqR018nmV3oca/urEwAWIYzw=; b=W7ZQSzUBhWTQYGJqkeRc vwRzSF9tXtfUKbWHPYmp7fk5rmNwFH2cWg60ccnbKqNuH47FrWXYBSSgAzyhS2jPuukOgxa4KGghR fW6Oa2xdVS1Mw3XFRm7dWPuyTAN1VvZ3nKoKsFU2OI5Meb5GVzI2w5GIaSit2vtkzKW9OMD8LHsF/ tVeRwZXuoVgikLJ13Q3izbblAuccfunqPu0BGiQn6HKKlH3VXGYVx9f8jgpkCfYeyXomVHlDdfC17 adV2nhi5fsMeV2nArX2709chDdHSGr0PgG2J+3Q8qLKpaC/qRKNEQajVShl182lGfU2zxYvtUT6D1 XhqZdKhBD7yG/A==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <875xmlnhho.fsf@u.northwestern.edu> (Karl G. Hallsby's message of "Sat, 11 Jan 2025 15:54:59 -0600") References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> <87fs4dqvml.fsf_-_@gnu.org> <87bkeekqqx.fsf@gmail.com> <875xmlnhho.fsf@u.northwestern.edu> Date: Thu, 16 Jan 2025 09:07:37 +0100 Message-ID: <87o7076v1y.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "Karl G. Hallsby" skribis: > What is the state of this patch's proposal? Is this warning check for > guix in propagated-inputs something we still want to warn about? I second Christopher here: there are legitimate cases for propagating Guix (Scheme libraries that themselves use Guix modules) so I would lean towards not including this lint check. Closing? Thanks, Ludo=E2=80=99. From unknown Tue Jun 17 01:48:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: Raven Hallsby Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Jun 2025 23:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64861@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines , Simon Tournier Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.175011676026450 (code B ref 64861); Mon, 16 Jun 2025 23:33:02 +0000 Received: (at 64861) by debbugs.gnu.org; 16 Jun 2025 23:32:40 +0000 Received: from localhost ([127.0.0.1]:49460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRJJe-0006sF-MG for submit@debbugs.gnu.org; Mon, 16 Jun 2025 19:32:40 -0400 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]:61440) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uRJJb-0006qT-45 for 64861@debbugs.gnu.org; Mon, 16 Jun 2025 19:32:35 -0400 Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-3ddc5084952so21962825ab.2 for <64861@debbugs.gnu.org>; Mon, 16 Jun 2025 16:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1750116748; x=1750721548; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=y+GhHMmNcL5Nw/rAxujSZVQ1b9OWO7IDc6IgFFqU9Nw=; b=cvnZSOfiz5wwJIGgoGeTxim+eya0x8wclTRbmJQLjtHEqSJhCL9aIzwyEwSUd121Nl BAlmwH4evIbzE9Xv/M+ZqlXe/d/1YapD+eokpfGV2imIcuK5TzB+D/Zu7YNNWfkj+FI6 D5MaXb4gsEVu/yYOvU2opuVy/qRAjuQioP/cO/d34FSFnsf4Piq5w362jWznhvsTBJWM AGBgZ0aikH2ezW5b47s+n4hg1cvkiKvi6WYroKq6fU9bxaUrDzP/O80wYd8TXzvgSqT1 MPDGho4sa7DbVFHpFaDDaQfzz1aoegF/rTN8pAZyn1iHCQE1PAEcAhSQKfzfrFmNndOL 1a4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750116748; x=1750721548; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y+GhHMmNcL5Nw/rAxujSZVQ1b9OWO7IDc6IgFFqU9Nw=; b=LdH12UTNFVTplynyNhV5ShiU6ZPb9mJnt0NT60WpNLAtcYWXvx2Bwm1wAdcWsaR9Q1 cQaINRcz63aBE1W2/KHB2PgyWu8aTma+bbXVSEQmTWgeVsRxOCMrDan8nwUGggIpkEmX 41+tbSnZWAHgTWSZ5hlHC5TtD1ThkB45xumquOwqp4Zo/oTCP30IExjFEWjLMALWN0O9 Lf/u1Q/3l5NzYDWIrXx9beX6qU1tmseVyiA67HP/oCn5xpqf9DuOJ7wyYrthNZIhVQTc veP3E/9/Xvhi/4H7IPsgeTxipXqDhGZdFm/bdTjdSDkoqjnIR3Z8SxPYyMWLo0OKsowG 0+Jw== X-Gm-Message-State: AOJu0YwCsbGTSX7A3TgdL1y1tyNfpB5RdvagulJhS3ljj6i5FjK7QjuV a/XAIrCyvJMcffLZS4CZdWWJNO19aVGKeOtc/21hMskYBzzNraDNNPDJdbDyoRvgpdmBuDEq3sZ mTw3M0Mg0 X-Gm-Gg: ASbGnct4R6N1qkRTk6l0M0Rxib1TuzeJBLAsqOKuo3Hl9j4GQTguSX3kjAcKATLNoSW i0+cpSFcwZzkUoU8xmSEyfBfGt2Yt/+psv6CRE+MsueAxghbd96AH8jMl21EuOHB5T1LUluQyEo CoqCcd1yj4iw/tIUv406MhAyLMedLSoSSeTDXL1fpeXgWNeYsQSHW3gOqeGbmaVbuBlcJChTFCS rsSqyjOx2Mt41Eanl1td3MTkA/oKxcBN62Z3alOGFvLgGikhteIeYqhdzuUDl9D0+YJm8J5y1zY xNFv/p1zemulA+sr+c/Ekn+q/W93zAw4nV0Yt4l/IjvBYG1C2C9A8tI= X-Google-Smtp-Source: AGHT+IGCXKtH4IqYUP85amtiPXtmLkkgHvZBkQoEJtRtzpreTQEI81nVFBlXiSrfcyhsVrVF5t0NOA== X-Received: by 2002:a05:6e02:1a44:b0:3dc:7df8:c830 with SMTP id e9e14a558f8ab-3de07c55a19mr121748865ab.7.1750116748320; Mon, 16 Jun 2025 16:32:28 -0700 (PDT) Received: from localhost ([207.237.222.72]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3de01a501f4sm22749955ab.63.2025.06.16.16.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 16:32:26 -0700 (PDT) From: Raven Hallsby In-Reply-To: <87o7076v1y.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 16 Jan 2025 09:07:37 +0100") References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> <87fs4dqvml.fsf_-_@gnu.org> <87bkeekqqx.fsf@gmail.com> <875xmlnhho.fsf@u.northwestern.edu> <87o7076v1y.fsf@gnu.org> User-Agent: mu4e 1.12.11; emacs 29.4 Date: Mon, 16 Jun 2025 18:32:26 -0500 Message-ID: <87v7ov9sad.fsf@hallsby.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In preparation for the full migration to Codeberg, should I close this? Or should one of you? -- Raven Hallsby karl@hallsby.com From unknown Tue Jun 17 01:48:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Karl Hallsby Subject: bug#64861: closed (Re: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input) Message-ID: References: <8734bybw0z.fsf@gnu.org> <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> X-Gnu-PR-Message: they-closed 64861 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 64861@debbugs.gnu.org Date: Tue, 17 Jun 2025 08:42:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1750149723-23429-1" This is a multi-part message in MIME format... ------------=_1750149723-23429-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64861: [PATCH] guix: Add lint check for guix as propagated-input which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64861@debbugs.gnu.org. --=20 64861: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64861 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1750149723-23429-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64861-done) by debbugs.gnu.org; 17 Jun 2025 08:41:32 +0000 Received: from localhost ([127.0.0.1]:53305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRRsq-00062n-0U for submit@debbugs.gnu.org; Tue, 17 Jun 2025 04:41:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56374) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRRsl-000624-St for 64861-done@debbugs.gnu.org; Tue, 17 Jun 2025 04:41:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRRse-0001kz-NV; Tue, 17 Jun 2025 04:41:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=IhkZg3lIo/Wo5q2gCF+PHsEz3c8GY7iE28AHbEUXrAA=; b=S5JsfKMAauajOEulu+/J elMzOYhZowiJXyksvl7wWXWcUEnMukND35LNGX6lfsGLmQNCzIfVWd2tkmN5X5quMwwlSwvFRS1Dh /2O7WKwvplljmjlxOpCeP2Q7ZPUvrAbufh4ISNmKClHE/HKy1ezwyblIr/7gJjK3JK23dWRO2tkhz 36uSN4nKqIWmM8fDijZRVnaNtdJjUQjxbIRK2+AlA+6IjhryA0YJVXGdLhkk0GpolMoynm/ouWHsj sTgFDGGzr/oB3KzjxzQCDkBjDptITDLh1TyPbM2Q524zu0mFVFk75wbSG35nb97VUdijj2JZVu9v6 nghU/Yd7MOssRQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Raven Hallsby Subject: Re: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input In-Reply-To: <87v7ov9sad.fsf@hallsby.com> (Raven Hallsby's message of "Mon, 16 Jun 2025 18:32:26 -0500") References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> <87fs4dqvml.fsf_-_@gnu.org> <87bkeekqqx.fsf@gmail.com> <875xmlnhho.fsf@u.northwestern.edu> <87o7076v1y.fsf@gnu.org> <87v7ov9sad.fsf@hallsby.com> User-Agent: mu4e 1.12.11; emacs 30.1 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: Nonidi 29 Prairial an 233 de la =?utf-8?Q?R=C3=A9vol?= =?utf-8?Q?ution=2C?= jour de la Pivoine Date: Tue, 17 Jun 2025 10:41:00 +0200 Message-ID: <8734bybw0z.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64861-done Cc: Christopher Baines , 64861-done@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Raven Hallsby writes: > In preparation for the full migration to Codeberg, should I close this? > Or should one of you? Yes, closing. Thanks, Ludo=E2=80=99. ------------=_1750149723-23429-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Jul 2023 18:05:42 +0000 Received: from localhost ([127.0.0.1]:46920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOMPl-0008JF-IR for submit@debbugs.gnu.org; Tue, 25 Jul 2023 14:05:41 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOMPj-0008J2-Hm for submit@debbugs.gnu.org; Tue, 25 Jul 2023 14:05:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOMPc-00059a-BS for guix-patches@gnu.org; Tue, 25 Jul 2023 14:05:33 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOMPa-0001aU-KJ for guix-patches@gnu.org; Tue, 25 Jul 2023 14:05:32 -0400 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-76c4890a220so166872885a.3 for ; Tue, 25 Jul 2023 11:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1690308328; x=1690913128; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Us5bBGdVGqarFjcvlUCXkJvAX9reMuPbZJ8HYWet8+g=; b=RhXJvGQM2jRRwbybvbUf6qPOwoDi20FH5ARmvKHm8NSUrchs4twihStMptbjB6smwj Xr+s2Mf2wwVnhliJoadDER58tDBi7YBvaaqr/kJ+7s89J5eu4QJR1wPKjpwG5xZmaeYR O+vlHN6oWJtte+jkGuzijy1egJy6mxg+I9QDU3kY88wyTZd4Cuw1WwkGKOXb8kSz1/Kj XSflh8oW/lZE/k6xdkiRfQ6J5CevS783kLFehPbj+SF2MAnm3I2oJ84FEvMGdSBwkANe QOGSi49OnbzEqrS0CglgXacFYsh5xwFpYcT+ONsh0LItpdJx+HQp8pa35TogySKjAJNZ 6pZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690308328; x=1690913128; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Us5bBGdVGqarFjcvlUCXkJvAX9reMuPbZJ8HYWet8+g=; b=hIvUNP6UJ5+UEmPtr1CJH3ob2T41ZX2ngM7cVGbt2C/rIvp3uGGlz2aM9npgOu2xtt Eh2dn5ZWYR2T1muNiyc7UXNXBNHoVzivjcq1dgSsMcM5OVBj3H9XWhpaphfPIbR68pWf NnlGEiGL2+r+BXkWqO1SO3k3HYs4TqaCCoVrTSRGnEr2si9pzyHSAg/ERWk9FY7NCEyb SfuiOdjgsN19SBmTcy/8VBaRm3jStUi/Op9aTyVA4Are0v07yW4jrpd1Rxo6csdYPxkl i+qQg+ScZRnncsq7EqfHzIo8GFG40JRHZBhhKE/l7pXX/Oj16y1ztzi0JcpKrEWO47td vR+Q== X-Gm-Message-State: ABy/qLa/WKtXN3dVA9nCbBVpZv0YtwzSJKMWXjvq6HZCU7UjzJxNT+oo F7EzBpWi3hhJjqtnNA6NazlQGBYqYrOQdE3ipgnIpA== X-Google-Smtp-Source: APBJJlFPL65ipNtupeeOTbJrTtH7T2S+XrgBb7iNnCehS9wRuc2kCVPw9s+5sQHfeBfS8KsM7h08Hg== X-Received: by 2002:a05:620a:2a01:b0:765:5982:81da with SMTP id o1-20020a05620a2a0100b00765598281damr4662589qkp.47.1690308328387; Tue, 25 Jul 2023 11:05:28 -0700 (PDT) Received: from Karl-Desktop.raven (1459483-v115.1145-static.batvilaa.metronetinc.net. [192.69.181.148]) by smtp.gmail.com with ESMTPSA id g28-20020a05620a13dc00b0076730d0b0b9sm3832433qkl.14.2023.07.25.11.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 11:05:27 -0700 (PDT) From: Karl Hallsby To: guix-patches@gnu.org Subject: [PATCH] guix: Add lint check for guix as propagated-input Date: Tue, 25 Jul 2023 13:04:43 -0500 Message-Id: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=karl@hallsby.com; helo=mail-qk1-x72e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Karl Hallsby X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * guix/lint.scm (new check): Run lint check warning user if the provided package uses guix as a propagated-input. Passing guix as a propagated-input is problematic when users install a package into their profiles. This can cause the guix propagated by the package to be used in preference of the real one in $HOME/.config/. It was first noticed on IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and reproduced with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#054737. --- guix/lint.scm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/guix/lint.scm b/guix/lint.scm index d173563e51..5fae34ca22 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -575,6 +575,16 @@ (define (check-input-labels package) (inputs ,package-inputs) (propagated-inputs ,package-propagated-inputs)))) +(define (check-guix-propagated-inputs package) + (if (and (not (null? (package-propagated-inputs package))) + (not (memq (@ (gnu packages package-management) guix) + (package-propagated-inputs package)))) + (list + (make-warning package + (G_ "are you sure guix should be a propagated-input?") + #:field 'propagated-inputs)) + '())) + (define (report-wrap-program-error package wrapper-name) "Warn that \"bash-minimal\" is missing from 'inputs', while WRAPPER-NAME requires it." @@ -1884,6 +1894,10 @@ (define %local-checkers (name 'input-labels) (description "Identify input labels that do not match package names") (check check-input-labels)) + (lint-checker + (name 'warn-guix-propagated-inputs) + (description "Emit warning if guix package is propagated-input") + (check check-guix-propagated-inputs)) (lint-checker (name 'wrapper-inputs) (description "Make sure 'wrap-program' can finds its interpreter.") base-commit: 9ff1e7652a407b88a3eeeab6a67261f6fee40807 -- 2.40.1 ------------=_1750149723-23429-1--