GNU bug report logs - #64855
30.0.50; ERC 5.6: Make scrolltobottom less erratic

Previous Next

Full log

Message #34 received at 64855 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 64855 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#64855: 30.0.50; ERC 5.6: Make scrolltobottom less erratic
Date: Tue, 24 Oct 2023 19:15:55 -0700

[Message part 1 (text/plain, inline)]

"J.P." <jp <at> neverwas.me> writes:

> I've added these changes as
>
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=328a9856
>
> This bug has already been closed. Thanks.

But wait, there's more! (There's always more.)

It seems I went a little overboard in reigning in the frequency of
scroll attempts. This has been walked back slightly in the attached
changes.

There's also a subtle quirk that's come to light involving `point-max'
and (recenter -1) where Emacs calculates point as having drifted off
screen. We could try tackling this with something kludgey, like
decrementing point temporarily during `recenter' attempts. But that
fails if the current input ends in a newline. I've instead decided to
address this by taking a page from other Emacs libraries and setting
`scroll-step' locally to 1 if a user hasn't customized
`scroll-conservatively'. See attached.

[0001-5.6-Be-slightly-more-aggressive-in-erc-scrolltobotto.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.