GNU bug report logs - #64845
[PATCH] gnu: fcode-utils: Fix cross-compilation.

Previous Next

Package: guix-patches;

Reported by: Zheng Junjie <873216071 <at> qq.com>

Date: Tue, 25 Jul 2023 07:47:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64845: closed ([PATCH] gnu: fcode-utils: Fix cross-compilation.)
Date: Thu, 26 Oct 2023 12:42:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 26 Oct 2023 14:41:17 +0200
with message-id <87sf5xk13m.fsf <at> gnu.org>
and subject line Re: [bug#64845] [PATCH v3 2/2] gnu: fcode-utils: Fix cross-compilation.
has caused the debbugs.gnu.org bug report #64845,
regarding [PATCH] gnu: fcode-utils: Fix cross-compilation.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64845: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64845
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Zheng Junjie <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: fcode-utils: Fix cross-compilation.
Date: Tue, 25 Jul 2023 15:45:13 +0800
* gnu/packages/firmware.scm (fcode-utils)
[arguments]: add remove-makefile-strip phase.
---
 gnu/packages/firmware.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
index 35d3100ac6..01565ed18a 100644
--- a/gnu/packages/firmware.scm
+++ b/gnu/packages/firmware.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2020, 2021, 2022 Marius Bakke <marius <at> gnu.org>
 ;;; Copyright © 2021 Petr Hodina <phodina <at> protonmail.com>
 ;;; Copyright © 2022, 2023 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -387,7 +388,14 @@ (define-public fcode-utils
               (string-append "DESTDIR=" #$output))
       #:phases
       #~(modify-phases %standard-phases
-          (delete 'configure))))        ; No configure script.
+          (delete 'configure)       ; No configure script.
+          (add-after 'unpack 'remove-makefile-strip
+            (lambda _
+              (substitute* '("detok/Makefile"
+                             "romheaders/Makefile"
+                             "toke/Makefile")
+                (("\\$\\(STRIP\\).*")
+                 "")))))))
     (native-inputs
      (list tcsh))
     (home-page "https://www.openfirmware.info/FCODE_suite")

base-commit: 76e041f9eef85bb039c5251d3350c62ee2066883
-- 
2.41.0



[Message part 3 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Zheng Junjie <873216071 <at> qq.com>
Cc: Vagrant Cascadian <vagrant <at> debian.org>,
 Ludovic Courtès <ludo <at> gnu.org>, 64845-done <at> debbugs.gnu.org,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#64845] [PATCH v3 2/2] gnu: fcode-utils: Fix
 cross-compilation.
Date: Thu, 26 Oct 2023 14:41:17 +0200
> * gnu/packages/firmware.scm (fcode-utils)
> [arguments]: use STRIP-FOR-TARGET.

Applied both patches, thanks,

Mathieu


This bug report was last modified 1 year and 211 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.