Subject: bug#64845: closed (Re: [bug#64845] [PATCH v3 2/2] gnu: fcode-utils: Fix cross-compilation.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 26 Oct 2023 12:42:02 +0000

Your bug report

#64845: [PATCH] gnu: fcode-utils: Fix cross-compilation.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
64845: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64845
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#64845] [PATCH v3 2/2] gnu: fcode-utils: Fix cross-compilation.
From: Mathieu Othacehe <[email-masked]>
To: Zheng Junjie <[email-masked]>
Cc: Vagrant Cascadian <[email-masked]>, Ludovic Courtès <[email-masked]>, [email-masked], Efraim Flashner <[email-masked]>
Date: Thu, 26 Oct 2023 14:41:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> * gnu/packages/firmware.scm (fcode-utils)
> [arguments]: use STRIP-FOR-TARGET.

Applied both patches, thanks,

Mathieu

Subject: [PATCH] gnu: fcode-utils: Fix cross-compilation.
From: Zheng Junjie <[email-masked]>
To: [email-masked]
Date: Tue, 25 Jul 2023 15:45:13 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/firmware.scm (fcode-utils)
[arguments]: add remove-makefile-strip phase.
---
 gnu/packages/firmware.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
index 35d3100ac6..01565ed18a 100644
--- a/gnu/packages/firmware.scm
+++ b/gnu/packages/firmware.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2020, 2021, 2022 Marius Bakke <[email-masked]>
 ;;; Copyright © 2021 Petr Hodina <[email-masked]>
 ;;; Copyright © 2022, 2023 Maxim Cournoyer <[email-masked]>
+;;; Copyright © 2023 Zheng Junjie <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -387,7 +388,14 @@ (define-public fcode-utils
               (string-append "DESTDIR=" #$output))
       #:phases
       #~(modify-phases %standard-phases
-          (delete 'configure))))        ; No configure script.
+          (delete 'configure)       ; No configure script.
+          (add-after 'unpack 'remove-makefile-strip
+            (lambda _
+              (substitute* '("detok/Makefile"
+                             "romheaders/Makefile"
+                             "toke/Makefile")
+                (("\\$\\(STRIP\\).*")
+                 "")))))))
     (native-inputs
      (list tcsh))
     (home-page "https://www.openfirmware.info/FCODE_suite")

base-commit: 76e041f9eef85bb039c5251d3350c62ee2066883
-- 
2.41.0