GNU bug report logs - #64841
[PATCH] gnu: python-shiboken-6: Remove inherited workaround.

Previous Next

Package: guix-patches;

Reported by: Hilton Chain <hako <at> ultrarare.space>

Date: Tue, 25 Jul 2023 00:19:01 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64841: closed ([PATCH] gnu: python-shiboken-6: Remove
 inherited workaround.)
Date: Wed, 26 Jul 2023 12:43:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 26 Jul 2023 14:42:39 +0200
with message-id <ZMEUv1by5ORpdd4F <at> jurong>
and subject line Re: [bug#64841] [PATCH] gnu: python-shiboken-6: Remove inherited workaround.
has caused the debbugs.gnu.org bug report #64841,
regarding [PATCH] gnu: python-shiboken-6: Remove inherited workaround.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64841: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64841
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>, Formbi <formbi <at> protonmail.com>
Subject: [PATCH] gnu: python-shiboken-6: Remove inherited workaround.
Date: Tue, 25 Jul 2023 08:16:11 +0800
Fixes: <https://issues.guix.gnu.org/64803>.

The importlib workaround inherited from python-shiboken-2 is not required for
building python-pyside-6, and will cause a build issue on the identation.

* gnu/packages/qt.scm (python-shiboken-6)[arguments]<#:phases>: Delete
'workaround-importlib-error.

Reported-by: Formbi <formbi <at> protonmail.com>
---
 gnu/packages/qt.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index a79338f84e..e8654eee44 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -4005,6 +4005,7 @@ (define-public python-shiboken-6
      (substitute-keyword-arguments (package-arguments python-shiboken-2)
        ((#:phases p)
         #~(modify-phases #$p
+            (delete 'workaround-importlib-error)
             (replace 'use-shiboken-dir-only
               (lambda _ (chdir "sources/shiboken6")))))
        ((#:configure-flags flags)

base-commit: 76e041f9eef85bb039c5251d3350c62ee2066883
-- 
2.41.0



[Message part 3 (message/rfc822, inline)]
From: Andreas Enge <andreas <at> enge.fr>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 64841-done <at> debbugs.gnu.org, Formbi <formbi <at> protonmail.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#64841] [PATCH] gnu: python-shiboken-6: Remove inherited
 workaround.
Date: Wed, 26 Jul 2023 14:42:39 +0200
Hello,

Am Tue, Jul 25, 2023 at 08:16:11AM +0800 schrieb Hilton Chain:
> Fixes: <https://issues.guix.gnu.org/64803>.

thanks for the report and the fix! I confirm it makes the package itself and
its unique dependent package python-pyside-6 build.

Closing the bug.

Andreas



This bug report was last modified 1 year and 296 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.