GNU bug report logs - #64830
29.1; C++ treesitter mode no coloration

Previous Next

Full log

Message #94 received at 64830 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 64830 <at> debbugs.gnu.org, acm <at> muc.de, stefankangas <at> gmail.com
Subject: Re: bug#64830: 30.0.50 C++ treesitter mode no coloration
Date: Thu, 29 Aug 2024 09:01:08 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Wed, 28 Aug 2024 21:54:26 -0700
> Cc: Stefan Kangas <stefankangas <at> gmail.com>,
>  Alan Mackenzie <acm <at> muc.de>,
>  64830 <at> debbugs.gnu.org
> 
> Ah, thanks for the review! TIL. Here’s the revised patch.

A few more nits:

> +  const char *sym;
> +  dynlib_addr((void (*) (void)) langfn, &loaded_lang.filename, &sym);
               ^^
We leave one space between the function name and the opening paren.
Also, do you really need the type-cast for langfn?  Do you get
compiler warnings if you remove the cast?

> +DEFUN ("treesit-grammar-location", Ftreesit_grammar_location,
> +       Streesit_grammar_location,
> +       1, 1, 0,
> +       doc: /* Return the path to the grammar file for LANGUAGE.
                             ^^^^
"Path" again.  I suggest "absolute file name" instead.

> +If LANGUAGE isn't loaded yet, load it first.  If the langauge can't be
> +loaded or the path couldn't be found, return nil.  */)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I suggest "or the file name couldn't be determined".

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.