From unknown Sun Jun 22 07:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64824: 30.0.50; define-error not fontified in font-lock mode Resent-From: nealsid@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jul 2023 07:31:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64824@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169018382426933 (code B ref -1); Mon, 24 Jul 2023 07:31:03 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jul 2023 07:30:24 +0000 Received: from localhost ([127.0.0.1]:41622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNq1F-0006zz-S9 for submit@debbugs.gnu.org; Mon, 24 Jul 2023 03:30:23 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNiVe-0002ex-UF for submit@debbugs.gnu.org; Sun, 23 Jul 2023 19:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNiVZ-0001uG-O8 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 19:29:01 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNiVX-0006Og-Ks for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 19:29:01 -0400 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6b9cf1997c4so3646724a34.3 for ; Sun, 23 Jul 2023 16:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690154937; x=1690759737; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Amy2B6O2Yr44+JPkIYhvKwg+yVJUvcYkF+CciA/MyPo=; b=V4CZVL4f5/m9DtUDr0N2Rlt3jBfv+tcpU0eE7EdTdhF870e8S4jHuur/oQ5HtxPh53 V8cntB7hF3ZdMf/aMurISCbj9xwcRnKZsjyUIZfOITApxLcJh3MGsBaElqZzIByFAjU9 GcFGn4cWThgX7ULqUI7Jaj//HHv9YDetRFg5AM9tsUoutZZorR/P/rkscgamaK/5gRv/ SYkE11Z/7mbrt1YNZz1TYonzx37ZMlHteYXrRQCodYNbio/inwvi8c36oD2XMG8zoX9A /xVGHMx7R8X5fVSYg9P3iKRuu/cXnppkwDi0g8mKvU9ketqzJUDnc/NXShajXTB2/rDs ao2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690154937; x=1690759737; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Amy2B6O2Yr44+JPkIYhvKwg+yVJUvcYkF+CciA/MyPo=; b=Nhj2wPoC3JvHAAph24IMV+HY59B/Yg4rPDwq+gcis5+rmkE5bIvMd1FhYPBp5QdLsm K5/yw5rgaOJ0k0w7BQQ6J2HPhKuVFEv3yrm0wm/+Ko4n0dtd3EEn3ktA16e0odr7qW6m heIAZHMHLfYH7DOFynoR1mu6HnXqPQDFEIvHjFCw+dS0veaLYhMmcWluJH2CI7IGOapE 1cMoFOrTqJ2DsrszAjqTAH/W5DxjgtihhEda2LtJ0PSJZEoXsQ+n6OkPxtRZ7oqw7Qg1 /kLjQoNkumQM309tHjRVMDqR6UALlcG5d9Db2qf47pkQp3REHj1+lhIwqLEYvZ0Q0kNS Wwug== X-Gm-Message-State: ABy/qLbvL4sWn9pbz4Ulg+nJ0YqbTDrSrhCyc3oFjHhpYaeetTokgN3f Qs/4pJlCkRFfPWcyMtIQK/snPcG8VWg= X-Google-Smtp-Source: APBJJlErjvZJGkF5uX799nJ8i89Sa5Fb2O6U3QJc1zzAbNVZmU/BmYft2a/1gVUYRmMIOOWnlC5j2g== X-Received: by 2002:a05:6871:10b:b0:1b7:642a:40c9 with SMTP id y11-20020a056871010b00b001b7642a40c9mr9048070oab.59.1690154937675; Sun, 23 Jul 2023 16:28:57 -0700 (PDT) Received: from archlinux (107-218-116-63.lightspeed.jcvlfl.sbcglobal.net. [107.218.116.63]) by smtp.gmail.com with ESMTPSA id u2-20020a05687036c200b0019f188355a8sm3761781oak.17.2023.07.23.16.28.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 16:28:57 -0700 (PDT) From: nealsid@gmail.com Date: Sun, 23 Jul 2023 19:28:56 -0400 Message-ID: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::32f; envelope-from=nealsid@gmail.com; helo=mail-ot1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Mon, 24 Jul 2023 03:30:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain In a buffer with emacs-lisp-mode active, 'define-error' is not fontified by font-lock mode. The keyword should be listed somewhere around line 360 in emacs-lisp/lisp-mode.el. Recipe: - Start emacs - Visit a file ending in .el - Type: (define-error 'new-error "this is a new error") - Wait for fontification to complete and notice it is not highlighted In lisp-mode.el, there is a comment about constructs being updated automatically from obarray, but I was not able to understand how this happens, and thought maybe the comment is referring to symbols created with those commands? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-define-error-to-font-lock-keywords-for-emacs-lis.patch Content-Description: Add define-error to font lock keywords & tests >From 39b0bfb5464ff59d11efb35d417bfb6b2b20c788 Mon Sep 17 00:00:00 2001 From: Neal Sidhwaney Date: Sun, 23 Jul 2023 19:25:51 -0400 Subject: [PATCH] Add define-error to font lock keywords for emacs-lisp-mode Also bump up test coverage for keywords to ensure they are fontified. --- lisp/emacs-lisp/lisp-mode.el | 2 +- test/lisp/emacs-lisp/lisp-mode-tests.el | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index 1990630608d..f1cacebb964 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -361,7 +361,7 @@ This will generate compile-time constants from BINDINGS." "define-globalized-minor-mode" "define-skeleton" "define-widget" "ert-deftest")) (el-vdefs '("defconst" "defcustom" "defvaralias" "defvar-local" - "defface")) + "defface" "define-error")) (el-tdefs '("defgroup" "deftheme")) (el-errs '("user-error")) ;; Common-Lisp constructs supported by EIEIO. FIXME: namespace. diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index 3e906497020..5a2d1ed53a8 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -355,5 +355,29 @@ Expected initialization file: `%s'\" ;; (should (equal (lisp-current-defun-name) "defblarg"))) ) +(ert-deftest test-font-lock-keywords () + "Keywords should be fontified in `font-lock-keyword-face`." + (with-temp-buffer + (emacs-lisp-mode) + (mapc (lambda (el-keyword) + (erase-buffer) + (insert (format "(%s some-symbol () \"hello\"" el-keyword)) + (font-lock-ensure) + ;; Verify face property throughout the keyword + (let* ((begin (1+ (point-min))) + (end (1- (+ begin (length el-keyword))))) + (mapc (lambda (pos) + (message "%s %s" el-keyword pos) + (should (equal (get-text-property pos 'face) + 'font-lock-keyword-face))) + (number-sequence begin end)))) + '("defsubst" "cl-defsubst" "define-inline" + "define-advice" "defadvice" "defalias" + "define-derived-mode" "define-minor-mode" + "define-generic-mode" "define-global-minor-mode" + "define-globalized-minor-mode" "define-skeleton" + "define-widget" "ert-deftest" "defconst" "defcustom" + "defvaralias" "defvar-local" "defface" "define-error")))) + (provide 'lisp-mode-tests) ;;; lisp-mode-tests.el ends here -- 2.41.0 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-15 built on archlinux Repository revision: c5fa58cbc4a33a0a65494b9ab2e35d4f30ab849b Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-libotf --without-m17n-flt --without-gconf --with-native-compilation=yes --with-xinput2 --with-x-toolkit=gtk3 --without-xaw3d --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection' LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: C.UTF-8 locale-coding-system: utf-8-unix Major mode: Shell Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t which-function-mode: t shell-dirtrack-mode: t comint-fontify-input-mode: t server-mode: t global-auto-revert-mode: t windmove-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/nealsid/.emacs.d/elpa/transient-20230501.1034/transient hides /usr/share/emacs/30.0.50/lisp/transient Features: (reveal smtpmail mailalias mailclient textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check shadow sort mail-extr emacsbug make-mode descr-text dabbrev erts-mode jka-compr apropos cc-langs grep mode-local re-builder mule-util display-line-numbers ffap cus-edit cus-start wid-edit cl-print shortdoc cl-indent inf-lisp help-fns radix-tree paredit magit-gitignore pcmpl-git misearch multi-isearch vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view vc bug-reference pcmpl-unix sh-script smie treesit executable ert pp ewoc debug backtrace sqlite flymake-proc flymake project cl compile noutline outline lisp-mnt thingatpt find-func vc-git vc-dispatcher magit-extras face-remap magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff diff-mode easy-mmode git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient edmacro kmacro magit-git magit-base magit-section format-spec cursor-sensor crm dash compat compat-29 dired-aux mm-archive message sendmail yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util text-property-search time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils which-func imenu files-x shell pcomplete comint ansi-osc ansi-color ring deeper-blue-theme server clarity-theme autorevert filenotify cus-load cc-mode cc-fonts cc-guess cc-menus cc-cmds windmove cc-styles cc-align cc-engine cc-vars cc-defs gnutls network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny comp comp-cstr warnings icons rx cl-extra help-mode epg rfc6068 epg-config finder-inf ido color-theme-modern-autoloads dirtree-autoloads elisp-autofmt-autoloads flycheck-autoloads ggtags-autoloads pcase paredit-autoloads pkg-info-autoloads epl-autoloads tree-mode-autoloads windata-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 2411138 372988) (symbols 48 43051 24) (strings 32 390907 16216) (string-bytes 1 13976841) (vectors 16 117983) (vector-slots 8 2802866 272351) (floats 8 232 9407) (intervals 56 238397 3159) (buffers 984 77)) --=-=-=-- From unknown Sun Jun 22 07:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64824: 30.0.50; define-error not fontified in font-lock mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jul 2023 12:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: nealsid@gmail.com Cc: 64824@debbugs.gnu.org Received: via spool by 64824-submit@debbugs.gnu.org id=B64824.16902011983219 (code B ref 64824); Mon, 24 Jul 2023 12:20:01 +0000 Received: (at 64824) by debbugs.gnu.org; 24 Jul 2023 12:19:58 +0000 Received: from localhost ([127.0.0.1]:42042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNuXe-0000pq-Ic for submit@debbugs.gnu.org; Mon, 24 Jul 2023 08:19:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNuXd-0000pZ-9r; Mon, 24 Jul 2023 08:19:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNuXW-0006Jz-B5; Mon, 24 Jul 2023 08:19:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Yjgy7RnbLPE6tfGjSZlzSKjUty8vCAdUPyOtzYXBqK4=; b=MzmlV3Z4ncOV vBoCQuOloD2OF7oFQEFoYQ9O6YuzhZZQhPLYDNB0SdIBfYO6RxfIXvS/2y8UGbTXmmVtjIFArYsPJ paQt2w8hQ7edAtLEs8CwaUjOT+ryYEphUZ0W58cFgF9VuyT1opIdFGwNb4K7o/RWBIlTVbzJyPUsx 8SMPIYINWUd90gNMYia4EBuaX9hIxoAMnBj1J56AP7do9+qlZIiV8ZzW0blaUySf13jk4R9QOz6tV GZKhs5+h/eA+Xpbs62tswlICiO8EDLHa2e5UUfIoHf2vslEjD41ocE3Ez+FxO4mVtSQvsjYLeTXmE oKKbBGQhn1g3W12tiGfVyQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNuXU-0004NU-D6; Mon, 24 Jul 2023 08:19:50 -0400 Date: Mon, 24 Jul 2023 15:20:32 +0300 Message-Id: <83mszlsdpr.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> (nealsid@gmail.com) References: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 64824 64823 thanks > From: nealsid@gmail.com > Date: Sun, 23 Jul 2023 19:28:56 -0400 > > In a buffer with emacs-lisp-mode active, 'define-error' is not fontified > by font-lock mode. The keyword should be listed somewhere around line 360 in > emacs-lisp/lisp-mode.el. > > Recipe: > > - Start emacs > - Visit a file ending in .el > - Type: (define-error 'new-error "this is a new error") > - Wait for fontification to complete and notice it is not highlighted > > In lisp-mode.el, there is a comment about constructs being updated > automatically from obarray, but I was not able to understand how this > happens, and thought maybe the comment is referring to symbols created > with those commands? Thanks I merged this with your original report, since it's the same issue. From unknown Sun Jun 22 07:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64824: 30.0.50; define-error not fontified in font-lock mode Resent-From: Neal Sidhwaney Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2023 07:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64824@debbugs.gnu.org Received: via spool by 64824-submit@debbugs.gnu.org id=B64824.16902701295077 (code B ref 64824); Tue, 25 Jul 2023 07:29:02 +0000 Received: (at 64824) by debbugs.gnu.org; 25 Jul 2023 07:28:49 +0000 Received: from localhost ([127.0.0.1]:44549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOCTN-0001Jk-OV for submit@debbugs.gnu.org; Tue, 25 Jul 2023 03:28:49 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:59618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qO1El-0003ZN-Vz for 64824@debbugs.gnu.org; Mon, 24 Jul 2023 15:28:57 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-98dfb3f9af6so816623266b.2 for <64824@debbugs.gnu.org>; Mon, 24 Jul 2023 12:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690226930; x=1690831730; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tdj9bQLdxCg4z7k96EgprJ5FpN1+Gm7fE1zZjn+Z+BM=; b=gSLmF60P4h+NlUQlwBlbDrfs/sWe3ut6y8jPODwqheX1qcYkdW+zKlHaU8sJRfJtM6 zIEg2gdo30DEzjFyEp/6XkDH1bEzsqSWYEpj5rr8TrnE7OXSrxFFy6pZKQ/1zVAK6Ruw LwS9KGQ2YSfLiMJyTT3U9o4sePZqvM7ZJsr7esnFqMNz8JRP/OuJow9mdTZX+gsYKdx5 on3gokqPNDokgIeN1ZzWqrh481hS1KadCYdj6ZQS5eXkmzLCO38WlZOBtTJZ7AyBP4yM rTZF0HhPpDp4WfFU/HYLCnh+z5nXzSJHj1Jehdv2CVTwx2J1TDO1exNEOSkmwnFGBYGQ 16qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690226930; x=1690831730; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tdj9bQLdxCg4z7k96EgprJ5FpN1+Gm7fE1zZjn+Z+BM=; b=eGLXkaO/PxMmyaLyIRqbhR3YT0ZvYlY8tZwNrxyWdfvtVcGxZ9owf5YpbFyMiB8HpV XZjyey9hfnSqUaE3TQn4HK7DJU6eprDHkS0gbFOpZGohRInb03wDgSZKhMlkkNWSSiAl a9Y01kE5EBHCDgIBTDnLsArOPLo8CCoReGcgoFEt+PdfSM62wzgEpQbtg7A3Ra8uof4j HigLzAmwZpVwnS/Jm660x9esPq1adwSflXi0plO5AfNUrulKPJta9xo5CMSao31V7T4Q +nxn2DhKvXVrSfwE5zTcQArtJQExhSKfO14NKiLX1FkdbngXhBCZEv6iqn7Fw4eXzLMg A6RQ== X-Gm-Message-State: ABy/qLZ+HwD/h0NN3/0cbVTPc/VwSaIfx+PmQsZlibpX75PHKAprzxuD GauL2o8xpfWoVR6Q5+EQlSIP1ikyppaSqicTcMI= X-Google-Smtp-Source: APBJJlEzk/Ze5evQFnJZPC8ohEAPGRCE0hM5CO96zpjwg0mWlVZ/6WO3daPSmJl9Dz0V50jn2VlYSpsRsIeUSLbspP0= X-Received: by 2002:a17:906:51de:b0:993:d97f:ae06 with SMTP id v30-20020a17090651de00b00993d97fae06mr11262122ejk.13.1690226930204; Mon, 24 Jul 2023 12:28:50 -0700 (PDT) MIME-Version: 1.0 References: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> <83mszlsdpr.fsf@gnu.org> In-Reply-To: <83mszlsdpr.fsf@gnu.org> From: Neal Sidhwaney Date: Mon, 24 Jul 2023 15:28:14 -0400 Message-ID: Content-Type: multipart/alternative; boundary="000000000000c3c7540601409f5a" X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Tue, 25 Jul 2023 03:28:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c3c7540601409f5a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks! Sorry, forgot the patch in the first email =F0=9F=A4=A6=E2=80=8D=E2= =99=82=EF=B8=8F On Mon, Jul 24, 2023 at 8:19=E2=80=AFAM Eli Zaretskii wrote: > merge 64824 64823 > thanks > > > From: nealsid@gmail.com > > Date: Sun, 23 Jul 2023 19:28:56 -0400 > > > > In a buffer with emacs-lisp-mode active, 'define-error' is not fontifie= d > > by font-lock mode. The keyword should be listed somewhere around line > 360 in > > emacs-lisp/lisp-mode.el. > > > > Recipe: > > > > - Start emacs > > - Visit a file ending in .el > > - Type: (define-error 'new-error "this is a new error") > > - Wait for fontification to complete and notice it is not highlighted > > > > In lisp-mode.el, there is a comment about constructs being updated > > automatically from obarray, but I was not able to understand how this > > happens, and thought maybe the comment is referring to symbols created > > with those commands? > > Thanks I merged this with your original report, since it's the same > issue. > --000000000000c3c7540601409f5a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks! Sorry, forgot the patch in the first email =F0=9F= =A4=A6=E2=80=8D=E2=99=82=EF=B8=8F

On Mon, Jul 24, 2023 at 8:19=E2=80=AFAM El= i Zaretskii <eliz@gnu.org> wrote:=
merge 64824 64823
thanks

> From: nealsid@g= mail.com
> Date: Sun, 23 Jul 2023 19:28:56 -0400
>
> In a buffer with emacs-lisp-mode active, 'define-error' is not= fontified
> by font-lock mode.=C2=A0 The keyword should be listed somewhere around= line 360 in
> emacs-lisp/lisp-mode.el.
>
> Recipe:
>
> - Start emacs
> - Visit a file ending in .el
> - Type: (define-error 'new-error "this is a new error")<= br> > - Wait for fontification to complete and notice it is not highlighted<= br> >
> In lisp-mode.el, there is a comment about constructs being updated
> automatically from obarray, but I was not able to understand how this<= br> > happens, and thought maybe the comment is referring to symbols created=
> with those commands?

Thanks I merged this with your original report, since it's the same
issue.
--000000000000c3c7540601409f5a-- From unknown Sun Jun 22 07:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64824: v2 of patch References: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> In-Reply-To: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> Resent-From: nealsid@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2023 07:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64824@debbugs.gnu.org Received: via spool by 64824-submit@debbugs.gnu.org id=B64824.16902701305084 (code B ref 64824); Tue, 25 Jul 2023 07:29:02 +0000 Received: (at 64824) by debbugs.gnu.org; 25 Jul 2023 07:28:50 +0000 Received: from localhost ([127.0.0.1]:44551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOCTR-0001Jq-EH for submit@debbugs.gnu.org; Tue, 25 Jul 2023 03:28:50 -0400 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]:55703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qO6Ms-0004m3-9u for 64824@debbugs.gnu.org; Mon, 24 Jul 2023 20:57:42 -0400 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-583d702129cso23742577b3.3 for <64824@debbugs.gnu.org>; Mon, 24 Jul 2023 17:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690246652; x=1690851452; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=4QkQ1n6t+PipAr4S2q0NnE/Caj3la1K31jFJeUJVSHQ=; b=WiEsvE9bbSPVnqA0/9uSLPPDP8Q0GmJUuCtmjT3gRQEDfiy0wyKh5xhW+m5AP38Ll0 e8fOUnImOCyhksBhDYC6KOJXTT10u+Ss2DraHRsuhhS7qrMAei9FZMYXNf5d/7s89KVx e0F3WbISvyjAlBN7nGhy5HoxWqZe3WPsr8mxLchikw6AX47AcKFmzslQCbwXg9pxVf3E /nEfX5kM5Z//ff/5XCK3CjTY15ubdn+2tcSyNP7wL7/0Lv0f/VryW/9kwm30XXAzvmUf a0xXzuZ+WlKifkVf+UCPNhHotb3QNJxKflyLd5bHt9J3J0079k5kZPKpms/1MfBkpfHn QMWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690246652; x=1690851452; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4QkQ1n6t+PipAr4S2q0NnE/Caj3la1K31jFJeUJVSHQ=; b=hrq7z0kyiHtKNXtpXmjyBVNsiWmhr9m2pZg+KeH2d71cDYAw5T4RSjWlJ+yqDq2nYM mUxILsU9FeOzDzmBUHep+Tn1XccmBuVpYPyDSes4ktt3EP+W/5Wuv1/m0zAUlP72edZZ yt2OSO+vf9cENaE+/yfK5tCbK4YQ/3ItzTCai6iGxqZLlqRj/AxlKDH/LX20vzrCY+tL rZiMFWFbQzMhxZsof9+HylhpX4xa391WZ3qnoQdkY+QpsJla03JpWOBZkny6pbyYaIzs A5tpmFFTYgF7bJncEylCS7YnJqkhM0iJ3enm+Jk3gMhwHxBOv1lOpvh0MCpMwET1lx4i hSRg== X-Gm-Message-State: ABy/qLbJ5xlq08JgiZQexPZ8mB5uD84cV8H8ZQhiLu/y9v8jHdAauu9u Iy7fxU3sOqrwr0ckT96vRIO0olt/xIE= X-Google-Smtp-Source: APBJJlG7jDZHn3Xc5sk6AQv0pRpT7zJjSh5aQIJvjMzvSjD8i9twInsJMFiuZmbXhv46ajym/dr0Dw== X-Received: by 2002:a0d:cbc4:0:b0:577:d44:a163 with SMTP id n187-20020a0dcbc4000000b005770d44a163mr7914403ywd.6.1690246651898; Mon, 24 Jul 2023 17:57:31 -0700 (PDT) Received: from archlinux (107-218-116-63.lightspeed.jcvlfl.sbcglobal.net. [107.218.116.63]) by smtp.gmail.com with ESMTPSA id s204-20020a8177d5000000b005837b48d16csm3199350ywc.84.2023.07.24.17.57.31 for <64824@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 17:57:31 -0700 (PDT) From: nealsid@gmail.com Date: Mon, 24 Jul 2023 20:57:30 -0400 Message-ID: <87ila8iz9h.fsf@archlinux.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Tue, 25 Jul 2023 03:28:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Sorry, I left some debug logging in the patch sent with the bug report. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-define-error-to-font-lock-keywords-for-emacs-lis.patch Content-Description: Add define-error to lisp font lock keywords and tests >From 7784ccf8555e31485c61468ee5c18533a2331421 Mon Sep 17 00:00:00 2001 From: Neal Sidhwaney Date: Sun, 23 Jul 2023 19:25:51 -0400 Subject: [PATCH] Add define-error to font lock keywords for emacs-lisp-mode Also bump up test coverage for keywords to ensure they are fontified. --- lisp/emacs-lisp/lisp-mode.el | 2 +- test/lisp/emacs-lisp/lisp-mode-tests.el | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index 1990630608d..f1cacebb964 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -361,7 +361,7 @@ This will generate compile-time constants from BINDINGS." "define-globalized-minor-mode" "define-skeleton" "define-widget" "ert-deftest")) (el-vdefs '("defconst" "defcustom" "defvaralias" "defvar-local" - "defface")) + "defface" "define-error")) (el-tdefs '("defgroup" "deftheme")) (el-errs '("user-error")) ;; Common-Lisp constructs supported by EIEIO. FIXME: namespace. diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index 3e906497020..825e6b6ab80 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -355,5 +355,28 @@ Expected initialization file: `%s'\" ;; (should (equal (lisp-current-defun-name) "defblarg"))) ) +(ert-deftest test-font-lock-keywords () + "Keywords should be fontified in `font-lock-keyword-face`." + (with-temp-buffer + (emacs-lisp-mode) + (mapc (lambda (el-keyword) + (erase-buffer) + (insert (format "(%s some-symbol () \"hello\"" el-keyword)) + (font-lock-ensure) + ;; Verify face property throughout the keyword + (let* ((begin (1+ (point-min))) + (end (1- (+ begin (length el-keyword))))) + (mapc (lambda (pos) + (should (equal (get-text-property pos 'face) + 'font-lock-keyword-face))) + (number-sequence begin end)))) + '("defsubst" "cl-defsubst" "define-inline" + "define-advice" "defadvice" "defalias" + "define-derived-mode" "define-minor-mode" + "define-generic-mode" "define-global-minor-mode" + "define-globalized-minor-mode" "define-skeleton" + "define-widget" "ert-deftest" "defconst" "defcustom" + "defvaralias" "defvar-local" "defface" "define-error")))) + (provide 'lisp-mode-tests) ;;; lisp-mode-tests.el ends here -- 2.41.0 --=-=-=-- From unknown Sun Jun 22 07:54:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: nealsid@gmail.com Subject: bug#64824: closed (Re: bug#64824: 30.0.50; define-error not fontified in font-lock mode) Message-ID: References: <83fs5aoilx.fsf@gnu.org> <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> X-Gnu-PR-Message: they-closed 64824 X-Gnu-PR-Package: emacs Reply-To: 64824@debbugs.gnu.org Date: Wed, 26 Jul 2023 14:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1690381502-7196-1" This is a multi-part message in MIME format... ------------=_1690381502-7196-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64824: 30.0.50; define-error not fontified in font-lock mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64824@debbugs.gnu.org. --=20 64824: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64824 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1690381502-7196-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64824-done) by debbugs.gnu.org; 26 Jul 2023 14:24:36 +0000 Received: from localhost ([127.0.0.1]:49755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOfRL-0001rQ-NC for submit@debbugs.gnu.org; Wed, 26 Jul 2023 10:24:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOfRJ-0001rB-Fr for 64824-done@debbugs.gnu.org; Wed, 26 Jul 2023 10:24:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOfRE-0002qD-2k; Wed, 26 Jul 2023 10:24:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DWDnU/tFGn+xgFg6f0IY1gyl/3kW+nYFHu2EAGtrzBY=; b=Cdij39tmNldA 5GE/XDK6CS5FSSY1seQiR1fdeXq9bY/nP4VPJlzg2olcPOeXwove5gsBOSZYbBr5R1IuLYkEdKDkW 6534E8QTw1fc9soJ1SzB+jobA4i5gMPGAfPm96ryUJbgna9Fe7IklcTwAi8gDCDtkAguOEpIrA1Mo /78nUcfK0AlbOoN9tdeb7Rhb2Kl9wX80Oo6+ibv7FoDSBYR8TvgU1/3IhYrjgFf1zv/G93KEnAWzb le8W0ri7P0sPI8CpBCNqHeFg2Mf78kiIZ81kikhHZhkTHLq9szRitcZJrsQtySsT0+MS4MzjEezaG cQuBgqR5dx2kzCofKWCWbQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOfRD-0000KU-8z; Wed, 26 Jul 2023 10:24:27 -0400 Date: Wed, 26 Jul 2023 17:25:14 +0300 Message-Id: <83fs5aoilx.fsf@gnu.org> From: Eli Zaretskii To: nealsid@gmail.com In-Reply-To: <87ila8iz9h.fsf@archlinux.mail-host-address-is-not-set> (nealsid@gmail.com) Subject: Re: bug#64824: 30.0.50; define-error not fontified in font-lock mode References: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> <87ila8iz9h.fsf@archlinux.mail-host-address-is-not-set> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64824-done Cc: 64824-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: nealsid@gmail.com > Date: Mon, 24 Jul 2023 20:57:30 -0400 > > Sorry, I left some debug logging in the patch sent with the bug > report. Thanks, installed on the master branch, and closing the bug. Please in the future format the commit log messages according to our conventions (see CONTRIBUTE for the details). Also, with this contribution you have exhausted the amount of code we can accept from you without a copyright assignment. Would you like to start the assignment paperwork at this time, so that we could accept more of your contributions without limitations? ------------=_1690381502-7196-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Jul 2023 07:30:24 +0000 Received: from localhost ([127.0.0.1]:41622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNq1F-0006zz-S9 for submit@debbugs.gnu.org; Mon, 24 Jul 2023 03:30:23 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNiVe-0002ex-UF for submit@debbugs.gnu.org; Sun, 23 Jul 2023 19:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNiVZ-0001uG-O8 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 19:29:01 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNiVX-0006Og-Ks for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 19:29:01 -0400 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6b9cf1997c4so3646724a34.3 for ; Sun, 23 Jul 2023 16:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690154937; x=1690759737; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Amy2B6O2Yr44+JPkIYhvKwg+yVJUvcYkF+CciA/MyPo=; b=V4CZVL4f5/m9DtUDr0N2Rlt3jBfv+tcpU0eE7EdTdhF870e8S4jHuur/oQ5HtxPh53 V8cntB7hF3ZdMf/aMurISCbj9xwcRnKZsjyUIZfOITApxLcJh3MGsBaElqZzIByFAjU9 GcFGn4cWThgX7ULqUI7Jaj//HHv9YDetRFg5AM9tsUoutZZorR/P/rkscgamaK/5gRv/ SYkE11Z/7mbrt1YNZz1TYonzx37ZMlHteYXrRQCodYNbio/inwvi8c36oD2XMG8zoX9A /xVGHMx7R8X5fVSYg9P3iKRuu/cXnppkwDi0g8mKvU9ketqzJUDnc/NXShajXTB2/rDs ao2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690154937; x=1690759737; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Amy2B6O2Yr44+JPkIYhvKwg+yVJUvcYkF+CciA/MyPo=; b=Nhj2wPoC3JvHAAph24IMV+HY59B/Yg4rPDwq+gcis5+rmkE5bIvMd1FhYPBp5QdLsm K5/yw5rgaOJ0k0w7BQQ6J2HPhKuVFEv3yrm0wm/+Ko4n0dtd3EEn3ktA16e0odr7qW6m heIAZHMHLfYH7DOFynoR1mu6HnXqPQDFEIvHjFCw+dS0veaLYhMmcWluJH2CI7IGOapE 1cMoFOrTqJ2DsrszAjqTAH/W5DxjgtihhEda2LtJ0PSJZEoXsQ+n6OkPxtRZ7oqw7Qg1 /kLjQoNkumQM309tHjRVMDqR6UALlcG5d9Db2qf47pkQp3REHj1+lhIwqLEYvZ0Q0kNS Wwug== X-Gm-Message-State: ABy/qLbvL4sWn9pbz4Ulg+nJ0YqbTDrSrhCyc3oFjHhpYaeetTokgN3f Qs/4pJlCkRFfPWcyMtIQK/snPcG8VWg= X-Google-Smtp-Source: APBJJlErjvZJGkF5uX799nJ8i89Sa5Fb2O6U3QJc1zzAbNVZmU/BmYft2a/1gVUYRmMIOOWnlC5j2g== X-Received: by 2002:a05:6871:10b:b0:1b7:642a:40c9 with SMTP id y11-20020a056871010b00b001b7642a40c9mr9048070oab.59.1690154937675; Sun, 23 Jul 2023 16:28:57 -0700 (PDT) Received: from archlinux (107-218-116-63.lightspeed.jcvlfl.sbcglobal.net. [107.218.116.63]) by smtp.gmail.com with ESMTPSA id u2-20020a05687036c200b0019f188355a8sm3761781oak.17.2023.07.23.16.28.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 16:28:57 -0700 (PDT) From: nealsid@gmail.com To: bug-gnu-emacs@gnu.org Subject: 30.0.50; define-error not fontified in font-lock mode Date: Sun, 23 Jul 2023 19:28:56 -0400 Message-ID: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::32f; envelope-from=nealsid@gmail.com; helo=mail-ot1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 24 Jul 2023 03:30:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain In a buffer with emacs-lisp-mode active, 'define-error' is not fontified by font-lock mode. The keyword should be listed somewhere around line 360 in emacs-lisp/lisp-mode.el. Recipe: - Start emacs - Visit a file ending in .el - Type: (define-error 'new-error "this is a new error") - Wait for fontification to complete and notice it is not highlighted In lisp-mode.el, there is a comment about constructs being updated automatically from obarray, but I was not able to understand how this happens, and thought maybe the comment is referring to symbols created with those commands? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-define-error-to-font-lock-keywords-for-emacs-lis.patch Content-Description: Add define-error to font lock keywords & tests >From 39b0bfb5464ff59d11efb35d417bfb6b2b20c788 Mon Sep 17 00:00:00 2001 From: Neal Sidhwaney Date: Sun, 23 Jul 2023 19:25:51 -0400 Subject: [PATCH] Add define-error to font lock keywords for emacs-lisp-mode Also bump up test coverage for keywords to ensure they are fontified. --- lisp/emacs-lisp/lisp-mode.el | 2 +- test/lisp/emacs-lisp/lisp-mode-tests.el | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index 1990630608d..f1cacebb964 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -361,7 +361,7 @@ This will generate compile-time constants from BINDINGS." "define-globalized-minor-mode" "define-skeleton" "define-widget" "ert-deftest")) (el-vdefs '("defconst" "defcustom" "defvaralias" "defvar-local" - "defface")) + "defface" "define-error")) (el-tdefs '("defgroup" "deftheme")) (el-errs '("user-error")) ;; Common-Lisp constructs supported by EIEIO. FIXME: namespace. diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index 3e906497020..5a2d1ed53a8 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -355,5 +355,29 @@ Expected initialization file: `%s'\" ;; (should (equal (lisp-current-defun-name) "defblarg"))) ) +(ert-deftest test-font-lock-keywords () + "Keywords should be fontified in `font-lock-keyword-face`." + (with-temp-buffer + (emacs-lisp-mode) + (mapc (lambda (el-keyword) + (erase-buffer) + (insert (format "(%s some-symbol () \"hello\"" el-keyword)) + (font-lock-ensure) + ;; Verify face property throughout the keyword + (let* ((begin (1+ (point-min))) + (end (1- (+ begin (length el-keyword))))) + (mapc (lambda (pos) + (message "%s %s" el-keyword pos) + (should (equal (get-text-property pos 'face) + 'font-lock-keyword-face))) + (number-sequence begin end)))) + '("defsubst" "cl-defsubst" "define-inline" + "define-advice" "defadvice" "defalias" + "define-derived-mode" "define-minor-mode" + "define-generic-mode" "define-global-minor-mode" + "define-globalized-minor-mode" "define-skeleton" + "define-widget" "ert-deftest" "defconst" "defcustom" + "defvaralias" "defvar-local" "defface" "define-error")))) + (provide 'lisp-mode-tests) ;;; lisp-mode-tests.el ends here -- 2.41.0 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-15 built on archlinux Repository revision: c5fa58cbc4a33a0a65494b9ab2e35d4f30ab849b Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-libotf --without-m17n-flt --without-gconf --with-native-compilation=yes --with-xinput2 --with-x-toolkit=gtk3 --without-xaw3d --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection' LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: C.UTF-8 locale-coding-system: utf-8-unix Major mode: Shell Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t which-function-mode: t shell-dirtrack-mode: t comint-fontify-input-mode: t server-mode: t global-auto-revert-mode: t windmove-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/nealsid/.emacs.d/elpa/transient-20230501.1034/transient hides /usr/share/emacs/30.0.50/lisp/transient Features: (reveal smtpmail mailalias mailclient textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check shadow sort mail-extr emacsbug make-mode descr-text dabbrev erts-mode jka-compr apropos cc-langs grep mode-local re-builder mule-util display-line-numbers ffap cus-edit cus-start wid-edit cl-print shortdoc cl-indent inf-lisp help-fns radix-tree paredit magit-gitignore pcmpl-git misearch multi-isearch vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view vc bug-reference pcmpl-unix sh-script smie treesit executable ert pp ewoc debug backtrace sqlite flymake-proc flymake project cl compile noutline outline lisp-mnt thingatpt find-func vc-git vc-dispatcher magit-extras face-remap magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff diff-mode easy-mmode git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient edmacro kmacro magit-git magit-base magit-section format-spec cursor-sensor crm dash compat compat-29 dired-aux mm-archive message sendmail yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util text-property-search time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils which-func imenu files-x shell pcomplete comint ansi-osc ansi-color ring deeper-blue-theme server clarity-theme autorevert filenotify cus-load cc-mode cc-fonts cc-guess cc-menus cc-cmds windmove cc-styles cc-align cc-engine cc-vars cc-defs gnutls network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny comp comp-cstr warnings icons rx cl-extra help-mode epg rfc6068 epg-config finder-inf ido color-theme-modern-autoloads dirtree-autoloads elisp-autofmt-autoloads flycheck-autoloads ggtags-autoloads pcase paredit-autoloads pkg-info-autoloads epl-autoloads tree-mode-autoloads windata-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 2411138 372988) (symbols 48 43051 24) (strings 32 390907 16216) (string-bytes 1 13976841) (vectors 16 117983) (vector-slots 8 2802866 272351) (floats 8 232 9407) (intervals 56 238397 3159) (buffers 984 77)) --=-=-=-- ------------=_1690381502-7196-1-- From unknown Sun Jun 22 07:54:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: nealsid@gmail.com Subject: bug#64823: closed (Re: bug#64824: 30.0.50; define-error not fontified in font-lock mode) Message-ID: References: <83fs5aoilx.fsf@gnu.org> <878rb6gqm0.fsf@archlinux.mail-host-address-is-not-set> X-Gnu-PR-Message: they-closed 64823 X-Gnu-PR-Package: emacs Reply-To: 64823@debbugs.gnu.org Date: Wed, 26 Jul 2023 14:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1690381502-7196-3" This is a multi-part message in MIME format... ------------=_1690381502-7196-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64824: 30.0.50; define-error in font-lock mode should be fontified which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64823@debbugs.gnu.org. --=20 64824: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64824 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1690381502-7196-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64824-done) by debbugs.gnu.org; 26 Jul 2023 14:24:36 +0000 Received: from localhost ([127.0.0.1]:49755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOfRL-0001rQ-NC for submit@debbugs.gnu.org; Wed, 26 Jul 2023 10:24:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOfRJ-0001rB-Fr for 64824-done@debbugs.gnu.org; Wed, 26 Jul 2023 10:24:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOfRE-0002qD-2k; Wed, 26 Jul 2023 10:24:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DWDnU/tFGn+xgFg6f0IY1gyl/3kW+nYFHu2EAGtrzBY=; b=Cdij39tmNldA 5GE/XDK6CS5FSSY1seQiR1fdeXq9bY/nP4VPJlzg2olcPOeXwove5gsBOSZYbBr5R1IuLYkEdKDkW 6534E8QTw1fc9soJ1SzB+jobA4i5gMPGAfPm96ryUJbgna9Fe7IklcTwAi8gDCDtkAguOEpIrA1Mo /78nUcfK0AlbOoN9tdeb7Rhb2Kl9wX80Oo6+ibv7FoDSBYR8TvgU1/3IhYrjgFf1zv/G93KEnAWzb le8W0ri7P0sPI8CpBCNqHeFg2Mf78kiIZ81kikhHZhkTHLq9szRitcZJrsQtySsT0+MS4MzjEezaG cQuBgqR5dx2kzCofKWCWbQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOfRD-0000KU-8z; Wed, 26 Jul 2023 10:24:27 -0400 Date: Wed, 26 Jul 2023 17:25:14 +0300 Message-Id: <83fs5aoilx.fsf@gnu.org> From: Eli Zaretskii To: nealsid@gmail.com In-Reply-To: <87ila8iz9h.fsf@archlinux.mail-host-address-is-not-set> (nealsid@gmail.com) Subject: Re: bug#64824: 30.0.50; define-error not fontified in font-lock mode References: <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> <87ila8iz9h.fsf@archlinux.mail-host-address-is-not-set> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64824-done Cc: 64824-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: nealsid@gmail.com > Date: Mon, 24 Jul 2023 20:57:30 -0400 > > Sorry, I left some debug logging in the patch sent with the bug > report. Thanks, installed on the master branch, and closing the bug. Please in the future format the commit log messages according to our conventions (see CONTRIBUTE for the details). Also, with this contribution you have exhausted the amount of code we can accept from you without a copyright assignment. Would you like to start the assignment paperwork at this time, so that we could accept more of your contributions without limitations? ------------=_1690381502-7196-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Jul 2023 07:30:14 +0000 Received: from localhost ([127.0.0.1]:41620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNq1E-0006zq-KM for submit@debbugs.gnu.org; Mon, 24 Jul 2023 03:30:13 -0400 Received: from lists.gnu.org ([2001:470:142::17]:57082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNiPi-0002Vz-9m for submit@debbugs.gnu.org; Sun, 23 Jul 2023 19:23:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNiPd-0001So-3I for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 19:22:53 -0400 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNiPb-0005X7-2H for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 19:22:52 -0400 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1bb7297c505so110903fac.1 for ; Sun, 23 Jul 2023 16:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690154568; x=1690759368; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=0Sc6GAaF0qA0ANDHkWqc4goQawECRiREkwZCcd/qxQY=; b=bGiMccpCJsITAAZxRQWE3hIG2Q5HOswdLYG3SvlxeSaYVUlk99C4zezkr4knN+iAxT sB9H3wg8o9eEkQmlQPfp8n9HW86E99+d5f8zJazBHGoWdSEyX/smXhkSh+jo7X0P8D54 roxcPvwBv+jDGmeU7ATWDQ4Q1dOHuig2lvgIdNtxOE9TyXBUXH1EpzHaKGmiBnMVG6PN ZLJ1BlH9BQKvg2Ovmy2k9PKW2j4rmIfSI3iK5QzmUPAILsr/S+WvYLg6UNQKOkboh4ot LWfUzPe/BHL0feZcNo6H4tO1wllCH8+jCNmbOu3QiemyKSKkmxC3g8H70xj+qYT/zLVY bP9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690154568; x=1690759368; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0Sc6GAaF0qA0ANDHkWqc4goQawECRiREkwZCcd/qxQY=; b=AjQzLNfl5pJBlLSq3q/YAWeXxDyNJku7FebzNrkh/go9LRtwUKCEC3L1KconY/aVY0 LkvWoY1wJGTiX/jBeaRqp5G1YTTHCWi3lMUqZgH8F1bxbJXaSU5BdjdPqkdZhQfOeKnl Sh2ZV94evheLRtnobUxduAuTOz92cyVB/AgaSToVeRJx1RYUkpLgylK9KJhgf2/sCRmA c6XRAYkmTplHupaLmtL5qprifu4mjy1ZRzCxvuNbj+vqjw1xonIZwNAWyWFwi7HwhgUH cmycwZWPjpyOICgalWnQLv6bIJsSAXWXX2gDjQr6mCZukfbS+iT4qq0/d+kHWBG+M1PQ yuDg== X-Gm-Message-State: ABy/qLZ8v5EysQr8UXTKhz1jy9CoGvqoZog63xI1WX92fhQAr9qWYqWR oMTi2EtLcYGmye0qiRJeMoqMa9XjRlg= X-Google-Smtp-Source: APBJJlGR0DIGbQ6kLTSbxSi6IMxi1BClL4p7iurWGkBpX6vM8eQmU6QZJ71pjKCySgb0vJH3v91KDA== X-Received: by 2002:a05:6871:89f:b0:1ba:caf2:acc3 with SMTP id r31-20020a056871089f00b001bacaf2acc3mr8418265oaq.5.1690154568293; Sun, 23 Jul 2023 16:22:48 -0700 (PDT) Received: from archlinux (107-218-116-63.lightspeed.jcvlfl.sbcglobal.net. [107.218.116.63]) by smtp.gmail.com with ESMTPSA id u4-20020a056870304400b001b10207f1edsm3739530oau.48.2023.07.23.16.22.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 16:22:47 -0700 (PDT) From: nealsid@gmail.com To: bug-gnu-emacs@gnu.org Subject: 30.0.50; define-error in font-lock mode should be fontified Date: Sun, 23 Jul 2023 19:22:47 -0400 Message-ID: <878rb6gqm0.fsf@archlinux.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4860:4864:20::31; envelope-from=nealsid@gmail.com; helo=mail-oa1-x31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 24 Jul 2023 03:30:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) In a buffer with emacs-lisp-mode active, 'define-error' is not fontified by font-lock mode. The keyword should be listed somewhere around line 360 in emacs-lisp/lisp-mode.el. Recipe: - Start emacs - Visit a file ending in .el - Type: (define-error 'new-error "this is a new error") - Wait for fontification to complete and notice it is not highlighted In lisp-mode.el, there is a comment about constructs being updated automatically from obarray, but I was not able to understand how this happens, and thought maybe the comment is referring to symbols created with those commands? In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-15 built on archlinux Repository revision: c5fa58cbc4a33a0a65494b9ab2e35d4f30ab849b Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-libotf --without-m17n-flt --without-gconf --with-native-compilation=yes --with-xinput2 --with-x-toolkit=gtk3 --without-xaw3d --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection' LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: C.UTF-8 locale-coding-system: utf-8-unix Major mode: Shell Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t which-function-mode: t shell-dirtrack-mode: t comint-fontify-input-mode: t server-mode: t global-auto-revert-mode: t windmove-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/nealsid/.emacs.d/elpa/transient-20230501.1034/transient hides /usr/share/emacs/30.0.50/lisp/transient Features: (shadow sort mail-extr emacsbug make-mode descr-text dabbrev erts-mode jka-compr apropos cc-langs grep mode-local re-builder mule-util display-line-numbers ffap cus-edit cus-start wid-edit cl-print shortdoc cl-indent inf-lisp help-fns radix-tree paredit magit-gitignore pcmpl-git misearch multi-isearch vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view vc bug-reference pcmpl-unix sh-script smie treesit executable ert pp ewoc debug backtrace sqlite flymake-proc flymake project cl compile noutline outline lisp-mnt thingatpt find-func vc-git vc-dispatcher magit-extras face-remap magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff diff-mode easy-mmode git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient edmacro kmacro magit-git magit-base magit-section format-spec cursor-sensor crm dash compat compat-29 dired-aux mm-archive message sendmail yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util text-property-search time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils which-func imenu files-x shell pcomplete comint ansi-osc ansi-color ring deeper-blue-theme server clarity-theme autorevert filenotify cus-load cc-mode cc-fonts cc-guess cc-menus cc-cmds windmove cc-styles cc-align cc-engine cc-vars cc-defs gnutls network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny comp comp-cstr warnings icons rx cl-extra help-mode epg rfc6068 epg-config finder-inf ido color-theme-modern-autoloads dirtree-autoloads elisp-autofmt-autoloads flycheck-autoloads ggtags-autoloads pcase paredit-autoloads pkg-info-autoloads epl-autoloads tree-mode-autoloads windata-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 2271743 440768) (symbols 48 42781 4) (strings 32 376192 15152) (string-bytes 1 13822104) (vectors 16 96038) (vector-slots 8 2449209 293184) (floats 8 233 9406) (intervals 56 236229 855) (buffers 984 70)) ------------=_1690381502-7196-3-- From unknown Sun Jun 22 07:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64824: closed (Re: bug#64824: 30.0.50; define-error not fontified in font-lock mode) Resent-From: Neal Sidhwaney Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jul 2023 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64824@debbugs.gnu.org Received: via spool by 64824-submit@debbugs.gnu.org id=B64824.169044153629322 (code B ref 64824); Thu, 27 Jul 2023 07:06:02 +0000 Received: (at 64824) by debbugs.gnu.org; 27 Jul 2023 07:05:36 +0000 Received: from localhost ([127.0.0.1]:40587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOv41-0007co-Su for submit@debbugs.gnu.org; Thu, 27 Jul 2023 03:05:35 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:53736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOsx8-00042U-1U for 64824@debbugs.gnu.org; Thu, 27 Jul 2023 00:50:19 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6bb2ce4f9f8so448127a34.3 for <64824@debbugs.gnu.org>; Wed, 26 Jul 2023 21:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690433412; x=1691038212; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=T5P9TpBWzYSneu03v/g7zOnJiGxSPF9QIrxkBTuiS+Y=; b=Z9pgzedPXT0Gv5Dr7JRtuqYOun2MZqy+Ll1NAmr0NCt3z2cdUC+frtnGBbGLWazbT6 k+JEeC8zXTDBCDnoWTaZsLNuxuV3xRzxBTy0iqqshMM7sJDary/06xGgQ45FmMoQNT7Y KdZUPobXRMobvguztBPV81PKbPOupzIVErTAcnPu1BgbTreWas/Rbz87OSs03vUm/mOG 4hO2cDDLw5g9ZUG9Ip9SexXEIDn+3pRYRjAm4EVXZaFqTTAezbtHcMtiV5hBc+6J07nK kScP6neF0F3yXjTGG0AerlosAJon9KRyt9iW8TQluhq3ouqb4cPPBXgeiGL52ehHd2kd nzgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690433412; x=1691038212; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T5P9TpBWzYSneu03v/g7zOnJiGxSPF9QIrxkBTuiS+Y=; b=GPlTh8Lfs4DYDmCbs7V+7L4n3XvaGi0vFgQzW8elpdh74iMIoil1l6ZvfOYbgkBgsW vgPHaYAJyEWABLznVJDgVwiNCVsjWR0V42IHNPCCEtMG8ZP9QIV7bGSZzF5OwEneuvXw O9Rl2XDEAFY6+nGx1jB6SWzLfp7M6BvopE4NY8DLKCJUIxr1nDszcgC151kzKyXAEKHx PowBX20KqVNDT594RmofHdVGbodbpa07HPhk/G3fBiYfgdFoy97X9XIk83mrdLpRLyYm U4ufdYvxzNg87GkveepZWj/M5uk6MYsLmGI1r9dCnkD9sU0sP0uPSwa+2nMuJ6vZ8Pw1 gliw== X-Gm-Message-State: ABy/qLahswd2RzgNxXLVVJ4Aaor6LOwQRjfJ/e7AVDN3NtdjLOPHmASi zdNVs4o7vSlstNQJywMWXl9y1JPGDKTeIyX6R5PzuVQK X-Google-Smtp-Source: APBJJlF4T0T/7a4uWtAmWZkJfMb0eq3varYtUg+TasY2At4JR7B3QsFo1hdgFUYJ7bK4edf/cg+xCyA3KAX6A3dyPf8= X-Received: by 2002:a05:6870:e748:b0:1b3:e46a:7164 with SMTP id t8-20020a056870e74800b001b3e46a7164mr2179061oak.40.1690433411944; Wed, 26 Jul 2023 21:50:11 -0700 (PDT) MIME-Version: 1.0 References: <83fs5aoilx.fsf@gnu.org> <874jlugqbr.fsf@archlinux.mail-host-address-is-not-set> In-Reply-To: From: Neal Sidhwaney Date: Thu, 27 Jul 2023 00:49:35 -0400 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000916cc060170b34e" X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Thu, 27 Jul 2023 03:05:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000916cc060170b34e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Eli, Excellent! I will use the conventions next time I send a patch, sorry for missing them for this one. I will also start the paperwork for assigning copyright before subsequent contributions. Thank you, Neal On Wed, Jul 26, 2023 at 10:25=E2=80=AFAM GNU bug Tracking System < help-debbugs@gnu.org> wrote: > Your bug report > > #64824: 30.0.50; define-error not fontified in font-lock mode > > which was filed against the emacs package, has been closed. > > The explanation is attached below, along with your original report. > If you require more details, please reply to 64824@debbugs.gnu.org. > > -- > 64824: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64824 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems > > > > ---------- Forwarded message ---------- > From: Eli Zaretskii > To: nealsid@gmail.com > Cc: 64824-done@debbugs.gnu.org > Bcc: > Date: Wed, 26 Jul 2023 17:25:14 +0300 > Subject: Re: bug#64824: 30.0.50; define-error not fontified in font-lock > mode > > From: nealsid@gmail.com > > Date: Mon, 24 Jul 2023 20:57:30 -0400 > > > > Sorry, I left some debug logging in the patch sent with the bug > > report. > > Thanks, installed on the master branch, and closing the bug. > > Please in the future format the commit log messages according to our > conventions (see CONTRIBUTE for the details). > > Also, with this contribution you have exhausted the amount of code we > can accept from you without a copyright assignment. Would you like to > start the assignment paperwork at this time, so that we could accept > more of your contributions without limitations? > > > > > ---------- Forwarded message ---------- > From: nealsid@gmail.com > To: bug-gnu-emacs@gnu.org > Cc: > Bcc: > Date: Sun, 23 Jul 2023 19:28:56 -0400 > Subject: 30.0.50; define-error not fontified in font-lock mode > > In a buffer with emacs-lisp-mode active, 'define-error' is not fontified > by font-lock mode. The keyword should be listed somewhere around line 36= 0 > in > emacs-lisp/lisp-mode.el. > > Recipe: > > - Start emacs > - Visit a file ending in .el > - Type: (define-error 'new-error "this is a new error") > - Wait for fontification to complete and notice it is not highlighted > > In lisp-mode.el, there is a comment about constructs being updated > automatically from obarray, but I was not able to understand how this > happens, and thought maybe the comment is referring to symbols created > with those commands? > > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.38, cairo version 1.17.8) of 2023-07-15 built on archlinux > Repository revision: c5fa58cbc4a33a0a65494b9ab2e35d4f30ab849b > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.1210100= 8 > System Description: Arch Linux > > Configured using: > 'configure --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/usr/lib > --localstatedir=3D/var --mandir=3D/usr/share/man --with-gameuser=3D:game= s > --with-modules --without-libotf --without-m17n-flt --without-gconf > --with-native-compilation=3Dyes --with-xinput2 --with-x-toolkit=3Dgtk3 > --without-xaw3d --with-sound=3Dno --with-tree-sitter --without-gpm > --without-compress-install > '--program-transform-name=3Ds/\([ec]tags\)/\1.emacs/' > 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptio= ns > -Wp,-D_FORTIFY_SOURCE=3D2 -Wformat -Werror=3Dformat-security > -fstack-clash-protection -fcf-protection' > LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' > > Configured features: > ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON > LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG > RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP > X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB > > Important settings: > value of $LANG: C.UTF-8 > locale-coding-system: utf-8-unix > > Major mode: Shell > > Minor modes in effect: > global-git-commit-mode: t > magit-auto-revert-mode: t > which-function-mode: t > shell-dirtrack-mode: t > comint-fontify-input-mode: t > server-mode: t > global-auto-revert-mode: t > windmove-mode: t > tooltip-mode: t > global-eldoc-mode: t > show-paren-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > column-number-mode: t > line-number-mode: t > transient-mark-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > > Load-path shadows: > /home/nealsid/.emacs.d/elpa/transient-20230501.1034/transient hides > /usr/share/emacs/30.0.50/lisp/transient > > Features: > (reveal smtpmail mailalias mailclient textsec uni-scripts idna-mapping > ucs-normalize uni-confusable textsec-check shadow sort mail-extr > emacsbug make-mode descr-text dabbrev erts-mode jka-compr apropos > cc-langs grep mode-local re-builder mule-util display-line-numbers ffap > cus-edit cus-start wid-edit cl-print shortdoc cl-indent inf-lisp > help-fns radix-tree paredit magit-gitignore pcmpl-git misearch > multi-isearch vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view > vc bug-reference pcmpl-unix sh-script smie treesit executable ert pp > ewoc debug backtrace sqlite flymake-proc flymake project cl compile > noutline outline lisp-mnt thingatpt find-func vc-git vc-dispatcher > magit-extras face-remap magit-submodule magit-blame magit-stash > magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone > magit-remote magit-commit magit-sequence magit-notes magit-worktree > magit-tag magit-merge magit-branch magit-reset magit-files magit-refs > magit-status magit magit-repos magit-apply magit-wip magit-log > magit-diff smerge-mode diff diff-mode easy-mmode git-commit log-edit > pcvs-util add-log magit-core magit-autorevert magit-margin > magit-transient magit-process with-editor magit-mode transient edmacro > kmacro magit-git magit-base magit-section format-spec cursor-sensor crm > dash compat compat-29 dired-aux mm-archive message sendmail yank-media > dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util > text-property-search time-date mailabbrev gmm-utils mailheader mm-decode > mm-bodies mm-encode mail-utils which-func imenu files-x shell pcomplete > comint ansi-osc ansi-color ring deeper-blue-theme server clarity-theme > autorevert filenotify cus-load cc-mode cc-fonts cc-guess cc-menus > cc-cmds windmove cc-styles cc-align cc-engine cc-vars cc-defs gnutls > network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047 > rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny comp comp-cstr > warnings icons rx cl-extra help-mode epg rfc6068 epg-config finder-inf > ido color-theme-modern-autoloads dirtree-autoloads > elisp-autofmt-autoloads flycheck-autoloads ggtags-autoloads pcase > paredit-autoloads pkg-info-autoloads epl-autoloads tree-mode-autoloads > windata-autoloads info package browse-url url url-proxy url-privacy > url-expand url-methods url-history url-cookie generate-lisp-file > url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq > eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv > bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip > cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type > elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd > fontset image regexp-opt fringe tabulated-list replace newcomment > text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow > isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax > font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic > indonesian philippine cham georgian utf-8-lang misc-lang vietnamese > tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek > romanian slovak czech european ethiopic indian cyrillic chinese > composite emoji-zwj charscript charprop case-table epa-hook > jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs > theme-loaddefs faces cus-face macroexp files window text-properties > overlay sha1 md5 base64 format env code-pages mule custom widget keymap > hashtable-print-readable backquote threads dbusbind inotify lcms2 > dynamic-setting system-font-setting font-render-setting cairo gtk > x-toolkit xinput2 x multi-tty move-toolbar make-network-process > native-compile emacs) > > Memory information: > ((conses 16 2411138 372988) (symbols 48 43051 24) > (strings 32 390907 16216) (string-bytes 1 13976841) > (vectors 16 117983) (vector-slots 8 2802866 272351) > (floats 8 232 9407) (intervals 56 238397 3159) (buffers 984 77)) > --0000000000000916cc060170b34e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Eli,

Excellent! I will us= e the conventions next time I send a patch, sorry for missing them for this= one.=C2=A0 I will also start the paperwork for assigning copyright before = subsequent contributions.

Thank you,
Neal

On Wed, Jul 26, 2023 at 10:25=E2=80=AFAM GNU bug = Tracking System <help-debbugs@gn= u.org> wrote:
Your bug report

#64824: 30.0.50; define-error not fontified in font-lock mode

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 64824@debbugs.gnu.org.

--
64824: https://debbugs.gnu.org/cgi/bugreport.cg= i?bug=3D64824
GNU Bug Tracking System
Contact help-debb= ugs@gnu.org with problems



---------- Forwarded message ----------
From:=C2=A0Eli Zaret= skii <eliz@gnu.org= >
To:=C2=A0nea= lsid@gmail.com
Cc:=C2=A064824-done@debbugs.gnu.org
Bcc:=C2=A0
Date:= =C2=A0Wed, 26 Jul 2023 17:25:14 +0300
Subject:=C2=A0Re: bug#64824: 30.0.= 50; define-error not fontified in font-lock mode
> From: nealsid@gmail.com
> Date: Mon, 24 Jul 2023 20:57:30 -0400
>
> Sorry, I left some debug logging in the patch sent with the bug
> report.

Thanks, installed on the master branch, and closing the bug.

Please in the future format the commit log messages according to our
conventions (see CONTRIBUTE for the details).

Also, with this contribution you have exhausted the amount of code we
can accept from you without a copyright assignment.=C2=A0 Would you like to=
start the assignment paperwork at this time, so that we could accept
more of your contributions without limitations?




---------- Forwarded message ----------
From:=C2=A0nealsid@gmail.com
To= :=C2=A0bug-gnu-e= macs@gnu.org
Cc:=C2=A0
Bcc:=C2=A0
Date:=C2=A0Sun, 23 Jul 2023 = 19:28:56 -0400
Subject:=C2=A030.0.50; define-error not fontified in font= -lock mode

In a buffer with emacs-lisp-mode active, 'define-error' is not font= ified
by font-lock mode.=C2=A0 The keyword should be listed somewhere around line= 360 in
emacs-lisp/lisp-mode.el.

Recipe:

- Start emacs
- Visit a file ending in .el
- Type: (define-error 'new-error "this is a new error")
- Wait for fontification to complete and notice it is not highlighted

In lisp-mode.el, there is a comment about constructs being updated
automatically from obarray, but I was not able to understand how this
happens, and thought maybe the comment is referring to symbols created
with those commands?


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
=C2=A03.24.38, cairo version 1.17.8) of 2023-07-15 built on archlinux
Repository revision: c5fa58cbc4a33a0a65494b9ab2e35d4f30ab849b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.1= 2101008
System Description: Arch Linux

Configured using:
=C2=A0'configure --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/us= r/lib
=C2=A0--localstatedir=3D/var --mandir=3D/usr/share/man --with-gameuser=3D:g= ames
=C2=A0--with-modules --without-libotf --without-m17n-flt --without-gconf =C2=A0--with-native-compilation=3Dyes --with-xinput2 --with-x-toolkit=3Dgtk= 3
=C2=A0--without-xaw3d --with-sound=3Dno --with-tree-sitter --without-gpm =C2=A0--without-compress-install
=C2=A0'--program-transform-name=3Ds/\([ec]tags\)/\1.emacs/'
=C2=A0'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -fe= xceptions
=C2=A0-Wp,-D_FORTIFY_SOURCE=3D2 -Wformat -Werror=3Dformat-security
=C2=A0-fstack-clash-protection -fcf-protection'
=C2=A0LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
=C2=A0 value of $LANG: C.UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mode: Shell

Minor modes in effect:
=C2=A0 global-git-commit-mode: t
=C2=A0 magit-auto-revert-mode: t
=C2=A0 which-function-mode: t
=C2=A0 shell-dirtrack-mode: t
=C2=A0 comint-fontify-input-mode: t
=C2=A0 server-mode: t
=C2=A0 global-auto-revert-mode: t
=C2=A0 windmove-mode: t
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 show-paren-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 column-number-mode: t
=C2=A0 line-number-mode: t
=C2=A0 transient-mark-mode: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t

Load-path shadows:
/home/nealsid/.emacs.d/elpa/transient-20230501.1034/transient hides /usr/sh= are/emacs/30.0.50/lisp/transient

Features:
(reveal smtpmail mailalias mailclient textsec uni-scripts idna-mapping
ucs-normalize uni-confusable textsec-check shadow sort mail-extr
emacsbug make-mode descr-text dabbrev erts-mode jka-compr apropos
cc-langs grep mode-local re-builder mule-util display-line-numbers ffap
cus-edit cus-start wid-edit cl-print shortdoc cl-indent inf-lisp
help-fns radix-tree paredit magit-gitignore pcmpl-git misearch
multi-isearch vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view
vc bug-reference pcmpl-unix sh-script smie treesit executable ert pp
ewoc debug backtrace sqlite flymake-proc flymake project cl compile
noutline outline lisp-mnt thingatpt find-func vc-git vc-dispatcher
magit-extras face-remap magit-submodule magit-blame magit-stash
magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-tag magit-merge magit-branch magit-reset magit-files magit-refs
magit-status magit magit-repos magit-apply magit-wip magit-log
magit-diff smerge-mode diff diff-mode easy-mmode git-commit log-edit
pcvs-util add-log magit-core magit-autorevert magit-margin
magit-transient magit-process with-editor magit-mode transient edmacro
kmacro magit-git magit-base magit-section format-spec cursor-sensor crm
dash compat compat-29 dired-aux mm-archive message sendmail yank-media
dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util
text-property-search time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils which-func imenu files-x shell pcomplete
comint ansi-osc ansi-color ring deeper-blue-theme server clarity-theme
autorevert filenotify cus-load cc-mode cc-fonts cc-guess cc-menus
cc-cmds windmove cc-styles cc-align cc-engine cc-vars cc-defs gnutls
network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047
rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny comp comp-cstr
warnings icons rx cl-extra help-mode epg rfc6068 epg-config finder-inf
ido color-theme-modern-autoloads dirtree-autoloads
elisp-autofmt-autoloads flycheck-autoloads ggtags-autoloads pcase
paredit-autoloads pkg-info-autoloads epl-autoloads tree-mode-autoloads
windata-autoloads info package browse-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie generate-lisp-file
url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv
bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process
native-compile emacs)

Memory information:
((conses 16 2411138 372988) (symbols 48 43051 24)
=C2=A0(strings 32 390907 16216) (string-bytes 1 13976841)
=C2=A0(vectors 16 117983) (vector-slots 8 2802866 272351)
=C2=A0(floats 8 232 9407) (intervals 56 238397 3159) (buffers 984 77))
--0000000000000916cc060170b34e--