GNU bug report logs - #64814
29.1; typescript-ts-mode indentation broken since 235561a

Previous Next

Full log

Message #11 received at 64814 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>, Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 64814 <at> debbugs.gnu.org
Subject: Re: bug#64814: 29.1; typescript-ts-mode indentation broken since
 235561a
Date: Mon, 24 Jul 2023 16:24:11 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
>> Date: Sun, 23 Jul 2023 22:23:04 +0100
>> 
>> 
>> Reproduction:
>> 
>> 1. emacs -q
>> 2. C-x C-f ~/test.ts
>> 3. M-x typescript-ts-mode
>> 4. Insert
>> 
>> ```typescript
>> if (true) {
>> console.log('hello');
>> }
>> ```
>> 
>> 5. Move point to the beginning of the second line
>> 6. TAB
>> 
>> Expectation:
>> 
>> I expect the indentation behavior to be the same as js-ts-mode, in which
>> the if statement body will be indented as I type RET after {, or on TAB
>> on the second line, but commit 235561a seems to have broken this behavior.
>
> Thanks.
>
> Theo and Vincenzo, could you please look into this?

Fixed in 4e977136d3148c3baa0e03568c7a2c7dc28eea65. Funnily enough, this
wasn't indentation related, but font-locking related. Seems
initialization of the major mode didn't work properly because the compat
check for font lock didn't account for typescript as a language. The fix
was simple enough.

Thanks,
Theo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.