From unknown Thu Aug 21 12:11:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64799 <64799@debbugs.gnu.org> To: bug#64799 <64799@debbugs.gnu.org> Subject: Status: [PATCH] Add 'project-prompt-key' face Reply-To: bug#64799 <64799@debbugs.gnu.org> Date: Thu, 21 Aug 2025 19:11:03 +0000 retitle 64799 [PATCH] Add 'project-prompt-key' face reassign 64799 emacs submitter 64799 Protesilaos Stavrou severity 64799 normal tag 64799 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 23 04:19:39 2023 Received: (at submit) by debbugs.gnu.org; 23 Jul 2023 08:19:40 +0000 Received: from localhost ([127.0.0.1]:37983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNUJX-0005de-Io for submit@debbugs.gnu.org; Sun, 23 Jul 2023 04:19:39 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNUJV-0005dD-Q5 for submit@debbugs.gnu.org; Sun, 23 Jul 2023 04:19:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNUJP-00074X-T5 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 04:19:32 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNUJN-0005cH-SI for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 04:19:31 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 31FE540003 for ; Sun, 23 Jul 2023 08:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690100365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=QOsLZfZwA0KTllVk/oo3qR05Kbg6DvsDMt/tuVKXFm0=; b=dB1AdXrdQA1NXiwa30CIZbro71ia4U60FbtqfgM/RufZi5+LfW++7CfVbKFFfYivsB5LGK MXuxdb4yKXsHhsaZKmhKNhQVoLe9Cw9G9JWJM7UKDykhmvXSAnZlFKIBTSnG2fgzAMvTKr V9uCgiQFnf/fAbDfMJ8UQCz05YW27hamm7sAA8Kki8JNXcj30vjgbgFN4LknHlTHi7+4V2 eKVMXrOlPov+FGXcWSjn3brwNgIgX7h5VDx85s2GAYh5oMEIqoyaQIRExWBxtYmNQ9Xm5C vDn9ykOV6yDO4CRECwB7ucGO7PROi5MOvb/1EyHJtZq4LlU5N6wQJ/eF0fJn1Q== From: Protesilaos Stavrou To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add 'project-prompt-key' face Date: Sun, 23 Jul 2023 11:19:23 +0300 Message-ID: <87zg3nqbuc.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: public@protesilaos.com Received-SPF: none client-ip=2001:4b98:dc4:8::222; envelope-from=info@protesilaos.com; helo=relay2-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Dear maintainers, I noticed that the project switching dispatch menu hardcodes its face to 'bold'. Adding a new face here allows themes/users to customise that style (e.g. to inherit the 'help-key-binding' face). This is the least intrusive change, though I would personally also remove the square brackets from the format specifier. What do you think? All the best, Protesilaos (or simply "Prot") -- Protesilaos Stavrou https://protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-project-prompt-key-face.patch >From fcef17068821bd05e281dc75452c807bbc27c8dd Mon Sep 17 00:00:00 2001 Message-ID: From: Protesilaos Stavrou Date: Sun, 23 Jul 2023 10:55:37 +0300 Subject: [PATCH] Add 'project-prompt-key' face * etc/NEWS: Announce the face. * lisp/progmodes/project.el (project-prompt-key): Define the face. (project--keymap-prompt): Use the face. --- etc/NEWS | 4 ++++ lisp/progmodes/project.el | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 5883b4df2a7..70d0bf18f50 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -82,6 +82,10 @@ This allows the user to customize the prompt that is appended by This is used for displaying the time and date components of 'display-time-mode'. +--- +** New face 'project-prompt-key'. +This is used in the Project switch commands prompt. + --- ** New icon images for general use. Several symbolic icons are added to "etc/images/symbols", including diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 03ed966cc45..c2deec7c38d 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1821,6 +1821,9 @@ (defcustom project-switch-use-entire-map nil :group 'project :version "28.1") +(defface project-prompt-key '((t :inherit bold)) + "Face for keys in the Project switch commands prompt.") + (defun project--keymap-prompt () "Return a prompt for the project switching dispatch menu." (mapconcat @@ -1834,7 +1837,7 @@ (defun project--keymap-prompt () (vector key) (where-is-internal cmd (list project-prefix-map) t)))) (format "[%s] %s" - (propertize (key-description key) 'face 'bold) + (propertize (key-description key) 'face 'project-prompt-key) label))) project-switch-commands " ")) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 23 09:41:57 2023 Received: (at 64799) by debbugs.gnu.org; 23 Jul 2023 13:41:57 +0000 Received: from localhost ([127.0.0.1]:39043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZLQ-0003UX-SO for submit@debbugs.gnu.org; Sun, 23 Jul 2023 09:41:57 -0400 Received: from mout02.posteo.de ([185.67.36.66]:49665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZLL-0003UH-Hv for 64799@debbugs.gnu.org; Sun, 23 Jul 2023 09:41:55 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EA436240106 for <64799@debbugs.gnu.org>; Sun, 23 Jul 2023 15:41:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690119704; bh=rob5Y8mMv5PG/X4aAgSSPYCeTWHy1dwAf1SOTamtbs0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=nUAKEij+a7czhaSiDAe1GNfMPGhf4JEMYRJhn3j63gueA2bZC7GIKf8OSirb8ZjJK dsOVQUjB8qkw5VbB8z9rwcZsz/ywDaFGGFHVLDteaeVSRTZ3VDfrnIz3e4kDmFXd4T qTumkkKpjYqR+H6fBltphx9O8gUl30mdXkW6qQLjU1hT6TJBVrurixC0a90nu0aqZZ P8vmOtURDXhW0DN6izOcAptcDzamLbHixyXKUOlJ5JS08pLAB7somSvZdiB/wjwRGb d9+PvMC7XREdFHW2Z8hBmEtUUAwccQdAks/2nfih1qRyFN7rNBsOlQV82eVDo7kgde Tpjkgmy4d3+tg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R84G03qvYz9ry0; Sun, 23 Jul 2023 15:41:44 +0200 (CEST) From: Philip Kaludercic To: Protesilaos Stavrou Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <87zg3nqbuc.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 23 Jul 2023 11:19:23 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 23 Jul 2023 13:41:43 +0000 Message-ID: <87wmyqhhig.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Protesilaos Stavrou writes: > Dear maintainers, > > I noticed that the project switching dispatch menu hardcodes its face to > 'bold'. Adding a new face here allows themes/users to customise that > style (e.g. to inherit the 'help-key-binding' face). Does this even need a separate face, or shouldn't `help-key-binding' be reused directly? > This is the least intrusive change, though I would personally also > remove the square brackets from the format specifier. > > What do you think? > > All the best, > Protesilaos (or simply "Prot") > > -- > Protesilaos Stavrou > https://protesilaos.com > >>>From fcef17068821bd05e281dc75452c807bbc27c8dd Mon Sep 17 00:00:00 2001 > Message-ID: > From: Protesilaos Stavrou > Date: Sun, 23 Jul 2023 10:55:37 +0300 > Subject: [PATCH] Add 'project-prompt-key' face > > * etc/NEWS: Announce the face. > * lisp/progmodes/project.el (project-prompt-key): Define the face. > (project--keymap-prompt): Use the face. > --- > etc/NEWS | 4 ++++ > lisp/progmodes/project.el | 5 ++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/etc/NEWS b/etc/NEWS > index 5883b4df2a7..70d0bf18f50 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -82,6 +82,10 @@ This allows the user to customize the prompt that is appended by > This is used for displaying the time and date components of > 'display-time-mode'. > > +--- > +** New face 'project-prompt-key'. > +This is used in the Project switch commands prompt. > + > --- > ** New icon images for general use. > Several symbolic icons are added to "etc/images/symbols", including > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 03ed966cc45..c2deec7c38d 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1821,6 +1821,9 @@ (defcustom project-switch-use-entire-map nil > :group 'project > :version "28.1") > > +(defface project-prompt-key '((t :inherit bold)) > + "Face for keys in the Project switch commands prompt.") > + > (defun project--keymap-prompt () > "Return a prompt for the project switching dispatch menu." > (mapconcat > @@ -1834,7 +1837,7 @@ (defun project--keymap-prompt () > (vector key) > (where-is-internal cmd (list project-prefix-map) t)))) > (format "[%s] %s" > - (propertize (key-description key) 'face 'bold) > + (propertize (key-description key) 'face 'project-prompt-key) > label))) > project-switch-commands > " ")) From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 23 09:49:42 2023 Received: (at 64799) by debbugs.gnu.org; 23 Jul 2023 13:49:42 +0000 Received: from localhost ([127.0.0.1]:39048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZSw-0003ks-4D for submit@debbugs.gnu.org; Sun, 23 Jul 2023 09:49:42 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:37981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZSs-0003kb-G9 for 64799@debbugs.gnu.org; Sun, 23 Jul 2023 09:49:41 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 31360E0004; Sun, 23 Jul 2023 13:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690120170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4HNgt9fagb5bkKTN7V9IfCcuod/7+3XEPwJn8wR6JkA=; b=KPOoRldY1PTTsF2TNvzx3uogmh6pPPnw2d4CG8vU3ijS5fsqd6mdMfta14zBdWYpIrQMUO WTZldmfHZycQ9aaPS6/C9ESo1FcoA/da7lX+BKKOzcMoDOCVc6f0AzN7ZouwQDWsC2oSNT 7igAazMzC4cXlG4pVc1/V7MTduXZVyfkkwGZT2VPo94RXLUsD05WNMejPIJJndJj2HyhQw PJw8fkwtrHtkVBmP9Cc3PLIsAEShBnVrGtE9NhUOktkld2LOASIOdxojcGuZxYeBjX+0UC xWbr6AcVMA89aAsXE16xanX1Ej6cVpvwAzjTbsaNQ1GfdX7N2pRS+G6m8ZuB+g== From: Protesilaos Stavrou To: Philip Kaludercic Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <87wmyqhhig.fsf@posteo.net> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> Date: Sun, 23 Jul 2023 16:49:27 +0300 Message-ID: <874jluspp4.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: public@protesilaos.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Philip Kaludercic > Date: Sun, 23 Jul 2023 13:41:43 +0000 > > Protesilaos Stavrou writes: > >> Dear maintainers, >> >> I noticed that the project switching dispatch menu hardcodes its face to >> 'bold'. Adding a new face here allows themes/users to customise that >> style (e.g. to inherit the 'help-key-binding' face). > > Does this even need a separate face, or shouldn't `help-key-binding' be > reused directly? That would be my choice, though also with the removal of the square brackets around it. The proposed patch is for backward-compatibility. -- Protesilaos Stavrou https://protesilaos.com From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 23 09:59:51 2023 Received: (at 64799) by debbugs.gnu.org; 23 Jul 2023 13:59:51 +0000 Received: from localhost ([127.0.0.1]:41079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZck-0004Tm-SY for submit@debbugs.gnu.org; Sun, 23 Jul 2023 09:59:51 -0400 Received: from mout01.posteo.de ([185.67.36.65]:47311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZci-0004TZ-8N for 64799@debbugs.gnu.org; Sun, 23 Jul 2023 09:59:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AD19A240028 for <64799@debbugs.gnu.org>; Sun, 23 Jul 2023 15:59:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690120782; bh=dhGLZ68G93PKyMC5k4cgGvjw4J9VAT5xa3SvW5Rd1Mg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=AP3L+OUTbR2AAJhQvVtN9ao0Zhp/S7KI7siTO292FNqCAlzd78HeXqW20vHjFdgEb qQTi1yc+j1OrVKKY3Cgsu0+pbJf6AoxwLZt21JHgU9lqWyCoQaklFdv528wC4mSPNT pH/JdsOYm3oF9g4fFXFumxXvAHSj7Os28UxLuiOWeEkFXLLJN6Ip2buvJyn2xjwdm7 K+QvOb7kxP3OVAFj9k8McE7jhmU5wX86OB21mLDAOemC7Qhx5qJmUfqH0qINpy49rR cE+c/Quozx/7RDvhEsLlsphYjKmo+qAOm1Tfvo7xA0QUPZc+PYzAVykC8tjosJ3seH nF+ejL1DSMv8A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R84fk2YW2z9rxL; Sun, 23 Jul 2023 15:59:42 +0200 (CEST) From: Philip Kaludercic To: Protesilaos Stavrou Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <874jluspp4.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 23 Jul 2023 16:49:27 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 23 Jul 2023 13:59:41 +0000 Message-ID: <87sf9ehgoi.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Protesilaos Stavrou writes: >> From: Philip Kaludercic >> Date: Sun, 23 Jul 2023 13:41:43 +0000 >> >> Protesilaos Stavrou writes: >> >>> Dear maintainers, >>> >>> I noticed that the project switching dispatch menu hardcodes its face to >>> 'bold'. Adding a new face here allows themes/users to customise that >>> style (e.g. to inherit the 'help-key-binding' face). >> >> Does this even need a separate face, or shouldn't `help-key-binding' be >> reused directly? > > That would be my choice, though also with the removal of the square > brackets around it. The proposed patch is for backward-compatibility. Backwards-compatible to what? Can someone depend on this specific behaviour? I think it would be better to replace the current code with what you are suggesting, as a step towards ensuring a more consistent user interface. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 24 01:53:33 2023 Received: (at 64799) by debbugs.gnu.org; 24 Jul 2023 05:53:33 +0000 Received: from localhost ([127.0.0.1]:41524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNoVh-0004Vb-G7 for submit@debbugs.gnu.org; Mon, 24 Jul 2023 01:53:33 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:40253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNoVc-0004VK-5F for 64799@debbugs.gnu.org; Mon, 24 Jul 2023 01:53:31 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6A43B240002; Mon, 24 Jul 2023 05:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690178001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lhg1DgAXkiZABvUkoHXZrowFOkMxepFe7NaWndb4mzQ=; b=ZGAHLPsJRksymYRpAEYC562xyqIQwA0fzDXG/RKuZEOeKhwiWz12RRCXH1HgBMfDxzvz42 qV88EIhh4YlYoq47GeujQabdk03ai31A+9vQx93GUC1NsgHys8Zz/4PEllNWjDkEZU2Wua /MYnuW1v3LVB5JYqhs/wob5rHaqUkcw+Tsmx9NKPNEERCo9qy09eFsNGtQ6i7CQp4ktHpx YgG2gJRTME8Zf/3jlv/ZCD4DdWGhyV2zrGjcqXaMK5XUlfT6gVhNuHxoVhhi5SA9OQu7Cz Zhc4i7DYrYrGOS1vvDF7LyS85Z4JIpXNIdc9WfTGSOWguX/Rk8+dNrNUViFn+A== From: Protesilaos Stavrou To: Philip Kaludercic Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <87sf9ehgoi.fsf@posteo.net> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> Date: Mon, 24 Jul 2023 08:53:20 +0300 Message-ID: <874jlt7t4f.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: public@protesilaos.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Philip Kaludercic > Date: Sun, 23 Jul 2023 13:59:41 +0000 > [... 14 lines elided] >>> Does this even need a separate face, or shouldn't `help-key-binding' be >>> reused directly? >> >> That would be my choice, though also with the removal of the square >> brackets around it. The proposed patch is for backward-compatibility. > > Backwards-compatible to what? Just so that existing users do not complain. > Can someone depend on this specific behaviour? No, but the appearance still comes with certain expectations. Plus, there is this at the top of the file: ;; This is a GNU ELPA :core package. Avoid using functionality that ;; not compatible with the version of Emacs recorded above The required Emacs version is 26.1, while that of 'help-key-binding' is 28.1. Perhaps a user option for the whole 'format' would be better? -- Protesilaos Stavrou https://protesilaos.com From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 24 21:56:42 2023 Received: (at 64799) by debbugs.gnu.org; 25 Jul 2023 01:56:42 +0000 Received: from localhost ([127.0.0.1]:44407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qO7I1-0006DD-KB for submit@debbugs.gnu.org; Mon, 24 Jul 2023 21:56:41 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qO7Hw-0006Cw-97 for 64799@debbugs.gnu.org; Mon, 24 Jul 2023 21:56:40 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 10B725C00E8; Mon, 24 Jul 2023 21:56:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 24 Jul 2023 21:56:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690250191; x=1690336591; bh=4Zh6fUPITShMZmDF0E2qsZFP5QA8WDKq7p+ h79sbQJU=; b=VppDbRW7V1yfumO+oZdyyW8LciQEWM28s7kN2XxyQAaP8z7gdnK vW6RgYgYNw5YB2uMggJITNtfIwKL3eVUV5SwxeLzD2/ho3DANUXjkM3bXbM707fy r8jPzJh5qzFx0AT3cnmryLgVZkNjcWGnl26CWgOJiRhXMTxDCNwhrMPA05R4EsnZ Px7vopw2J8i7kdrA6YQ+sptsNLg9Dttx+b+1uOLzmtj7BG+hEidOA2rgFMX2h0pZ vBXM3dzkO+yw02JnSlDPKKXc/qYRQKPfMe+Zj0T7l8KNZ7OHFs6udWkz8xQCInJp KqPbbYx9k/k9qUzOVeo6lXBYftKmkQfmrtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690250191; x=1690336591; bh=4Zh6fUPITShMZmDF0E2qsZFP5QA8WDKq7p+ h79sbQJU=; b=0GJgdJQbq0n2fOHmSlOnUefV+iStbxWXCE1NnlgP+kQc1bB48nk CH4GXyevRhSaCSEhAyF4byOrFbWYUa5wIpa+Qh2XgkhMI0dGPJaE6gaWlA3R75FX p5LaYiAt8LSHgxYpzHrdvtdTaSTKsmUEiJpkpJk1zMVgs39fmt/5Me0fXz7EnbIM td3ZbDkJ2RfFZ/QUSQhZ/J5gM7LSabArikNykt+4FKyLZUITkFP/rkyuc9D7scRA FXGYwreYLnU/UVxb4+gA9xJtfqZnJUi55Sg5h9WZH75mwOes5J7mviLlw2AyJDsv qCOTe44LgCQrA12fmBt9CBn3kapq+7CRqmg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrheelgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 Jul 2023 21:56:29 -0400 (EDT) Message-ID: <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> Date: Tue, 25 Jul 2023 04:56:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Protesilaos Stavrou , Philip Kaludercic References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> From: Dmitry Gutov In-Reply-To: <874jlt7t4f.fsf@protesilaos.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 24/07/2023 08:53, Protesilaos Stavrou wrote: >> From: Philip Kaludercic >> Date: Sun, 23 Jul 2023 13:59:41 +0000 > >> [... 14 lines elided] > >>>> Does this even need a separate face, or shouldn't `help-key-binding' be >>>> reused directly? >>> >>> That would be my choice, though also with the removal of the square >>> brackets around it. The proposed patch is for backward-compatibility. >> >> Backwards-compatible to what? > > Just so that existing users do not complain. > >> Can someone depend on this specific behaviour? > > No, but the appearance still comes with certain expectations. Plus, > there is this at the top of the file: > > ;; This is a GNU ELPA :core package. Avoid using functionality that > ;; not compatible with the version of Emacs recorded above > > The required Emacs version is 26.1, while that of 'help-key-binding' is > 28.1. Indeed, so if we switch to it in project.el, it will need some polyfill for Emacs 26-27. > Perhaps a user option for the whole 'format' would be better? We can add a user option. But while we could also apply 'face' property on that option's string value, that doesn't seem like a very user-friendly approach toward someone who will want to change the face used (it will require some Lisp knowledge from the user). But a user option to change how the prompt text is constructed -- why not. E.g. one defaulting to "[%s] %s". From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 25 02:39:39 2023 Received: (at 64799) by debbugs.gnu.org; 25 Jul 2023 06:39:39 +0000 Received: from localhost ([127.0.0.1]:44509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOBhr-0008UT-5z for submit@debbugs.gnu.org; Tue, 25 Jul 2023 02:39:39 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOBho-0008UF-L1 for 64799@debbugs.gnu.org; Tue, 25 Jul 2023 02:39:38 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9510E240029 for <64799@debbugs.gnu.org>; Tue, 25 Jul 2023 08:39:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690267170; bh=VeZK2lCaNCtBV4z4Yk/5qG4+9iSVV7E2J8y6aKactGg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=jt87G3R9EtgyM0ESy8qdrBNDxQVAAl6RzGcnvgeTH1UsRdkgDPcYAqzsVaeCYKuBh PoSognG495aeK9TTSs2XLX20xcI29AjmgnTUku8n/ZLpCX4bLuSu+ll+KpKfl4CAVk /g/ygOzcH2sA8xyGuB1QOFuW7A+al0Akf0QoUtpGxxevVQgp0vLbWenaVsdghEuVgL 7Wi+I+Cq+gxHkScgsL/FGpgudNe4OpUzkqUM8UCk66yzfgsPpwKnD34LCXglV7gdb0 J1coecYenwFRuyzaONLZeKemo4lFtJ9sitzYr2aKTyczob2wNOynjbvXhVGHXkeofY cR3HXMaQ3uwXQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R96ns5Zrbz9ryJ; Tue, 25 Jul 2023 08:39:29 +0200 (CEST) From: Philip Kaludercic To: Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> (Dmitry Gutov's message of "Tue, 25 Jul 2023 04:56:27 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Tue, 25 Jul 2023 06:39:26 +0000 Message-ID: <87sf9cmr4x.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov writes: > On 24/07/2023 08:53, Protesilaos Stavrou wrote: >>> From: Philip Kaludercic >>> Date: Sun, 23 Jul 2023 13:59:41 +0000 >> >>> [... 14 lines elided] >> >>>>> Does this even need a separate face, or shouldn't `help-key-binding' be >>>>> reused directly? >>>> >>>> That would be my choice, though also with the removal of the square >>>> brackets around it. The proposed patch is for backward-compatibility. >>> >>> Backwards-compatible to what? >> Just so that existing users do not complain. >> >>> Can someone depend on this specific behaviour? >> No, but the appearance still comes with certain expectations. Plus, >> there is this at the top of the file: >> ;; This is a GNU ELPA :core package. Avoid using functionality >> that >> ;; not compatible with the version of Emacs recorded above >> The required Emacs version is 26.1, while that of 'help-key-binding' >> is >> 28.1. > > Indeed, so if we switch to it in project.el, it will need some > polyfill for Emacs 26-27. If there is interest, this face could be added to the Compat package, if it would be OK to add Compat as a dependency for project.el on ELPA (this would also mean that project.el wouldn't have to use a custom `project--buffer-check'/`buffer-match-p' implementation). Alternatively, we could add a version/facep check and always prefer `help-key-binding' if it is available, otherwise fall-back to the current option. >> Perhaps a user option for the whole 'format' would be better? > > We can add a user option. But while we could also apply 'face' > property on that option's string value, that doesn't seem like a very > user-friendly approach toward someone who will want to change the face > used (it will require some Lisp knowledge from the user). > > But a user option to change how the prompt text is constructed -- why > not. E.g. one defaulting to "[%s] %s". Is there really such a wide range of options that users might be interested in here? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 25 09:05:26 2023 Received: (at 64799) by debbugs.gnu.org; 25 Jul 2023 13:05:27 +0000 Received: from localhost ([127.0.0.1]:44876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOHjC-0004rd-L6 for submit@debbugs.gnu.org; Tue, 25 Jul 2023 09:05:26 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:48705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOHjA-0004rI-TH for 64799@debbugs.gnu.org; Tue, 25 Jul 2023 09:05:25 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 33A0B3200931; Tue, 25 Jul 2023 09:05:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 25 Jul 2023 09:05:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690290318; x=1690376718; bh=vFAbNYLAtsIbzGrYbNfe1RDI/u65qRyuYyq eYfJZB50=; b=M7oXubv1hkSE3+Ajkp5hL9XejM1txb/utkFuVxsAs8EtCc44LMQ 3+F4heZQX0Q42AH6M2f+2z1464yiGqHa60b24DSwFTiRbZlIikogW8dzw8RWMf0d vML0sGQJkDd3kcIFVYYGhjClQQBusI/waiSS/ZT+nbfybfaQGzsJIBeHxt5kRLI0 +VzmQYZyx61KXalEhlI8LepWyuIgj9wZ8rJup4ixea51N7+q6/7aHi2G2yoRoh9+ sopeaNhrW8KsngfLf+2g7cc1sFYsXij4ciPsIM27Q2UhD4KdzNXZY8swn891sb45 xqKVV+gnOYGf4icmZPsI8RbR8+ufj6G9XpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690290318; x=1690376718; bh=vFAbNYLAtsIbzGrYbNfe1RDI/u65qRyuYyq eYfJZB50=; b=elZ0oEPuZO+F30hKuvez0xe5mA+vJmwFEfO9bBYQYaz/DdwqBws sywfjTyiqDrKiPN/eJ+rMh5OOjLBeyK6YKIf8jHwBXISlNyRoddv1Yll7rYNqhz/ aSOixjYvjI6KwhwPllIbVjYXOL1YnyTOoK+Ru47v+eClFZmBSTz0cJJUhHP3jsfY h0kqLg2eQa65uBJRFZQhCpiYH/HXlqSSNYw2VXSS/dMNRf8XbFFbYJeMdT8EJYT4 KbaW8aXUL+D1/70txm7EYDG/e/BVKexvtFo+vsz8H1gi5Reg0/U6S1zxpTA9FywE GiQZHQEkyUWibl8H/2zgr30Vxkmn7Khlc6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedriedtgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jul 2023 09:05:16 -0400 (EDT) Message-ID: <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> Date: Tue, 25 Jul 2023 16:05:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Philip Kaludercic References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> From: Dmitry Gutov In-Reply-To: <87sf9cmr4x.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64799 Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 25/07/2023 09:39, Philip Kaludercic wrote: >> Indeed, so if we switch to it in project.el, it will need some >> polyfill for Emacs 26-27. > > If there is interest, this face could be added to the Compat package, if > it would be OK to add Compat as a dependency for project.el on ELPA > (this would also mean that project.el wouldn't have to use a custom > `project--buffer-check'/`buffer-match-p' implementation). Good suggestion, but let's hold off on that still. > Alternatively, we could add a version/facep check and always prefer > `help-key-binding' if it is available, otherwise fall-back to the > current option. That works for me. >>> Perhaps a user option for the whole 'format' would be better? >> >> We can add a user option. But while we could also apply 'face' >> property on that option's string value, that doesn't seem like a very >> user-friendly approach toward someone who will want to change the face >> used (it will require some Lisp knowledge from the user). >> >> But a user option to change how the prompt text is constructed -- why >> not. E.g. one defaulting to "[%s] %s". > > Is there really such a wide range of options that users might be > interested in here? Protesilaos wanted to use a different format? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 00:50:39 2023 Received: (at 64799) by debbugs.gnu.org; 26 Jul 2023 04:50:39 +0000 Received: from localhost ([127.0.0.1]:47330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOWTu-00007Y-Um for submit@debbugs.gnu.org; Wed, 26 Jul 2023 00:50:39 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOWTs-00007D-7x for 64799@debbugs.gnu.org; Wed, 26 Jul 2023 00:50:37 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 04928E0003; Wed, 26 Jul 2023 04:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690347029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q+oU8hixBNSzuqduPQhuBDObgpB1eKE+oujwANMvQWY=; b=ps2YYLL0MeRwFLRq21AMHZMalFtRnGeC+8vbrFWGPfKIGz5+yVjG396GdeBRjCPBYRYlg8 3eW5vp2FBcCT5W2qZDgRtdORSmRCxw3m+AFPKRi21UzPPGaox2FzxetieOADy2BYdZWdRx MFeKOTqULdbwTIqBp6NSY/PPr4uj7WNcJuFlj55TPbRO2VI1SSA+LxUXEhaJLV9Gl4PfCI wvsaT8tswJlhdOTbDXgstFZF3oJPo6hwmmUEgzEL/pWLVr+k7cSFr4XDrVMObIbUpL6Psu 9d7lCmraPBRriUDn9X48DVxYFBCb06aYuUcdZbmre5VZ1XjR3989CpFDeq81gQ== From: Protesilaos Stavrou To: Dmitry Gutov , Philip Kaludercic Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> Date: Wed, 26 Jul 2023 07:50:26 +0300 Message-ID: <87jzun5l9p.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: public@protesilaos.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Dmitry Gutov > Date: Tue, 25 Jul 2023 16:05:15 +0300 > [... 13 lines elided] >> Alternatively, we could add a version/facep check and always prefer >> `help-key-binding' if it is available, otherwise fall-back to the >> current option. > > That works for me. Me too! >>>> Perhaps a user option for the whole 'format' would be better? >>> >>> We can add a user option. But while we could also apply 'face' >>> property on that option's string value, that doesn't seem like a very >>> user-friendly approach toward someone who will want to change the face >>> used (it will require some Lisp knowledge from the user). >>> >>> But a user option to change how the prompt text is constructed -- why >>> not. E.g. one defaulting to "[%s] %s". >> >> Is there really such a wide range of options that users might be >> interested in here? > > Protesilaos wanted to use a different format? For my use, and Emacs 28+, I want this: (format "%s %s" (propertize (key-description key) 'face 'project-prompt-key) label) The reason I mentioned the possibility of a user option is because without the square brackets the bold face will not have the same effect as the current design. The square brackets help add structure and make it easier to identify the keys. The use of 'bold' without the square brackets may make it more difficult for users to spot the keys. -- Protesilaos Stavrou https://protesilaos.com From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 07:10:27 2023 Received: (at 64799) by debbugs.gnu.org; 26 Jul 2023 11:10:27 +0000 Received: from localhost ([127.0.0.1]:47624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOcPT-0001nI-3O for submit@debbugs.gnu.org; Wed, 26 Jul 2023 07:10:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOcPR-0001n2-7r for 64799@debbugs.gnu.org; Wed, 26 Jul 2023 07:10:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOcPK-0005wZ-B9; Wed, 26 Jul 2023 07:10:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FsRsC5Y5G+XP6ZoYzG9QXaQnHnfub16NVU7u6C7b8QM=; b=lvTCLiAeNR7a 9eCGSnL6iqaI9wMBe81UsYUr26FTsvcLlOq8y9B50xBkRS5Ta0gPKjU56l0z+Fz5CMEkEGSqzj+II hyOobXqG+W57mf1LWk/43H+lIaxpdsN9huQR5d1HGu4qvqY4wWZlrGtY6J6eESwCfA7kUPc+bZswe fmE2G4bQZj4fyw464Y5arfBgorLdNXLh7bH0eZ9Amj7VPTa1+OI5P87rS5ApjENWdFCf06ynokYwu nUJAPda30kplImTUR4aM0DVgf5beHsspNuVoKE7bhZoVe5cLnEwwCuMYN5RXtC70BCkXjIJAM6yzk yV7BJ0zCIk6b3yzCK8sL1g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOcP7-0001GF-Qq; Wed, 26 Jul 2023 07:10:17 -0400 Date: Wed, 26 Jul 2023 14:10:53 +0300 Message-Id: <83wmynnd1e.fsf@gnu.org> From: Eli Zaretskii To: Protesilaos Stavrou In-Reply-To: <87jzun5l9p.fsf@protesilaos.com> (message from Protesilaos Stavrou on Wed, 26 Jul 2023 07:50:26 +0300) Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: dmitry@gutov.dev, philipk@posteo.net, 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 64799@debbugs.gnu.org > From: Protesilaos Stavrou > Date: Wed, 26 Jul 2023 07:50:26 +0300 > > >>> But a user option to change how the prompt text is constructed -- why > >>> not. E.g. one defaulting to "[%s] %s". > >> > >> Is there really such a wide range of options that users might be > >> interested in here? > > > > Protesilaos wanted to use a different format? > > For my use, and Emacs 28+, I want this: > > (format "%s %s" > (propertize (key-description key) 'face 'project-prompt-key) > label) > > The reason I mentioned the possibility of a user option is because > without the square brackets the bold face will not have the same effect > as the current design. The square brackets help add structure and make > it easier to identify the keys. The use of 'bold' without the square > brackets may make it more difficult for users to spot the keys. Beware: the 'bold' face changes the metrics of the font glyphs (wrt the 'medium' variant), and at least with some fonts could cause a small 1- or 2-pixel vertical resize of the mini-window, which is generally distracting and even annoying. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 21:01:28 2023 Received: (at 64799) by debbugs.gnu.org; 27 Jul 2023 01:01:28 +0000 Received: from localhost ([127.0.0.1]:40356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOpNg-0006hP-Hb for submit@debbugs.gnu.org; Wed, 26 Jul 2023 21:01:28 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:47471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOpNe-0006hB-Dh for 64799@debbugs.gnu.org; Wed, 26 Jul 2023 21:01:27 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 9CE4D3200929; Wed, 26 Jul 2023 21:01:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 26 Jul 2023 21:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690419680; x=1690506080; bh=T9tEPLiJtsbjlxabhYUaXmRmxednY090W5h H1Kw53B8=; b=JT38HSZGNgpruSrbAFss8pPADctArsaT1HoVBYpqicRCGc5yDtk 3UiA18jQse5JMsIGAdCzeLwfeY8pqnHeafcu5WnwydB/NGkSBXg3QSPPGGX7MtQz 3zHKXlzE9ezmKxv8fmSwPbOPyHFw5MO48kNDnWgHLtanFc/3GIhF0MDZfpkomcXG Q4fuZuP4SUHQ7y9wZY2HKj4Gn/19RHdUgNdqm/5raRd7bcaMp7U6+mi+j6dDRwRo CfmLOntS8H6Zww7iMWu03xXZ/tcTwLhO+pDPfMl16n5nDL+qpzlLxCiVhT5o8vtX t/kMinMrUK6xqmLjItErcLqitEaC7kGk6mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690419680; x=1690506080; bh=T9tEPLiJtsbjlxabhYUaXmRmxednY090W5h H1Kw53B8=; b=oz9kwd8IYra9rCTnugBP50woZBz9RSxa5e2+NUQT6JsYX7idaF0 eL02m3gvwAZT7w5r8Yj6qAMYM13lDGZP7ZIDLPT7sheWI23AZRquyXkZJfmzzELE AVi+7kgDcpP9bok80pii7wTj3hrOg8ml/VwZJEKzXmzljrlVYe2nKrqh8Jmr7jea okOlR/cs3sBNGkpfVafPu1NttGKyIjk7S67IQX6xnrCMI/s3HDUFnpMorT/+zS8c PPoNGojCD8ZvAI+3+XXx8ZXhhV1nRwQAnpNKHnS0S+4GGJymOanQ62K98I9ewLMG EWKguVmdCFsW2y5fy5iPz+2X2OXzrx2iE0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieefgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Jul 2023 21:01:18 -0400 (EDT) Message-ID: <11d47a2d-c068-b40f-ad86-6025201e8484@gutov.dev> Date: Thu, 27 Jul 2023 04:01:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Eli Zaretskii , Protesilaos Stavrou References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <83wmynnd1e.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83wmynnd1e.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64799 Cc: philipk@posteo.net, 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 26/07/2023 14:10, Eli Zaretskii wrote: > Beware: the 'bold' face changes the metrics of the font glyphs (wrt > the 'medium' variant), and at least with some fonts could cause a > small 1- or 2-pixel vertical resize of the mini-window, which is > generally distracting and even annoying. Only non-monospaced font, though, right? Or ones without a 'bold' variant. Anyway, we're talking about switching from 'bold' to 'help-key-binding', which uses the default weight. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 21:28:20 2023 Received: (at 64799) by debbugs.gnu.org; 27 Jul 2023 01:28:21 +0000 Received: from localhost ([127.0.0.1]:40374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOpng-0007Ka-Jk for submit@debbugs.gnu.org; Wed, 26 Jul 2023 21:28:20 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:36079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOpne-0007K9-BV for 64799@debbugs.gnu.org; Wed, 26 Jul 2023 21:28:19 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id DC67A320091A; Wed, 26 Jul 2023 21:28:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 26 Jul 2023 21:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690421291; x=1690507691; bh=rKq9cbVW8y5EitFAMm7iRERh7ZIgljrrQxA y/VJlWck=; b=CPWqEikx/EFl84iV6OwVajG4yI/yNenXtJ7yE3MFOOWYRbF5wTJ taoxrc8fbBGV7nD2C6glaGhAAfRoJOQkQyWT7Z6TEQJ6SNgzSLzEa9BWkbAaOTm2 9xMVJlGlmGQ9sVCh7Fgok+WidkPWB+LLK4xtCJmwYqTIpq85Mp16vhhXNHO1aa2c tPD5f58pcAPGwV02ds9DOxBwo0Tewe5C+sw4WowKHJw2ja0s/U9MB+o1404nx2Fb YqD9YIHFl0d1pqyM2JmzyqZnSWl/ViMrK1bHyL0Axk6vB0B1GWq9uMIi2UDmNATt ApICeKr35CgyYtFyEsV4WMMRPYrhUMqcxDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690421291; x=1690507691; bh=rKq9cbVW8y5EitFAMm7iRERh7ZIgljrrQxA y/VJlWck=; b=Vt1GPbf4BmKbQNJoJorY5PYDMxisoEB22hSHmJuSd1NQZzNBaDg oE/+N9oQBqwlPFJnFwbRhX2oSSx88Ias7YP7PEFwAPBhxPWYvbgGKrs2Gv4XMT/v CDkbg7JAr82tJI77kiMXXo71X2g1HjnlhdZIzFdM0BV3iWjYPx+RlQ/KfrFaiAam Esi1zBOiUN7IZI3XjeURTKcr985JINjiCUdznXrIoYrWVgIR/dbVQAZCzy/G557w LZyGw0dbnEFuycgZX43o6UH0bImCaKOZlnwcFe5mWyu/N75eJJMqw5M8nlmrvtt0 FFAzMa21aebd+FFbQ/uaj/7/Xn6U8f5kBAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieefgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Jul 2023 21:28:10 -0400 (EDT) Message-ID: <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> Date: Thu, 27 Jul 2023 04:28:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Protesilaos Stavrou , Philip Kaludercic References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> From: Dmitry Gutov In-Reply-To: <87jzun5l9p.fsf@protesilaos.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 26/07/2023 07:50, Protesilaos Stavrou wrote: > For my use, and Emacs 28+, I want this: > > (format "%s %s" > (propertize (key-description key) 'face 'project-prompt-key) > label) > > The reason I mentioned the possibility of a user option is because > without the square brackets the bold face will not have the same effect > as the current design. The square brackets help add structure and make > it easier to identify the keys. The use of 'bold' without the square > brackets may make it more difficult for users to spot the keys. The change in format seems to go hand-in-hand with the change in face, though, because help-key-binding has a box already. Does this look good to everybody? diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index d482cc24d70..3611757fb82 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1781,9 +1781,13 @@ project--keymap-prompt (let ((key (if key (vector key) (where-is-internal cmd (list project-prefix-map) t)))) - (format "[%s] %s" - (propertize (key-description key) 'face 'bold) - label))) + (if (facep 'help-key-binding) + (format "%s %s" + (propertize (key-description key) 'face 'help-key-binding) + label) + (format "[%s] %s" + (propertize (key-description key) 'face 'bold) + label)))) project-switch-commands " ")) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 27 01:28:18 2023 Received: (at 64799) by debbugs.gnu.org; 27 Jul 2023 05:28:18 +0000 Received: from localhost ([127.0.0.1]:40521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOtXt-0005AC-ST for submit@debbugs.gnu.org; Thu, 27 Jul 2023 01:28:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOtXr-00059y-4J for 64799@debbugs.gnu.org; Thu, 27 Jul 2023 01:28:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOtXl-0004YL-7U; Thu, 27 Jul 2023 01:28:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LRhJPurGXKgC6lGuGJdHjGJdg5i5aGi3McC1nm5tbMo=; b=TSY0Xg/24wS6 iYrnozOrx3R05TFCiyxhfMurSB8LINP/Us2CHV7TTUINweOoRmYpk8JV2ixJ7mPDTpC9z3M5AscQc F+cSFYl/T0qks2a4PGgfZ6wwKobJR07xxW3nGhaF+PYnURIaw4wTGvSsJbXlE9hD5ls0JV0TyAjNV AUgyJilv1PLoLk6rqqBxOcNHq7nSQ/S09tgRZEzG+b1rGWYsB/MKidDBVIEZQRxDrMTg3fe/sLp7v WqFy8TvO3bLICv5mZ5f/T2tfOr1OslEu8XFiyP1s/OhPY089sEnL5AKkgLKEMaqyot6qK8CIK+pFe ABY6VcCR8aXaQ1iFgukjgg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOtXk-0002Pg-N8; Thu, 27 Jul 2023 01:28:09 -0400 Date: Thu, 27 Jul 2023 08:28:58 +0300 Message-Id: <83tttpncrp.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <11d47a2d-c068-b40f-ad86-6025201e8484@gutov.dev> (message from Dmitry Gutov on Thu, 27 Jul 2023 04:01:17 +0300) Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <83wmynnd1e.fsf@gnu.org> <11d47a2d-c068-b40f-ad86-6025201e8484@gutov.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: info@protesilaos.com, 64799@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 27 Jul 2023 04:01:17 +0300 > Cc: philipk@posteo.net, 64799@debbugs.gnu.org > From: Dmitry Gutov > > On 26/07/2023 14:10, Eli Zaretskii wrote: > > Beware: the 'bold' face changes the metrics of the font glyphs (wrt > > the 'medium' variant), and at least with some fonts could cause a > > small 1- or 2-pixel vertical resize of the mini-window, which is > > generally distracting and even annoying. > > Only non-monospaced font, though, right? Or ones without a 'bold' variant. No, not only those. I'm talking about the _vertical_ metrics, so whether the font is monospaced is not relevant. Try marking files for deletion in Dired, and you will see that, at least with some fonts and some sizes. Here on MS-Windows the default face's font (Courier New) does that, for some sizes of the font. I have customized eldoc-highlight-function-argument to use 'underline' instead of 'bold' for that very reason. > Anyway, we're talking about switching from 'bold' to 'help-key-binding', > which uses the default weight. That's fine. I was under the impression that 'bold' is also being considered, and wanted to warn about this. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 27 20:57:11 2023 Received: (at 64799) by debbugs.gnu.org; 28 Jul 2023 00:57:11 +0000 Received: from localhost ([127.0.0.1]:43305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPBn4-0005tV-Qu for submit@debbugs.gnu.org; Thu, 27 Jul 2023 20:57:11 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:59541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPBn1-0005tE-H7 for 64799@debbugs.gnu.org; Thu, 27 Jul 2023 20:57:08 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 01B5E3200931; Thu, 27 Jul 2023 20:57:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 27 Jul 2023 20:57:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690505820; x=1690592220; bh=L4EcSX3IaJYumePYd1CzaNp1zCeoL4AzTXz 3ZkAIwMo=; b=Jpm2v3Gljtr0K7kodmZ3qNmlukN+OKqcYglK8AFiEMDgwTW4rNz pK2O6Sbmv3HUBL8hpGeqcsVunX5htQTrxI1jg8k5RoOe4URLQVP6IbwI3g3O+Det YRg+XiVvFm0GkubGx+SVVJgvCflFX7F12S9wKi2frRYd2ttyYz5CZrkeqn4EQsj8 3p1lrwsSROOWnic44N1ZFr41jlNJbQKOFX3CdYK9rF+OO4MHt1180G7xmxBB0UOb uAukAg0JEyF573PK3Dk7+shCMIFfGElDNZuBudfeiw1eaIu3Puj6yLSEaF/HBUfd JBjEQSoiNraJiZJqT08ik0R7KtDVw9aQrFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690505820; x=1690592220; bh=L4EcSX3IaJYumePYd1CzaNp1zCeoL4AzTXz 3ZkAIwMo=; b=NFMxhqFt0HnCIeZ5xd9UlevY62YKdK0oWEzbMVpWe3ueS86Kn60 y/SwZBEJBS9mfmraWNqK9KHMGAFdNE7RhiADwsfwKoVALjAxwLeIPYEBz3rtgxv3 tLAGCKv02WRFFxmSV2RGptiiU+HU6Z8v2vD9Ct5zt4oC97vF7UdEhOPp9bhpe/hx uRfDFtY4ze3tazXZgqujZU3lGSW396yMoyqJNLCuoXSu+QX0VC2yHxCQnrD1BJTU 3isgFByfhuf93SwYTqESpOdqyHwzN1g8Mq9Ch4eCVcfLz8jI/GhgjMzK7rLpoOmQ QQjWRch1dcZXH0BrlG1SY+kHJW039kQhuLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieehgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Jul 2023 20:56:58 -0400 (EDT) Message-ID: <467660c0-8d69-1273-3fba-5474fec546a3@gutov.dev> Date: Fri, 28 Jul 2023 03:56:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Eli Zaretskii References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <83wmynnd1e.fsf@gnu.org> <11d47a2d-c068-b40f-ad86-6025201e8484@gutov.dev> <83tttpncrp.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83tttpncrp.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64799 Cc: info@protesilaos.com, 64799@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 27/07/2023 08:28, Eli Zaretskii wrote: >> Date: Thu, 27 Jul 2023 04:01:17 +0300 >> Cc:philipk@posteo.net,64799@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 26/07/2023 14:10, Eli Zaretskii wrote: >>> Beware: the 'bold' face changes the metrics of the font glyphs (wrt >>> the 'medium' variant), and at least with some fonts could cause a >>> small 1- or 2-pixel vertical resize of the mini-window, which is >>> generally distracting and even annoying. >> Only non-monospaced font, though, right? Or ones without a 'bold' variant. > No, not only those. I'm talking about the_vertical_ metrics, so > whether the font is monospaced is not relevant. Try marking files for > deletion in Dired, and you will see that, at least with some fonts and > some sizes. Here on MS-Windows the default face's font (Courier New) > does that, for some sizes of the font. I have customized > eldoc-highlight-function-argument to use 'underline' instead of 'bold' > for that very reason. Good to know. That does sound problematic (e.g. when used with Eldoc, contributing to extra jumpiness). FWIW, I haven't been able to reproduce this here on GNU/Linux with several sizes of Courier New that I tried. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 27 23:34:12 2023 Received: (at 64799) by debbugs.gnu.org; 28 Jul 2023 03:34:12 +0000 Received: from localhost ([127.0.0.1]:43393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPEF2-0001aL-BH for submit@debbugs.gnu.org; Thu, 27 Jul 2023 23:34:12 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:43917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPEEx-0001Zk-Ne for 64799@debbugs.gnu.org; Thu, 27 Jul 2023 23:34:11 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 1E6E460005; Fri, 28 Jul 2023 03:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690515239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CHqnwMY57/WrT77ithKdS8f+SGn1oWPbg9bLBMfAx7k=; b=cI0EWjAUQJCvQOxdSQQCMizOAEXjPDnO9WGZTXqO3x1BinQ+8OBfbnCTlgG8Jqjk82Na1a jtgfJ9fqcceW+NhjTr2J4pcHmcf4/yrGxW01/yMK9VN3y4gfSpG9qSN5YTCI5S5MQGn77L uDQ6l9M2Qw8099Jt/eLB078OD0L0dWbIsxVgeOjm+41s4Gd3N6D72niIx+kvLAD5I36jT4 Hc6xdSuAciKXnfjraLYmAmlfcH4r8+UcyqbSFJ7cLXjveD9shN0BbFzTKrnt/fUwWtpEvo n00MZ1K81kL287WV1aSyKIuVxsemRJYOZwRu1E7bx68B7rY/DHrJsAJhYbEqfQ== From: Protesilaos Stavrou To: Dmitry Gutov , Philip Kaludercic Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> Date: Fri, 28 Jul 2023 06:33:56 +0300 Message-ID: <875y64wvyz.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: public@protesilaos.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64799 Cc: 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Dmitry Gutov > Date: Thu, 27 Jul 2023 04:28:08 +0300 > [... 14 lines elided] > The change in format seems to go hand-in-hand with the change in face, > though, because help-key-binding has a box already. > > Does this look good to everybody? > > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index d482cc24d70..3611757fb82 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1781,9 +1781,13 @@ project--keymap-prompt > (let ((key (if key > (vector key) > (where-is-internal cmd (list project-prefix-map) t)))) > - (format "[%s] %s" > - (propertize (key-description key) 'face 'bold) > - label))) > + (if (facep 'help-key-binding) > + (format "%s %s" > + (propertize (key-description key) 'face > 'help-key-binding) > + label) > + (format "[%s] %s" > + (propertize (key-description key) 'face 'bold) > + label)))) > project-switch-commands > " ")) I am fine with this approach, thank you! -- Protesilaos Stavrou https://protesilaos.com From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 28 01:50:28 2023 Received: (at 64799) by debbugs.gnu.org; 28 Jul 2023 05:50:28 +0000 Received: from localhost ([127.0.0.1]:43502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPGMt-0005Z8-R4 for submit@debbugs.gnu.org; Fri, 28 Jul 2023 01:50:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPGMr-0005Yv-Au for 64799@debbugs.gnu.org; Fri, 28 Jul 2023 01:50:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPGMk-0004CS-NV; Fri, 28 Jul 2023 01:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D6AXC3jMkTPZ+EdZ5dbJ1SHkoqcCZ1eL+V+J3y4DknM=; b=sX71RV8oIkH6 4iSux49kWZ5vR84r7uJ0UYKl/eKVq5OsEgHlMGX7nozrY0b/Eu5JQOESdGrA55/0LS8PDEcCrc9YK ExS7IYj/3mLPQa1CUb2DRJMOemSWp4fOcxbujkjEUyxdQiQ0aD6U1EFy4yK4CwZ33paPWfapZE2BN fmPdQfrpthJM+XKG90/vNN9X9Of7FRpUnWqAKlFEUDTSzmV7kWEvcMxOX9SXK1WPI4Mi+pOh8jscx wQ5JTm4XkWctH5CrwnV3jpS1d5LwOPEKWN6M0ib5yMb9IDBbyZPzz2cDArfqp2brnXPCe1xZfgxgg F83Ghbuy9WVDt3SEMAcjKQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPGMg-0005bW-F5; Fri, 28 Jul 2023 01:50:18 -0400 Date: Fri, 28 Jul 2023 08:51:07 +0300 Message-Id: <833518lh2s.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <467660c0-8d69-1273-3fba-5474fec546a3@gutov.dev> (message from Dmitry Gutov on Fri, 28 Jul 2023 03:56:56 +0300) Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <83wmynnd1e.fsf@gnu.org> <11d47a2d-c068-b40f-ad86-6025201e8484@gutov.dev> <83tttpncrp.fsf@gnu.org> <467660c0-8d69-1273-3fba-5474fec546a3@gutov.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: info@protesilaos.com, 64799@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 28 Jul 2023 03:56:56 +0300 > Cc: info@protesilaos.com, philipk@posteo.net, 64799@debbugs.gnu.org > From: Dmitry Gutov > > On 27/07/2023 08:28, Eli Zaretskii wrote: > >> Date: Thu, 27 Jul 2023 04:01:17 +0300 > >> Cc:philipk@posteo.net,64799@debbugs.gnu.org > >> From: Dmitry Gutov > >> > >> On 26/07/2023 14:10, Eli Zaretskii wrote: > >>> Beware: the 'bold' face changes the metrics of the font glyphs (wrt > >>> the 'medium' variant), and at least with some fonts could cause a > >>> small 1- or 2-pixel vertical resize of the mini-window, which is > >>> generally distracting and even annoying. > >> Only non-monospaced font, though, right? Or ones without a 'bold' variant. > > No, not only those. I'm talking about the_vertical_ metrics, so > > whether the font is monospaced is not relevant. Try marking files for > > deletion in Dired, and you will see that, at least with some fonts and > > some sizes. Here on MS-Windows the default face's font (Courier New) > > does that, for some sizes of the font. I have customized > > eldoc-highlight-function-argument to use 'underline' instead of 'bold' > > for that very reason. > > Good to know. That does sound problematic (e.g. when used with Eldoc, > contributing to extra jumpiness). > > FWIW, I haven't been able to reproduce this here on GNU/Linux with > several sizes of Courier New that I tried. It could be a bug in the fonts on my system, for all I know. AFAIK, Courier New was modified significantly in recent versions of Windows, so maybe they fixed this. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 28 02:35:36 2023 Received: (at 64799) by debbugs.gnu.org; 28 Jul 2023 06:35:36 +0000 Received: from localhost ([127.0.0.1]:43513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPH4Z-0006ej-Ly for submit@debbugs.gnu.org; Fri, 28 Jul 2023 02:35:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPH4W-0006eT-I6 for 64799@debbugs.gnu.org; Fri, 28 Jul 2023 02:35:34 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 52F64240101 for <64799@debbugs.gnu.org>; Fri, 28 Jul 2023 08:35:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690526126; bh=bQV9YhGGwGLVpQjro8P3VOq4TSt2cNUubL0DVT3hIWg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=LJZkAgEBlft9f3m+QKWe8TZBXZ0SfRb3m421RpOIQOUuSnfE4iEGT+KuzRDKurC/x 5KnjO83iq1l9Kq5bJfwXLCOdPrIIERLbwwVIJHPuDeFH18bkc6hwof+ZgnaL92f1N7 vi+4qZ2w9UpqMNp0Rj+sFLe8uJsmQEkxaky5SA/o3U4etergbIvIjfKATcie31mqju sjnCt+Z4r9hFLI89jcWMIxcGCP+p2Un94Q0K6LPdLmyCSWk2ENlpvqd07vYSNd4imC QSRJY4QXIFD/xjJueb5rBjQQzE7SXaRJkE3aKDR+a2BkZun4hGcGTVDQ3evcbxa4UN rJUBR7TfTZr/w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RByYn3D3lz9s1r; Fri, 28 Jul 2023 08:35:25 +0200 (CEST) From: Philip Kaludercic To: Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> (Dmitry Gutov's message of "Thu, 27 Jul 2023 04:28:08 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 28 Jul 2023 06:35:24 +0000 Message-ID: <87zg3g5ys3.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov writes: > On 26/07/2023 07:50, Protesilaos Stavrou wrote: >> For my use, and Emacs 28+, I want this: >> (format "%s %s" >> (propertize (key-description key) 'face 'project-prompt-key) >> label) >> The reason I mentioned the possibility of a user option is because >> without the square brackets the bold face will not have the same effect >> as the current design. The square brackets help add structure and make >> it easier to identify the keys. The use of 'bold' without the square >> brackets may make it more difficult for users to spot the keys. > > The change in format seems to go hand-in-hand with the change in face, > though, because help-key-binding has a box already. > > Does this look good to everybody? Looks good to me too, but I haven't tried it out. > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index d482cc24d70..3611757fb82 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1781,9 +1781,13 @@ project--keymap-prompt > (let ((key (if key > (vector key) > (where-is-internal cmd (list project-prefix-map) t)))) > - (format "[%s] %s" > - (propertize (key-description key) 'face 'bold) > - label))) > + (if (facep 'help-key-binding) > + (format "%s %s" > + (propertize (key-description key) 'face > 'help-key-binding) > + label) > + (format "[%s] %s" > + (propertize (key-description key) 'face 'bold) > + label)))) > project-switch-commands > " ")) From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 11 20:35:51 2023 Received: (at 64799-done) by debbugs.gnu.org; 12 Aug 2023 00:35:51 +0000 Received: from localhost ([127.0.0.1]:48269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUcbf-0006VU-4T for submit@debbugs.gnu.org; Fri, 11 Aug 2023 20:35:51 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:44337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUcbZ-0006VB-TU for 64799-done@debbugs.gnu.org; Fri, 11 Aug 2023 20:35:50 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D1F123200925; Fri, 11 Aug 2023 20:35:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 11 Aug 2023 20:35:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1691800537; x=1691886937; bh=XN6qW01ZZv01Segx1q4AxBDTn9sB4AgbQHI LhhNmOx4=; b=HYfhwGTHLGmn/5TkbkKquZSI6Nbt/qHauZWAyu+SuYJmPXv6rqt PKBtAhQdOTZlpWrp8HmkYMn8gxZwBTacMcN72bUEYcGRFcZp/GTZ+F2gC6iU+sBH nawP3q39ft9mW49xuBVMBCDZr5R9cKLcE/v+GleEP+I9kU2LQHzGeYKQiYncVP4F /e5TSSkzB1ZJSHqlEtxlVajJssn4gJfpxOpIeA/AYXWSvSLRkrRH3GQM8Ys9Y5v7 bY6UrTJVK4HuxZvSHkNPi9rKXdo6x/d60al8XV/nojbzczq45hL7D8L45PjMglW6 U32hRTifcGhBS2InxHhuXEEIoFQNI1YZq+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1691800537; x=1691886937; bh=XN6qW01ZZv01Segx1q4AxBDTn9sB4AgbQHI LhhNmOx4=; b=JEf+iHcVJ2VoznycE/S23HffOQOTg83FXAnu377Cc1p88bQ/F0e Y1+9LrBq7gncabU5qdaaSVnOa72e+bA7fdr5e8QqIONiYfhk9E6fw97Q0ooTVPos 5WA52XTkF3kJYgGY4X6Btesi/qUrFWM5H1zJqj8Na97VmBB8CauEVKXFpJx1Fpex Tuen86b3UdrfJ/EMAMxImQTTsTdcZNgo3ktEE6GysASVJFHGs+GkHb57s/m7PySk MS3ebnlk+EBsXV23rD43JxD9gnqzvL6M+V9TesTDvJ/gglXH8XPRUA5t2NXsj+71 953mNYohlsh7U2Z2fBgGo4zW3XYHyMTdimA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrleelgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Aug 2023 20:35:35 -0400 (EDT) Message-ID: <0e3bcc19-ded4-7612-5b7d-d5147c8842d9@gutov.dev> Date: Sat, 12 Aug 2023 03:35:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Protesilaos Stavrou , Philip Kaludercic References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <875y64wvyz.fsf@protesilaos.com> From: Dmitry Gutov In-Reply-To: <875y64wvyz.fsf@protesilaos.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64799-done Cc: 64799-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Version: 30.1 On 28/07/2023 06:33, Protesilaos Stavrou wrote: >> From: Dmitry Gutov >> Date: Thu, 27 Jul 2023 04:28:08 +0300 >> [... 14 lines elided] >> The change in format seems to go hand-in-hand with the change in face, >> though, because help-key-binding has a box already. >> >> Does this look good to everybody? >> >> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el >> index d482cc24d70..3611757fb82 100644 >> --- a/lisp/progmodes/project.el >> +++ b/lisp/progmodes/project.el >> @@ -1781,9 +1781,13 @@ project--keymap-prompt >> (let ((key (if key >> (vector key) >> (where-is-internal cmd (list project-prefix-map) t)))) >> - (format "[%s] %s" >> - (propertize (key-description key) 'face 'bold) >> - label))) >> + (if (facep 'help-key-binding) >> + (format "%s %s" >> + (propertize (key-description key) 'face >> 'help-key-binding) >> + label) >> + (format "[%s] %s" >> + (propertize (key-description key) 'face 'bold) >> + label)))) >> project-switch-commands >> " ")) > I am fine with this approach, thank you! Now pushed to master, thanks all! From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 06:35:29 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 10:35:29 +0000 Received: from localhost ([127.0.0.1]:32885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYlCy-0004SN-Qx for submit@debbugs.gnu.org; Wed, 23 Aug 2023 06:35:29 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:45353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYlCw-0004SA-PV for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 06:35:27 -0400 Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-1bf7423ef3eso22727155ad.3 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 03:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692786917; x=1693391717; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x2QSezNLkGz78rdv/jdGp6UbPlL+tod1TovS+MDcgFE=; b=HOFhBB+8lm4jKpwwVGXwUnpDE9hGWDDzoKk6bhgSR/PVCiSuThDCNymW9JLwheyA7j P3SqEPy0Ci8cFmrudtsRbRx7FufZQAGcoWUkSTFo5hIk44utY/JjJwyLyCmgv1qKASBT d9grlR+0Gzv++7g4vEjuUd6jDAuGM/HQvgzcDcxPs/3Y4KWWIzl+AJrfzcM8ZtZafH0Q PH/BSysdu/UyWb10y9O6vwvcqa+vVssE0xI8Rr6PD3qIrfiM3fEHfLoYT7MElI3++EYK NR8n1jQxLCu+pD8ainri1c7/8OXz3D8iReWP180FAb9nfhgWNxXEWtImsc97FeKkWSme 4Zpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692786917; x=1693391717; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x2QSezNLkGz78rdv/jdGp6UbPlL+tod1TovS+MDcgFE=; b=R/cS1ZXsBdjCVbzyQRWOyYIkAl7uzB4YS8LXTN0EV+io3Y3i1j36+pgkt02IBH6WBm sGo4RIWSgl2a/GbHCo4SQvB95jxRpPwXynvmWX7T+RyX167kAcu5U60arAzqws4MwOMO 0/M1KN30I+pygmAQkCnPTN/Fokv3khULXwmHEQ9KAIqfAY1bsBNwpSIHzl+pa21BYent nkuV81pVktcGF5zM06auzq+N8oz5JZV41PSDwHSBMn+x7471Bh1whrsOzlmwra57pot8 rvBqdP9n13yIvdh7HNiUhr7bbmJG5bDVpOQnktERgHG4k1QukZb4L2g/ArU6VDVjloUW bYYw== X-Gm-Message-State: AOJu0Yyb8Y4X1bY8wy67jyS43UvLpTSAvUUL6QWdmgmTzDdlyf87qfOz 0oA/NzbeCq5E6IPoNZVVgBA= X-Google-Smtp-Source: AGHT+IH78WV69RtRbdrkZ2wylrvx0tIocED+N5UaiFhNBYc3DOje6tiKsttEAjKJ9WrdcloXL7JrkA== X-Received: by 2002:a17:903:124b:b0:1b7:e646:4cc4 with SMTP id u11-20020a170903124b00b001b7e6464cc4mr12215403plh.28.1692786917421; Wed, 23 Aug 2023 03:35:17 -0700 (PDT) Received: from localhost ([14.139.216.98]) by smtp.gmail.com with ESMTPSA id i3-20020a170902c94300b001b890009634sm10576223pla.139.2023.08.23.03.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 03:35:16 -0700 (PDT) From: Visuwesh To: Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> (Dmitry Gutov's message of "Thu, 27 Jul 2023 04:28:08 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> Date: Wed, 23 Aug 2023 16:05:14 +0530 Message-ID: <87ttsq2gil.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64799 Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=9C= =E0=AF=82=E0=AE=B2=E0=AF=88 27, 2023] Dmitry Gutov wrote: > On 26/07/2023 07:50, Protesilaos Stavrou wrote: >> For my use, and Emacs 28+, I want this: >> (format "%s %s" >> (propertize (key-description key) 'face 'project-prompt-= key) >> label) >> The reason I mentioned the possibility of a user option is because >> without the square brackets the bold face will not have the same effect >> as the current design. The square brackets help add structure and make >> it easier to identify the keys. The use of 'bold' without the square >> brackets may make it more difficult for users to spot the keys. > > The change in format seems to go hand-in-hand with the change in face, > though, because help-key-binding has a box already. > > Does this look good to everybody? Sorry for replying so late. I make help-key-binding look the same as the default face, and now I can't distinguish the keys from the labels anymore since the former aren't bold anymore. :-( Can there a way to get them back? If you think it would be too ugly, then I can locally patch the function. [ FWIW, I liked the bold approach since it is similar to what read-multiple-choice does. ] From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 08:18:19 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 12:18:19 +0000 Received: from localhost ([127.0.0.1]:33099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYmoV-0001bu-FD for submit@debbugs.gnu.org; Wed, 23 Aug 2023 08:18:19 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYmoR-0001bd-Ro for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 08:18:18 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1F15A240104 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 14:18:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692793086; bh=KYFvFc+tHUcZdFxwXqvrgJa6XCN73Wrf+1soEmdVt0o=; h=Date:From:To:CC:Subject:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=Mhrr/LNXnJVH5oF0IkjCz/sLXgdoSv5wm/+zpZHErgOMPHVwo9KYm6eK3IG/Dbiy9 uAQorJP+gAHYcr8Vd2Vnv0HtMQT/zRqwiKGibmuyHDDfpEIJHidD6plW6PLgcEtvqA s9Gf6uBHXZnu9pUZsaykOdVHzhXTFIjg0AReVkp3IK+iGYTzrO9t6Hrsrn6lAr2BmY OiZQr8hVOXY2qSlhUT0AQoq/8h0w/gbgT4VLKLNaY705DDl6G7FqR69cPNHrTdzUtH JXjkt1rWYIWGiR8X6fvXRWoiC0450YOnZvA/+pymIqxrBLYYBK3/sEkkxTjQQk4tbb HiV8Edsl2jKTA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RW4x91M3jz9rxH; Wed, 23 Aug 2023 14:18:05 +0200 (CEST) Date: Wed, 23 Aug 2023 12:18:02 +0000 From: Philip Kaludercic To: Visuwesh , Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <87ttsq2gil.fsf@gmail.com> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64799 Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Would remapping help-key-binding to bold be a possible solution? On August 23, 2023 12:35:14 PM GMT+02:00, Visuwesh = wrote: >[=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =9C=E0=AF=82=E0=AE=B2=E0=AF=88 27, 2023] Dmitry Gutov wrote: > >> On 26/07/2023 07:50, Protesilaos Stavrou wrote: >>> For my use, and Emacs 28+, I want this: >>> (format "%s %s" >>> (propertize (key-description key) 'face 'project-promp= t-key) >>> label) >>> The reason I mentioned the possibility of a user option is because >>> without the square brackets the bold face will not have the same effec= t >>> as the current design=2E The square brackets help add structure and m= ake >>> it easier to identify the keys=2E The use of 'bold' without the squar= e >>> brackets may make it more difficult for users to spot the keys=2E >> >> The change in format seems to go hand-in-hand with the change in face, >> though, because help-key-binding has a box already=2E >> >> Does this look good to everybody? > >Sorry for replying so late=2E I make help-key-binding look the same as >the default face, and now I can't distinguish the keys from the labels >anymore since the former aren't bold anymore=2E :-( >Can there a way to get them back? If you think it would be too ugly, >then I can locally patch the function=2E > >[ FWIW, I liked the bold approach since it is similar to what > read-multiple-choice does=2E ] From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 08:45:11 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 12:45:11 +0000 Received: from localhost ([127.0.0.1]:33120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYnEU-0002KD-TY for submit@debbugs.gnu.org; Wed, 23 Aug 2023 08:45:11 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:42361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYnEQ-0002JJ-WF for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 08:45:09 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 89F53320092A; Wed, 23 Aug 2023 08:44:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 23 Aug 2023 08:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1692794696; x=1692881096; bh=ySpyYZ55ZiyYOwCDqAgjTN6KKB8rA3wE/Ga NCf/TYEU=; b=oxljl9xp9ubAjG7vEcB5ZdGpIEHukLXm755C4tNgWttUwqE2Tp7 K2IV+5JQ6KWg16HNnMqjMgMwNkMAdGqDbk0nC98PRwhuDd84pGJ2kkW7vgUpvkEw S7N61AutohpBUIsGITUknuV/pv0q/tp9A3zFvF6W0+unCJfusMg8K671HVpGDJ+e AvRCqJtGkFWWzU1mHZcM3w+fIslgL6dW68j4CsGYojRkzhTbdCzNL3IqPx4AHO1z lvuFUPBl2ONPkInUCH46+k3brlL9ijJtS2/HJdKI+BphjOjnp3LPR/ssMw7krdU9 RiEPOeJt9xezj9jlS7CXdcLQVQ7bKmm0gzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692794696; x=1692881096; bh=ySpyYZ55ZiyYOwCDqAgjTN6KKB8rA3wE/Ga NCf/TYEU=; b=QQVhowKxSQ6wnA6nAav8bX9pg1e6xvFY71mbbLsSMcop1d101EA 72aeBIDPp4PRJDHpkp6E5rBf0dEqpxTs5nnBgmVvbbWJgrhQuA2E21h7EOBWNi8J P0Wjwv9Oda7xVvtKyU5g6byf68vLrRGWvqfngCJbeeQcIFJMhTxhacE4xvC5nrD0 e2WLumolFRyLuP/04+r/dtVGmKxdP/ZANpC3NHKwsVKFfb3j0Ims6Uj1O4RzWanx iGyQaUDPzJXTJBxFk6wDNnwdB6RTWpEFwaK1HlCikv3nsurQ1FnaZp7OnP5uXYln Mo/fjTjX8I1COtDGnl4zD6HrGX0IkElkZBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Aug 2023 08:44:54 -0400 (EDT) Message-ID: Date: Wed, 23 Aug 2023 15:44:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Philip Kaludercic , Visuwesh References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 64799 Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 23/08/2023 15:18, Philip Kaludercic wrote: > Would remapping help-key-binding to bold be a possible solution? In one specific buffer? Through a hook or something? It seems to me Visuwesh wants the brackets back as well. As user option could do that. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 10:13:33 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 14:13:33 +0000 Received: from localhost ([127.0.0.1]:34841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYoc0-00058Y-Ra for submit@debbugs.gnu.org; Wed, 23 Aug 2023 10:13:33 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:42105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYobz-00058J-7U for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 10:13:31 -0400 Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-1c0bae4da38so1364585ad.0 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 07:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692800002; x=1693404802; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rDdqZTT6DysmumU2A9hIl9aNAY9eyDkyHw9/odXXcFM=; b=Mi5R3E4ZHdJIek6xKv239qRU/QaK1kQRERe+pR1PV/vRZzl/4V2WfbFGAiDRUHJUDS gqtk0WWVVdOHNMF/b+48qERpnBsEXInE8FRTEUD07+Y/NzdRtYIRv+hG632LP3zt1KLh DljonCaARrIk0rWfKs+BOKnf3xTqPJyGit0qXGX0ElQFED1C4NRaC7pNbw14Zcc0ZJ4S jw1O/P3I/f1BOCUb8U2gIcaQz+6lJG59EGK8YLWOAp9cdvtItz6bmdM/XE1o9ZnR/ZOe 23BUOB6S9XgxPxsu8cuZvRUfy7hzWGvqU8J7nrvvKn0VHMB5y7Vxt6WI7uFJqsEArv8g e1mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692800002; x=1693404802; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rDdqZTT6DysmumU2A9hIl9aNAY9eyDkyHw9/odXXcFM=; b=hFmL/Yaiw4wDXcdHQcg1cenMVrwQYhmTeB3eAG6VdjLq+7Qi7nVimK9pjz4ib6uBe5 MvQDrj/t0onI8n2NGUPN4UmdcNQdeJV750LKj6zQWOAeZ50NkvEjtdVL4PVT/qnj+YqL +HBMRL1XYeBtlEf7XlabHfyiA9prVZ466YcXHvKgvzi98skXrroarkApfifF9JSalkFB 5VLZoODUemBaqUcSUAqpjK3QKyO0iyVwjO7K+8UB4xQCGw9G0bqP8IRC503IzU0Y1iyl TYJWkAV4lMxdOyXMGfkI9aP0l6KB0Tk1V5Y34bWWkn279wKzuSTTRN85ehnCT2ExLVg9 lSMg== X-Gm-Message-State: AOJu0Yzm1WrReTcGVhj4VhCT/dZuGU+lkWcj9Y18Rab97R4jnTMiVMXU WVZlHMcx1Ym8NyaFHTsiaKQ= X-Google-Smtp-Source: AGHT+IEbLvpku4PS+HeeRGy/JgN6Cu9ZHAPFUBhcKoQCTQxVM4tqbfEwKq6HRzni68xL+7Xm/wrD6A== X-Received: by 2002:a17:903:41d0:b0:1bb:fcb9:f85 with SMTP id u16-20020a17090341d000b001bbfcb90f85mr20038795ple.32.1692800001818; Wed, 23 Aug 2023 07:13:21 -0700 (PDT) Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id z2-20020a170902ee0200b001bbb1eec92esm10962277plb.281.2023.08.23.07.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 07:13:21 -0700 (PDT) From: Visuwesh To: Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: (Dmitry Gutov's message of "Wed, 23 Aug 2023 15:44:52 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> Date: Wed, 23 Aug 2023 19:43:18 +0530 Message-ID: <87pm3d3kzl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE=B8= =E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: > On 23/08/2023 15:18, Philip Kaludercic wrote: >> Would remapping help-key-binding to bold be a possible solution? I hope not globally. > In one specific buffer? Through a hook or something? I was first thinking of writing an advice project--keymap-prompt to temporarily advice facep to return nil always in my init.el... > It seems to me Visuwesh wants the brackets back as well. As user > option could do that. I would like to have it, yes. I am so bad at picking up different typefaces _and_ colours that if I don't have extra characters around, I fail to recognise the emphasis. It is embarrassing, really. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 11:25:10 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 15:25:10 +0000 Received: from localhost ([127.0.0.1]:34910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYpjK-0007H7-FI for submit@debbugs.gnu.org; Wed, 23 Aug 2023 11:25:10 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:51925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYpjH-0007Gc-Lt for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 11:25:09 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 74309320095E; Wed, 23 Aug 2023 11:24:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 23 Aug 2023 11:24:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1692804296; x=1692890696; bh=ktgnnG+CWkUBxW6o7RBTE1tr9PAcCR/7x0U BVEpzza4=; b=dPTPoahfVxZRIG2DgJmvYPkyhgrtRkaqrkTOElsBOm3QkW/dl/L mMhhEi8oErp/JFa5tfioObcerrynrAHeIjDDvAJMbIYEHtqOkHIjvKts5svVF7ED yPPCB8C9qTF2Vzg1nNn35SV01LZvKvdamcecoLsIwxuc80IBhbHKj88pwIxE47jA kXnE64kXeainFA6zWSBIrXihXhUqyd7+v97T5dMoQvl88bfCq/FsoI2dzfU7T+x4 DgcAlqk4DMmU5lCq5TZTB7Miu6pjafzvDI+oG9Ba29bS52ViNLX4R8eZdfsaimOK X/1PbFzDwEbVNNPQkJXCyRyTG3IZAsNrrqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692804296; x=1692890696; bh=ktgnnG+CWkUBxW6o7RBTE1tr9PAcCR/7x0U BVEpzza4=; b=FZF7kLkxoA/Ss07IVYB+xe5+GLq1xNq0KTzkg3PYw/SOUHFmHlw yldMR9kw18QUN89C+grpnQLE2dUa7iGODvNdVoYORdI1k3v4RNCyzA5T8F1GX2CI pQQabhx7q/7pJgjSnPqjO3at8EnYOfKjCwfKFKIxOQbc5oFPwSh82poyi0FyM0O1 WUFqxCgVe8AWISTPNxzVoZ27vSg+QkH5X8Ep2piodvorLt6i7lR6/M7AL0w1AxfM L+lnLObG7R7XII5ab6CCAXjbWRDP6oXEzOrdzaOJ9o28AvkIVo8b9nwwY399KH5r gkGt+DwBPmQq5Ud/yrNUJTQAqWJveZQu85g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Aug 2023 11:24:55 -0400 (EDT) Message-ID: <355df502-0c6d-a070-119d-19daae961588@gutov.dev> Date: Wed, 23 Aug 2023 18:24:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Visuwesh References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87pm3d3kzl.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 23/08/2023 17:13, Visuwesh wrote: > [புதன் ஆகஸ்ட் 23, 2023] Dmitry Gutov wrote: > >> On 23/08/2023 15:18, Philip Kaludercic wrote: >>> Would remapping help-key-binding to bold be a possible solution? > > I hope not globally. > >> In one specific buffer? Through a hook or something? > > I was first thinking of writing an advice project--keymap-prompt to > temporarily advice facep to return nil always in my init.el... We can add an option, no problem. >> It seems to me Visuwesh wants the brackets back as well. As user >> option could do that. > > I would like to have it, yes. I am so bad at picking up different > typefaces _and_ colours that if I don't have extra characters around, I > fail to recognise the emphasis. It is embarrassing, really. Could you explain, then, why you customized help-key-binding to look like default? For example, the below customization would make it relatively close to how brackets look (but of course not exactly the same): (set-face-attribute 'help-key-binding nil :box '(:color "blue" :style released-button :line-width (6 . 0))) And the two places where this face is most prominently used (the one under discussion, and 'M-x describe-bindings' output) seem to use the face fairly similarly, so it seems to make sense, no? Anyway, if you want the option, can you suggest how it will be called? Will it be just boolean? From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 11:36:05 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 15:36:05 +0000 Received: from localhost ([127.0.0.1]:34921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYptt-0007Zs-7a for submit@debbugs.gnu.org; Wed, 23 Aug 2023 11:36:05 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:44422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYptr-0007ZP-HU for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 11:36:04 -0400 Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-1bbc87ded50so38823335ad.1 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 08:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692804954; x=1693409754; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+K2ZAAZMdPjZJ27VyoFTvwHqr1c0L06BXafm8rUfpLM=; b=T4iAxrifCopM+Q+swKdt1IXvQDSix700J2C6ceIqvmQkj2EmR5pKKKUQxeI0V85L82 5h7GRFm+iJrq7C+SRY0rARwK9XM1rEuiv5GMuV1/gyX6BJ34zNZ2eseF/9Euxu+ru/66 4loBT7S3qPSTF0wCaTEBv19S6+8Fm6drN6Nl/WAvXPI8/xZcag57kw6++JSSUozfn3l2 qhL/pEMVpc7JVbikhOR7I6viUccxymU7K2DHGElVJaXo07b1eO75ypRudZCjACfUXEmS daSWT1plBp9pMHfIKS2b9qE9EIAldPPgrUwzyeMuUueMqn4mn6mN2NyPtg68ekxFfzYG klVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692804954; x=1693409754; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+K2ZAAZMdPjZJ27VyoFTvwHqr1c0L06BXafm8rUfpLM=; b=Ph1oL3aURlbTTCiVdvxaIHkTIdXkeVQiBS+mGrXm0ImnTtzgEUBl+Y7onpSHbe4MfT bvWcW/LvSdsOGqDZXJ8WAflPzyIKQp3q8+yvAq0uuWt9SxTqSr1byU5e+vLofGTw/2RM tFW/79lyOYSt5eg0GtjoxQkJdNRhdgX7oez6BgNCTA56MF6/rtc4pafoZDwdyxpWNNUR ZcEvq7IxycTExSoAWlgRfAyhmAwzVya3R3wY3NULM2RRAxRDvw5orNDRJuei1Ndy/bcm novVy/boQsb/P7Hu6dvRK+GOqixDEd4lLg6eXDJgIT/Nkxnl9GJRUEh0tEp4lOCScZ6a hS5Q== X-Gm-Message-State: AOJu0YzryIWguqc+zQeJi4ss2dobmKXAkf3LvDLoQWY2RHDrs6NQ5tHo yrxAe3W4VIVoJhk89I47TMo= X-Google-Smtp-Source: AGHT+IFBtWs72Nwv//kCAiCp9MxF4/V7heJf+GQcSv9vM38rKMNB4nYrDz40ET1y63486KtqxVRSqA== X-Received: by 2002:a17:902:6b47:b0:1b8:b3f0:3d57 with SMTP id g7-20020a1709026b4700b001b8b3f03d57mr9491013plt.31.1692804954278; Wed, 23 Aug 2023 08:35:54 -0700 (PDT) Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id t8-20020a170902bc4800b001bbfa86ca3bsm11071623plz.78.2023.08.23.08.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 08:35:53 -0700 (PDT) From: Visuwesh To: Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <355df502-0c6d-a070-119d-19daae961588@gutov.dev> (Dmitry Gutov's message of "Wed, 23 Aug 2023 18:24:52 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> Date: Wed, 23 Aug 2023 21:05:51 +0530 Message-ID: <87lee13h60.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE=B8= =E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: > On 23/08/2023 17:13, Visuwesh wrote: >> [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE= =B8=E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: >>=20 >>> On 23/08/2023 15:18, Philip Kaludercic wrote: >>>> Would remapping help-key-binding to bold be a possible solution? >> I hope not globally. >>=20 >>> In one specific buffer? Through a hook or something? >> I was first thinking of writing an advice project--keymap-prompt to >> temporarily advice facep to return nil always in my init.el... > > We can add an option, no problem. Thanks! >>> It seems to me Visuwesh wants the brackets back as well. As user >>> option could do that. >> I would like to have it, yes. I am so bad at picking up different >> typefaces _and_ colours that if I don't have extra characters around, I >> fail to recognise the emphasis. It is embarrassing, really. > > Could you explain, then, why you customized help-key-binding to look > like default? I simply think it makes the text look too busy. I find it unnecessary to distinguish keys in *Help* buffers (and most other places), for example. > For example, the below customization would make it relatively close to > how brackets look (but of course not exactly the same): > > (set-face-attribute 'help-key-binding nil > :box '(:color "blue" :style released-button > :line-width (6 . 0))) > > And the two places where this face is most prominently used (the one > under discussion, and 'M-x describe-bindings' output) seem to use the > face fairly similarly, so it seems to make sense, no? See above. C-h b IMHO is too ugly with such a setting. > Anyway, if you want the option, can you suggest how it will be called? > Will it be just boolean? A boolean option will be fine. The facep condition can then be changed to (and NEW-OPTION (facep 'help-key-binding)). From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 11:37:41 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 15:37:41 +0000 Received: from localhost ([127.0.0.1]:34928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYpvQ-0007cO-M9 for submit@debbugs.gnu.org; Wed, 23 Aug 2023 11:37:41 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:58575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYpvN-0007c6-N0 for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 11:37:39 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5A23A3200916; Wed, 23 Aug 2023 11:37:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 23 Aug 2023 11:37:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1692805046; x=1692891446; bh=OTe50aii6dPutfl/NBSTohtUjMgr3zyfUiB mi7gCC1c=; b=axhJxPBiP+hHOYIfP35esD2xwaJhtILIZQ7TGw3jXkYcqk5QZl5 mWiRQk9P+kMFq9ly2R9rBDa8IhGjqAnWHPJcYiX1FLAidT5nDqrcBc1vokw2lIRV yqfBACnuj8EMq38tyLITgCpCSamkXBUY6JxX9AuP2eMtDU+ega8FYPOvE+jWKaji uD7K0Kk2iJt24OZGMSIciJc4DzH6B3djKbnNx1RxHBzd67rWwd6wdpt967+pTXyR oEJv028iyNEvD54WMOWURbbTCLUVkS7iHuHP6Wz93sQV8j1aQdunUGgZUCSR+1eY tDt5r8AvYcwgf5qrY5PjYfAfWNkuwNQ1fSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692805046; x=1692891446; bh=OTe50aii6dPutfl/NBSTohtUjMgr3zyfUiB mi7gCC1c=; b=PBwYi22wdONdqA6vX/vhlW/zphJdgvXA05GY1pY5rWJ5D2QyImm 2iqXv7mWVNlmefUF8N9J/uANp/La4Vh0jUD0BYhyG0ucWDQK9thmRlg7JJGVKArP Z4ZbaginokmnprcE09wR/vYP1/I5UC2ADcan25iWIpnXKeQj+bsShktHUqwFsPDR DNKeoOYaS55l9M+6Egri6RyUH+OUU5hc/qmSkhQ8G16fKbsThsdHic8S8+VGsZEz YunTqaK02+vLkDzTwV1v/oifx3JvrieiahV9iXBiO2boOOWBpppwaqrjloPaHTBR +IxRgI6kzkUZHn7jziztOk1OJMxrSs7M7gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Aug 2023 11:37:25 -0400 (EDT) Message-ID: Date: Wed, 23 Aug 2023 18:37:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Visuwesh References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> <87lee13h60.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87lee13h60.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 23/08/2023 18:35, Visuwesh wrote: >> Anyway, if you want the option, can you suggest how it will be called? >> Will it be just boolean? > A boolean option will be fine. The facep condition can then be changed > to (and NEW-OPTION (facep 'help-key-binding)). Any ideas for the name? From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 11:46:21 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 15:46:21 +0000 Received: from localhost ([127.0.0.1]:34934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYq3o-0007pY-Om for submit@debbugs.gnu.org; Wed, 23 Aug 2023 11:46:20 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:42061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYq3k-0007pI-SD for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 11:46:18 -0400 Received: by mail-pl1-x641.google.com with SMTP id d9443c01a7336-1c0bae4da38so2099825ad.0 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 08:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692805567; x=1693410367; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ffz6aKY28BIzlz3c/xNuJjtw+cm+3VGccjbJjdVTt3Y=; b=i/9++GJrE+tngzmxs6GgwdQ9j84x2+se9RPJcCG/f0Z9HucCOBLvatcvUQggAMBMUj m0maZF17fJEsGjdgMfvmE0KKwpkD6IaqsKYWWPVRJziQYVvzo0Zi6w51qqCKlNBPl7Il RSulvy7hVQbIl7j3joph0CtJcQDjYvCKWXmAwe6IUYm8yyQKVUQn+jO2ucypyFAkJu6Y hhT4QkVFpXyxkL52pffMv35temFmbuxCOb0uV5Dumg3SUiPMjqE/6hHEcImnY/fp9xf9 G6XJ7TTLkZuFsQu1wbXg5hhnFXNqhtGR7mjghGuNtftGerTk5mmENl947o+vXE/jnTyC ESiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692805567; x=1693410367; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ffz6aKY28BIzlz3c/xNuJjtw+cm+3VGccjbJjdVTt3Y=; b=ZunT7dukvZD5FEtUBRbJoq3WlL4DVgN5OYkNPRxvrPOFO9+iUymBiSxsfb24BC/CIj H/1mZUxd1Ieh21Hczn3UCBN2KafVLJJDZwJLvxGf9HFjKC7HGgriK9oPZUJna7yNkzaG OoVVlJaxHNF04WYUka3+d1eYQ6CSuTmzYKV5EquOffYxT8FZnj8DyrkyohD6AIHJgQQ6 Dm0j8o6gj1QqqrlSugAfhheXoAbtJa29fpH3KH90+IzcJtcwRhRJViNDyn9K1QwuXudM dYuSm05KmymBq//bfFjBvjMYSAIXpY2ANSjbYMgcprzX+GuBizbK3flf4e+NJdaVToZS 8vMw== X-Gm-Message-State: AOJu0YzRs3E3ilsGBeTr/pfO/p7Llg7Bri0Tnx/yZ7ESUBIOlgK2e5rj HUZQlNUjRlXA9SIi6Buc9Dk= X-Google-Smtp-Source: AGHT+IFiXHJvH18zc7897oMUoiwp5uKz3Ob6oPWBS3kOMoP0BiP6QSPeoPou8x4GkTvvOGZ4FRiOow== X-Received: by 2002:a17:902:d50c:b0:1bb:d586:d29a with SMTP id b12-20020a170902d50c00b001bbd586d29amr20258492plg.34.1692805567596; Wed, 23 Aug 2023 08:46:07 -0700 (PDT) Received: from localhost ([14.139.216.98]) by smtp.gmail.com with ESMTPSA id jk8-20020a170903330800b001b672af624esm11083270plb.164.2023.08.23.08.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 08:46:07 -0700 (PDT) From: Visuwesh To: Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: (Dmitry Gutov's message of "Wed, 23 Aug 2023 18:37:23 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> <87lee13h60.fsf@gmail.com> Date: Wed, 23 Aug 2023 21:15:50 +0530 Message-ID: <87h6op3gpd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE=B8= =E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: > On 23/08/2023 18:35, Visuwesh wrote: >>> Anyway, if you want the option, can you suggest how it will be called? >>> Will it be just boolean? >> A boolean option will be fine. The facep condition can then be changed >> to (and NEW-OPTION (facep 'help-key-binding)). > > Any ideas for the name? project-prompt-key-use-bold-face? I am unfortunately terrible at naming things. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 12:41:10 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 16:41:10 +0000 Received: from localhost ([127.0.0.1]:35021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYqur-0000vi-IP for submit@debbugs.gnu.org; Wed, 23 Aug 2023 12:41:10 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:41507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYquW-0000sk-FF for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 12:40:49 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id B9D383200319; Wed, 23 Aug 2023 12:40:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 23 Aug 2023 12:40:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1692808838; x=1692895238; bh=EevekPP3hBooGWqnKkwR6mxenKA5JgyVSN0 gw5gaL9Q=; b=FdH4W3+J2epWpqenJGbTKqv7BN/3m/b0CQGPNlZvJv1eKgi7VVx K+ruPjO/424ol9xICgEX6h/870ksubFFIZirkqTrturxgq4V0MW+3r2VOY1Rjn1d Ttb1gaxaTibP5Kpvn7uWG/j15/z77k4m634z9fHu2JAQG4QF5swrMurG0QmKJaDL RFY9R3QSyok2ktrKA/Nh07/ibbepyZ33oWKiQ5vVBwNqsxrjD2UtNDKl6vZquXZn /KKtxaU3KA+OZCCIJ6of9QcYPuKqPI1Kj3+eIjCE3b+q7Y93Y5FP21I2UgDfU0qW 3sNQrdn6fhxjK9uLR5k4NDfCVloKUcgMEjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692808838; x=1692895238; bh=EevekPP3hBooGWqnKkwR6mxenKA5JgyVSN0 gw5gaL9Q=; b=N6hPz4TgQPPk26ocKhCFgIyutB1iRhe7ojb/x1wLN8Nl3pYfSzH kvslhEucJzUSJQtPdY8966cOomrYDEAcB3SwCXaVtnQIfaIxg0sHDPElMgJWmbFx QJ9L484W91JzIRaaGqWWVglnN4Cqs5/Je5B8+jdG0GN6/+sauQlf1UF6b8dJov8d t/tAs9VpUJnGbJYQD+jHAUpO6m6O3eB7cXte3/bPCwcJTa2xeQqdnsl4NYFFHVMD ACXZGUqcs2UmJR8W3dBskLOKw6PDTcvYtSI+FqnI86Tdp5tVcLpgl92nBtORaaCK Cvf0clI2xwY7fOs/f0vTPDcA+9q8rB0ORPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffg feejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Aug 2023 12:40:36 -0400 (EDT) Message-ID: <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> Date: Wed, 23 Aug 2023 19:40:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Visuwesh References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> <87lee13h60.fsf@gmail.com> <87h6op3gpd.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87h6op3gpd.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 23/08/2023 18:45, Visuwesh wrote: > [புதன் ஆகஸ்ட் 23, 2023] Dmitry Gutov wrote: > >> On 23/08/2023 18:35, Visuwesh wrote: >>>> Anyway, if you want the option, can you suggest how it will be called? >>>> Will it be just boolean? >>> A boolean option will be fine. The facep condition can then be changed >>> to (and NEW-OPTION (facep 'help-key-binding)). >> Any ideas for the name? > project-prompt-key-use-bold-face? I am unfortunately terrible at naming > things. Ok, I've added project-key-prompt-style. Please test whenever convenient. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 13:36:54 2023 Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 17:36:54 +0000 Received: from localhost ([127.0.0.1]:35100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYrmn-0002VN-TY for submit@debbugs.gnu.org; Wed, 23 Aug 2023 13:36:54 -0400 Received: from mail-oa1-x43.google.com ([2001:4860:4864:20::43]:45533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYrml-0002V9-U6 for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 13:36:52 -0400 Received: by mail-oa1-x43.google.com with SMTP id 586e51a60fabf-1c0fa9dd74fso3912442fac.3 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 10:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692812202; x=1693417002; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vWRT7B2N9ZCgHf5UqT8FJAvyfItQ+3XUo2DR1Vbi58I=; b=WlECS1G6ElEBtmgxl9LlobHDJWucHXVbfN5btPhQ8zhuA6F0EENmtQbx6OzFDX9kN2 PXI3PflT9AZO5xmrqcjLKXxNA/Im42vKxgojfTHYXIUsm/GONphUmcBmDE/N9vbQ2JUe 95LTq3mzML8SUFXO6vPJeT29lCWRX7C6wTgYNrzwHNIhbvj7nUzLcGsMxGXu6F5W4cCi oLmrdntSchUo7vxN211Xh457Dx7TQ1Jsy8g4sBdst0gxcc1s6dvkK1Cbu/oxSosBGjTH juC0wTo6jsL53AaztdShQX8KFUiuua9I0W/eczH+rgmujtgOL9vm9FgF5giV3lveoRQt s+Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692812202; x=1693417002; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vWRT7B2N9ZCgHf5UqT8FJAvyfItQ+3XUo2DR1Vbi58I=; b=I7+JXFnV9Nvij5dvDfimLGylIntfk8jbgePq68CNI22pXkrbBtlpZ6ndjIwFSrCKnL b0PrtL+blmVN3vamttOYdN0r2gVsvCEVoNnW4vtGhpvP4w/okytrS5pX3ilFi2ROY+cC k7HJr3kIC5lYCAYIiAFqmpJJ0wS4QJc0WTWxDyV6HAocbxS0Fs3OugXq3YBx2dyEMO02 ohu2iU2xwEsn0g9pHW4l8imI9iMbIgIlNbspmnWgmEWRZvS4z21zGUKv8eohXhyHy8sB 9BuiPbRioxmgji4qgOxHI36aSdRLIMgHVUhO+B4LBqac5hdFLHpoTiMORvFzp1xvVdkx GDuw== X-Gm-Message-State: AOJu0YzIm5lUDrwPnkd4EqS7v56ZuvKoLxsZdAXm+SnHsTIbel/zsgnY 0/qCe0p/KwNWUOI7fVBTDSg= X-Google-Smtp-Source: AGHT+IHCu08Rw6n0dQGEhKFuDCgs2xcx3gpL8QpYeet9QeaLUBx6ZofZoygl9L8rIlP0i/Loe0Hbbw== X-Received: by 2002:a05:6871:551:b0:1c0:a784:cf7e with SMTP id t17-20020a056871055100b001c0a784cf7emr19239505oal.51.1692812202401; Wed, 23 Aug 2023 10:36:42 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id t7-20020a17090aba8700b0026b3773043dsm74006pjr.22.2023.08.23.10.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 10:36:41 -0700 (PDT) From: Visuwesh To: Dmitry Gutov Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face In-Reply-To: <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> (Dmitry Gutov's message of "Wed, 23 Aug 2023 19:40:34 +0300") References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> <87lee13h60.fsf@gmail.com> <87h6op3gpd.fsf@gmail.com> <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> Date: Wed, 23 Aug 2023 23:06:34 +0530 Message-ID: <87cyzd3bkt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE=B8= =E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: > On 23/08/2023 18:45, Visuwesh wrote: >> [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE= =B8=E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: >>=20 >>> On 23/08/2023 18:35, Visuwesh wrote: >>>>> Anyway, if you want the option, can you suggest how it will be called? >>>>> Will it be just boolean? >>>> A boolean option will be fine. The facep condition can then be changed >>>> to (and NEW-OPTION (facep 'help-key-binding)). >>> Any ideas for the name? >> project-prompt-key-use-bold-face? I am unfortunately terrible at naming >> things. > > Ok, I've added project-key-prompt-style. > > Please test whenever convenient. Thanks, it works as expected. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 07:59:30 2023 Received: (at 64799) by debbugs.gnu.org; 24 Aug 2023 11:59:30 +0000 Received: from localhost ([127.0.0.1]:36287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ8zq-0003Mo-ID for submit@debbugs.gnu.org; Thu, 24 Aug 2023 07:59:30 -0400 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]:51594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ8zo-0003Mb-L5 for 64799@debbugs.gnu.org; Thu, 24 Aug 2023 07:59:30 -0400 Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6bd6a34474cso4738561a34.3 for <64799@debbugs.gnu.org>; Thu, 24 Aug 2023 04:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692878359; x=1693483159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0p69uUxxjwtNGfpF+ruGakK9Xy6XejhWWPIwIOn4MpE=; b=ZtPOk476PZAdO1Aa+dNrVTcNFbNG0jUJh9jZR/w57p8Nt1Bue4taGmKB4XfPsNh5Te eBgsIA1/A5vaY+Q8dc60BH6Gob5/h/Axxrl50evofMaNj1v20mVVxs1QszlHm+t+sBIj qitr+w/ADKijbbsTg3hMoOA9/4BeywExsiyq7MNLoHMVrJMB5gK38Z7s9p96BAqHtmSk Fjm4RQw2ELxTCatGcbZsTlQ3vgeN2AKXPOR2N/yvIZ1uwgrA10ZCG0LmuIR7HSYnEprD YqnEmEUpCBTgX+xGHqQA8jNrZOF+9IUrt/rAvgZJSe+WH1RxgK+l16/3ksUq1RyExy6G blvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692878359; x=1693483159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0p69uUxxjwtNGfpF+ruGakK9Xy6XejhWWPIwIOn4MpE=; b=UABl3MM3sLZpPdkZ2NHtIn6T4qjaQuriIEAp+1oOVAStLh7Xmk+UtFy5+pkaT2Sq5W fwRAyPr5uSq2ncP3e5W75f0Ky8U3KsBPdMAga8l9GkXhk3Dq3Q6zSLmefoqe66jQtmPt E86B9V651y/p5JrMQCvhv0kFX6Rz876ypRcy1OrqCxvhOO7xqDrqNgSLhQJ1ovXAQsHI dgBmVe3yQmkWypeqXNNnBirH0EHOBE/D4vB8fDfnQ73TLx4MlfLc4oNh/t2wRmMXUz2T jSNNeRZUlDvDyz5InIVdholoM0yMwSiaw7/9JCPifnH6D37DbafpXl3kweP4H63+RYL4 RRZQ== X-Gm-Message-State: AOJu0YzbJHIQKI8X76CZWpf6Y8WM3DrAZRLOoZSJcB1KKiJidOgQThNf VjSGeDNcBzEGYWw9jpkRzL0= X-Google-Smtp-Source: AGHT+IH2XT9eMoF7+52A5duJX//kOGw78+V6+VkLzuuN4RcvXoGDQUQ/GNfkvg8+jivFiEeVYtW1BQ== X-Received: by 2002:a05:6870:9a1f:b0:1c8:c7d1:b4f9 with SMTP id fo31-20020a0568709a1f00b001c8c7d1b4f9mr18342634oab.29.1692878358798; Thu, 24 Aug 2023 04:59:18 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id v2-20020a056870e28200b001b3d67934e9sm8027164oad.26.2023.08.24.04.59.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 04:59:16 -0700 (PDT) Message-ID: <43bb13ec-98d3-7b9b-4129-72030b08a5ab@gmail.com> Date: Thu, 24 Aug 2023 08:59:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Dmitry Gutov References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> <87lee13h60.fsf@gmail.com> <87h6op3gpd.fsf@gmail.com> <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> From: Mauro Aranda In-Reply-To: <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Dmitry Gutov writes: > On 23/08/2023 18:45, Visuwesh wrote: >> [புதன் ஆகஸ்ட் 23, 2023] Dmitry Gutov wrote: >> >>> On 23/08/2023 18:35, Visuwesh wrote: >>>>> Anyway, if you want the option, can you suggest how it will be called? >>>>> Will it be just boolean? >>>> A boolean option will be fine. The facep condition can then be changed >>>> to (and NEW-OPTION (facep 'help-key-binding)). >>> Any ideas for the name? >> project-prompt-key-use-bold-face? I am unfortunately terrible at naming >> things. > > Ok, I've added project-key-prompt-style. > > Please test whenever convenient. Hi Dmitry, > (defcustom project-key-prompt-style (if (facep 'help-key-binding) > t > 'brackets) > "Which presentation to use when asking to choose a command by key. > > When `brackets', use text brackets and `bold' for the character. > Otherwise, use the face `help-key-binding' in the prompt." > :type 'boolean > :group 'project > :version "30.1") Shouldn't the :type be a choice between t and brackets? From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 08:35:15 2023 Received: (at 64799) by debbugs.gnu.org; 24 Aug 2023 12:35:15 +0000 Received: from localhost ([127.0.0.1]:36325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ9YQ-0004MG-Ov for submit@debbugs.gnu.org; Thu, 24 Aug 2023 08:35:15 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ9YN-0004M0-AC for 64799@debbugs.gnu.org; Thu, 24 Aug 2023 08:35:13 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9E1A85C00D1; Thu, 24 Aug 2023 08:35:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 24 Aug 2023 08:35:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1692880501; x=1692966901; bh=zC/fOP6SoITKVc2Y+EUNCXEvOqhdeWr7XBg J870V2R8=; b=UGggyVn5T6Ill5JI87JYp9UwmEoDupKCliL49JbMDgHcqZIHUqz 1ffQ2XRcxrgQyjBCQCEqUX1iO7IKa8rrAzpk1E3SghhaOTF5mYba7Joq310tV4lN bMKCsIA6UhuJo1XNc1Ze0carWUwiC4wNUKDtPUQhXRhQYED/2urmZuyHfabGfA0m j1I9/DWTut6Sl+Xy2mmRsmb9HrBmo9vZZn1IJ9z7YhGiqHJ88NN0FTm6ngE8Uizf QSJOOZa+m2bWR6i51sj5fnM9GrOc+pUpYqxY9CeY3PBmiDGKVKqVtRCr072jIxG2 vSFRjQ7howgVlbpW8NDv3WON0BRJmJQJwfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692880501; x=1692966901; bh=zC/fOP6SoITKVc2Y+EUNCXEvOqhdeWr7XBg J870V2R8=; b=dW6pR864u/KQDpNAH3cmBc3cRE246Tza2MTw4xY5mWQpu6vPs34 xFqVy9tai+WtpTmUFQwtBGrWXHS86ZxN7x4qAknWIAhUz7JccyLWIcW51UxsiuJ+ PVi1nKE9b89zSN/5IGe1P07sVPJMpZVpo0JPHQY173Zset75lyfVpbwNQgj9N78y vyE3Fr18Xwl00mx0HNl7v2V9r2yfUPc4bkWStaTYrxLgLVHEQAgqMMjeLrlVGJt3 rGb//MSm/6P5iHAMSkCXWevaixGpkKrzK0UNAliFY2CORdPlUc1QVhEXIKXdL+4T HD/dw/evHpKeWCKaweSpdpBOWwkDg0ioJEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddviedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Aug 2023 08:34:59 -0400 (EDT) Message-ID: Date: Thu, 24 Aug 2023 15:34:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face Content-Language: en-US To: Mauro Aranda References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> <87lee13h60.fsf@gmail.com> <87h6op3gpd.fsf@gmail.com> <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> <43bb13ec-98d3-7b9b-4129-72030b08a5ab@gmail.com> From: Dmitry Gutov In-Reply-To: <43bb13ec-98d3-7b9b-4129-72030b08a5ab@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 64799 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 24/08/2023 14:59, Mauro Aranda wrote: > Shouldn't the :type be a choice between t and brackets? Thanks! Fixed. From unknown Thu Aug 21 12:11:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Sep 2023 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator