Subject: bug#64799: [PATCH] Add 'project-prompt-key' face

From: Mauro Aranda <[email-masked]>
Date: Thu, 24 Aug 2023 08:59:13 -0300

Dmitry Gutov <[email-masked]> writes:

 > On 23/08/2023 18:45, Visuwesh wrote:
 >> [புதன் ஆகஸ்ட் 23, 2023] Dmitry Gutov wrote:
 >>
 >>> On 23/08/2023 18:35, Visuwesh wrote:
 >>>>> Anyway, if you want the option, can you suggest how it will be 
called?
 >>>>> Will it be just boolean?
 >>>> A boolean option will be fine.  The facep condition can then be 
changed
 >>>> to (and NEW-OPTION (facep 'help-key-binding)).
 >>> Any ideas for the name?
 >> project-prompt-key-use-bold-face?  I am unfortunately terrible at naming
 >> things.
 >
 > Ok, I've added project-key-prompt-style.
 >
 > Please test whenever convenient.

Hi Dmitry,

 > (defcustom project-key-prompt-style (if (facep 'help-key-binding)
 >                                         t
 >                                       'brackets)
 >   "Which presentation to use when asking to choose a command by key.
 >
 > When `brackets', use text brackets and `bold' for the character.
 > Otherwise, use the face `help-key-binding' in the prompt."
 >   :type 'boolean
 >   :group 'project
 >   :version "30.1")

Shouldn't the :type be a choice between t and brackets?