GNU bug report logs - #64786
[PATCH]: services: databases: add option to specify UID / GID for the postgres user

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64786: closed ([PATCH]: services: databases: add option to
 specify UID / GID for the postgres user)
Date: Wed, 16 Aug 2023 20:45:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 16 Aug 2023 22:44:22 +0200
with message-id <87y1ia3eft.fsf <at> gnu.org>
and subject line Re: bug#64786: [PATCH]: services: databases: add option to specify UID / GID for the postgres user
has caused the debbugs.gnu.org bug report #64786,
regarding [PATCH]: services: databases: add option to specify UID / GID for the postgres user
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64786: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64786
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Martin Baulig <martin <at> baulig.is>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH]: services: databases: add option to specify UID / GID for the
 postgres user
Date: Sat, 22 Jul 2023 00:27:19 +0000

[Message part 3 (text/plain, inline)]

Hello,

This is my first contribution to GNU Guix, and I hope this patch is in the correct format.

Attached is a small patch to gnu/services/databases.scm that adds an option to explicitly
specify the UID / GID for the postgres user, as well as an option not to create the service
account at all.

I added some documentation as well and provided a detailed reasoning and background
in the commit message.

Hope this is useful and looking forward to hearing back to you,

Martin

[Message part 4 (text/html, inline)]

[0001-services-databases-Add-option-to-specify-UID-GID-for.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Martin Baulig <martin <at> baulig.is>
Cc: 64786-done <at> debbugs.gnu.org
Subject: Re: bug#64786: [PATCH]: services: databases: add option to specify
 UID / GID for the postgres user
Date: Wed, 16 Aug 2023 22:44:22 +0200

Hi Martin,

Martin Baulig <martin <at> baulig.is> skribis:

> From ae2534f6cc8611483a11f7a934777a03bd194a27 Mon Sep 17 00:00:00 2001
> From: Martin Baulig <martin <at> baulig.is>
> Date: Mon, 17 Jul 2023 18:13:42 -0400
> Subject: [PATCH] services: databases: Add option to specify UID / GID for
>  postgres user.
>
> Add 'createAccount?', 'uid' and 'gid' to <postgresql-configuation>.
>
> Unlike other system daemons, the PostgreSQL data directory is typically
> meant to persist across 'guix system reconfigure' and once created, you
> don't want it's UID or GID to change anymore.
>
> Furthermore, if you want to place the data directory on a network share
> and use NFSv4 with idmap, then the 'postgres' user must exist when the
> 'rpc.idmapd' daemon is launched; prior to mounting the share.  And it
> needs to be possible to mount the share without configuring PostgreSQL.
>
> With NFSv3, the UID and GID typically needs to match those on the
> server.
>
> The added options allow for both of these scenarios:
>
> You can either create the user in (operating-system (users)) completely
> independently of the 'postgresql-service-type' (for instance to get your
> NFS setup working first prior to configuring your databases) - or "pin"
> it's UID / GID values.

This look very useful.  I wish this situation could be handled in a more
automatic way somehow, but at least this patch lets admins handle it
“manually” as you write, and that’s a great improvement.

I expanded the commit log to match the conventions as noted in
<https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html>
and applied it.

Thank you, and welcome!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.