GNU bug report logs - #64775
/run should be cleaned on boot

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72670: closed (avahi-daemon can fail to restart due to stale
 /run/avahi-daemon/pid)
Date: Wed, 25 Sep 2024 14:56:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 25 Sep 2024 16:26:09 +0200
with message-id <8734lnu7we.fsf <at> gnu.org>
and subject line Re: [bug#72920] [PATCH 0/3] Clean out /run upon boot
has caused the debbugs.gnu.org bug report #64775,
regarding avahi-daemon can fail to restart due to stale /run/avahi-daemon/pid
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64775: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64775
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: bug-guix <at> gnu.org
Subject: avahi-daemon can fail to restart due to stale /run/avahi-daemon/pid
Date: Fri, 16 Aug 2024 15:32:29 +0200

The ‘avahi-daemon’ service fails to restart these days: a stale
/run/avahi-daemon/pid upon reboot leads it to abandon.  From
/var/log/messages:

--8<---------------cut here---------------start------------->8---
Aug 16 13:29:11 localhost shepherd[1]: Starting service avahi-daemon... 
Aug 16 13:29:11 localhost shepherd[1]: Service avahi-daemon has been started. 
Aug 16 13:29:11 localhost shepherd[1]: Service avahi-daemon started. 
Aug 16 13:29:11 localhost shepherd[1]: Service avahi-daemon running with value (("unknown" . #<input-output: socket 27>)). 
Aug 16 13:29:11 localhost shepherd[1]: Spawning systemd-style service /gnu/store/yfl1x5k3njghkg4ckximqb0ysppvx8na-avahi-0.8/sbin/avahi-daemon. 
Aug 16 13:29:11 localhost shepherd[1]: Running value of service avahi-daemon changed to 1497. 
Aug 16 13:29:11 localhost shepherd[1]: Service avahi-daemon (PID 1497) exited with 255. 
Aug 16 13:29:11 localhost shepherd[1]: Service avahi-daemon has been disabled. 
Aug 16 13:29:11 localhost shepherd[1]:   (Respawning too fast.) 
--8<---------------cut here---------------end--------------->8---

… and /var/log/avahi-daemon.log:

--8<---------------cut here---------------start------------->8---
2024-08-16 13:29:11 Daemon already running on PID 1346
2024-08-16 13:29:11 Daemon already running on PID 1346
2024-08-16 13:29:11 Daemon already running on PID 1346
2024-08-16 13:29:11 Daemon already running on PID 1346
2024-08-16 13:29:11 Daemon already running on PID 1346
2024-08-16 13:29:11 Daemon already running on PID 1346
2024-08-16 13:29:11 Daemon already running on PID 1346
--8<---------------cut here---------------end--------------->8---

The issue was uncovered by the switch to socket activation in commit
3298ec0200af0d0b0850a388df0a78e87320307f: despite using socket
activation, avahi-daemon checks for the presence of a PID file; however,
there’s no longer a cleanup process as is the case when #:log-file is
used, hence the bug.

But the core problem seems to be that ‘cleanup-service-type’ deletes
/var/run at boot but not /run.  I guess it should delete /run as well?

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 64775-done <at> debbugs.gnu.org, 72670-done <at> debbugs.gnu.org,
 72920-done <at> debbugs.gnu.org
Subject: Re: [bug#72920] [PATCH 0/3] Clean out /run upon boot
Date: Wed, 25 Sep 2024 16:26:09 +0200

Vagrant Cascadian <vagrant <at> debian.org> skribis:

> On 2024-08-31, Ludovic Courtès wrote:
>> Ludovic Courtès (3):
>>   services: cleanup: Run under C.UTF-8 locale.
>>   services: cleanup: Create directories with the right mode upfront.
>>   services: cleanup: Delete /run upon boot.
>
> As they say, Looks Good To Me. :)

Thanks, pushed as c250033aa69f35e64949a87fd8482b253dd416b4, except for
the first one because I remembered that C.UTF-8 is unavailable in
cross-compiled programs.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.