GNU bug report logs - #64760
make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

Previous Next

Full log

View this message in rfc822 format

From: Janneke Nieuwenhuizen <janneke <at> gnu.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 64760 <at> debbugs.gnu.org
Subject: bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty.
Date: Fri, 28 Jul 2023 10:52:16 +0200

Josselin Poiret writes:

Hi!

> * tests/store-roots.scm ("gc-roots, initial"): Set expected result to empty.
> Also do not error out if /profiles doesn't exist.
> ---
>  tests/store-roots.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/store-roots.scm b/tests/store-roots.scm
> index 9877987a65..d82a29e313 100644
> --- a/tests/store-roots.scm
> +++ b/tests/store-roots.scm
> @@ -31,10 +31,11 @@ (define %store #f)
>  (test-begin "store-roots")
>  
>  (test-equal "gc-roots, initial"
> -  (list (string-append %state-directory "/profiles"))
> +  '()
>    (begin
>      ;; 'gc-roots' should gracefully handle lack of that directory.
> -    (delete-file-recursively (string-append %state-directory "/profiles"))
> +    (false-if-exception
> +     (delete-file-recursively (string-append %state-directory "/profiles")))
>      (gc-roots)))
>  
>  ;; The 'open-connection' call below gets guix-daemon to create

Just a headsup that this change breaks the store-roots test on the hurd
for me.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.