GNU bug report logs - #64755
[PATCH] gnu: git-modes -> emacs-git-modes.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64755 in the body.
You can then email your comments to 64755 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: guix-patches <at> gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH] gnu: git-modes -> emacs-git-modes.
Date: Fri, 21 Jul 2023 00:49:18 +0400

* gnu/packages/emacs-xyz.scm (emacs-git-modes): New variable.
(git-modes): Deprecate variable.
---

This makes the package name consistent when installing it through 'guix package -i' and a variable name in a system declaration file (e.g. /etc/config.scm). It finishes the job in #29582.

Not sure if the deprecation method I used is optimal, since it brings back to life the package name 'git-modes'. However, putting 'emacs-git-modes' in 'old-name' causes 'warning: ambiguous package specification', as expected.

 gnu/packages/emacs-xyz.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 550e5d2a65..6e8b2b313c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1261,7 +1261,7 @@ (define-public emacs-project
 some utility functions, and commands using that infrastructure.")
     (license license:gpl3+)))
 
-(define-public git-modes
+(define-public emacs-git-modes
   (package
     (name "emacs-git-modes")
     (version "1.4.1")
@@ -1285,6 +1285,9 @@ (define-public git-modes
 @file{.git/config}.")
     (license license:gpl3+)))
 
+(define-public git-modes
+  (deprecated-package "git-modes" emacs-git-modes))
+
 (define-public emacs-with-editor
   (package
     (name "emacs-with-editor")

base-commit: 21b718f4d6c3ded8ef50d12f6e9ae6474f74620f
-- 
2.41.0

Message #8 received at 64755 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Ahmad Draidi <a.r.draidi <at> redscript.org>, 64755 <at> debbugs.gnu.org
Cc: Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#64755] [PATCH] gnu: git-modes -> emacs-git-modes.
Date: Fri, 21 Jul 2023 20:27:30 +0200

Am Freitag, dem 21.07.2023 um 00:49 +0400 schrieb Ahmad Draidi:
> * gnu/packages/emacs-xyz.scm (emacs-git-modes): New variable.
> (git-modes): Deprecate variable.
> ---
> 
> This makes the package name consistent when installing it through
> 'guix package -i' and a variable name in a system declaration file
> (e.g. /etc/config.scm). It finishes the job in #29582.
> 
> Not sure if the deprecation method I used is optimal, since it brings
> back to life the package name 'git-modes'. However, putting 'emacs-
> git-modes' in 'old-name' causes 'warning: ambiguous package
> specification', as expected.
There is define-deprecated/public, as well as more idiomatic ways of
writing the commit message, i.e. 

gnu: Rename git-modes to emacs-git-modes.

* gnu/packages/emacs-xyz.scm (git-modes): Deprecate and rename to…
(emacs-git-modes): … this.

Cheers

Message #11 received at 64755 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 64755 <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#64755] [PATCH] gnu: git-modes -> emacs-git-modes.
Date: Sat, 22 Jul 2023 14:15:52 +0400

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Freitag, dem 21.07.2023 um 00:49 +0400 schrieb Ahmad Draidi:
>> * gnu/packages/emacs-xyz.scm (emacs-git-modes): New variable.
>> (git-modes): Deprecate variable.
>> ---
>>
>> This makes the package name consistent when installing it 
>> through
>> 'guix package -i' and a variable name in a system declaration 
>> file
>> (e.g. /etc/config.scm). It finishes the job in #29582.
>>
>> Not sure if the deprecation method I used is optimal, since it 
>> brings
>> back to life the package name 'git-modes'. However, putting 
>> 'emacs-
>> git-modes' in 'old-name' causes 'warning: ambiguous package
>> specification', as expected.
> There is define-deprecated/public, as well as more idiomatic 
> ways of
> writing the commit message, i.e.
>
I grepped the repo, but managed to miss 'deprecation.scm' 
somehow. Thanks for the tip.
I updated the patch with 'define-deprecated/public-alias'.

> gnu: Rename git-modes to emacs-git-modes.
>
> * gnu/packages/emacs-xyz.scm (git-modes): Deprecate and rename 
> to…
> (emacs-git-modes): … this.
>
I got the previous commit message from 3aeca58073, which seemed 
weird to me, but I thought it's the way to go.

I'll email the updated patch shortly.
> Cheers

Thanks

Message #14 received at 64755 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 64755 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v2] gnu: Rename git-modes to emacs-git-modes.
Date: Sat, 22 Jul 2023 14:35:37 +0400

* gnu/packages/emacs-xyz.scm (git-modes): Deprecate and rename to...
(emacs-git-modes): ... this.
[use-modules]: Add (guix deprecation).
---
 gnu/packages/emacs-xyz.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6af5faf4cb..10bfb76046 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -153,6 +153,7 @@ (define-module (gnu packages emacs-xyz)
   #:use-module (guix packages)
   #:use-module (guix cvs-download)
   #:use-module (guix download)
+  #:use-module (guix deprecation)
   #:use-module (guix bzr-download)
   #:use-module (guix gexp)
   #:use-module (guix i18n)
@@ -1261,7 +1262,7 @@ (define-public emacs-project
 some utility functions, and commands using that infrastructure.")
     (license license:gpl3+)))
 
-(define-public git-modes
+(define-public emacs-git-modes
   (package
     (name "emacs-git-modes")
     (version "1.4.1")
@@ -1285,6 +1286,8 @@ (define-public git-modes
 @file{.git/config}.")
     (license license:gpl3+)))
 
+(define-deprecated/public-alias git-modes emacs-git-modes)
+
 (define-public emacs-with-editor
   (package
     (name "emacs-with-editor")

base-commit: ab7bae8de3d3a27556dfe8e13ca349eabd730fa1
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.