GNU bug report logs - #64748
[PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8

Previous Next

Full log

Message #32 received at 64748 <at> debbugs.gnu.org (full text, mbox):

From: Distopico <distopico <at> riseup.net>
To: Saku Laesvuori <saku <at> laesvuori.fi>
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>, 64748 <at> debbugs.gnu.org,
 hako <at> ultrarare.space
Subject: Re: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to
 a45d8b8
Date: Mon, 24 Jul 2023 12:07:12 -0500

I just tested trying to replace all the libsrtp but not luck from side,
they use for example:
- third_party/libsrtp/crypto/include/crypto_types.h
- third_party/libsrtp/include/srtp.h

not exposed by "libsrtp" package, also they use a custom configuration
for that library
https://github.com/desktop-app/tg_owt/blob/master/src/third_party/libsrtp_config/config.h

Also there is many other references to `libsrtp` .C source code
https://github.com/desktop-app/tg_owt/blob/a45d8b8f0a99bd0e5118dda1dc4a8b7b3ad5dcfd/cmake/libsrtp.cmake#L4

I was checking nix implementation and they just use the submodules
https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/applications/networking/instant-messengers/telegram/telegram-desktop/tg_owt.nix#L19
and not "srtp" package.

So I think the patch that i sent is a good solution, similar to the nix
one, but if someone else want to try another option would be great.


On 2023-07-22, Saku Laesvuori <saku <at> laesvuori.fi> wrote:

> [[PGP Signed Part:Undecided]]
>> If libsrtp in Guix uses something other than openssl by default, then we 
>> could create a package-definition "libsrtp-openssl" which inherits from 
>> "libsrtp" and build-flagged to use openssl. We can then use that for 
>> telegram desktop.
>
> Yes, but we would still need to patch webrtc-for-telegram-desktop as the
> code currently refers to headers in the submodule directory. Now that I
> think of it, it could actually be relatively easy with a regex substitution
> (something like s!^#include "third_party/(srtp/[^"]*)"$!#include <\1>!)
> on every file. That's of course assuming that the code only refers to
> headers in the submodule.
>
> [[End of PGP Signed Part]]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.