From unknown Fri Jun 20 05:29:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64733 <64733@debbugs.gnu.org> To: bug#64733 <64733@debbugs.gnu.org> Subject: Status: [PATCH] ; Handle string-at-point at end of buffer gracefully Reply-To: bug#64733 <64733@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:29:27 +0000 retitle 64733 [PATCH] ; Handle string-at-point at end of buffer gracefully reassign 64733 emacs submitter 64733 Philip Kaludercic severity 64733 normal tag 64733 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 19 14:51:33 2023 Received: (at submit) by debbugs.gnu.org; 19 Jul 2023 18:51:33 +0000 Received: from localhost ([127.0.0.1]:57123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMCGq-0000HZ-Q9 for submit@debbugs.gnu.org; Wed, 19 Jul 2023 14:51:33 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMCGl-0000H9-Jt for submit@debbugs.gnu.org; Wed, 19 Jul 2023 14:51:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMCGe-00007u-Be for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2023 14:51:21 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMCGa-0003G5-K5 for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2023 14:51:18 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B14DA240028 for ; Wed, 19 Jul 2023 20:51:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689792674; bh=0vUEQMAJmf5w6CXt6AVqIVPkapx6gY+IDj/Dpb81vIk=; h=From:To:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Z/9STzjaK81iWC8OpmY+d4xIGKWdckuOLXSBjqZJeWbS57VHUtmFBdjR18s8I+/6t yaHAQ6CHiyPrpCIDkw5aJluIaVyjGlLh6zxLislQPvxAW7r5RF9I9fP1MXnQEZBbmS xktCnE2I8PZAY1hk8jVbwsBOmZaR71kUveFOnLxoskbsi2hJVZphjwN5QOdU7W+fjL YJ438F2f2h/r86zvB3jwYZRpdXD8WhHMij9f8sywoDzrHQyusPjsH+rTtkmJ7WGL9a euK7/kjF7EWoiYZmC9YUKHdVkQ4h9Bl/cgbBwfzZFs6otRKkLUSovyVysYbce7LNFn ilAzVoPQXYjfw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R5lJy2Qrtz9rxK for ; Wed, 19 Jul 2023 20:51:14 +0200 (CEST) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Handle string-at-point at end of buffer gracefully Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Wed, 19 Jul 2023 18:51:05 +0000 Message-ID: <87zg3rn3ae.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch Evaluating (thing-at-point 'string) at the end of a buffer raises an error: --8<---------------cut here---------------start------------->8--- Debugger entered--Lisp error: (wrong-type-argument characterp nil) char-syntax(nil) (eq (char-syntax (char-after)) 34) (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound))) (if (nth 3 ppss) (condition-case nil (progn (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) (error nil)) (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound)))) (let ((ppss (syntax-ppss))) (if (nth 3 ppss) (condition-case nil (progn (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) (error nil)) (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound))))) (save-excursion (let ((ppss (syntax-ppss))) (if (nth 3 ppss) (condition-case nil (progn (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) (error nil)) (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point ...))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound)))))) thing-at-point-bounds-of-string-at-point() funcall(thing-at-point-bounds-of-string-at-point) (cond ((get thing 'bounds-of-thing-at-point) (funcall (get thing 'bounds-of-thing-at-point))) ((and (not (eq thing 'whitespace)) (save-excursion (goto-char (point-min)) (not (re-search-forward "[^\11\n ]" nil t)))) nil) (t (let ((orig (point))) (condition-case nil (progn (save-excursion (funcall (or ... ...)) (funcall (or ... ...)) (let (...) (if ... ... ... ... ... ...)))) (error nil))))) bounds-of-thing-at-point(string) (let ((bounds (bounds-of-thing-at-point thing))) (if bounds (progn (buffer-substring (car bounds) (cdr bounds))))) (cond ((let* ((--cl-var-- thing-at-point-provider-alist) #'nil (pthing nil) (result nil) (--cl-var-- t) (--cl-var-- t) --cl-var--) (while (and (consp --cl-var--) (progn (progn (setq function ...) (setq pthing ...)) (if (eq pthing thing) (progn ...)) (if result (progn ... ...) t))) (setq --cl-var-- (cdr --cl-var--)) (setq --cl-var-- nil)) --cl-var--)) ((get thing 'thing-at-point) (funcall (get thing 'thing-at-point))) (t (let ((bounds (bounds-of-thing-at-point thing))) (if bounds (progn (buffer-substring (car bounds) (cdr bounds))))))) (let ((text (cond ((let* ((--cl-var-- thing-at-point-provider-alist) #'nil (pthing nil) (result nil) (--cl-var-- t) (--cl-var-- t) --cl-var--) (while (and ... ...) (setq --cl-var-- ...) (setq --cl-var-- nil)) --cl-var--)) ((get thing 'thing-at-point) (funcall (get thing 'thing-at-point))) (t (let ((bounds ...)) (if bounds (progn ...))))))) (if (and text no-properties (sequencep text)) (progn (set-text-properties 0 (length text) nil text))) text) thing-at-point(string) eval-expression((thing-at-point 'string) nil nil 127) funcall-interactively(eval-expression (thing-at-point 'string) nil nil 127) command-execute(eval-expression) --8<---------------cut here---------------end--------------->8--- In this case it is easy to avoid it, with the below patch, by ensuring that `char-syntax' is not passed a nil. In GNU Emacs 29.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-07-16 built on quetzal Repository revision: fcde115d5748880ad7ebbf43a10753fb7014a6e1 Repository branch: emacs-29 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --with-pgtk --with-native-compilation --with-imagemagick --with-tree-sitter' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Handle-string-at-point-at-end-of-buffer-gracefully.patch >From fb5da3b4a4785938d82c8ce4ea59215a8905ddd7 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Wed, 19 Jul 2023 20:49:30 +0200 Subject: [PATCH] ; Handle string-at-point at end of buffer gracefully * lisp/thingatpt.el (thing-at-point-bounds-of-string-at-point): Check if 'char-after' returns non-nil before passing it to 'char-syntax'. --- lisp/thingatpt.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 9363a474cb5..46e700c2091 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -250,7 +250,7 @@ thing-at-point-bounds-of-string-at-point (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) ;; At the beginning of the string - (if (eq (char-syntax (char-after)) ?\") + (if (and (char-after) (eq (char-syntax (char-after)) ?\")) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) -- 2.39.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 19 15:06:26 2023 Received: (at 64733) by debbugs.gnu.org; 19 Jul 2023 19:06:27 +0000 Received: from localhost ([127.0.0.1]:57129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMCVG-0000eW-He for submit@debbugs.gnu.org; Wed, 19 Jul 2023 15:06:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMCVE-0000eI-UD for 64733@debbugs.gnu.org; Wed, 19 Jul 2023 15:06:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMCV8-00008x-0a; Wed, 19 Jul 2023 15:06:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aobA+/hNlJBU2bFjA74/YKZH2Wk4aooJXgSPTVUoZeQ=; b=abvTi4EPVoAQ LYaGbNRM450OxYfeaMcLRD/dkXUMNPKaIbigaTZcBr/WkErf8d9GGgro0h4pZBRz17qEZ0yYa1LPw Hadu7xbK8lmyZaNnL1ih52svKhjBIp3FddZYtevOmbhzas2933D4Nd0Ff8JFHbUx6NLkUYfTOAeU8 NiXc65xe1qSSxlw3mwFE6NCy54zTG6mM+NZVHEChDfhDkwaeErQAwAgKIKOBXZnmPTcMiePSVxf7F PMA8McmkXkdsL61gfHzo+UV6kNRQSDGUCzbh8YYDrgPWv+Cl2JIwv8WA5Xfeudcw3Idlo6QQIjQG+ r58vi6qMCyXdNg437bXMWw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMCV7-0006vi-FY; Wed, 19 Jul 2023 15:06:17 -0400 Date: Wed, 19 Jul 2023 22:06:48 +0300 Message-Id: <83cz0n4t6f.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87zg3rn3ae.fsf@posteo.net> (message from Philip Kaludercic on Wed, 19 Jul 2023 18:51:05 +0000) Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully References: <87zg3rn3ae.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Date: Wed, 19 Jul 2023 18:51:05 +0000 > > Evaluating (thing-at-point 'string) at the end of a buffer raises an > error: > > --8<---------------cut here---------------start------------->8--- > Debugger entered--Lisp error: (wrong-type-argument characterp nil) > char-syntax(nil) > (eq (char-syntax (char-after)) 34) > (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound))) > (if (nth 3 ppss) (condition-case nil (progn (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) (error nil)) (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound)))) > (let ((ppss (syntax-ppss))) (if (nth 3 ppss) (condition-case nil (progn (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) (error nil)) (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound))))) > (save-excursion (let ((ppss (syntax-ppss))) (if (nth 3 ppss) (condition-case nil (progn (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) (error nil)) (if (eq (char-syntax (char-after)) 34) (let ((bound (bounds-of-thing-at-point ...))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) bound)))))) > thing-at-point-bounds-of-string-at-point() > funcall(thing-at-point-bounds-of-string-at-point) > (cond ((get thing 'bounds-of-thing-at-point) (funcall (get thing 'bounds-of-thing-at-point))) ((and (not (eq thing 'whitespace)) (save-excursion (goto-char (point-min)) (not (re-search-forward "[^\11\n ]" nil t)))) nil) (t (let ((orig (point))) (condition-case nil (progn (save-excursion (funcall (or ... ...)) (funcall (or ... ...)) (let (...) (if ... ... ... ... ... ...)))) (error nil))))) > bounds-of-thing-at-point(string) > (let ((bounds (bounds-of-thing-at-point thing))) (if bounds (progn (buffer-substring (car bounds) (cdr bounds))))) > (cond ((let* ((--cl-var-- thing-at-point-provider-alist) #'nil (pthing nil) (result nil) (--cl-var-- t) (--cl-var-- t) --cl-var--) (while (and (consp --cl-var--) (progn (progn (setq function ...) (setq pthing ...)) (if (eq pthing thing) (progn ...)) (if result (progn ... ...) t))) (setq --cl-var-- (cdr --cl-var--)) (setq --cl-var-- nil)) --cl-var--)) ((get thing 'thing-at-point) (funcall (get thing 'thing-at-point))) (t (let ((bounds (bounds-of-thing-at-point thing))) (if bounds (progn (buffer-substring (car bounds) (cdr bounds))))))) > (let ((text (cond ((let* ((--cl-var-- thing-at-point-provider-alist) #'nil (pthing nil) (result nil) (--cl-var-- t) (--cl-var-- t) --cl-var--) (while (and ... ...) (setq --cl-var-- ...) (setq --cl-var-- nil)) --cl-var--)) ((get thing 'thing-at-point) (funcall (get thing 'thing-at-point))) (t (let ((bounds ...)) (if bounds (progn ...))))))) (if (and text no-properties (sequencep text)) (progn (set-text-properties 0 (length text) nil text))) text) > thing-at-point(string) > eval-expression((thing-at-point 'string) nil nil 127) > funcall-interactively(eval-expression (thing-at-point 'string) nil nil 127) > command-execute(eval-expression) > --8<---------------cut here---------------end--------------->8--- > > In this case it is easy to avoid it, with the below patch, by ensuring > that `char-syntax' is not passed a nil. Thanks, but could you rewrite so as not to call char-after more than once? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 19 15:17:21 2023 Received: (at 64733) by debbugs.gnu.org; 19 Jul 2023 19:17:21 +0000 Received: from localhost ([127.0.0.1]:57134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMCfn-0000uH-Rd for submit@debbugs.gnu.org; Wed, 19 Jul 2023 15:17:21 -0400 Received: from mout01.posteo.de ([185.67.36.65]:57339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMCfi-0000tz-De for 64733@debbugs.gnu.org; Wed, 19 Jul 2023 15:17:18 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9F947240029 for <64733@debbugs.gnu.org>; Wed, 19 Jul 2023 21:17:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689794228; bh=9saomB3Uw/a8Rka3i//oqVFRMj1BTM7svohLzI4w2p4=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=NrPnMkPJEX3QIqY47eBnVTWd8OW8wIAKAxdbf/G45d7ykmkyQOc0fM+1GAkOqGc/t ovUM9CnKDbOpkvMa46B26wSRRsiIAhuX2+zCURxpAvIfzty0ALQ3AUMYX9n/Yaai52 XHPw39Gow9pPpyuSnRhtoJnkru/Hbe7ht7gRb+YXoO6UbUnbm65UJUiCT4zedIX4ZO 81n7VanMVYy8N/CFDYZEGtVq35+TYnqQP7UOwsYJNoFI5oEsJ1bXcu2KuuOAT/sK/l KMK9B2iFQ1MldFncmz+IErlDxRn64zB/xH0Pwmoh5PAutkI3hiq/RmdcQltbYVwQR9 iTOXFwlh/bInA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R5ltr0tzBz9rxB; Wed, 19 Jul 2023 21:17:07 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully In-Reply-To: <83cz0n4t6f.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Jul 2023 22:06:48 +0300") References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Wed, 19 Jul 2023 19:17:07 +0000 Message-ID: <87r0p3n230.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Thanks, but could you rewrite so as not to call char-after more than > once? Sure, --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Handle-string-at-point-at-end-of-buffer-gracefully.patch >From 6fe6b91970a50c5609e81567c4b486b02e4f1a66 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Wed, 19 Jul 2023 21:14:40 +0200 Subject: [PATCH] ; Handle string-at-point at end of buffer gracefully * lisp/thingatpt.el (thing-at-point-bounds-of-string-at-point): Check if 'char-after' returns non-nil before passing it to 'char-syntax'. (Bug#64733) --- lisp/thingatpt.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 46e700c2091..22a356efa83 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -250,7 +250,8 @@ thing-at-point-bounds-of-string-at-point (goto-char (nth 8 ppss)) (cons (point) (progn (forward-sexp) (point)))) ;; At the beginning of the string - (if (and (char-after) (eq (char-syntax (char-after)) ?\")) + (if (let ((ca (char-after))) + (and ca (eq (char-syntax ca) ?\"))) (let ((bound (bounds-of-thing-at-point 'sexp))) (and bound (<= (car bound) (point)) (< (point) (cdr bound)) -- 2.39.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 00:40:17 2023 Received: (at 64733) by debbugs.gnu.org; 20 Jul 2023 04:40:17 +0000 Received: from localhost ([127.0.0.1]:57465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMLSa-0008OL-RU for submit@debbugs.gnu.org; Thu, 20 Jul 2023 00:40:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMLSU-0008Nu-PV for 64733@debbugs.gnu.org; Thu, 20 Jul 2023 00:40:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMLSP-0000Dq-5n; Thu, 20 Jul 2023 00:40:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=itKvHv00Mg6/pyjNqJo9fZtwUOB+1xC8TagrNQ6AKHQ=; b=SmXOiKQum5Zr nZa0/P7DeiVMHtA/vSmTGBTtEaYh/Wl38vnskEKVfUjb9Qf+zULNO/rOwqwzkwBB+AUmutEYeo6WR SRDyrrTqAs0327UXVUkY4cUqzdPbNmstwJu0d4LFZg6CIsrkQeb6EKnhpC+Xm/bQx1bSGttyM+vsZ QPxxLJZ2pr4LrIbzhCEYAX4+NWR9n5mekf2/X1fCMVdKDI7fpsT8vhAxTAyiWWytCCypYLo7ODh/D D7ED+XvEEhaCQvPkFYN/8IKdVko77fZ6dmMEbNRAWv47Z/pfRKWs/GY++8hTDojc3wVB3K2/uTg2A t5fmZKwMpnd7o8okAEfCfw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMLSO-0004pB-DV; Thu, 20 Jul 2023 00:40:04 -0400 Date: Thu, 20 Jul 2023 07:40:35 +0300 Message-Id: <83bkg742m4.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87r0p3n230.fsf@posteo.net> (message from Philip Kaludercic on Wed, 19 Jul 2023 19:17:07 +0000) Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 64733@debbugs.gnu.org > Date: Wed, 19 Jul 2023 19:17:07 +0000 > > Eli Zaretskii writes: > > > Thanks, but could you rewrite so as not to call char-after more than > > once? > > Sure, Thanks, this LGTM, but please wait for a couple of days to let others comment. This is for master, right? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 02:57:27 2023 Received: (at 64733) by debbugs.gnu.org; 20 Jul 2023 06:57:27 +0000 Received: from localhost ([127.0.0.1]:57569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMNbL-0003zw-4V for submit@debbugs.gnu.org; Thu, 20 Jul 2023 02:57:27 -0400 Received: from mout02.posteo.de ([185.67.36.66]:34771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMNbI-0003zg-5A for 64733@debbugs.gnu.org; Thu, 20 Jul 2023 02:57:26 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 17535240101 for <64733@debbugs.gnu.org>; Thu, 20 Jul 2023 08:57:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689836238; bh=Btle343utV9piBl9fynOyn4MV5PkfAda804HQkstTK8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=E25OmFYaoCX0hQYMK1LP/x71kn0s6DsjqlWei+FmkAWWVWYJG0RQgxgOxeNf3pnbj 4t1NzCaEZOElyKWvgAqCenzyBgOohaA6SHp6K5rE/84hC3cDG9ljkh82VIIQ+PFRLK DQNzmTBvfxL3+xB1lonMDd0sBYGGa1BmcjAL29ajDbt5SLT8JzNpsRdlWWVClNvAuX DeTBOLeniNePC5Wqwk8Y/03M3qVqgNj8iDRX4dB1Ob+X5RYvMGOm3j5UxYu88i2gWN AWQoK7tbhYlOCGEFjG1epw6FLOW81v9tAautkAZoAxzSb2ah0Zj6yG3F58Xvd2Jo/u IBE5/xrFVQ9EQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R63Qj5G5Lz6tw3; Thu, 20 Jul 2023 08:57:17 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully In-Reply-To: <83bkg742m4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 20 Jul 2023 07:40:35 +0300") References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> <83bkg742m4.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Thu, 20 Jul 2023 06:57:17 +0000 Message-ID: <87sf9jyss2.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 64733@debbugs.gnu.org >> Date: Wed, 19 Jul 2023 19:17:07 +0000 >> >> Eli Zaretskii writes: >> >> > Thanks, but could you rewrite so as not to call char-after more than >> > once? >> >> Sure, > > Thanks, this LGTM, but please wait for a couple of days to let others > comment. OK, > This is for master, right? I actually had indented for this and bug#64664 to be applied onto emacs-29. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 03:37:43 2023 Received: (at 64733) by debbugs.gnu.org; 20 Jul 2023 07:37:43 +0000 Received: from localhost ([127.0.0.1]:57595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMOEJ-00056V-FK for submit@debbugs.gnu.org; Thu, 20 Jul 2023 03:37:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMOEG-00056E-3o for 64733@debbugs.gnu.org; Thu, 20 Jul 2023 03:37:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMOEA-0005yc-2e; Thu, 20 Jul 2023 03:37:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6+t8/VUjh1Ey5juQWEoRpgcvllv2EKpchxpEHOiGDiM=; b=eK1lHj4MjsoT f7mUnN6uH8yP4g/JL9D50JSargw7y0lwUy2RJGQNo7CqaFrUk0EArIn+/ntHrvLhTOO8UWmCgKWdb +IZOK7gTtMppjCTxPsehZX62hF6VOiV93/PMX2UOvM5MD68q0AV6DDBWh5apWbSWHKFx1YfRxyFUN bkRUxAZ+nqvybVxKdk+spkuRjkDBIpw9DTTR9JV3a+LpaeIi/gghq+1Ue9IrT0xKf1XmUA9dO9uUj C0c6/R3Gk5Irh1quYICgusY4xfDsdbdr1O9MTbuoSwmpH4/aIg+7N+dfm6360n3hNMlitMUe+bVfY ZcQu3LLWM8R+xSoWepAp0w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMOE8-00071b-TX; Thu, 20 Jul 2023 03:37:33 -0400 Date: Thu, 20 Jul 2023 10:38:06 +0300 Message-Id: <83zg3r2ftt.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87sf9jyss2.fsf@posteo.net> (message from Philip Kaludercic on Thu, 20 Jul 2023 06:57:17 +0000) Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> <83bkg742m4.fsf@gnu.org> <87sf9jyss2.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 64733@debbugs.gnu.org > Date: Thu, 20 Jul 2023 06:57:17 +0000 > > Eli Zaretskii writes: > > > This is for master, right? > > I actually had indented for this and bug#64664 to be applied onto > emacs-29. Why are these important enough to install on the release branch? Did the behavior change in Emacs 29? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 04:42:29 2023 Received: (at 64733) by debbugs.gnu.org; 20 Jul 2023 08:42:29 +0000 Received: from localhost ([127.0.0.1]:57657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMPEy-0006sy-M9 for submit@debbugs.gnu.org; Thu, 20 Jul 2023 04:42:28 -0400 Received: from mout02.posteo.de ([185.67.36.66]:55683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMPEt-0006si-N4 for 64733@debbugs.gnu.org; Thu, 20 Jul 2023 04:42:27 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 95E1B240103 for <64733@debbugs.gnu.org>; Thu, 20 Jul 2023 10:42:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689842537; bh=7qSOFvVml2ZZGeqX9bLSTO0fg80+MlCc7oYbR8mNXN8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=OPXe/Ixome+ALmKg7XvsD+pJnDg0Xm+DUG5pQ9grplWKcPm0S7Pk0TB5ZFlYYYvvO 9DXfkJ19IqV7DMfLuMg61FRZ6CuWHESo8nco0Cz7yq5HozORgsQOQfeP/vhc6nn8i+ ROj6LkoA29qOMj2WtkJdj1Eb3/RH3eOMDaDVB6d4fkTJtxseOvZ9rQTbsT+C3Xm3sV 2NGX+FopE5TjGYxKgT8avz2EuFEyRHJYXLNLYt5Kd6Wn+NcjTvNP68zhJsH+zHlgR0 grgZQHY68OqNngsJWyPMvpgU6RCSO4W58+lfvvsKJhkw8WLP6Qua2FOZPus1j4k9C8 JrmpTCCyD82Kg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R65ls117Sz6twx; Thu, 20 Jul 2023 10:42:16 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully In-Reply-To: <83zg3r2ftt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 20 Jul 2023 10:38:06 +0300") References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> <83bkg742m4.fsf@gnu.org> <87sf9jyss2.fsf@posteo.net> <83zg3r2ftt.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Thu, 20 Jul 2023 08:42:15 +0000 Message-ID: <87o7k7ynx4.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 64733@debbugs.gnu.org >> Date: Thu, 20 Jul 2023 06:57:17 +0000 >> >> Eli Zaretskii writes: >> >> > This is for master, right? >> >> I actually had indented for this and bug#64664 to be applied onto >> emacs-29. > > Why are these important enough to install on the release branch? Did > the behavior change in Emacs 29? I assumed so, but on checking both of these issues exist since Emacs 28. That being said, the fact that (thing-at-point 'string) raises an (avoidable) error seems to be something that shouldn't be the case, but I don't know if that warrants applying this patch at this late stage. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 06:20:44 2023 Received: (at 64733) by debbugs.gnu.org; 20 Jul 2023 10:20:44 +0000 Received: from localhost ([127.0.0.1]:57735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMQm4-00018v-Cr for submit@debbugs.gnu.org; Thu, 20 Jul 2023 06:20:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMQlz-00018c-1m for 64733@debbugs.gnu.org; Thu, 20 Jul 2023 06:20:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMQlt-000550-Km; Thu, 20 Jul 2023 06:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AMcxNVPLMmFJez6hEB2/oStW5TzHy/4T51k0pO3KR/E=; b=K6XghKBYBP9p 4E7vWRp3xEOCIQzliuzBbUEi1AWdlJtaPUF90TTWQkEzQNjYXjbZ/QbOMj8w2JCKDkYpRTTfErIry kMP2nggcFw8PFikjXX2X36FWBisy8FDPphHJRzivi0s3lp6CgDc6/TKfZEthLpUfBKhxQdu2cKd8w JrSujp1aGblA1HSFyWbtH6QgXpt3M5zuS3VTN/MG/UY2ksLppZN16yU1HyYFSlQkeA3On3WkNs4gw hq5/9vhw0RBM4K+O3sVnCNnywnP0IuqR5SztwwwFwp/kAJQ4mwwx8H86IxVtZGApkxfn9OibDnETy 7bp6rU9QdmzCuDdMcxMkLw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMQlt-0001Xf-3h; Thu, 20 Jul 2023 06:20:33 -0400 Date: Thu, 20 Jul 2023 13:21:07 +0300 Message-Id: <83sf9i3muk.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87o7k7ynx4.fsf@posteo.net> (message from Philip Kaludercic on Thu, 20 Jul 2023 08:42:15 +0000) Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> <83bkg742m4.fsf@gnu.org> <87sf9jyss2.fsf@posteo.net> <83zg3r2ftt.fsf@gnu.org> <87o7k7ynx4.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 64733@debbugs.gnu.org > Date: Thu, 20 Jul 2023 08:42:15 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: 64733@debbugs.gnu.org > >> Date: Thu, 20 Jul 2023 06:57:17 +0000 > >> > >> Eli Zaretskii writes: > >> > >> > This is for master, right? > >> > >> I actually had indented for this and bug#64664 to be applied onto > >> emacs-29. > > > > Why are these important enough to install on the release branch? Did > > the behavior change in Emacs 29? > > I assumed so, but on checking both of these issues exist since Emacs 28. > That being said, the fact that (thing-at-point 'string) raises an > (avoidable) error seems to be something that shouldn't be the case, but > I don't know if that warrants applying this patch at this late stage. Let's install these on master, and maybe consider backporting then after Emacs 29.1 is released. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 21 10:53:28 2023 Received: (at 64733) by debbugs.gnu.org; 21 Jul 2023 14:53:28 +0000 Received: from localhost ([127.0.0.1]:34473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMrVX-0004DC-QL for submit@debbugs.gnu.org; Fri, 21 Jul 2023 10:53:28 -0400 Received: from mout02.posteo.de ([185.67.36.66]:34655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMrVT-0004Cv-O0 for 64733@debbugs.gnu.org; Fri, 21 Jul 2023 10:53:26 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AD23B240101 for <64733@debbugs.gnu.org>; Fri, 21 Jul 2023 16:53:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689951197; bh=bQgp/oZ80LTfMsY7AtWG3E4SrzZgqljIasevr+C3uEs=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=qjgPxPDwOHRPgrGMuCvmXwMYcivG8OVUEiEHfeN7ni/h/VRFjZrQzJMtHrnO4b0ix L1OqLvoG0M7DgcOAI6/KpT68EqQEoNrgOA13CJ8/n3hEGHT6epcFUR6ytIXK5PiiBH Phr3KtrbRUI9kwn4qTm7gtem0nm5N1ODwajvfKv9OT5YgTZ+45tY10btDcRV7f/Sww yeU5GO3UOFmf+Wf3L7zvIUJ9U6tbiHG8XB8sfZxse0ssq1qxLzibYTT79wYGPNYeRf U9SfULV/TovW1GNCFSr+u5+fDYUkkLitQWJ1hl+FkOjpZXiK/Co4xHEJTph7HNro8m pUUeygWL5VCFQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R6sxS6wtsz6tyW; Fri, 21 Jul 2023 16:53:16 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully In-Reply-To: <83sf9i3muk.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 20 Jul 2023 13:21:07 +0300") References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> <83bkg742m4.fsf@gnu.org> <87sf9jyss2.fsf@posteo.net> <83zg3r2ftt.fsf@gnu.org> <87o7k7ynx4.fsf@posteo.net> <83sf9i3muk.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 21 Jul 2023 14:53:14 +0000 Message-ID: <871qh12u5h.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 64733@debbugs.gnu.org >> Date: Thu, 20 Jul 2023 08:42:15 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Cc: 64733@debbugs.gnu.org >> >> Date: Thu, 20 Jul 2023 06:57:17 +0000 >> >> >> >> Eli Zaretskii writes: >> >> >> >> > This is for master, right? >> >> >> >> I actually had indented for this and bug#64664 to be applied onto >> >> emacs-29. >> > >> > Why are these important enough to install on the release branch? Did >> > the behavior change in Emacs 29? >> >> I assumed so, but on checking both of these issues exist since Emacs 28. >> That being said, the fact that (thing-at-point 'string) raises an >> (avoidable) error seems to be something that shouldn't be the case, but >> I don't know if that warrants applying this patch at this late stage. > > Let's install these on master, and maybe consider backporting then > after Emacs 29.1 is released. Wasn't the plan to wait for others to comment. Or has enough time passed? > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 21 11:12:45 2023 Received: (at 64733) by debbugs.gnu.org; 21 Jul 2023 15:12:45 +0000 Received: from localhost ([127.0.0.1]:34491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMroD-0004fl-1I for submit@debbugs.gnu.org; Fri, 21 Jul 2023 11:12:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMro8-0004fS-90 for 64733@debbugs.gnu.org; Fri, 21 Jul 2023 11:12:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMro2-0001ls-Nk; Fri, 21 Jul 2023 11:12:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XATw5XPJTAxrr2PR09Ha1tmTYz5EtvWuzg2Pc8HMIUM=; b=F3dTlsLr80II IP50tWNpl8PEkg5S3OiWtXoPZQjwqPAm6gJETE43ZGO6KDKhXw4SZ3vVbvf/va5ViFnMKzOtpG0ip xZrL4SRW/HHarGrVI9A1ffON0GV9dHXZ5IY7URwPfOiV2It+jn1+4Di9t+ehKU+UJnPMC0tO2eBZg RvEYv0AMaRPCTxRzPr/wmSXvmJFuRIe1Ps4zg7rNxvve76N0Gz29zC1RhJU2+fJPa5EaGNj9QNs6F iXMPvIgq/V2IJMpc/MIckjGT3/is5io45uiQwMBDzdrPSYSCtqjyVdskUiqywyFlIBoRgSj+ssA7K 6ZJxt28aIZcIVkTFm9I9Tw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMro0-00084e-JS; Fri, 21 Jul 2023 11:12:34 -0400 Date: Fri, 21 Jul 2023 18:13:09 +0300 Message-Id: <835y6db8my.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <871qh12u5h.fsf@posteo.net> (message from Philip Kaludercic on Fri, 21 Jul 2023 14:53:14 +0000) Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> <83bkg742m4.fsf@gnu.org> <87sf9jyss2.fsf@posteo.net> <83zg3r2ftt.fsf@gnu.org> <87o7k7ynx4.fsf@posteo.net> <83sf9i3muk.fsf@gnu.org> <871qh12u5h.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733 Cc: 64733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 64733@debbugs.gnu.org > Date: Fri, 21 Jul 2023 14:53:14 +0000 > > Eli Zaretskii writes: > > > Let's install these on master, and maybe consider backporting then > > after Emacs 29.1 is released. > > Wasn't the plan to wait for others to comment. Yes. I just wanted to make sure we are on the same page regarding the branch where to install this. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 22 03:21:51 2023 Received: (at 64733-done) by debbugs.gnu.org; 22 Jul 2023 07:21:51 +0000 Received: from localhost ([127.0.0.1]:35365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qN6w3-00009i-9r for submit@debbugs.gnu.org; Sat, 22 Jul 2023 03:21:51 -0400 Received: from mout01.posteo.de ([185.67.36.65]:37215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qN6w1-00009U-5N for 64733-done@debbugs.gnu.org; Sat, 22 Jul 2023 03:21:50 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7C958240028 for <64733-done@debbugs.gnu.org>; Sat, 22 Jul 2023 09:21:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690010503; bh=zWsaCFchIZaZyeezGN7AXWMUCWvM2UCqspJezwdKwK0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=NhiYZsMbSXS5PcCfwMJf2hbNGfH9s5TiptD5JJdObXJkknhaxVuMb9jizpDEPCYy5 DSQ5fG8fByZNbdx+df9tFU7pSCCjUWzykg6Y9ktTIkH7Z8Ybqo/JoUxrIjb11JWOhb eOSUaYbG6rhPorIztorEfRKqwrMIXC5oCfCBvEq7p5gfV71pyoqnDbXw4CGggGcYRh w4aI9CxltVrDaYFvmk2yjBDB6/NmW0JDQo7H9VUdgXqDc2gaHocOCAxMKLlul4VzpX bYyB7NkLv+TSaztQEZCX5yOtfBzTPJH+CC3QA2yRaO249QDxbrxFVFzhcIBYQV9IWv C0MwIxKiW5S5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R7Hsy73c2z6ty0; Sat, 22 Jul 2023 09:21:42 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64733: [PATCH] ; Handle string-at-point at end of buffer gracefully In-Reply-To: <835y6db8my.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jul 2023 18:13:09 +0300") References: <87zg3rn3ae.fsf@posteo.net> <83cz0n4t6f.fsf@gnu.org> <87r0p3n230.fsf@posteo.net> <83bkg742m4.fsf@gnu.org> <87sf9jyss2.fsf@posteo.net> <83zg3r2ftt.fsf@gnu.org> <87o7k7ynx4.fsf@posteo.net> <83sf9i3muk.fsf@gnu.org> <871qh12u5h.fsf@posteo.net> <835y6db8my.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 22 Jul 2023 07:21:42 +0000 Message-ID: <87pm4kif7d.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64733-done Cc: 64733-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 64733@debbugs.gnu.org >> Date: Fri, 21 Jul 2023 14:53:14 +0000 >> >> Eli Zaretskii writes: >> >> > Let's install these on master, and maybe consider backporting then >> > after Emacs 29.1 is released. >> >> Wasn't the plan to wait for others to comment. > > Yes. I just wanted to make sure we are on the same page regarding > the branch where to install this. OK, I've pushed the patches. From unknown Fri Jun 20 05:29:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Aug 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator