GNU bug report logs - #64732
[PATCH 0/2] Add r128gain

Previous Next

Package: guix-patches;

Reported by: Parnikkapore <poomklao <at> yahoo.com>

Date: Wed, 19 Jul 2023 15:33:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "jgart" <jgart <at> dismail.de>
To: "Parnikkapore" <poomklao <at> yahoo.com>, 64732 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>, Lars-Dominik Braun <lars <at> 6xq.net>
Subject: [bug#64732] [PATCH v3 1/2] gnu: Add python-ffmpeg-python.
Date: Sat, 22 Jul 2023 13:54:21 +0000
Lars,

Should these be patched to refer to our ffmpeg?

https://github.com/kkroening/ffmpeg-python/blob/df129c7ba30aaa9ffffb81a48f53aa7253b0b4e6/ffmpeg/_run.py#L302

And a call to subprocess.check_call in the tests:

https://github.com/kkroening/ffmpeg-python/blob/df129c7ba30aaa9ffffb81a48f53aa7253b0b4e6/ffmpeg/tests/test_ffmpeg.py#L29

WDYT if we document our policy for patching executables. Currently, this practice is tribal knowledge that Guixers receive during patch review but we don't have it officially in writing anywhere (e.g. manual, cookbook, etc)

Ludo WDYT

all best,

jgart




This bug report was last modified 1 year and 330 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.