GNU bug report logs - #64711
[PATCH 00/45] Fix builds and skip failing tests for the Hurd.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Janneke Nieuwenhuizen <janneke <at> gnu.org>
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>, 64711 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: [bug#64711] [PATCH 40/43] gnu: pango: Support build for the Hurd.
Date: Tue, 18 Jul 2023 16:04:51 -0400

Hi Janneke,

Thanks for your efforts on this.

Janneke Nieuwenhuizen <janneke <at> gnu.org> writes:

> * gnu/packages/gtk.scm (pango)[native-inputs]: Do not include
> gobject-introspection when building for the Hurd.
> ---
>  gnu/packages/gtk.scm | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index 853696c7f5..15dea2852b 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -401,12 +401,14 @@ (define-public pango
>       (list bash-minimal
>             zlib))
>      (native-inputs
> -     (list `(,glib "bin")               ;glib-mkenums, etc.
> -           gobject-introspection        ;g-ir-compiler, etc.
> -           help2man
> -           perl
> -           pkg-config
> -           python-wrapper))
> +     `((,glib "bin")               ;glib-mkenums, etc.
> +       ,@(if (target-hurd?)
> +             '()
> +             (list gobject-introspection)) ;g-ir-compiler, etc.
> +       ,help2man
> +       ,perl
> +       ,pkg-config
> +       ,python-wrapper))

Stylistically, I think it'd be better to use append (and 'if') here than
quasiquotes (to avoid having to unquote all inputs).

Otherwise it LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.