Subject: [bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd.

From: Janneke Nieuwenhuizen <[email-masked]>
Date: Wed, 19 Jul 2023 07:23:40 +0200

Ludovic Courtès writes:

Hi!

> (+Cc: Josselin.)
>
> Janneke Nieuwenhuizen <[email-masked]> skribis:
>
>> * gnu/packages/guile.scm (guile-3.0)[arguments]: When building on the Hurd,
>> add stage 'disable-popen.test-open-pipe' to avoid running the
>> open-input-pipe test (hangs) and open-output-pipe test (fails.
>
> [...]
>
>> +                   #~((add-after 'unpack 'disable-popen.test-no-duplicate
>> +                        ;; This test hangs on the Hurd.
>> +                        (lambda _
>> +                          (substitute* "test-suite/tests/popen.test"
>> +                            (("\\(pass-if \"no duplicate\".*" all)
>> +                             (string-append all "     (when (string-ci= \"GNU\" (vector-ref (uname) 0)) (throw 'unresolved))
>> +"))))))
>
> Maybe write:
>
>   (string-append all
>                  (object->string '(when …)))

That's a neat trick; changed to

                             (string-append
                              all
                              (object->string
                               '(when (string-ci= "GNU"
                                                  (vector-ref (uname) 0))
                                  (throw 'unresolved)))))))))

> Out of curiosity, is there a bug report for this one?

Sorry, no!  I was kinda hoping this would resolve itself somehow, I
think.  Let's make sure there's a bug report if we still need this
after Josselin's work.

>  IIRC, the test suite of Guile 3.0.9 + ‘guile-hurd-posix-spawn.patch’
> used to pass on glibc 2.35.

Ok, good to know.

> As discussed on IRC, skipping this test is not great in that it’ll
> likely come to haunt us.  However, like you write, we can do that for
> now in the interest of making progress :-) and remove it with a proper
> fix once we have it.
>
> So… LGTM!

Thanks!

Janneke

-- 
Janneke Nieuwenhuizen <[email-masked]>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com