Subject: Re: bug#64711: [PATCH 00/45] Fix builds and skip failing tests for the Hurd.

From: Ludovic Courtès <[email-masked]>
Date: Tue, 18 Jul 2023 22:18:56 +0200

Hi,

(+Cc: Josselin.)

Janneke Nieuwenhuizen <[email-masked]> skribis:

> * gnu/packages/guile.scm (guile-3.0)[arguments]: When building on the Hurd,
> add stage 'disable-popen.test-open-pipe' to avoid running the
> open-input-pipe test (hangs) and open-output-pipe test (fails.

[...]

> +                   #~((add-after 'unpack 'disable-popen.test-no-duplicate
> +                        ;; This test hangs on the Hurd.
> +                        (lambda _
> +                          (substitute* "test-suite/tests/popen.test"
> +                            (("\\(pass-if \"no duplicate\".*" all)
> +                             (string-append all "     (when (string-ci= \"GNU\" (vector-ref (uname) 0)) (throw 'unresolved))
> +"))))))

Maybe write:

  (string-append all
                 (object->string '(when …)))

Out of curiosity, is there a bug report for this one?  IIRC, the test
suite of Guile 3.0.9 + ‘guile-hurd-posix-spawn.patch’ used to pass on
glibc 2.35.

As discussed on IRC, skipping this test is not great in that it’ll
likely come to haunt us.  However, like you write, we can do that for
now in the interest of making progress :-) and remove it with a proper
fix once we have it.

So… LGTM!

Ludo’.