From unknown Thu Sep 18 21:58:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 08:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64697@debbugs.gnu.org Cc: Alan Third X-Debbugs-Original-To: Emacs Bug Report Received: via spool by submit@debbugs.gnu.org id=B.16896690626750 (code B ref -1); Tue, 18 Jul 2023 08:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jul 2023 08:31:02 +0000 Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLg6n-0001ki-L7 for submit@debbugs.gnu.org; Tue, 18 Jul 2023 04:31:01 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLg6h-0001kC-MJ for submit@debbugs.gnu.org; Tue, 18 Jul 2023 04:30:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLg6W-0005c8-Ar for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 04:30:49 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLg6U-00075u-BF for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 04:30:43 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4fdbfda94c4so3012599e87.0 for ; Tue, 18 Jul 2023 01:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689669040; x=1692261040; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=6Q8cvkG8tnLTcwYRVjuqTE0HAUbsnuMQhbcpRrY4CPk=; b=hakuJZJ1gWq/oTdeZMGssLkljF0ze6TxO1b/mKBgelxLHP4n2ndrH5u5n0DZbeGf8Z kbsBKPfZuY3/gOzI6OuXB2fhL/GbfXyeWod/rcFsueONksPT/ioPUCXbJsPm201Y5+fT +notnp9NL2w0kA78I0bYAO0af7Ut6KF/XtKZisnRGJdHJguxCZ9N0KkKbuTtOR5dkX5I tNuhnLtl+pZCzhrQhRc663zs6cwFHfFyoHDpqPB24CPXQtzC9i+2DLsltWS5nYjnbyvV WIHYnbwagsaSLmnHfMPSb1j2LDpud92p9u2PARpKHtK4G10v6IxI7G646taq3wuOIKnF uELQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689669040; x=1692261040; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Q8cvkG8tnLTcwYRVjuqTE0HAUbsnuMQhbcpRrY4CPk=; b=BVSVIQdVQr5d8fv3eXiIg3OsgxKGpn9+u+CbaaP2Ql1g7wmgvl/hf3RVCppJ+sMVR5 ak35SGy/X+zqnpm4HJuDyAw17pttotvBoMtR8bqi8/orHF+Sk6B1MWxXdiVmRRtBxTgy 0qCg0J4ulT+4Bu6jWP8iz84HR9kPfX/+VoQnATZkutP9REWX8GK0Ze8rZgCxIim704Z1 XFPb+Z/mGNTLl1EjUA38Sz2DSgWRDwtA9M9z+Hmy7K86F6Mmx5Nk90hiPNfIXuYtI96H aLsN7bH4/oIhHfLuYQPn5GmGod9s9+EvJb/HzhJ9KDYOdF0DUjQHjuwfo9QavGgGZv3W KhnQ== X-Gm-Message-State: ABy/qLZ1WCDKoxalJLcOl67vYlZ6RuNoUU1sWFcpKWnFgYP82kclXrtl pOROhTVo+/g5ZY37ZR1kaa3f+1gF2tk= X-Google-Smtp-Source: APBJJlH1r30XLTNfmpVZb861lOgOWK8k/TBNbRoExF5lYKrT3k06v33CGQ78303SF/V7VwxGmoyQSA== X-Received: by 2002:a05:6512:3454:b0:4f9:596d:c803 with SMTP id j20-20020a056512345400b004f9596dc803mr11140279lfr.53.1689669040123; Tue, 18 Jul 2023 01:30:40 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id b12-20020ac247ec000000b004fb99da37e3sm324552lfp.220.2023.07.18.01.30.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2023 01:30:39 -0700 (PDT) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Message-Id: Date: Tue, 18 Jul 2023 10:30:38 +0200 X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii In Emacs 29, text pasted from the clipboard on macOS will be truncated = if containing NULs. Reproduction: copy text with NUL in the middle from Emacs 28 (or any = other application), and paste into Emacs 29. This was probably caused by 7e3c2b553f, where construction of a Lisp = string was changed from make_string to build_string. Suggested patch attached. If valid, would it qualify for emacs-29? --Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A Content-Disposition: attachment; filename=lispString.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="lispString.diff" Content-Transfer-Encoding: 7bit diff --git a/src/nsfns.m b/src/nsfns.m index 8804a7df7cf..d7ad0fa8341 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -3829,7 +3829,8 @@ handled fairly well by the NS libraries (displayed with distinct /* Make a Lisp string from an NSString. */ - (Lisp_Object)lispString { - return build_string ([self UTF8String]); + return make_string ([self UTF8String], + [self lengthOfBytesUsingEncoding: NSUTF8StringEncoding]); } @end --Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A-- From unknown Thu Sep 18 21:58:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 09:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 64697@debbugs.gnu.org X-Debbugs-Original-Cc: Emacs Bug Report Received: via spool by submit@debbugs.gnu.org id=B.168967216511891 (code B ref -1); Tue, 18 Jul 2023 09:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jul 2023 09:22:45 +0000 Received: from localhost ([127.0.0.1]:51555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLguq-00035j-OR for submit@debbugs.gnu.org; Tue, 18 Jul 2023 05:22:44 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLgul-00035S-3T for submit@debbugs.gnu.org; Tue, 18 Jul 2023 05:22:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLguf-00064y-S1 for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 05:22:33 -0400 Received: from dane.soverin.net ([185.233.34.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLgua-0000ld-1H for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 05:22:33 -0400 Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4R4tl24VQ8zyhK; Tue, 18 Jul 2023 09:22:22 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4R4tl202xpzFf; Tue, 18 Jul 2023 09:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1689672142; bh=ScGTuwThKvvLxCHVb/YlseV7k4GcRrnEXTa4idC8k9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GjGfcL+AaCygyDEvQx3bmVuvbahYXsjMdwXe2XoU7ijq2plzG0YuEk0/KaIQbLsV7 GO2KgQQ4W32XoPfXzRohlr0fdf5gjHULUwkKRi80AfM6Besxye3eBOMplmu0WSV8ho VxQ42c/EQgQ9Pr91gfTeVnEda3TYrNv5/yEwGjkduooPqMhubZCmgCn0eXwiHCxCu8 Bh0Y3vBpRa9ehJSIbCSCCOKj4XYhnnmhgfnWgCwrdDGh+CQUH5FPRMQ5Dhx3dvPJhd DSNVR4bGVztZZDLPJTh9m+H+bjE9KP7LeETu1I5AzQjSM/jE3b2MWVjdSgnl+v/I6z rck0L6I4k21cQ== Received: from alan by faroe.holly.idiocy.org with local (Exim 4.96) (envelope-from ) id 1qLguT-0007dO-0J; Tue, 18 Jul 2023 10:22:21 +0100 Date: Tue, 18 Jul 2023 10:22:21 +0100 X-Soverin-Authenticated: true From: Alan Third Message-ID: Mail-Followup-To: Alan Third , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Emacs Bug Report References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.4 cv=JPD98eGb c=1 sm=1 tr=0 ts=64b659ce a=8nJEP1OIZ-IA:10 a=ws7JD89P4LkA:10 a=JattOXTR3PdM9CtwCWkA:9 a=wPNLvfGTeEIA:10 X-Cloudmark-Reporter: bAViV5j57NBF8AjXtpaPaAWHTZ0= Received-SPF: pass client-ip=185.233.34.25; envelope-from=alan@idiocy.org; helo=dane.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Jul 18, 2023 at 10:30:38AM +0200, Mattias Engdegård wrote: > In Emacs 29, text pasted from the clipboard on macOS will be truncated if containing NULs. > > Reproduction: copy text with NUL in the middle from Emacs 28 (or any other application), and paste into Emacs 29. > > This was probably caused by 7e3c2b553f, where construction of a Lisp string was changed from make_string to build_string. LGTM I considered this approach but wasn't aware of any situation where make_string would be better. You've found one. :) > Suggested patch attached. If valid, would it qualify for emacs-29? That's up to the maintainers, but I will say that it looks safe, if that's a concern. -- Alan Third From unknown Thu Sep 18 21:58:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 11:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: alan@idiocy.org, 64697@debbugs.gnu.org Received: via spool by 64697-submit@debbugs.gnu.org id=B64697.168967969125323 (code B ref 64697); Tue, 18 Jul 2023 11:29:01 +0000 Received: (at 64697) by debbugs.gnu.org; 18 Jul 2023 11:28:11 +0000 Received: from localhost ([127.0.0.1]:51726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLisF-0006aN-9S for submit@debbugs.gnu.org; Tue, 18 Jul 2023 07:28:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLisC-0006a9-0U for 64697@debbugs.gnu.org; Tue, 18 Jul 2023 07:28:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLis5-0000ZY-ST; Tue, 18 Jul 2023 07:28:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7DTUJ6oZC0zjdmvASmSak/bNuWuXN9rK+N3JBvZuVWM=; b=ZGIOONAinpaEQfbyG5UT TAV7GnRp01ljNAmHGi92KrmajCKSq49al4NDoeTKogJCXx3AGJFVWAGI8xurWpvryKoYb8+ouialj BCadDSIiMhfDo5SKmYR3qhUElqivo+ghdJiuNB6M5VkhIRg8oOabMfeZ1NyD7Z2ULmc+deue+5M1k mcSX04n0LXJm76PbMXqPsd1qthEXLgSF5wiUQciud1wtm5stjhbt4I2VprR9AG80B9REx8tNYJ3yI jpKtEbYaIIITNz+RrczHAaYUHsAWa8/aS46eNtG35fCyYD3OpWhJtpFNOoQVF88JvF7LxHVSF2/3O 8ab9BywuGpSDJw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLis4-0001uD-Hn; Tue, 18 Jul 2023 07:28:01 -0400 Date: Tue, 18 Jul 2023 14:28:28 +0300 Message-Id: <83h6q1792b.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 18 Jul 2023 10:30:38 +0200) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Alan Third > From: Mattias EngdegÃ¥rd > Date: Tue, 18 Jul 2023 10:30:38 +0200 > > In Emacs 29, text pasted from the clipboard on macOS will be truncated if containing NULs. > > Reproduction: copy text with NUL in the middle from Emacs 28 (or any other application), and paste into Emacs 29. > > This was probably caused by 7e3c2b553f, where construction of a Lisp string was changed from make_string to build_string. > > Suggested patch attached. If valid, would it qualify for emacs-29? This is OK for emacs-29, but I wonder: do we want a unibyte string here or a multibyte string? We should try to call either make_unibyte_string or make_multibyte_string accordingly, because make_string has its own ideas about which one to produce. Thanks. From unknown Thu Sep 18 21:58:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 11:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Third Cc: mattias.engdegard@gmail.com, 64697@debbugs.gnu.org Received: via spool by 64697-submit@debbugs.gnu.org id=B64697.16896798953021 (code B ref 64697); Tue, 18 Jul 2023 11:32:01 +0000 Received: (at 64697) by debbugs.gnu.org; 18 Jul 2023 11:31:35 +0000 Received: from localhost ([127.0.0.1]:51740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLivX-0000mf-Dw for submit@debbugs.gnu.org; Tue, 18 Jul 2023 07:31:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLivV-0000mT-Lw for 64697@debbugs.gnu.org; Tue, 18 Jul 2023 07:31:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLivP-0001a8-Th; Tue, 18 Jul 2023 07:31:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+xcu7Or61K0PLBo3pbjwo6g2eQ13y/tlD4BmeVBaJ1U=; b=jSX0hEF26raB 3pgCHZK85EGX76tVMNbJaZuvVgMFjOTCQ84XoLP6hH2kAzOB1W20eVdZSZeQ3TRgaMtkJ6NcZ0rW7 BcJynPODV5HHIgpwzIa5Mne6whVq1Kqd9oxQl9ZHl2LiBl7185M7TkjzWkny8YRiV0GVt85RAkweD sUGJk/QA5+qVcXlGalq5Tb3Eeemm37vuuIthZh7342twdd4ZiPIMNkYkvCTWG3jjghbkXOVDZNS+o tcniSeFJWM3+Din1WVko21XZfJdtm5GgYAcgpWOe6z3jJeMMOuw03smLAEs0r7SHaCn5dcMQAq2um nacGM37QLNWV5LDZWwYsTA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLiv5-0008O5-RH; Tue, 18 Jul 2023 07:31:27 -0400 Date: Tue, 18 Jul 2023 14:31:37 +0300 Message-Id: <83fs5l78x2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Alan Third on Tue, 18 Jul 2023 10:22:21 +0100) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 64697@debbugs.gnu.org > Date: Tue, 18 Jul 2023 10:22:21 +0100 > From: Alan Third > > > This was probably caused by 7e3c2b553f, where construction of a Lisp string was changed from make_string to build_string. > > I considered this approach but wasn't aware of any situation where > make_string would be better. You've found one. :) I would actually recommend the opposite rule of thumb: only use build_string if you have good reasons to do so. Basically, build_string is unreliable with anything but fixed-value pure-ASCII strings. From unknown Thu Sep 18 21:58:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 12:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: alan@idiocy.org, 64697@debbugs.gnu.org Received: via spool by 64697-submit@debbugs.gnu.org id=B64697.16896816606530 (code B ref 64697); Tue, 18 Jul 2023 12:01:02 +0000 Received: (at 64697) by debbugs.gnu.org; 18 Jul 2023 12:01:00 +0000 Received: from localhost ([127.0.0.1]:51828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLjNz-0001hE-OR for submit@debbugs.gnu.org; Tue, 18 Jul 2023 08:01:00 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:56718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLjNw-0001gz-QI for 64697@debbugs.gnu.org; Tue, 18 Jul 2023 08:00:58 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4fb8574a3a1so8995342e87.1 for <64697@debbugs.gnu.org>; Tue, 18 Jul 2023 05:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689681651; x=1692273651; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=RdNnop+MoWOk4eAc8Ug/CGMYUVk/hmyeSPUCLc4HFoQ=; b=iAT3Nbk61u3nARCT84DnoQLa4/qLVFi9zcKIFZqyuy1CP4O930RrlusBEUn1sWIWoG 68COrUH0jSZeYEIvKfXY4ar4CvtCgw28eiZUO30KMeYuZWpE3F/GD4rJXuDKF0kVQbxL 42g3J+UBplN76CjBHxbuRAvh0MolkjEbKOCTuhZUijpw7axEekEm+6dy+d985YDwMkIq dJPh7vwS7E+G2wB0ufXGqg1k24siYyJdJW4wAf7tRcd9MrQgVyxgh3XA7pNQKBTaBb8l O53w0phTiiZnRZPFu6rL3Z+3hJFR/Ys93IXXZHsPfjZcYWw+H6HwRtgtvLQOZNqZVvXK 6VeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689681651; x=1692273651; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RdNnop+MoWOk4eAc8Ug/CGMYUVk/hmyeSPUCLc4HFoQ=; b=RD0LdhJ196QG/HNaLDDnxcU4TuNARW08Ag28ohU0YPrTpt7gCGx7l15CMacU8J7owV GzjEpedwyqg0pFYWrlwWc7kkLRgoYrITOIy2SwmLgcYS02Oc+S6TXh7JlggkI+jfkaZV 0SU36dvd0hiV54EV2+jVCvpGfzQcAZBCSOe4JYxKwhne3ckdgyXSdVXgOfoZO+pQawyz XFOlrXiwINHsRSzThjM7ishezjn8TiTT7BUz4GzN9/+cISuBiJ//nkCT+eDHWjQ3ASEC DabbeUdC1dIg2Jf/FuHf+PWuvxes+azZ18kviFheFyEYClq6BqaQP3eyajOUfxpmiI6D dKDQ== X-Gm-Message-State: ABy/qLbgU/nWJNM+/VM+rJkbwLf2vcdm2DDgmJ1RtewK59UJXGBO7Bnt 3cM2w0vdpnl/jkC3fDI1VS8= X-Google-Smtp-Source: APBJJlFYn7bjDWFMpjKFr7Bmy5/ieroWCDrDgrj3VMTi8YDlmZ8/6K1gbUuFy0oByMpsZfS/zdzw2g== X-Received: by 2002:a19:915d:0:b0:4fb:caed:95c3 with SMTP id y29-20020a19915d000000b004fbcaed95c3mr8749275lfj.53.1689681650429; Tue, 18 Jul 2023 05:00:50 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id k2-20020ac24562000000b004fdc0023a44sm398626lfm.211.2023.07.18.05.00.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2023 05:00:50 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83h6q1792b.fsf@gnu.org> Date: Tue, 18 Jul 2023 14:00:49 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <1CC6B049-A652-4ACE-9E71-590D9A7893D1@gmail.com> References: <83h6q1792b.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 18 juli 2023 kl. 13.28 skrev Eli Zaretskii : > do we want a unibyte string > here or a multibyte string? > We should try to call either > make_unibyte_string or make_multibyte_string accordingly, because > make_string has its own ideas about which one to produce. That is more than I expected to change in emacs-29, but we could do that = too if you like. Since the input is UTF-8 the result, with the patch, will always be = either a multibyte string or a unibyte ASCII string. Always making a = multibyte string would also do and be marginally faster, but not more = correct in any meaningful way. From unknown Thu Sep 18 21:58:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 13:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: alan@idiocy.org, 64697@debbugs.gnu.org Received: via spool by 64697-submit@debbugs.gnu.org id=B64697.168968535213633 (code B ref 64697); Tue, 18 Jul 2023 13:03:01 +0000 Received: (at 64697) by debbugs.gnu.org; 18 Jul 2023 13:02:32 +0000 Received: from localhost ([127.0.0.1]:52070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLkLX-0003Xo-Vl for submit@debbugs.gnu.org; Tue, 18 Jul 2023 09:02:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLkLW-0003XZ-7I for 64697@debbugs.gnu.org; Tue, 18 Jul 2023 09:02:30 -0400 Received: from fencepost.gnu.org ([209.51.188.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLkLP-0002z4-RQ; Tue, 18 Jul 2023 09:02:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ayx9C/qrPHx7nrDCJIkBG7Ua3lOn+Phw8lIM5nUVeQI=; b=lEOjSs4fCMCytD4mAmas 8Q/BNBdvpoKZCbbqRyMNmvjFlDr3sUQ6UIyxDg75bNZmf3T1g136NegTgit66pqTOYpiVzSWBnZjY TH4KwbwEn0GRPnaWlQ/jr+psp6OJppT/sy0pnmMlmZ6DkJunFkxMiER0lWfypkMuSXEJuddz6uqWV NMcSyBT2uNnNWXSOxasVqUeAHRMrJ9gp/b4woJAFY1SA7+0QU7QpWeJ8WCgD6GHPICwnrsbGWihFA SaNOpnep9lEbNEANOIyf3nyBgzApiqZwzE62/gXugivXv+dBi7cu3ukCgHHgHtKhfdumWgHYd/y+u JleGkjkuFbv0nQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLkLN-0001xL-6N; Tue, 18 Jul 2023 09:02:22 -0400 Date: Tue, 18 Jul 2023 16:02:50 +0300 Message-Id: <834jm174p1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <1CC6B049-A652-4ACE-9E71-590D9A7893D1@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 18 Jul 2023 14:00:49 +0200) References: <83h6q1792b.fsf@gnu.org> <1CC6B049-A652-4ACE-9E71-590D9A7893D1@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Tue, 18 Jul 2023 14:00:49 +0200 > Cc: 64697@debbugs.gnu.org, > alan@idiocy.org > > 18 juli 2023 kl. 13.28 skrev Eli Zaretskii : > > > do we want a unibyte string > > here or a multibyte string? > > We should try to call either > > make_unibyte_string or make_multibyte_string accordingly, because > > make_string has its own ideas about which one to produce. > > That is more than I expected to change in emacs-29, but we could do that too if you like. Let's install your change on emacs-29, and do the rest (if needed) on master. > Since the input is UTF-8 the result, with the patch, will always be either a multibyte string or a unibyte ASCII string. Always making a multibyte string would also do and be marginally faster, but not more correct in any meaningful way. OK, but please add a comment there with the above rationale. Thanks. From unknown Thu Sep 18 21:58:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Alan Third , 64697@debbugs.gnu.org Received: via spool by 64697-submit@debbugs.gnu.org id=B64697.168968859620699 (code B ref 64697); Tue, 18 Jul 2023 13:57:01 +0000 Received: (at 64697) by debbugs.gnu.org; 18 Jul 2023 13:56:36 +0000 Received: from localhost ([127.0.0.1]:53650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLlBs-0005Nn-7J for submit@debbugs.gnu.org; Tue, 18 Jul 2023 09:56:36 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:45131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLlBn-0005Ne-Fk for 64697@debbugs.gnu.org; Tue, 18 Jul 2023 09:56:34 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so9489419e87.2 for <64697@debbugs.gnu.org>; Tue, 18 Jul 2023 06:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689688585; x=1692280585; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=E4dK+fRvvkRSVRa6MHx6NGUr0W4Lh/YR/l3o/1xTbdc=; b=GuVimNdtyKYGQvsXeSDe7ZHB96Y67pWp5nl3Qz2KmlePOLnt6PvtwXczTwK9dV4mTg lqAHXkedlupuNai6eBMkVYEo8Ul39hxDePwGskpa5aL3Bm9pbKjY0AT37mWMdGDELd1M ZpBc3sQ2/KnRgKa+1HTiA6xS8yco2BfOHcSdXkrM1j8r+h8/dgM09Yq8IhsOI/wb5D1b D4Yg93wM76dXgFeuVawGyPbauCBniWFCcGuTcipo/h0/P3OSbZUzHFytHs14/PuEbKc6 R+jpB0HL5bvkLj14leeePXtsxuX9HgsX/pqbYHFMMbV754wR7R+liZ6SzRhui1s5pB7g CLCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689688585; x=1692280585; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=E4dK+fRvvkRSVRa6MHx6NGUr0W4Lh/YR/l3o/1xTbdc=; b=XxBEWFiy+aW98/9Id8u3Mc64pbwwrbmO5quUclzlP1XFoUg5f5IF8OWkybTCAUVinX x0SteMJkExyTgFTEgrXUV9LwQKYyJvIMm3mtd3CRbznqVehwEbuNOfYIvKvsTvXakVOb eNT/jgM2/vQAn6B6/ZwwlCG6V/ZwjQPSKuYh37G96ft4YVAhBcru6KsrWVlnpgBR2OGK RcVowX4pYsPZZm0nnl/zZcKO5d/a95N6UNYXD8bNk7OFDjXXhZKbNcF7+sawfrRoFgDC KjqIpaEppJRopPmssn/xp/FMnhIb191txjxT34eaupPFpOJJ34SG9HG/O0UZbkiaOo3E snbg== X-Gm-Message-State: ABy/qLZoTiHI06ujDEKAocvxq6ZEmwNovNYMfZETyo1QhR7RcGj1yVHe VsIrzQRFD5m4UIKN7Hu1t9Q= X-Google-Smtp-Source: APBJJlHFXih2S7zapLOKz75I6ObueyzMKa0imwNu/6nKnIeT0Eg4jvAHEB834o42TiSISXx43OBudw== X-Received: by 2002:a05:6512:3e1b:b0:4f9:ec5e:d624 with SMTP id i27-20020a0565123e1b00b004f9ec5ed624mr2143991lfv.38.1689688585153; Tue, 18 Jul 2023 06:56:25 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id s11-20020a19ad4b000000b004fdb913af80sm445032lfd.209.2023.07.18.06.56.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2023 06:56:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <834jm174p1.fsf@gnu.org> Date: Tue, 18 Jul 2023 15:56:23 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <84236135-993C-489B-9C6F-F1C7834C474B@gmail.com> References: <83h6q1792b.fsf@gnu.org> <1CC6B049-A652-4ACE-9E71-590D9A7893D1@gmail.com> <834jm174p1.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 18 juli 2023 kl. 15.02 skrev Eli Zaretskii : > Let's install your change on emacs-29, and do the rest (if needed) on > master. Now installed on emacs-29. Any improvement will be added on master after = the merge. Alan and Eli, thank you both. From unknown Thu Sep 18 21:58:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Subject: bug#64697: closed (Re: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28)) Message-ID: References: <6F11B1EB-FE0F-4A84-817E-3105E35614F1@gmail.com> X-Gnu-PR-Message: they-closed 64697 X-Gnu-PR-Package: emacs Reply-To: 64697@debbugs.gnu.org Date: Sat, 19 Aug 2023 17:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1692466502-21866-1" This is a multi-part message in MIME format... ------------=_1692466502-21866-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64697@debbugs.gnu.org. --=20 64697: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64697 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1692466502-21866-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64697-done) by debbugs.gnu.org; 19 Aug 2023 17:34:18 +0000 Received: from localhost ([127.0.0.1]:52228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXPq6-0005fl-JH for submit@debbugs.gnu.org; Sat, 19 Aug 2023 13:34:18 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:53388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXPq3-0005fU-Ol for 64697-done@debbugs.gnu.org; Sat, 19 Aug 2023 13:34:17 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2bb9a063f26so30844501fa.2 for <64697-done@debbugs.gnu.org>; Sat, 19 Aug 2023 10:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692466448; x=1693071248; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=MC3vO0IYXUr8LWJCqTFrg1NSxAC2AmMwI5wEjpT+x2w=; b=PIazmxT70nc6E30m4K/U8gs3s1UwlXvo1wyfRAMKKN2xtCjTuaYy0M5cMKLZr976DH HPc1HdA6iMhw5AztcsnxgXDBentdtWCMf0Gris4zvDD/S+bPSuT2lVrx/nixR8QuC86B aAMrjqZ2zxnqqx8TIQuZ1pCsaDBueM8vshYnPEw7TxcrfUm4WLaGpas/4WqmQaXjN1Jb sPAir83HZZeXrxFwn7iMON0v/ha4TYKSyAKc6LUZKnSZEIESvNp9s+gAfO+kft4hXU8p VDReNjUyVjTd98sAhEurGCZH3QnizbwwMFHzDb0bDHWDH1WeOs+34IEJTPNeiuW4hYeW XfMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692466448; x=1693071248; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MC3vO0IYXUr8LWJCqTFrg1NSxAC2AmMwI5wEjpT+x2w=; b=J6xLhcDrDOgrUpDQEC+iucp6TDnaW6gr34lmo1+IpBefXJi6tk+tzKIiupgWKBnbZ5 BpSf/tnOQXjCKKf9jU1IPqXH5L7oK7qndyhtvzQPQUgrwfq/u6SBVDtDSHw63QMot/Ps 3gNU8Ns5VoyGjly7VKlx0F0mld0cX2lX9blYgkBt35uJsMvhYfGK2Dhs2wktvpveEUys zPuiCyfZIJ2e5hnNTPURzByQd7+knxpEytrBTyiQlxPfgVBQrpKOwQaggStf2ahoghpU iyivt94DSibM0UwHWEl2fnH8NX8/pkI4TJVzexx6dRpfGj8cETDFRBJepO7U1LWtECzO me0Q== X-Gm-Message-State: AOJu0YzL+Piidja4xlVdAEvEGNHDV38EAUz5pKQRdxmkMTH5g9wqRr6L Ld6Hv/bkioLqCheV0Twgj7IvbJAIpTk= X-Google-Smtp-Source: AGHT+IGwWYBLl34aoytYHMAHhRj6goIcHI+UBX4vqoUQYmIb1uYmaMB/jLDKbKjV04LvqEPfVIn+cA== X-Received: by 2002:a2e:b0c9:0:b0:2b6:fa8d:ff91 with SMTP id g9-20020a2eb0c9000000b002b6fa8dff91mr1833576ljl.3.1692466448255; Sat, 19 Aug 2023 10:34:08 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id i15-20020a2e808f000000b002ba13fec4a0sm1237049ljg.59.2023.08.19.10.34.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Aug 2023 10:34:07 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <84236135-993C-489B-9C6F-F1C7834C474B@gmail.com> Date: Sat, 19 Aug 2023 19:34:07 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <6F11B1EB-FE0F-4A84-817E-3105E35614F1@gmail.com> References: <83h6q1792b.fsf@gnu.org> <1CC6B049-A652-4ACE-9E71-590D9A7893D1@gmail.com> <834jm174p1.fsf@gnu.org> <84236135-993C-489B-9C6F-F1C7834C474B@gmail.com> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64697-done Cc: 64697-done@debbugs.gnu.org, Alan Third X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Now installed on emacs-29. Any improvement will be added on master = after the merge. A faster conversion was added in 722b1ebc6e. Closing. ------------=_1692466502-21866-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Jul 2023 08:31:02 +0000 Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLg6n-0001ki-L7 for submit@debbugs.gnu.org; Tue, 18 Jul 2023 04:31:01 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLg6h-0001kC-MJ for submit@debbugs.gnu.org; Tue, 18 Jul 2023 04:30:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLg6W-0005c8-Ar for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 04:30:49 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLg6U-00075u-BF for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 04:30:43 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4fdbfda94c4so3012599e87.0 for ; Tue, 18 Jul 2023 01:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689669040; x=1692261040; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=6Q8cvkG8tnLTcwYRVjuqTE0HAUbsnuMQhbcpRrY4CPk=; b=hakuJZJ1gWq/oTdeZMGssLkljF0ze6TxO1b/mKBgelxLHP4n2ndrH5u5n0DZbeGf8Z kbsBKPfZuY3/gOzI6OuXB2fhL/GbfXyeWod/rcFsueONksPT/ioPUCXbJsPm201Y5+fT +notnp9NL2w0kA78I0bYAO0af7Ut6KF/XtKZisnRGJdHJguxCZ9N0KkKbuTtOR5dkX5I tNuhnLtl+pZCzhrQhRc663zs6cwFHfFyoHDpqPB24CPXQtzC9i+2DLsltWS5nYjnbyvV WIHYnbwagsaSLmnHfMPSb1j2LDpud92p9u2PARpKHtK4G10v6IxI7G646taq3wuOIKnF uELQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689669040; x=1692261040; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Q8cvkG8tnLTcwYRVjuqTE0HAUbsnuMQhbcpRrY4CPk=; b=BVSVIQdVQr5d8fv3eXiIg3OsgxKGpn9+u+CbaaP2Ql1g7wmgvl/hf3RVCppJ+sMVR5 ak35SGy/X+zqnpm4HJuDyAw17pttotvBoMtR8bqi8/orHF+Sk6B1MWxXdiVmRRtBxTgy 0qCg0J4ulT+4Bu6jWP8iz84HR9kPfX/+VoQnATZkutP9REWX8GK0Ze8rZgCxIim704Z1 XFPb+Z/mGNTLl1EjUA38Sz2DSgWRDwtA9M9z+Hmy7K86F6Mmx5Nk90hiPNfIXuYtI96H aLsN7bH4/oIhHfLuYQPn5GmGod9s9+EvJb/HzhJ9KDYOdF0DUjQHjuwfo9QavGgGZv3W KhnQ== X-Gm-Message-State: ABy/qLZ1WCDKoxalJLcOl67vYlZ6RuNoUU1sWFcpKWnFgYP82kclXrtl pOROhTVo+/g5ZY37ZR1kaa3f+1gF2tk= X-Google-Smtp-Source: APBJJlH1r30XLTNfmpVZb861lOgOWK8k/TBNbRoExF5lYKrT3k06v33CGQ78303SF/V7VwxGmoyQSA== X-Received: by 2002:a05:6512:3454:b0:4f9:596d:c803 with SMTP id j20-20020a056512345400b004f9596dc803mr11140279lfr.53.1689669040123; Tue, 18 Jul 2023 01:30:40 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id b12-20020ac247ec000000b004fb99da37e3sm324552lfp.220.2023.07.18.01.30.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2023 01:30:39 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Message-Id: Date: Tue, 18 Jul 2023 10:30:38 +0200 To: Emacs Bug Report X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit Cc: Alan Third X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii In Emacs 29, text pasted from the clipboard on macOS will be truncated = if containing NULs. Reproduction: copy text with NUL in the middle from Emacs 28 (or any = other application), and paste into Emacs 29. This was probably caused by 7e3c2b553f, where construction of a Lisp = string was changed from make_string to build_string. Suggested patch attached. If valid, would it qualify for emacs-29? --Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A Content-Disposition: attachment; filename=lispString.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="lispString.diff" Content-Transfer-Encoding: 7bit diff --git a/src/nsfns.m b/src/nsfns.m index 8804a7df7cf..d7ad0fa8341 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -3829,7 +3829,8 @@ handled fairly well by the NS libraries (displayed with distinct /* Make a Lisp string from an NSString. */ - (Lisp_Object)lispString { - return build_string ([self UTF8String]); + return make_string ([self UTF8String], + [self lengthOfBytesUsingEncoding: NSUTF8StringEncoding]); } @end --Apple-Mail=_4CFEEC7E-1604-4A46-BD7D-70CF29CCE88A-- ------------=_1692466502-21866-1--