GNU bug report logs - #64682
[PATCH] eglot.el: Avoid premature bailout in eglot-imenu

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> posteo.net>

Date: Mon, 17 Jul 2023 12:17:02 UTC

Severity: normal

Tags: patch

Done: João Távora <joaotavora <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brian Leung <leungbk <at> posteo.net>
Subject: bug#64682: closed (Re: bug#64682: [PATCH] eglot.el: Avoid
 premature bailout in eglot-imenu)
Date: Mon, 17 Jul 2023 13:39:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#64682: [PATCH] eglot.el: Avoid premature bailout in eglot-imenu

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 64682 <at> debbugs.gnu.org.

-- 
64682: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64682
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: João Távora <joaotavora <at> gmail.com>
To: Brian Leung <leungbk <at> posteo.net>, 64682-done <at> debbugs.gnu.org
Subject: Re: bug#64682: [PATCH] eglot.el: Avoid premature bailout in
 eglot-imenu
Date: Mon, 17 Jul 2023 14:38:37 +0100
Thanks.

Pushed to master as 7446a8c34e2b793df52dbf56b630e20f8c10568c,
and closing.

João

On Mon, Jul 17, 2023 at 1:17 PM Brian Leung <leungbk <at> posteo.net> wrote:
>
> Tags: patch
>
> On current master branch, running M-: (eglot-imenu) in buffers
> using LSP servers supporting the textDocument/documentSymbol
> request always results in an early exit since the server
> capability is NOT named "textDocument/documentSymbol", but rather
> "documentSymbolProvider".
>
> This patch corrects that, so that now (eglot-imenu) works as
> expected.
>
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo
> version 1.16.0, Xaw3d scroll bars)
> Repository revision: c5fa58cbc4a33a0a65494b9ab2e35d4f30ab849b
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version
> 11.0.12101008
> System Description: NixOS 23.11 (Tapir)
>
> Configured using:
>  'configure
>  --prefix=/nix/store/rl8pgvclyashprbz6xr84x6l0n9q37l2-emacs-git-20230715.0
>  --disable-build-details --with-modules --with-x-toolkit=lucid
>  --with-xft --with-cairo --with-native-compilation
>  --with-tree-sitter'



-- 
João Távora

[Message part 3 (message/rfc822, inline)]
From: Brian Leung <leungbk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: [PATCH] eglot.el: Avoid premature bailout in eglot-imenu
Date: Mon, 17 Jul 2023 12:09:26 +0000
[Message part 4 (text/plain, inline)]
Tags: patch

On current master branch, running M-: (eglot-imenu) in buffers 
using LSP servers supporting the textDocument/documentSymbol 
request always results in an early exit since the server 
capability is NOT named "textDocument/documentSymbol", but rather 
"documentSymbolProvider".

This patch corrects that, so that now (eglot-imenu) works as 
expected.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, 
cairo
version 1.16.0, Xaw3d scroll bars)
Repository revision: c5fa58cbc4a33a0a65494b9ab2e35d4f30ab849b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 
11.0.12101008
System Description: NixOS 23.11 (Tapir)

Configured using:
'configure
--prefix=/nix/store/rl8pgvclyashprbz6xr84x6l0n9q37l2-emacs-git-20230715.0
--disable-build-details --with-modules --with-x-toolkit=lucid
--with-xft --with-cairo --with-native-compilation 
--with-tree-sitter'
[0001-eglot.el-Avoid-premature-bailout-in-eglot-imenu.patch (text/patch, attachment)]

This bug report was last modified 1 year and 313 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.