GNU bug report logs - #64667
[PATCH 0/1] Add grub-coreboot

Previous Next

Full log

Message #11 received at 64667 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>, 64667 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot
Date: Tue, 18 Jul 2023 11:00:45 -0700

[Message part 1 (text/plain, inline)]

On 2023-07-16, Denis 'GNUtoo' Carikli wrote:
> * gnu/packages/bootloaders.scm (grub-coreboot): New variable.
...
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index 01fd1093ff..c5090d1ead 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
...
> +(define-public grub-coreboot
> +  (package
> +    (inherit grub)
> +    (name "grub-coreboot")
> +    (synopsis "GRand Unified Boot loader (Coreboot payload version)")
> +    (arguments
> +     `(,@(substitute-keyword-arguments (package-arguments grub)
> +           ;; Several tests fail
> +           ((#:tests? _ #f)
> +            #f)

Could you explain in more detail about the failing tests in the comment?
Which tests?  Are they testing things that are not valid in a
grub-coreboot context?  Is it not reasonable or not plausible to
selectively disable only the failing tests?


QA seems to build it fine, and nothing else obviously leaps out at me.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.