Subject: Re: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot

From: Vagrant Cascadian <[email-masked]>
Date: Tue, 18 Jul 2023 11:00:45 -0700

On 2023-07-16, Denis 'GNUtoo' Carikli wrote:
> * gnu/packages/bootloaders.scm (grub-coreboot): New variable.
...
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index 01fd1093ff..c5090d1ead 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
...
> +(define-public grub-coreboot
> +  (package
> +    (inherit grub)
> +    (name "grub-coreboot")
> +    (synopsis "GRand Unified Boot loader (Coreboot payload version)")
> +    (arguments
> +     `(,@(substitute-keyword-arguments (package-arguments grub)
> +           ;; Several tests fail
> +           ((#:tests? _ #f)
> +            #f)

Could you explain in more detail about the failing tests in the comment?
Which tests?  Are they testing things that are not valid in a
grub-coreboot context?  Is it not reasonable or not plausible to
selectively disable only the failing tests?

QA seems to build it fine, and nothing else obviously leaps out at me.

live well,
  vagrant