From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 0/1] Add grub-coreboot Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: , guix-patches@gnu.org Resent-Date: Sun, 16 Jul 2023 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64667@debbugs.gnu.org Cc: Denis 'GNUtoo' Carikli , ( , Christopher Baines , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: ( , Christopher Baines , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart Received: via spool by submit@debbugs.gnu.org id=B.16895262044790 (code B ref -1); Sun, 16 Jul 2023 16:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jul 2023 16:50:04 +0000 Received: from localhost ([127.0.0.1]:48450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL4wd-0001F9-TX for submit@debbugs.gnu.org; Sun, 16 Jul 2023 12:50:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL4wa-0001EM-09 for submit@debbugs.gnu.org; Sun, 16 Jul 2023 12:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL4wU-0005A3-HO for guix-patches@gnu.org; Sun, 16 Jul 2023 12:49:54 -0400 Received: from cyberdimension.org ([80.67.179.20] helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qL4wS-00063p-HY for guix-patches@gnu.org; Sun, 16 Jul 2023 12:49:54 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 4575bff4; Sun, 16 Jul 2023 16:49:48 +0000 (UTC) Received: from localhost.localdomain (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id a608a8c7; Sun, 16 Jul 2023 16:49:48 +0000 (UTC) From: Denis 'GNUtoo' Carikli Date: Sun, 16 Jul 2023 18:49:32 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=80.67.179.20; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi, In the following mail there will be a patch that adds grub-coreboot. The './pre-inst-env guix lint grub-coreboot' command shows some warnings: [...]/bootloaders.scm:301:2: grub-coreboot@2.06: label 'qemu' does not match package name 'qemu-minimal' [...]/bootloaders.scm:301:2: grub-coreboot@2.06: label 'gettext' does not match package name 'gettext-minimal' [...]/bootloaders.scm:301:2: grub-coreboot@2.06: file names of patches should start with the package name [...]/bootloaders.scm:301:2: grub-coreboot@2.06: probably vulnerable to CVE-2022-2601, CVE-2022-3775, CVE-2021-3981 [...]/bootloaders.scm:301:2: grub-coreboot@2.06: updater 'gnu' failed to find upstream releases but since this package is based on grub-coreboot, I guess that things should be fixed there instead. A standalone image was built with the following commands: modules="ahci at_keyboard cbfs ehci ext2 fat ohci part_gpt part_msdos \ pata uhci usb_keyboard usbms usbserial_usbdebug" install_modules="acpi ahci all_video archelp at_keyboard ata blocklist \ boot btrfs cat cbfs cbls cbls cbmemc cbmemc cbtime cbtime chain chain \ cmosdump cmostest cmp configfile configfile cpio cpuid crc64 crypto \ cryptodisk cs5536 date datehook datetime disk diskfilter div dm_nv echo \ echo ehci elf eval exfat ext2 extcmd fat file fshelp gcry_crc gcry_rfc2268 \ gcry_rijndael gcry_rsa gcry_seed gcry_serpent gcry_sha1 gcry_sha256 \ gcry_sha512 gcry_twofish gettext gfxmenu gfxterm_background gfxterm_menu \ gptsync gzio gzio halt halt hashsum hdparm help help hexdump hexdump iorw \ iorw iso9660 jpeg keylayouts keystatus ldm linux linux linux16 linux16 \ loadenv loopback ls ls lsacpi lsacpi lsmmap lsmmap lspci lspci luks lvm \ lzopio mda_text memdisk memrw memrw minicmd minicmd mmap morse mpi \ msdospart multiboot multiboot multiboot2 nativedisk newc nilfs2 normal \ normal odc offsetio ohci part_gpt part_msdos parttool password \ password_pbkdf2 password_pbkdf2 pata pbkdf2 pci pcidump pcidump pgp play \ priority_queue probe procfs progress random read reboot reboot regexp \ regexp relocator romfs scsi search search search_fs_file search_fs_uuid \ search_label serial serial setjmp setpci setpci sfs sleep spkmodem squash4 \ syslinuxcfg syslinuxcfg tar terminal terminfo test test testload testspeed \ time tr trig true udf uhci usb usb_keyboard usbms usbserial_common \ usbserial_ftdi usbserial_pl2303 usbserial_usbdebug video_colors videoinfo \ xnu xzio" "/gnu/store/[...]/bin/grub-mkstandalone" \ -O i386-coreboot \ -o grub_payload.elf \ --fonts= \ --themes= \ --locales= \ --modules="${modules}" \ --install-modules="${install_modules}" \ /boot/grub/grub.cfg=coreboot.cfg The coreboot.cfg file was taken from grub source code (GPLv3+) and consist of the following: if test -f (cbfsdisk)/etc/grub.cfg; then source (cbfsdisk)/etc/grub.cfg fi The resulting image was tested on a Thinkpad X200 running a custom 100% free software version of Coreboot with as a GRUB payload) with the following commands: chainloader /path/to/grub_payload.elf boot It then booted fine. As for the partitions I used, I have LUKS encrypted hard drive with LVM2 and a mix of BTRFS and ext4 partitions. Denis 'GNUtoo' Carikli (1): gnu: Add grub-coreboot gnu/packages/bootloaders.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) base-commit: 796c823a0d1d0aec9f4af908eca462e58e5675b5 -- 2.41.0 From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: efraim@flashner.co.il, ludo@gnu.org, vagrant@debian.org, guix-patches@gnu.org Resent-Date: Sun, 16 Jul 2023 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64667@debbugs.gnu.org Cc: Denis 'GNUtoo' Carikli , Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Vagrant Cascadian X-Debbugs-Original-Xcc: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Vagrant Cascadian Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.16895265985460 (code B ref 64667); Sun, 16 Jul 2023 16:57:02 +0000 Received: (at 64667) by debbugs.gnu.org; 16 Jul 2023 16:56:38 +0000 Received: from localhost ([127.0.0.1]:48464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL530-0001Pz-0v for submit@debbugs.gnu.org; Sun, 16 Jul 2023 12:56:38 -0400 Received: from cyberdimension.org ([2001:910:1314:ffff::1]:60052 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL52x-0001Pm-6M for 64667@debbugs.gnu.org; Sun, 16 Jul 2023 12:56:36 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id aecdb929; Sun, 16 Jul 2023 16:56:34 +0000 (UTC) Received: from localhost.localdomain (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 651e6234; Sun, 16 Jul 2023 16:56:34 +0000 (UTC) From: Denis 'GNUtoo' Carikli Date: Sun, 16 Jul 2023 18:56:25 +0200 Message-ID: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/bootloaders.scm (grub-coreboot): New variable. Signed-off-by: Denis 'GNUtoo' Carikli --- gnu/packages/bootloaders.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 01fd1093ff..c5090d1ead 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -15,7 +15,7 @@ ;;; Copyright © 2020, 2021 Pierre Langlois ;;; Copyright © 2021 Vincent Legoll ;;; Copyright © 2021 Brice Waegeneire -;;; Copyright © 2022 Denis 'GNUtoo' Carikli +;;; Copyright © 2022, 2023 Denis 'GNUtoo' Carikli ;;; Copyright © 2021 Stefan ;;; Copyright © 2022, 2023 Maxim Cournoyer ;;; @@ -297,6 +297,21 @@ (define-public grub-minimal #t)))))))) +(define-public grub-coreboot + (package + (inherit grub) + (name "grub-coreboot") + (synopsis "GRand Unified Boot loader (Coreboot payload version)") + (arguments + `(,@(substitute-keyword-arguments (package-arguments grub) + ;; Several tests fail + ((#:tests? _ #f) + #f) + ((#:configure-flags flags + ''()) + `(cons* "--with-platform=coreboot" + ,flags))))))) + (define-public grub-efi (package (inherit grub) -- 2.41.0 From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Denis 'GNUtoo' Carikli , 64667@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Efraim Flashner Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.168970327624276 (code B ref 64667); Tue, 18 Jul 2023 18:02:02 +0000 Received: (at 64667) by debbugs.gnu.org; 18 Jul 2023 18:01:16 +0000 Received: from localhost ([127.0.0.1]:54259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLp0d-0006JU-PO for submit@debbugs.gnu.org; Tue, 18 Jul 2023 14:01:16 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:36950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLp0b-0006JF-W6 for 64667@debbugs.gnu.org; Tue, 18 Jul 2023 14:01:15 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 64D141ABAC; Tue, 18 Jul 2023 11:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1689703264; bh=fjOCNeoHJdbb6Ll96MI8evwS9qr8YvYl8bsBXZMJJTk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GUNcdrcwaXfpXLxyZ/Sar0Whe5L8713okwZLBVYlbUwIvqi7VIoGEQj2V0LDft7XP 6Kef5R3OqK4p4EQXv+fGADnBfxHBcKXENoXzcTt3O1xCsq0qaAXNSm8xEBjtc+6JxN kqBvUN0dVV/c3jktjLUm40y1IbLwTyaPBj9/WSDzRqp83N5ahxXGZt9oQzw4+clvRw WvMsdvMZTC8jdYVexzOIY2dE26RzfilkpvJfielMrJW1uYHyD2wrvznH3hyKGTgzQX H3Li5uX8MV7sMtIGn7YlOWTzaiIO1HDBQCxmi6tSj1bpNUeX2ota8H+xjcFaqWIBxk lkJyzje1vVaoQ== From: Vagrant Cascadian In-Reply-To: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> Date: Tue, 18 Jul 2023 11:00:45 -0700 Message-ID: <87v8eh14mq.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 2023-07-16, Denis 'GNUtoo' Carikli wrote: > * gnu/packages/bootloaders.scm (grub-coreboot): New variable. ... > diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm > index 01fd1093ff..c5090d1ead 100644 > --- a/gnu/packages/bootloaders.scm > +++ b/gnu/packages/bootloaders.scm ... > +(define-public grub-coreboot > + (package > + (inherit grub) > + (name "grub-coreboot") > + (synopsis "GRand Unified Boot loader (Coreboot payload version)") > + (arguments > + `(,@(substitute-keyword-arguments (package-arguments grub) > + ;; Several tests fail > + ((#:tests? _ #f) > + #f) Could you explain in more detail about the failing tests in the comment? Which tests? Are they testing things that are not valid in a grub-coreboot context? Is it not reasonable or not plausible to selectively disable only the failing tests? QA seems to build it fine, and nothing else obviously leaps out at me. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZLbTTQAKCRDcUY/If5cW qicGAPsETo9jC4k6Lsk+ZBZFsRsrvmeT+nO9f0QRkCYvlYKm0wEAgum+XvcVnG7P yctPYXbZP8c8NBEywz5kC+47rDCcQAU= =J8/d -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 27 Jul 2023 03:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Efraim Flashner , 64667@debbugs.gnu.org Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.16904293708631 (code B ref 64667); Thu, 27 Jul 2023 03:43:02 +0000 Received: (at 64667) by debbugs.gnu.org; 27 Jul 2023 03:42:50 +0000 Received: from localhost ([127.0.0.1]:40445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOrtp-0002F8-Mq for submit@debbugs.gnu.org; Wed, 26 Jul 2023 23:42:50 -0400 Received: from cyberdimension.org ([2001:910:1314:ffff::1]:57698 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOrtl-0002Ey-RH for 64667@debbugs.gnu.org; Wed, 26 Jul 2023 23:42:47 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 88fe8258; Thu, 27 Jul 2023 03:42:43 +0000 (UTC) Received: from primary_laptop (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 0d0a4cad; Thu, 27 Jul 2023 03:42:42 +0000 (UTC) Date: Thu, 27 Jul 2023 05:42:24 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20230727054224.138476d6@primary_laptop> In-Reply-To: <87v8eh14mq.fsf@wireframe> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> <87v8eh14mq.fsf@wireframe> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/JO2pCAFxNRKepPdR5loViN7"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/JO2pCAFxNRKepPdR5loViN7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, On Tue, 18 Jul 2023 11:00:45 -0700 Vagrant Cascadian wrote: > > + ;; Several tests fail > > + ((#:tests? _ #f) > > + #f) >=20 > Could you explain in more detail about the failing tests in the > comment? Which tests? Are they testing things that are not valid in a > grub-coreboot context? Is it not reasonable or not plausible to > selectively disable only the failing tests? I've looked into it, and the reason the test fails is similar than with UEFI: many tests require to build a Coreboot image (and also to build cbfstool which is available in Coreboot)[1]. And building Coreboot for qemu would require to deblob it first, and simply using Libreboot for that doesn't work anymore because recent versions don't deblob Coreboot and even ship nonfree software in the releases. So at some point we will likely have some clean solution for that, but it could take some time. In the meantime if the comment is changed for the following, would it work for you? > ;; TODO: Tests need a (deblobbed) Coreboot firmware for qemu. Or do I really need to disable the failing tests[2]? References: ----------- [1]To be more precise in tests/util/grub-shell.in we have: > if [ x$boot =3D xcoreboot ]; then > imgfile=3D`mktemp "${TMPDIR:-/tmp}/tmp.XXXXXXXXXX"` || exit 1 > cp "${GRUB_COREBOOT_ROM}" "${imgfile}" > "${GRUB_CBFSTOOL}" "${imgfile}" add-payload -f \ > "${rom_directory}/coreboot.elf" -n fallback/payload > [...] > fi And GRUB_COREBOOT_ROM and GRUB_CBFSTOOL are not provided anywhere so somehow the user has to provide them. It's also pretty clear (for people used to Coreboot) that GRUB_COREBOOT_ROM is a Coreboot image because the cbfstool command above is for coreboot images. [2]Here's the output of the build failure with tests enabled: make check-TESTS make[3]: Entering directory '/tmp/guix-build-grub-coreboot-2.06.drv-0/gr= ub-2.06' make[4]: Entering directory '/tmp/guix-build-grub-coreboot-2.06.drv-0/gr= ub-2.06' SKIP: ext234_test SKIP: squashfs_test SKIP: iso9660_test SKIP: hfsplus_test SKIP: ntfs_test SKIP: reiserfs_test SKIP: fat_test SKIP: minixfs_test SKIP: xfs_test SKIP: f2fs_test SKIP: nilfs2_test SKIP: romfs_test SKIP: exfat_test SKIP: tar_test SKIP: udf_test SKIP: hfs_test SKIP: jfs_test SKIP: btrfs_test SKIP: zfs_test SKIP: cpio_test PASS: example_scripted_test FAIL: pata_test FAIL: ahci_test PASS: gettext_strings_test FAIL: uhci_test FAIL: ehci_test FAIL: example_grub_script_test FAIL: ohci_test FAIL: grub_script_eval FAIL: grub_script_echo1 FAIL: grub_script_test FAIL: grub_script_echo_keywords FAIL: grub_script_vars1 FAIL: grub_script_leading_whitespace FAIL: grub_script_while1 FAIL: grub_script_for1 PASS: grub_script_blanklines PASS: grub_script_final_semicolon PASS: grub_script_dollar FAIL: grub_script_comments FAIL: grub_script_if FAIL: grub_script_break FAIL: grub_script_functions FAIL: grub_script_shift FAIL: grub_script_continue FAIL: grub_script_blockarg FAIL: grub_script_setparams FAIL: grub_cmd_regexp FAIL: grub_script_return FAIL: grub_cmd_date FAIL: grub_script_expansion FAIL: grub_cmd_sleep PASS: grub_script_no_commands SKIP: partmap_test PASS: hddboot_test PASS: fddboot_test PASS: cdboot_test PASS: netboot_test PASS: pseries_test PASS: core_compress_test SKIP: xzcompress_test SKIP: gzcompress_test SKIP: lzocompress_test FAIL: grub_cmd_echo FAIL: help_test FAIL: grub_script_not FAIL: grub_script_gettext FAIL: grub_script_escape_comma FAIL: grub_script_strcmp FAIL: test_sha512sum FAIL: test_unset FAIL: grub_cmd_tr FAIL: file_filter_test PASS: grub_cmd_test PASS: syslinux_test PASS: example_unit_test PASS: printf_test PASS: date_test PASS: cmp_test PASS: priority_queue_unit_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D Testsuite summary for GRUB 2.06 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D # TOTAL: 80 # PASS: 19 # SKIP: 24 # XFAIL: 0 # FAIL: 37 # XPASS: 0 # ERROR: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D See ./test-suite.log Please report to bug-grub@gnu.org =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D make[4]: *** [Makefile:11629: test-suite.log] Error 1 make[4]: Leaving directory '/tmp/guix-build-grub-coreboot-2.06.drv-0/gru= b-2.06' make[3]: *** [Makefile:11737: check-TESTS] Error 2 make[3]: Leaving directory '/tmp/guix-build-grub-coreboot-2.06.drv-0/gru= b-2.06' make[2]: *** [Makefile:12533: check-am] Error 2 make[2]: Leaving directory '/tmp/guix-build-grub-coreboot-2.06.drv-0/gru= b-2.06' make[1]: *** [Makefile:11514: check-recursive] Error 1 make[1]: Leaving directory '/tmp/guix-build-grub-coreboot-2.06.drv-0/gru= b-2.06' make: *** [Makefile:12535: check] Error 2 =20 Test suite failed, dumping logs. =20 --- ./test-suite.log ---------------------------------------------------= ----- =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D GRUB 2.06: ./test-suite.log =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D =20 # TOTAL: 80 # PASS: 19 # SKIP: 24 # XFAIL: 0 # FAIL: 37 # XPASS: 0 # ERROR: 0 =20 .. contents:: :depth: 2 =20 SKIP: ext234_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP ext234_test (exit status: 77) =20 SKIP: squashfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 mksquashfs not installed; cannot test squashfs. SKIP squashfs_test (exit status: 77) =20 SKIP: iso9660_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 xorriso not installed; cannot test iso9660. SKIP iso9660_test (exit status: 77) =20 SKIP: hfsplus_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP hfsplus_test (exit status: 77) =20 SKIP: ntfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP ntfs_test (exit status: 77) =20 SKIP: reiserfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP reiserfs_test (exit status: 77) =20 SKIP: fat_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP fat_test (exit status: 77) =20 SKIP: minixfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP minixfs_test (exit status: 77) =20 SKIP: xfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP xfs_test (exit status: 77) =20 SKIP: f2fs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP f2fs_test (exit status: 77) =20 SKIP: nilfs2_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP nilfs2_test (exit status: 77) =20 SKIP: romfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 genromfs not installed; cannot test romfs. SKIP romfs_test (exit status: 77) =20 SKIP: exfat_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP exfat_test (exit status: 77) =20 SKIP: tar_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 tar not installed; cannot test tar. SKIP tar_test (exit status: 77) =20 SKIP: udf_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP udf_test (exit status: 77) =20 SKIP: hfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP hfs_test (exit status: 77) =20 SKIP: jfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP jfs_test (exit status: 77) =20 SKIP: btrfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP btrfs_test (exit status: 77) =20 SKIP: zfs_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 SKIP zfs_test (exit status: 77) =20 SKIP: cpio_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cpio not installed; cannot test cpio. SKIP cpio_test (exit status: 77) =20 FAIL: pata_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 tar: Removing leading `/' from member names cp: cannot stat '': No such file or directory FAIL pata_test (exit status: 1) =20 FAIL: ahci_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 tar: Removing leading `/' from member names cp: cannot stat '': No such file or directory FAIL ahci_test (exit status: 1) =20 FAIL: uhci_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 tar: Removing leading `/' from member names cp: cannot stat '': No such file or directory FAIL uhci_test (exit status: 1) =20 FAIL: ohci_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 tar: Removing leading `/' from member names cp: cannot stat '': No such file or directory FAIL ohci_test (exit status: 1) =20 FAIL: ehci_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 tar: Removing leading `/' from member names cp: cannot stat '': No such file or directory FAIL ehci_test (exit status: 1) =20 FAIL: example_grub_script_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL example_grub_script_test (exit status: 1) =20 FAIL: grub_script_eval =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_eval (exit status: 1) =20 FAIL: grub_script_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_test (exit status: 1) =20 FAIL: grub_script_echo1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_echo1 (exit status: 1) =20 FAIL: grub_script_leading_whitespace =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_leading_whitespace (exit status: 1) =20 FAIL: grub_script_echo_keywords =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_echo_keywords (exit status: 1) =20 FAIL: grub_script_vars1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_vars1 (exit status: 1) =20 FAIL: grub_script_for1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_for1 (exit status: 1) =20 FAIL: grub_script_while1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_while1 (exit status: 1) =20 FAIL: grub_script_if =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_if (exit status: 1) =20 FAIL: grub_script_comments =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_comments (exit status: 1) =20 FAIL: grub_script_functions =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_functions (exit status: 1) =20 FAIL: grub_script_break =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_break (exit status: 1) =20 FAIL: grub_script_continue =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_continue (exit status: 1) =20 FAIL: grub_script_shift =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_shift (exit status: 1) =20 FAIL: grub_script_blockarg =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D =20 cp: cannot stat '': No such file or directory [] !=3D [{ true }] FAIL grub_script_blockarg (exit status: 1) =20 FAIL: grub_script_setparams =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_setparams (exit status: 1) =20 FAIL: grub_script_return =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_return (exit status: 1) =20 FAIL: grub_cmd_regexp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_cmd_regexp (exit status: 1) =20 FAIL: grub_cmd_date =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory Date not in range: 1690428943 <=3D 1690416000 <=3D 1690428943 FAIL grub_cmd_date (exit status: 1) =20 FAIL: grub_cmd_sleep =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_cmd_sleep (exit status: 1) =20 FAIL: grub_script_expansion =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_expansion (exit status: 1) =20 FAIL: grub_script_not =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_not (exit status: 1) =20 SKIP: partmap_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 parted not installed; cannot test partmap SKIP partmap_test (exit status: 77) =20 SKIP: xzcompress_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 xz not installed; cannot test xz compression. SKIP xzcompress_test (exit status: 77) =20 SKIP: gzcompress_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 gzip not installed; cannot test gzip compression. SKIP gzcompress_test (exit status: 77) =20 SKIP: lzocompress_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 lzop not installed; cannot test lzo compression. SKIP lzocompress_test (exit status: 77) =20 FAIL: grub_cmd_echo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_cmd_echo (exit status: 1) =20 FAIL: help_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL help_test (exit status: 1) =20 FAIL: grub_script_gettext =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_gettext (exit status: 1) =20 FAIL: grub_script_escape_comma =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_escape_comma (exit status: 1) =20 FAIL: grub_script_strcmp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_script_strcmp (exit status: 1) =20 FAIL: test_sha512sum =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory GRUB sha512sum output did not match sha512sum output. See diff -u /tmp/guix-build-grub-coreboot-2.06.drv-0/tmp.3JBlCBhBGy /tmp= /guix-build-grub-coreboot-2.06.drv-0/tmp.1s7bz8jSnV FAIL test_sha512sum (exit status: 1) =20 FAIL: test_unset =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL test_unset (exit status: 1) =20 FAIL: grub_cmd_tr =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL grub_cmd_tr (exit status: 1) =20 FAIL: file_filter_test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 cp: cannot stat '': No such file or directory FAIL file_filter_test (exit status: 1) =20 =20 error: in phase 'check': uncaught exception: %exception #<&invoke-error program: "make" arguments: ("check" "-j" "2")= exit-status: 2 term-signal: #f stop-signal: #f>=20 phase `check' failed after 34.0 seconds command "make" "check" "-j" "2" failed with status 2 builder for `/gnu/store/h78fy12q7nijz54ppfdr7z3h7yvpnyxs-grub-coreboot-2= .06.drv' failed with exit code 1 build of /gnu/store/h78fy12q7nijz54ppfdr7z3h7yvpnyxs-grub-coreboot-2.06.= drv failed View build log at '/var/log/guix/drvs/h7/8fy12q7nijz54ppfdr7z3h7yvpnyxs-= grub-coreboot-2.06.drv.gz'. guix build: error: build of `/gnu/store/h78fy12q7nijz54ppfdr7z3h7yvpnyxs= -grub-coreboot-2.06.drv' failed Denis --Sig_/JO2pCAFxNRKepPdR5loViN7 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmTB56AACgkQX138wUF3 4mNU0w//WLcxuKJdj6tTcUIgE0vH+XcPofLI2XLxbzrFq5N20azs0P4Vs7GPX6bE /2rYBzBmWbRPC5qJ0o7PrT8lEXt1SKKygtGX9SaBVdvDeH89xLTnNQoHpfReAEGc gPh971IhZEW8bFyP/dmA58HUDM214Zsdv4nMKmlP7VGyWZFECy+fPsoUQQIf3oHD NDM/eNSTDN10HfNDe6U1Z3/+BoFnO5KPPBPfLfK7cLnOZhKJZnFK4Ng1iWYiuXq1 y4cmhHPieBXUlWfZm1c9dHVfnU+CQoEaeAg3MfeYPqVdHWwkSdJc2Q/dbCO50sQk VkAmnEMeENpgCkAOZGkXMDiKqTVdbUjFe2HoaS0huL4ER7JNuKRBLD0NtcAk2nhA lyJURDJyechNKohkuy//IBjjqwJAjUKCilvoTa/XD8Gydf82VvW8Bn4WBHzoCUZt V58Kv2DEmaz79r3keVXIpoibu+daDxSr+awHvoJnXppHpFQ5C7Iu7kS1OeoHrt+6 518uhIjKCndZTNhFoRRSOJXPHqvR2Y9HfByKV9724PAWQ89YvqX6Dj5Xp0UYW/Y0 hQsm+cSV55nB8itTp85kit28EqB++h9TFyZu+EFtK9PS0lOsj+L6CfdXGSLUNDID EbLGG+dFtD/g7OmfLan1II8Ci5eMP9oACugC82g7BxPbleGYE/Q= =aorc -----END PGP SIGNATURE----- --Sig_/JO2pCAFxNRKepPdR5loViN7-- From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Aug 2023 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Denis 'GNUtoo' Carikli Cc: Efraim Flashner , 64667@debbugs.gnu.org Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.169334994010432 (code B ref 64667); Tue, 29 Aug 2023 22:59:02 +0000 Received: (at 64667) by debbugs.gnu.org; 29 Aug 2023 22:59:00 +0000 Received: from localhost ([127.0.0.1]:51790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb7fo-0002iC-D7 for submit@debbugs.gnu.org; Tue, 29 Aug 2023 18:59:00 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:36400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb7fi-0002ht-6Z for 64667@debbugs.gnu.org; Tue, 29 Aug 2023 18:58:59 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 97D2F1ADEE; Tue, 29 Aug 2023 15:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1693349917; bh=n1n84Cc3jd2t6evAHnELDgYaKsIp17IRjZHFpdaFXjw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UrZZdcMHRdVRmehAcLl7ztIzRtaPBA7W6bEj73xioCMhj+uAzCAcF4+DZTufP5xc2 m0aJbmb4M/M+VH4Dbjsx3pM98kmspkNHKhnGirGM0cGsELRsVarjRgeYoRkKTZ7it5 5OlX0DsCccH6UX9qIONPPhtad6IWD7WnhwXD6VHstZ4FCy4gftiJcOzg0dgq6FwQzI n+SXe6GUpG3/b5xuVmFFkV+eTbLrPTieIDsV3Ly3oiJ3tlxyoa+de/WVsKp4z+4uEf 5P68njBqW2N70isWLIG6pkbhPTUqZYn0vv/r+oHep9BveUKPtqBm13Yt7kDfOXvqV8 aTG63VJOre9Kg== From: Vagrant Cascadian In-Reply-To: <20230727054224.138476d6@primary_laptop> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> <87v8eh14mq.fsf@wireframe> <20230727054224.138476d6@primary_laptop> Date: Tue, 29 Aug 2023 15:58:33 -0700 Message-ID: <87il8xv4km.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-07-27, Denis 'GNUtoo' Carikli wrote: > On Tue, 18 Jul 2023 11:00:45 -0700 > Vagrant Cascadian wrote: >> > + ;; Several tests fail >> > + ((#:tests? _ #f) >> > + #f) >>=20 >> Could you explain in more detail about the failing tests in the >> comment? Which tests? Are they testing things that are not valid in a >> grub-coreboot context? Is it not reasonable or not plausible to >> selectively disable only the failing tests? > I've looked into it, and the reason the test fails is similar than with > UEFI: many tests require to build a Coreboot image (and also to > build cbfstool which is available in Coreboot)[1]. > > And building Coreboot for qemu would require to deblob it first, and > simply using Libreboot for that doesn't work anymore because recent > versions don't deblob Coreboot and even ship nonfree software in the > releases. > > So at some point we will likely have some clean solution for that, but > it could take some time. > > In the meantime if the comment is changed for the following, would it > work for you? >> ;; TODO: Tests need a (deblobbed) Coreboot firmware for qemu. Still seems a bit brief, but I suppose it is not terrible. :) I might want to identify in the comment which tests need a coreboot image and which need cbfstool for example. If it is really involved, perhaps a link to a more detailed explanation, such as to a comment filed on this bug report. > Or do I really need to disable the failing tests[2]? Well... > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > GRUB 2.06: ./test-suite.log > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20=20=20=20 > # TOTAL: 80 > # PASS: 19 > # SKIP: 24 > # XFAIL: 0 > # FAIL: 37 > # XPASS: 0 > # ERROR: 0 Disabling all the tests means that you would miss out on at least 19 tests that currently PASS (but might someday fail, because they are actually presumably testing something)... Are all of the failures or skipped tests things that cannot reasonably be fixed, such as being unable to build a coreboot image or cbfstool? live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZO54GQAKCRDcUY/If5cW qmGRAQCpfsZsbSwo9NVda0EgHd5A5IjGA07w+HONet6PIGoLoAD/fePNi7RUmxMY Q9Yf9y9PFuMpLgk280sYHBKKsjvElQs= =IcVM -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Sep 2023 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: Efraim Flashner , 64667@debbugs.gnu.org Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.16947883357851 (code B ref 64667); Fri, 15 Sep 2023 14:33:01 +0000 Received: (at 64667) by debbugs.gnu.org; 15 Sep 2023 14:32:15 +0000 Received: from localhost ([127.0.0.1]:44440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh9ri-00022Z-Pu for submit@debbugs.gnu.org; Fri, 15 Sep 2023 10:32:15 -0400 Received: from cyberdimension.org ([2001:910:1314:ffff::1]:51536 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh9rh-00022P-Gs for 64667@debbugs.gnu.org; Fri, 15 Sep 2023 10:32:14 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 5a4815b0; Fri, 15 Sep 2023 14:32:03 +0000 (UTC) Received: from primary_laptop (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 5e6da4ec; Fri, 15 Sep 2023 14:32:03 +0000 (UTC) Date: Fri, 15 Sep 2023 16:31:59 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20230915163159.51d2e7fa@primary_laptop> In-Reply-To: <87il8xv4km.fsf@wireframe> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> <87v8eh14mq.fsf@wireframe> <20230727054224.138476d6@primary_laptop> <87il8xv4km.fsf@wireframe> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/vSpajFXnBKUHSM6vzOqQIAd"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/vSpajFXnBKUHSM6vzOqQIAd Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, On Tue, 29 Aug 2023 15:58:33 -0700 Vagrant Cascadian wrote: > Still seems a bit brief, but I suppose it is not terrible. :) With: > I might want to identify in the comment which tests need a coreboot > image and which need cbfstool for example. and: > Are all of the failures or skipped tests things that cannot reasonably > be fixed, such as being unable to build a coreboot image or cbfstool? I've looked and luckily all the tests that we need to disable fail because they miss a Coreboot image. I'll send a v2. > If it is really involved, perhaps a link to a more detailed > explanation, such as to a comment filed on this bug report. In the v2 I've also improved a bit the description of the issue. Denis. --Sig_/vSpajFXnBKUHSM6vzOqQIAd Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmUEat8ACgkQX138wUF3 4mPcBQ//a65D9pT7a8BqsaVgy1ABpE94ENX+Jyra9ANF2knfoWuzcnQ9X5LHcP+i T6kswOxW9rplayEP1zwZg2h2JSIkxp6qSyDZNiphyWhQkFtWhMF0VHp5oSaYPcwZ mCqn626t/Qn5+IDNPt5aYRwMuAQ+TY/fNZ28C6Dx0HSq44/4xmwIp2X+sAiGkcPc OmNrOXZAEgMkP2BVEymp9ug5jIwPdUzRI+GBg3SOaDJlSDiTN1zYHyfQTAAwU3dX 8ANDZLzegUabjGuRdfRUXPzsEPQy1+VPJgk9F/mNUO51ze3UVAUg7acIYI58JunW Mena0SWBYUKl4/15NF8254fHjZvLpIjxBwlXwQ4Ts7S66pj9MhO1jnxmd1gJbzg9 cyoIevdAwAP7Az/mD6dp19GdJm9HmBNfmRfFJC7MP+IW7tbINJdppvRBa30PH4G3 sGL5D0SWl7EhvtpkR4oz1jIFaWeF0rX5stdTMjQrBopQBwcLTKwFIg1y/Z3GMuun J4vaxPkj1I2Oxwlcyj2If1bXba+6m/+kBVaVbhnvY2vx+CV24Xbm9wP24+r1HGW7 RBFeZ+7HNS2tKj/hzlStxWmDV5fTHGvVfe4LtxX9GtQ1tSWCHuGCVkfFe8lMJ0wo NBLEPJ6d3i6ib7B/nxfvX2SwrTYlHBoQHxdwbB/4S1+pAPBi44M= =EQkI -----END PGP SIGNATURE----- --Sig_/vSpajFXnBKUHSM6vzOqQIAd-- From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH v2] gnu: Add grub-coreboot References: In-Reply-To: Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: , guix-patches@gnu.org Resent-Date: Fri, 15 Sep 2023 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64667@debbugs.gnu.org Cc: Denis 'GNUtoo' Carikli , ( , Christopher Baines , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart X-Debbugs-Original-Xcc: ( , Christopher Baines , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.16947884808075 (code B ref 64667); Fri, 15 Sep 2023 14:35:02 +0000 Received: (at 64667) by debbugs.gnu.org; 15 Sep 2023 14:34:40 +0000 Received: from localhost ([127.0.0.1]:44444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh9u4-00026B-FM for submit@debbugs.gnu.org; Fri, 15 Sep 2023 10:34:40 -0400 Received: from cyberdimension.org ([2001:910:1314:ffff::1]:53920 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh9u1-000260-5n for 64667@debbugs.gnu.org; Fri, 15 Sep 2023 10:34:39 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 7bafdce5; Fri, 15 Sep 2023 14:34:29 +0000 (UTC) Received: from localhost.localdomain (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 4d51c32b; Fri, 15 Sep 2023 14:34:29 +0000 (UTC) From: Denis 'GNUtoo' Carikli Date: Fri, 15 Sep 2023 16:34:25 +0200 Message-ID: <6ea5063330afa7ae3b9f008552be81641747863e.1694788144.git.GNUtoo@cyberdimension.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/bootloaders.scm (grub-coreboot): New variable. Signed-off-by: Denis 'GNUtoo' Carikli --- ChangeLog: * All the failing tests failed because they require a Coreboot image. So now: * Only theses tests are disabled, enabling other tests to run. * There is a better comment explaning why these tests needed to be disabled. --- gnu/packages/bootloaders.scm | 67 +++++++++++++++++++++++++++++++++++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 1c47636341..15c3de2619 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -15,7 +15,7 @@ ;;; Copyright © 2020, 2021 Pierre Langlois ;;; Copyright © 2021 Vincent Legoll ;;; Copyright © 2021 Brice Waegeneire -;;; Copyright © 2022 Denis 'GNUtoo' Carikli +;;; Copyright © 2022, 2023 Denis 'GNUtoo' Carikli ;;; Copyright © 2021 Stefan ;;; Copyright © 2022, 2023 Maxim Cournoyer ;;; @@ -297,6 +297,71 @@ (define-public grub-minimal #t)))))))) +(define-public grub-coreboot + (package + (inherit grub) + (name "grub-coreboot") + (synopsis "GRand Unified Boot loader (Coreboot payload version)") + (arguments + `(,@(substitute-keyword-arguments (package-arguments grub) + ((#:phases phases '%standard-phases) + `(modify-phases ,phases + (add-before 'check 'disable-broken-tests + (lambda _ + (setenv "DISABLE_HARD_ERRORS" "1") + (setenv + "XFAIL_TESTS" + (string-join + ;; TODO: All the tests below use grub shell + ;; (tests/util/grub-shell.in), and here grub-shell uses + ;; QEMU and a Coreboot image to run the tests. Since we + ;; don't have a Coreboot package in Guix yet these tests + ;; are disabled. See the Guix bug #64667 for more details + ;; (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64667). + (list + "pata_test" + "ahci_test" + "uhci_test" + "ehci_test" + "example_grub_script_test" + "ohci_test" + "grub_script_eval" + "grub_script_echo1" + "grub_script_test" + "grub_script_leading_whitespace" + "grub_script_echo_keywords" + "grub_script_vars1" + "grub_script_for1" + "grub_script_while1" + "grub_script_if" + "grub_script_comments" + "grub_script_functions" + "grub_script_continue" + "grub_script_break" + "grub_script_shift" + "grub_script_blockarg" + "grub_script_return" + "grub_script_setparams" + "grub_cmd_date" + "grub_cmd_sleep" + "grub_cmd_regexp" + "grub_script_not" + "grub_cmd_echo" + "grub_script_expansion" + "grub_script_gettext" + "grub_script_escape_comma" + "help_test" + "grub_script_strcmp" + "test_sha512sum" + "grub_cmd_tr" + "test_unset" + "file_filter_test") + " ")))))) + ((#:configure-flags flags + ''()) + `(cons* "--with-platform=coreboot" + ,flags))))))) + (define-public grub-efi (package (inherit grub) base-commit: 0c1aa354048f82023e6d2043bfecc4fd58bc9b58 -- 2.41.0 From unknown Fri Aug 15 20:26:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Nov 2023 11:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: Efraim Flashner , 64667@debbugs.gnu.org Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.17007388967488 (code B ref 64667); Thu, 23 Nov 2023 11:29:01 +0000 Received: (at 64667) by debbugs.gnu.org; 23 Nov 2023 11:28:16 +0000 Received: from localhost ([127.0.0.1]:60768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r67sW-0001wi-G9 for submit@debbugs.gnu.org; Thu, 23 Nov 2023 06:28:16 -0500 Received: from cyberdimension.org ([80.67.179.20]:48276 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r67sS-0001wX-Ea for 64667@debbugs.gnu.org; Thu, 23 Nov 2023 06:28:14 -0500 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id d33c1b44; Thu, 23 Nov 2023 11:28:06 +0000 (UTC) Received: from primary_laptop (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id ed5fb8b7; Thu, 23 Nov 2023 11:28:05 +0000 (UTC) Date: Thu, 23 Nov 2023 12:27:57 +0100 From: Denis 'GNUtoo' Carikli Message-ID: <20231123122757.1b726d81@primary_laptop> In-Reply-To: <20230915163159.51d2e7fa@primary_laptop> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> <87v8eh14mq.fsf@wireframe> <20230727054224.138476d6@primary_laptop> <87il8xv4km.fsf@wireframe> <20230915163159.51d2e7fa@primary_laptop> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/oW2TRsq3XmVq.8xrFnE6I_Q"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/oW2TRsq3XmVq.8xrFnE6I_Q Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 15 Sep 2023 16:31:59 +0200 Denis 'GNUtoo' Carikli wrote: > I'll send a v2. That is now done. Ping. Denis. --Sig_/oW2TRsq3XmVq.8xrFnE6I_Q Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmVfNz0ACgkQX138wUF3 4mMQDQ//fBNdv2mBtozoiyIrW5ydiag8cFZeTFdbHjTKDk37gFQzy82BhdUIkOcf P7NLnds30YxYNMfsxZiymOExL01qRQnRVE+FZ7CLUPVdSeIOMlmLNRGWarEXIpRK O6Ht625GL/S9HwdRpKmPVkOOUPADZDPOU9q7chD1Cr1iJ60K/BSy7gX2Z2mBTbMP p8ZaRX7HnBH2luRjYwXXhicPpDCfaTSF2aGqu2EwERlisUUrej8ahxCD5wMkPOpH MXTA6rE9btIb6wskkkjyxmjBJYgO4fax4bFfa8KU9XL05pBxlaSFfwAOmHUK9cG+ VdYtUSYLNaHR6edqftP5mucuK9Har3mPk7MwDPRu10UdJF3F4yVBWhUwIaNQa1Y/ 8+r+/IA/SB1YiUiZ2t62hSrwe5VsNQPEv5XyuolGPFT/mXhJD/vhx/+R6KqVBE9+ avqhoyANoHxL7GV85ayDJzsKPaLY5IdFQ7UoYLHGbYhri2WXNnGQtkV563sQIy0I N2k3A5M6UjE36e1i0CDrL/iiVkKvK3TkOg0ymJGGkAQaJQmHLhvsZOqw68p2wqNC jDXm8XJX8gOA/mLXFxE1tlO2Q4uGT/z0YUVLko/Kno3MkwUCAkI6hfbjtebuXznt xG/3vMkEGLOJB8Uz45X3O0SKP0nhI18Cpaq5E1vJ9cMvYN1xOf4= =ejDd -----END PGP SIGNATURE----- --Sig_/oW2TRsq3XmVq.8xrFnE6I_Q-- From unknown Fri Aug 15 20:26:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Denis 'GNUtoo' Carikli Subject: bug#64667: closed (Re: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot) Message-ID: References: <87zfz2rfp7.fsf@wireframe> X-Gnu-PR-Message: they-closed 64667 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 64667@debbugs.gnu.org Date: Fri, 24 Nov 2023 21:43:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1700862181-25227-1" This is a multi-part message in MIME format... ------------=_1700862181-25227-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64667: [PATCH 0/1] Add grub-coreboot which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64667@debbugs.gnu.org. --=20 64667: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64667 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1700862181-25227-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64667-done) by debbugs.gnu.org; 24 Nov 2023 21:42:51 +0000 Received: from localhost ([127.0.0.1]:37369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6dwp-0006YX-CF for submit@debbugs.gnu.org; Fri, 24 Nov 2023 16:42:51 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:45570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6dwm-0006YE-8x for 64667-done@debbugs.gnu.org; Fri, 24 Nov 2023 16:42:49 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id F40801AE37; Fri, 24 Nov 2023 13:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1700862155; bh=qrroujdPjwfmT24o4ZO4Z6zV7yuSnu6Jszr8kPCp6UE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AtAFh2uGMLzdmEjkyxh7h3fhxYiGS6Ogj6SpiDWdMh/ybhbGgS03IfPTYYbpu+S0/ 9AS0KQ9tx+pomTuQD061BFylKTzbcilzgXxRlJS9VTxAqhS8tXVU53BXvO2yBQRl4a i7cQ6S6X6esctU0KmoTofLwOorkLxKF5CsEZQ17ZI3SIdqbjePDUjcL0ZoMwp0uzFI 0qrj/yOz6MDBQX1EXhH2l473rdcIcI0NUnmlrM6O6oU789vqmdUHaB/VmPxmc6rIYG a5a2iKXkg+j0d5HDQuA1ch3eW7MC4Pv0nXD7Txbpbvjla9ic1SXRmdnzCca5rFqlXW d39D6CSldr90Q== From: Vagrant Cascadian To: Denis 'GNUtoo' Carikli Subject: Re: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot In-Reply-To: <20231123122757.1b726d81@primary_laptop> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> <87v8eh14mq.fsf@wireframe> <20230727054224.138476d6@primary_laptop> <87il8xv4km.fsf@wireframe> <20230915163159.51d2e7fa@primary_laptop> <20231123122757.1b726d81@primary_laptop> Date: Fri, 24 Nov 2023 13:42:28 -0800 Message-ID: <87zfz2rfp7.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64667-done Cc: Efraim Flashner , 64667-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 2023-11-23, Denis 'GNUtoo' Carikli wrote: > On Fri, 15 Sep 2023 16:31:59 +0200 > Denis 'GNUtoo' Carikli wrote: >> I'll send a v2. > That is now done. > > Ping. Never received the patch; it was only sent to the bug tracking system, not the team members. Pushed now as: 4b6f6b3e180afc5d1b286130710dd9e3eb6c2889 gnu: Add grub-coreboot live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZWEYxAAKCRDcUY/If5cW qiw9AP9jSWah9SuJ/LGQT+Z/FVL/2W5LcW7ZtrF+rQCirsWQlgEAqwBY2fcy7CqK erJIKoclitN3PGDbgFInvnPywpx+ig4= =/P5o -----END PGP SIGNATURE----- --=-=-=-- ------------=_1700862181-25227-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Jul 2023 16:50:04 +0000 Received: from localhost ([127.0.0.1]:48450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL4wd-0001F9-TX for submit@debbugs.gnu.org; Sun, 16 Jul 2023 12:50:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL4wa-0001EM-09 for submit@debbugs.gnu.org; Sun, 16 Jul 2023 12:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL4wU-0005A3-HO for guix-patches@gnu.org; Sun, 16 Jul 2023 12:49:54 -0400 Received: from cyberdimension.org ([80.67.179.20] helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qL4wS-00063p-HY for guix-patches@gnu.org; Sun, 16 Jul 2023 12:49:54 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 4575bff4; Sun, 16 Jul 2023 16:49:48 +0000 (UTC) Received: from localhost.localdomain (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id a608a8c7; Sun, 16 Jul 2023 16:49:48 +0000 (UTC) From: Denis 'GNUtoo' Carikli To: guix-patches@gnu.org Subject: [PATCH 0/1] Add grub-coreboot Date: Sun, 16 Jul 2023 18:49:32 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: ( , Christopher Baines , Ludovic Courtès , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=80.67.179.20; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Denis 'GNUtoo' Carikli X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi, In the following mail there will be a patch that adds grub-coreboot. The './pre-inst-env guix lint grub-coreboot' command shows some warnings: [...]/bootloaders.scm:301:2: grub-coreboot@2.06: label 'qemu' does not match package name 'qemu-minimal' [...]/bootloaders.scm:301:2: grub-coreboot@2.06: label 'gettext' does not match package name 'gettext-minimal' [...]/bootloaders.scm:301:2: grub-coreboot@2.06: file names of patches should start with the package name [...]/bootloaders.scm:301:2: grub-coreboot@2.06: probably vulnerable to CVE-2022-2601, CVE-2022-3775, CVE-2021-3981 [...]/bootloaders.scm:301:2: grub-coreboot@2.06: updater 'gnu' failed to find upstream releases but since this package is based on grub-coreboot, I guess that things should be fixed there instead. A standalone image was built with the following commands: modules="ahci at_keyboard cbfs ehci ext2 fat ohci part_gpt part_msdos \ pata uhci usb_keyboard usbms usbserial_usbdebug" install_modules="acpi ahci all_video archelp at_keyboard ata blocklist \ boot btrfs cat cbfs cbls cbls cbmemc cbmemc cbtime cbtime chain chain \ cmosdump cmostest cmp configfile configfile cpio cpuid crc64 crypto \ cryptodisk cs5536 date datehook datetime disk diskfilter div dm_nv echo \ echo ehci elf eval exfat ext2 extcmd fat file fshelp gcry_crc gcry_rfc2268 \ gcry_rijndael gcry_rsa gcry_seed gcry_serpent gcry_sha1 gcry_sha256 \ gcry_sha512 gcry_twofish gettext gfxmenu gfxterm_background gfxterm_menu \ gptsync gzio gzio halt halt hashsum hdparm help help hexdump hexdump iorw \ iorw iso9660 jpeg keylayouts keystatus ldm linux linux linux16 linux16 \ loadenv loopback ls ls lsacpi lsacpi lsmmap lsmmap lspci lspci luks lvm \ lzopio mda_text memdisk memrw memrw minicmd minicmd mmap morse mpi \ msdospart multiboot multiboot multiboot2 nativedisk newc nilfs2 normal \ normal odc offsetio ohci part_gpt part_msdos parttool password \ password_pbkdf2 password_pbkdf2 pata pbkdf2 pci pcidump pcidump pgp play \ priority_queue probe procfs progress random read reboot reboot regexp \ regexp relocator romfs scsi search search search_fs_file search_fs_uuid \ search_label serial serial setjmp setpci setpci sfs sleep spkmodem squash4 \ syslinuxcfg syslinuxcfg tar terminal terminfo test test testload testspeed \ time tr trig true udf uhci usb usb_keyboard usbms usbserial_common \ usbserial_ftdi usbserial_pl2303 usbserial_usbdebug video_colors videoinfo \ xnu xzio" "/gnu/store/[...]/bin/grub-mkstandalone" \ -O i386-coreboot \ -o grub_payload.elf \ --fonts= \ --themes= \ --locales= \ --modules="${modules}" \ --install-modules="${install_modules}" \ /boot/grub/grub.cfg=coreboot.cfg The coreboot.cfg file was taken from grub source code (GPLv3+) and consist of the following: if test -f (cbfsdisk)/etc/grub.cfg; then source (cbfsdisk)/etc/grub.cfg fi The resulting image was tested on a Thinkpad X200 running a custom 100% free software version of Coreboot with as a GRUB payload) with the following commands: chainloader /path/to/grub_payload.elf boot It then booted fine. As for the partitions I used, I have LUKS encrypted hard drive with LVM2 and a mix of BTRFS and ext4 partitions. Denis 'GNUtoo' Carikli (1): gnu: Add grub-coreboot gnu/packages/bootloaders.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) base-commit: 796c823a0d1d0aec9f4af908eca462e58e5675b5 -- 2.41.0 ------------=_1700862181-25227-1--