GNU bug report logs - #64656
29.0.91; Doc of minibuffer histories and completing-read - automatic addition of completions to DEFAULT list

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 64656 <at> debbugs.gnu.org
Subject: bug#64656: 29.0.91; Doc of minibuffer histories and completing-read - automatic addition of completions to DEFAULT list
Date: Thu, 09 Nov 2023 18:34:52 +0200

> Customizing 'completions-sort' to the option 'nil' ("No sorting")
> reveals more interesting things.  For example, when vc completes a backend,
> it turns out that the order is manually crafted:
>
>   (defcustom vc-handled-backends '(RCS CVS SVN SCCS SRC Bzr Git Hg)
>     ;; RCS, CVS, SVN, SCCS, and SRC come first because they are per-dir
>     ;; rather than per-tree.  RCS comes first because of the multibackend
>     ;; support intended to use RCS for local commits (with a remote CVS server).

I guess not many users customize 'completions-sort' to nil.
Otherwise someone may notice that the order of unsorted files
is reversed from the output of `ls -U`.  This could be fixed by:

diff --git a/src/dired.c b/src/dired.c
index c10531cdb16..0f527a801f7 100644
--- a/src/dired.c
+++ b/src/dired.c
@@ -846,7 +846,7 @@ DEFUN ("file-name-all-completions", Ffile_name_all_completions,
   bestmatch = unbind_to (count, bestmatch);
 
   if (all_flag || NILP (bestmatch))
-    return bestmatch;
+    return Fnreverse (bestmatch);
   /* Return t if the supplied string is an exact match (counting case);
      it does not require any change to be made.  */
   if (matchcount == 1 && !NILP (Fequal (bestmatch, file)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.