From unknown Fri Sep 05 18:47:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64649 <64649@debbugs.gnu.org> To: bug#64649 <64649@debbugs.gnu.org> Subject: Status: 30.0.50; Customize: Comments on face customization not being saved Reply-To: bug#64649 <64649@debbugs.gnu.org> Date: Sat, 06 Sep 2025 01:47:03 +0000 retitle 64649 30.0.50; Customize: Comments on face customization not being = saved reassign 64649 emacs submitter 64649 Mauro Aranda severity 64649 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 09:38:58 2023 Received: (at submit) by debbugs.gnu.org; 15 Jul 2023 13:38:58 +0000 Received: from localhost ([127.0.0.1]:44385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKfU9-0005l3-CX for submit@debbugs.gnu.org; Sat, 15 Jul 2023 09:38:57 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKfU5-0005kn-Ll for submit@debbugs.gnu.org; Sat, 15 Jul 2023 09:38:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKfU0-0001OV-8M for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 09:38:48 -0400 Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKfTx-0003R4-4e for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 09:38:48 -0400 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1b8eb69d641so2200681fac.0 for ; Sat, 15 Jul 2023 06:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689428322; x=1692020322; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=DXRnvZaBaf2UgeXkC5g9wJ9LUanSQGItQ+WFDtECwIU=; b=P4cWor5KDKttjgZWpaH8LW6jpm3JEolGC5KdImqZSQKEb7HUqfBZggj3rsm5GdUDro LoYMiOIdlZJpYluFg/7MOLfWwnqaNCkavaGaWSD2xn3Z6YQNUcPEbL968XBLovtXKWt6 0/XWD338+6Ohxq/UNOHuYjVpa1kH3h1ZApr/UYtfyHUw7f5M+wrffz4kQ8DMwDxmBeUH waMo6PYeT1DZO3XtyHpLlQ+zrlGTurvR9f6xKKC2SOhBbThWP3VpTyaf9EFZJsAuHIyi LJhUtWehMQ4XcgEwgkUHNqlQ9woDm4kSfv+rP2VVx7XGhedG9VrmOLIfAMTP85WXuS6j 7pzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689428322; x=1692020322; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DXRnvZaBaf2UgeXkC5g9wJ9LUanSQGItQ+WFDtECwIU=; b=aRL/jYyDP24sT+zCama3V1MklLrvwwAMPg42MRvLbamysOJ7wT8GXPqLOigO+bm0YP HZA1lbK1VLeG3K4GKFzl7Ez06hzXOib9FlKG3rQCgJbf3dnFv/Aw0+9z2GU9pzpSt96U 5UazqHvcAByI5rcK+8PBDBg7eiueX+k+L/InWyyy3UGY+C2CI8Nr8x9e9EsBu/ADK/ut YhYqw02xRZLZViRMqzZIigvu6oJFj8f8PS/c5ZPOqbpKQo8lOXAfQaxdupdR6RqznMR7 B97ejZrVAQCiELNGX44yWR030JAsqTY2QuRN78fjcpW/CJPJKD9LJSRrV3L0ZzCgJ5h3 +AVQ== X-Gm-Message-State: ABy/qLbX2/RAW54xp6Bf/vgvYzY0RreAIFBXx2U988fjb2SlCw6uUOVT r2/VvaOpuNh2d/xZXSICpgk+5A9CXPb3cw== X-Google-Smtp-Source: APBJJlE6uBHOyT/W3IpXaL3o6rK0XoxLgBOJWRFYK+i7S/9cf9ggHtTMDbuKIiiAypEWyz9cvAG4ug== X-Received: by 2002:a05:6870:538a:b0:1b4:5ef7:50fe with SMTP id h10-20020a056870538a00b001b45ef750femr9229777oan.29.1689428322413; Sat, 15 Jul 2023 06:38:42 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id b1-20020a056870b24100b001a9eb707366sm5090008oam.15.2023.07.15.06.38.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jul 2023 06:38:41 -0700 (PDT) Message-ID: Date: Sat, 15 Jul 2023 10:38:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 30.0.50; Customize: Comments on face customization not being saved Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4860:4864:20::35; envelope-from=maurooaranda@gmail.com; helo=mail-oa1-x35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This cannot be reproduced with emacs -Q, since it involves saving the customizations to the custom-file. So, backup your custom-file, follow these steps with a test user, or something.  Start Emacs and evaluate the following: (defface foo '((t nil))   "...") Then: M-x customize-face RET foo Edit at least an attribute, like the foreground color, for example. Action the State button and "Add Comment" Add a comment in the comment widget, like "Test" Action the State button and "Save for Future Sessions" Now visit the custom file: C-x C-f CUSTOM-FILE Search for the foo customization:  '(foo ((t (:foreground "gray")))) The "Test" comment isn't saved. This used to work in Emacs 27, but stopped working in Emacs 28. I think the following commit introduced this regression: commit a4c07bc8c8201a620c4365c1d0d2cb814cc677a9 Author: Alan Mackenzie Date:   Fri May 1 12:23:15 2020 +0000     Protect non-selected face spec components in custimize-face.  Fixes bug #40866     * lisp/cus-edit.el (custom-face-save): If the current face widget is only     displaying part of the face spec, temporarily set it to "display" the whole     spec around the call to custom-face-mark-to-save. In GNU Emacs 30.0.50 (build 27, x86_64-pc-linux-gnu, GTK+ Version  3.24.33, cairo version 1.16.0) of 2023-07-14 built on tbb-desktop Repository revision: e27cb447a8ceeee02428840baa29d122d2b6bd56 Repository branch: bug64347-eli Windowing system distributor 'The X.Org Foundation', version 11.0.12201001 System Description: Ubuntu 22.04.2 LTS Configured using:  'configure --with-mailutils' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: es_AR.UTF-8   value of $LC_NUMERIC: es_AR.UTF-8   value of $LC_TIME: es_AR.UTF-8   value of $LANG: en_US.UTF-8   value of $XMODIFIERS: @im=ibus   locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect:   auto-insert-mode: t   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   tool-bar-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   column-number-mode: t   line-number-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: ~/code/emacs/hiddenquote/hiddenquote/hiddenquote hides /home/tbb/.emacs.d/elpa/hiddenquote-20210205.1401/hiddenquote /home/tbb/.emacs.d/elpa/transient-20221019.941/transient hides /home/tbb/code/emacs/emacs/lisp/transient Features: (shadow mail-extr emacsbug message yank-media puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail solarized-dark-high-contrast-theme solarized-palettes solarized solarized-faces color autoinsert init-perl init-web company-web dash company-css web-completion-data company edmacro kmacro pcase init-ext init-emms dbus emms-librefm-stream emms-librefm-scrobbler emms-playlist-limit emms-volume easy-mmode emms-volume-mixerctl emms-volume-pulse emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-playing-time emms-lyrics emms-url emms-streams emms-show-all emms-tag-editor emms-mark emms-mode-line emms-cache emms-info-exiftool emms-info-tinytag emms-info-metaflac emms-info-opusinfo emms-info-ogginfo emms-info-mp3info emms-info emms-later-do emms-playlist-mode emms-player-vlc advice emms-player-mpv emms-player-mplayer emms-player-simple emms-source-playlist emms-source-file locate dired dired-loaddefs emms-setup emms emms-compat init-gnus gnus nnheader gnus-util text-property-search range init-org s ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table ox-ascii ox-publish ox org-element org-persist xdg org-id org-refile avl-tree org-clock org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities noutline outline icons ob-emacs-lisp ob-core ob-eval org-cycle org-table ol rx org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs format-spec init-social newsticker newst-treeview tree-widget wid-edit newst-plainview newst-reader newst-ticker newst-backend iso8601 time-date xml init-octave init-rmail undigest rmail rfc6068 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils init-vc vc vc-dispatcher init-cc-mode init-c init-yasnippet init-eshell eshell esh-cmd generator esh-ext esh-opt esh-proc esh-io esh-arg pcomplete comint ansi-osc ansi-color ring esh-module esh-groups esh-util files-x init-lisp init-elisp init-global finder-inf init-package 750words-autoloads adjust-parens-autoloads auctex-autoloads tex-site cider-autoloads epkg-autoloads closql-autoloads git-modes-autoloads inf-clojure-autoloads clojure-mode-autoloads magit-autoloads git-commit-autoloads magit-section-autoloads parseedn-autoloads parseclj-autoloads pdf-tools-autoloads perl-doc-autoloads queue-autoloads sesman-autoloads slime-autoloads swift-mode-autoloads uniquify-files-autoloads with-editor-autoloads dash-autoloads transient-autoloads info compat-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 461348 66691) (symbols 48 31470 0)  (strings 32 151984 5310) (string-bytes 1 4227883) (vectors 16 55630)  (vector-slots 8 1370848 173062) (floats 8 377 4610)  (intervals 56 450 0) (buffers 984 10)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 17:59:43 2023 Received: (at 64649) by debbugs.gnu.org; 15 Jul 2023 21:59:43 +0000 Received: from localhost ([127.0.0.1]:46218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKnIk-00083d-HB for submit@debbugs.gnu.org; Sat, 15 Jul 2023 17:59:42 -0400 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]:60863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKnIi-00083O-3I for 64649@debbugs.gnu.org; Sat, 15 Jul 2023 17:59:41 -0400 Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-38c35975545so2581608b6e.1 for <64649@debbugs.gnu.org>; Sat, 15 Jul 2023 14:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689458374; x=1692050374; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=69CXrCq7zSRI/3IB75tx1Cz8Vq7xPAW3b+rneS+X2/A=; b=CKvmRZwcyz1GMp1sW/qhMnaed0vw81PmqM0FiHC06ualndiFTRCG1eHDtCxU6FtK+7 OwNYry2OalEqg7duQJzK4uQku9Yqop81PGnTTqQqIKB9fqXqYkbOQArp5a8jDPubB1Dj yIHaU/mTpNME+6OMGbqXGfgzcT8/odXb/SnT6hgjxAw3SV27oYb3nK+ge25adjUccqrQ PuqmzKJxISeZ+U0Qx+4He1cH7f/jRxGvYT6rG0V9Ibn/OwT+0NqpBwSTBtatFf2bfvwN tYpeIlYzmG/psIbob8p8CSfb2B2G4MDOf2Ftth/gjCvpA/9kVuDBHuLTcr4tjjH9VzY2 t6pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689458374; x=1692050374; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=69CXrCq7zSRI/3IB75tx1Cz8Vq7xPAW3b+rneS+X2/A=; b=hhWeHXJNlTwgNgZvxlf6RQ5wvxFHj9F3K7P1eb+hTPaBIAKzV+JA2/wX3RAtqqZYqM evkjLk8BDeJO2mVXVBTyWT0Pn2t1Pm4/w1OImqAa5QcaAouOXO4wZWOEtu2Sd2WYBegQ lrkEAxIGoAO2HaE6PpNzDRW9bv+gofj5Wfd0fbIydF8K2lOnjFTqeLvMVxWAfB2Xtn5e IqhQWPT6YBBww0wVQGkDwTRT02fJk7CQyTociCLzPjiB5jVPeDNWikaHcQMW/lx1HbZZ xtmzOj2aFUCYDSXuh8s5/QrUXlaPtumYh+nDM/GNllQ8ZkQeis7XVRTY1a3zB/uNlkX/ DpmQ== X-Gm-Message-State: ABy/qLZ/j19tzhAzzegLN3WUcGvvv5DdeR2OYPKfX97nj58i0zm7Lkf/ FNUGKCQECa7I+Qm7z8vfZ8j2t0fERe5Bow== X-Google-Smtp-Source: APBJJlHKT3+XK/HUH6PAtYcoBq0ZgVh1t/tem09Xey+wwkqqXe4A0Kop/Lvtx46lLi0tm/vlSebaXg== X-Received: by 2002:aca:bd04:0:b0:398:2f92:65ca with SMTP id n4-20020acabd04000000b003982f9265camr6752042oif.7.1689458373287; Sat, 15 Jul 2023 14:59:33 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id o21-20020a4a2c15000000b0054fcc25de1fsm5479804ooo.2.2023.07.15.14.59.31 for <64649@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jul 2023 14:59:32 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------IZ6i88LFbnZ86Cn4H0C8KkJ1" Message-ID: Date: Sat, 15 Jul 2023 18:59:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: 64649@debbugs.gnu.org From: Mauro Aranda Subject: bug#64649: 30.0.50; Customize: Comments on face customization not being saved X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64649 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------IZ6i88LFbnZ86Cn4H0C8KkJ1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I attach a patch to fix this.  The commit that introduced this regression showed that we weren't taking care of preserving the comments when redrawing either the custom-face or the custom-variable widget. --------------IZ6i88LFbnZ86Cn4H0C8KkJ1 Content-Type: text/x-patch; charset=UTF-8; name="0001-Preserve-comments-when-redrawing-a-widget-Bug-64649.patch" Content-Disposition: attachment; filename*0="0001-Preserve-comments-when-redrawing-a-widget-Bug-64649.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSBkNzc4NTFiYThiNDM0Njk3YTdlNWE3OTdlOTExNWZlMDA4YjRlY2Y1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFNhdCwgMTUgSnVsIDIwMjMgMTg6NTQ6MTQgLTAzMDAKU3ViamVjdDog W1BBVENIXSBQcmVzZXJ2ZSBjb21tZW50cyB3aGVuIHJlZHJhd2luZyBhIHdpZGdldCAoQnVn IzY0NjQ5KQoKKiBsaXNwL2N1cy1lZGl0LmVsIChjdXN0b20tY29tbWVudC1wcmVzZXJ2ZSk6 IE5ldyBmdW5jdGlvbi4KKGN1c3RvbS1yZWRyYXcpOiBVc2UgaXQuCihjdXN0b20tY29tbWVu dC1jcmVhdGUpOiBNYWtlIHN1cmUgOmNvbW1lbnQtc2hvd24gaXMgc2V0IHRvIHQgaWYgdGhl CmNvbW1lbnQgd2lkZ2V0IGdldHMgY3JlYXRlZC4KKGN1c3RvbS1mYWNlLXZhbHVlLWNyZWF0 ZSwgY3VzdG9tLXZhcmlhYmxlLXZhbHVlLWNyZWF0ZSk6IFJlY3JlYXRlIHRoZQpjdXN0b20t Y29tbWVudCB3aWRnZXQgd2l0aCB0aGUgcHJlc2VydmVkIHZhbHVlLCBpZiBhbnkuCi0tLQog bGlzcC9jdXMtZWRpdC5lbCB8IDQ1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEzIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1l ZGl0LmVsCmluZGV4IGRiZWY1ZjQ3Y2Q2Li4xYzRkZTkyZGIxMiAxMDA2NDQKLS0tIGEvbGlz cC9jdXMtZWRpdC5lbAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC0yMzMwLDYgKzIzMzAs NyBAQCBjdXN0b20tcmVkcmF3CiAJKGZyb20gKG1hcmtlci1wb3NpdGlvbiAod2lkZ2V0LWdl dCB3aWRnZXQgOmZyb20pKSkKIAkodG8gKG1hcmtlci1wb3NpdGlvbiAod2lkZ2V0LWdldCB3 aWRnZXQgOnRvKSkpKQogICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgKGN1c3RvbS1jb21t ZW50LXByZXNlcnZlIHdpZGdldCkKICAgICAgICh3aWRnZXQtdmFsdWUtc2V0IHdpZGdldCAo d2lkZ2V0LXZhbHVlIHdpZGdldCkpCiAgICAgICAoY3VzdG9tLXJlZHJhdy1tYWdpYyB3aWRn ZXQpKQogICAgICh3aGVuIChhbmQgKD49IHBvcyBmcm9tKSAoPD0gcG9zIHRvKSkKQEAgLTI1 MDksNyArMjUxMCw5IEBAIGN1c3RvbS1jb21tZW50LWNyZWF0ZQogICAobGV0KiAoKG51bGwt Y29tbWVudCAoZXF1YWwgIiIgKHdpZGdldC12YWx1ZSB3aWRnZXQpKSkpCiAgICAgKGlmIChv ciAod2lkZ2V0LWdldCAod2lkZ2V0LWdldCB3aWRnZXQgOnBhcmVudCkgOmNvbW1lbnQtc2hv d24pCiAJICAgIChub3QgbnVsbC1jb21tZW50KSkKLQkod2lkZ2V0LWRlZmF1bHQtY3JlYXRl IHdpZGdldCkKKyAgICAgICAgKHByb2duCisgICAgICAgICAgKHdpZGdldC1kZWZhdWx0LWNy ZWF0ZSB3aWRnZXQpCisgICAgICAgICAgKHdpZGdldC1wdXQgKHdpZGdldC1nZXQgd2lkZ2V0 IDpwYXJlbnQpIDpjb21tZW50LXNob3duIHQpKQogICAgICAgOzsgYHdpZGdldC1kZWZhdWx0 LWRlbGV0ZScgZXhwZWN0cyBtYXJrZXJzIGluIHRoZXNlIHNsb3RzIC0tCiAgICAgICA7OyBt YXliZSBpdCBzaG91bGRuJ3QuCiAgICAgICAod2lkZ2V0LXB1dCB3aWRnZXQgOmZyb20gKHBv aW50LW1hcmtlcikpCkBAIC0yNTQyLDYgKzI1NDUsMTQgQEAgY3VzdG9tLWNvbW1lbnQtaW52 aXNpYmxlLXAKICAgICAoYW5kIChlcXVhbCAiIiB2YWwpCiAJIChub3QgKHdpZGdldC1nZXQg d2lkZ2V0IDpjb21tZW50LXNob3duKSkpKSkKIAorOzsgVGhpcyBpcyB1c2VmdWwgd2hlbiB3 ZSB3YW50IHRvIHJlZHJhdyBhIHdpZGdldCwgYnV0IHdlIHdhbnQgdG8gcHJlc2VydmUKKzs7 IGVkaXRzIG1hZGUgYnkgdGhlIHVzZXIgaW4gdGhlIGNvbW1lbnQgd2lkZ2V0LiAgKFNlZSBC dWcjNjQ2NDkpCisoZGVmdW4gY3VzdG9tLWNvbW1lbnQtcHJlc2VydmUgKHdpZGdldCkKKyAg IlByZXNlcnZlIHRoZSBjb21tZW50IHRoYXQgYmVsb25ncyB0byBXSURHRVQuIgorICAod2hl biAod2lkZ2V0LWdldCB3aWRnZXQgOmNvbW1lbnQtc2hvd24pCisgICAgKGxldCAoKGNvbW1l bnQtd2lkZ2V0ICh3aWRnZXQtZ2V0IHdpZGdldCA6Y29tbWVudC13aWRnZXQpKSkKKyAgICAg ICh3aWRnZXQtcHV0IGNvbW1lbnQtd2lkZ2V0IDp2YWx1ZSAod2lkZ2V0LXZhbHVlIGNvbW1l bnQtd2lkZ2V0KSkpKSkKKwogOzs7IFRoZSBgY3VzdG9tLXZhcmlhYmxlJyBXaWRnZXQuCiAK IChkZWZmYWNlIGN1c3RvbS12YXJpYWJsZS1vYnNvbGV0ZQpAQCAtMjgyMSwxMiArMjgzMiwx NiBAQCBjdXN0b20tdmFyaWFibGUtdmFsdWUtY3JlYXRlCiAKICAgICAgIDs7IFRoZSBjb21t ZW50IGZpZWxkCiAgICAgICAodW5sZXNzIChlcSBzdGF0ZSAnaGlkZGVuKQotCShsZXQqICgo Y29tbWVudCAoZ2V0IHN5bWJvbCAndmFyaWFibGUtY29tbWVudCkpCi0JICAgICAgIChjb21t ZW50LXdpZGdldAotCQkod2lkZ2V0LWNyZWF0ZS1jaGlsZC1hbmQtY29udmVydAotCQkgd2lk Z2V0ICdjdXN0b20tY29tbWVudAotCQkgOnBhcmVudCB3aWRnZXQKLQkJIDp2YWx1ZSAob3Ig Y29tbWVudCAiIikpKSkKKyAgICAgICAgKGxldCAoKGNvbW1lbnQtd2lkZ2V0CisgICAgICAg ICAgICAgICAod2lkZ2V0LWNyZWF0ZS1jaGlsZC1hbmQtY29udmVydAorICAgICAgICAgICAg ICAgIHdpZGdldCAnY3VzdG9tLWNvbW1lbnQKKyAgICAgICAgICAgICAgICA6cGFyZW50IHdp ZGdldAorICAgICAgICAgICAgICAgIDp2YWx1ZSAob3IKKyAgICAgICAgICAgICAgICAgICAg ICAgIChhbmQKKyAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LWdldCB3aWRnZXQg OmNvbW1lbnQtc2hvd24pCisgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC12YWx1 ZSAod2lkZ2V0LWdldCB3aWRnZXQgOmNvbW1lbnQtd2lkZ2V0KSkpCisgICAgICAgICAgICAg ICAgICAgICAgICAoZ2V0IHN5bWJvbCAndmFyaWFibGUtY29tbWVudCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICIiKSkpKQogCSAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjb21tZW50LXdp ZGdldCBjb21tZW50LXdpZGdldCkKIAkgIDs7IERvbid0IHB1c2ggaXQgISEhIEN1c3RvbSBh c3N1bWVzIHRoYXQgdGhlIGZpcnN0IGNoaWxkIGlzIHRoZQogCSAgOzsgdmFsdWUgb25lLgpA QCAtMzgzMSwxMiArMzg0NiwxNiBAQCBjdXN0b20tZmFjZS12YWx1ZS1jcmVhdGUKIAkgd2lk Z2V0IDp2aXNpYmlsaXR5LXdpZGdldCAnY3VzdG9tLXZpc2liaWxpdHkpCiAJOzsgVGhlIGNv bW1lbnQgZmllbGQKIAkodW5sZXNzIGhpZGRlbnAKLQkgIChsZXQqICgoY29tbWVudCAoZ2V0 IHN5bWJvbCAnZmFjZS1jb21tZW50KSkKLQkJIChjb21tZW50LXdpZGdldAotCQkgICh3aWRn ZXQtY3JlYXRlLWNoaWxkLWFuZC1jb252ZXJ0Ci0JCSAgIHdpZGdldCAnY3VzdG9tLWNvbW1l bnQKLQkJICAgOnBhcmVudCB3aWRnZXQKLQkJICAgOnZhbHVlIChvciBjb21tZW50ICIiKSkp KQorCSAgKGxldCAoKGNvbW1lbnQtd2lkZ2V0CisgICAgICAgICAgICAgICAgICh3aWRnZXQt Y3JlYXRlLWNoaWxkLWFuZC1jb252ZXJ0CisgICAgICAgICAgICAgICAgICB3aWRnZXQgJ2N1 c3RvbS1jb21tZW50CisgICAgICAgICAgICAgICAgICA6cGFyZW50IHdpZGdldAorICAgICAg ICAgICAgICAgICAgOnZhbHVlIChvcgorICAgICAgICAgICAgICAgICAgICAgICAgICAoYW5k CisgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LWdldCB3aWRnZXQgOmNvbW1l bnQtc2hvd24pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LXZhbHVlICh3 aWRnZXQtZ2V0IHdpZGdldCA6Y29tbWVudC13aWRnZXQpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgKGdldCBzeW1ib2wgJ2ZhY2UtY29tbWVudCkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgIiIpKSkpCiAJICAgICh3aWRnZXQtcHV0IHdpZGdldCA6Y29tbWVudC13aWRn ZXQgY29tbWVudC13aWRnZXQpCiAJICAgIChwdXNoIGNvbW1lbnQtd2lkZ2V0IGNoaWxkcmVu KSkpKQogCi0tIAoyLjM0LjEKCg== --------------IZ6i88LFbnZ86Cn4H0C8KkJ1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 11:53:10 2023 Received: (at 64649-done) by debbugs.gnu.org; 20 Jul 2023 15:53:10 +0000 Received: from localhost ([127.0.0.1]:59508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMVxm-0005z6-7O for submit@debbugs.gnu.org; Thu, 20 Jul 2023 11:53:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMVxj-0005yr-On for 64649-done@debbugs.gnu.org; Thu, 20 Jul 2023 11:53:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMVxe-0002xj-I6; Thu, 20 Jul 2023 11:53:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Dqtc29EAMazMYsorNbh62D+lguiwwt2ns3A6ExeM1kQ=; b=TUOxoLMJq5eceW4jMYT0 A8N64MimR356CE44OrN3td9hgrrteU7r7Hrosaak2GuQV6oK8Y4l3w5idin/pKELogTshN+PxAtvC vD+x+MwSHwJ8WhFy6hlfY4TohnrcZyrBjjloFGjcDZVQJaYVnkimtirOq351MaoLPf0FbCRLw9L76 L97HNVz9VxESKzPBMy6d/Wgk8B2yDykrCeeIO9FYEd5hJtK5QG7DbxT/yMVukZ9gj8ltb5T6PpPYw wRekTfy075mc62h/JeoH/2P2CZZxuVUfqR+KJNG3oxURxKXUkksUx9jlgp34x6LRUzXsIXTCl6aMB 2P69vJmsgfX++w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMVxe-0006hS-1P; Thu, 20 Jul 2023 11:53:02 -0400 Date: Thu, 20 Jul 2023 18:53:36 +0300 Message-Id: <83edl237gf.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: (message from Mauro Aranda on Sat, 15 Jul 2023 18:59:29 -0300) Subject: Re: bug#64649: 30.0.50; Customize: Comments on face customization not being saved References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64649-done Cc: 64649-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 15 Jul 2023 18:59:29 -0300 > From: Mauro Aranda > > I attach a patch to fix this.  The commit that introduced this > regression showed that we weren't taking care of preserving the comments > when redrawing either the custom-face or the custom-variable widget. Thanks, installed on the master branch, and closing the bug. From unknown Fri Sep 05 18:47:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Aug 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator