From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 05:38:29 2023 Received: (at submit) by debbugs.gnu.org; 15 Jul 2023 09:38:29 +0000 Received: from localhost ([127.0.0.1]:44172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbjQ-0004aW-KK for submit@debbugs.gnu.org; Sat, 15 Jul 2023 05:38:28 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbjN-0004aF-FB for submit@debbugs.gnu.org; Sat, 15 Jul 2023 05:38:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbjI-0007aZ-5r for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 05:38:20 -0400 Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbjG-0004qK-9G for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 05:38:19 -0400 Received: (qmail 36541 invoked by uid 3782); 15 Jul 2023 11:38:14 +0200 Received: from acm.muc.de (pd953a5ce.dip0.t-ipconnect.de [217.83.165.206]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 15 Jul 2023 11:38:14 +0200 Received: (qmail 16790 invoked by uid 1000); 15 Jul 2023 09:38:13 -0000 Date: Sat, 15 Jul 2023 09:38:13 +0000 To: bug-gnu-emacs@gnu.org Subject: 29.0.92; Native compiler doesn't compile dynamically bound functions. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hello, Emacs. In the Emacs 29 pretest version (or the master version): (i) emacs -Q (ii) C-x b foo.el (iii) M-x emacs-lisp-mode Don't set lexical-binding in this buffer. (iv) Enter a function called foo: (defun foo () "foo doc string" (lambda (bar) "lambda doc string" (car bar))) (v) With point after the function, evaluate it with C-x C-e. (vi) M-: (native-compile 'foo) This signals an error, native-compiler-error-dyn-func. This is a bug. ######################################################################### The immediate cause of the bug is in the version of comp-spill-lap-function which processes named functions (comp.el). Unlike the other version of the cl-defmethod (which processes lambda functions), there is no code for dynamic functions here. If the intention is not to process dynamic functions, this should be indicated by an error message rather than a signal. Personally, I feel that dynamic functions ought to be handled in Emacs-29. Fixing this bug should be relatively straightforward, since it should only involve copying and adapting the corresponding code in the lambda version of comp-spill-lap-function. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 05:53:40 2023 Received: (at 64642) by debbugs.gnu.org; 15 Jul 2023 09:53:40 +0000 Received: from localhost ([127.0.0.1]:44202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKby7-00050o-S5 for submit@debbugs.gnu.org; Sat, 15 Jul 2023 05:53:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKby4-00050X-D4 for 64642@debbugs.gnu.org; Sat, 15 Jul 2023 05:53:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbxy-00030K-Hd; Sat, 15 Jul 2023 05:53:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=K1/Z5r3zB3m8szju7dleXij6dhwhUyondAQDDGRY10Y=; b=EJE66AeipNIk neKkn46RSgbZPotG1jascv9TLs1kiv28ISHwascJz2X2DmBmemUVgJTeosOrcB4k3btzdOJmns/yn xLdTbaU+XyErdL5xwbObfg4zf9Y8FTFCl1wTuCqaNzXKJlTos4AbdEGeizTPsXLXOBDO/uAQwMQQb HgNjgm3JQl0O+d1HDRG5vorH7gkxNyYfUMc8u1CRvYubDd1MvE55ge5b91qIn8cE8ulKKWgflJDkf Av/S2suM08P60j0IG8X/SkDfxrlyRSAkTEyKC66l3IHM/AwiRDIvAQ0uxgwwN3zeRUhyqmS1ChGUh KjGtWKgMUauA6/6TFjzzzA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbxy-0005UM-0y; Sat, 15 Jul 2023 05:53:30 -0400 Date: Sat, 15 Jul 2023 12:53:51 +0300 Message-Id: <838rbhcxg0.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie , Andrea Corallo In-Reply-To: (message from Alan Mackenzie on Sat, 15 Jul 2023 09:38:13 +0000) Subject: Re: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64642 Cc: 64642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 15 Jul 2023 09:38:13 +0000 > From: Alan Mackenzie > > Hello, Emacs. > > In the Emacs 29 pretest version (or the master version): > (i) emacs -Q > (ii) C-x b foo.el > (iii) M-x emacs-lisp-mode > Don't set lexical-binding in this buffer. > (iv) Enter a function called foo: > (defun foo () "foo doc string" > (lambda (bar) "lambda doc string" (car bar))) > (v) With point after the function, evaluate it with C-x C-e. > > (vi) M-: (native-compile 'foo) > This signals an error, native-compiler-error-dyn-func. This is a bug. > > ######################################################################### > > The immediate cause of the bug is in the version of > comp-spill-lap-function which processes named functions (comp.el). > Unlike the other version of the cl-defmethod (which processes lambda > functions), there is no code for dynamic functions here. > > If the intention is not to process dynamic functions, this should be > indicated by an error message rather than a signal. Personally, I feel > that dynamic functions ought to be handled in Emacs-29. > > Fixing this bug should be relatively straightforward, since it should > only involve copying and adapting the corresponding code in the lambda > version of comp-spill-lap-function. Adding Andrea. It is unlikely that this will be fixed in Emacs 29, unless the fix is so simple that will surprise me. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 11:17:29 2023 Received: (at 64642) by debbugs.gnu.org; 15 Jul 2023 15:17:29 +0000 Received: from localhost ([127.0.0.1]:45787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKh1V-0002uZ-8l for submit@debbugs.gnu.org; Sat, 15 Jul 2023 11:17:29 -0400 Received: from mx3.muc.de ([193.149.48.5]:43492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKh1T-0002uL-8Q for 64642@debbugs.gnu.org; Sat, 15 Jul 2023 11:17:28 -0400 Received: (qmail 36935 invoked by uid 3782); 15 Jul 2023 17:17:20 +0200 Received: from acm.muc.de (pd953a5ce.dip0.t-ipconnect.de [217.83.165.206]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 15 Jul 2023 17:17:20 +0200 Received: (qmail 28041 invoked by uid 1000); 15 Jul 2023 15:17:20 -0000 Date: Sat, 15 Jul 2023 15:17:20 +0000 To: Eli Zaretskii , Andrea Corallo Subject: Re: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. Message-ID: References: <838rbhcxg0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838rbhcxg0.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64642 Cc: 64642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli and Andrea. On Sat, Jul 15, 2023 at 12:53:51 +0300, Eli Zaretskii wrote: > > Date: Sat, 15 Jul 2023 09:38:13 +0000 > > From: Alan Mackenzie > > Hello, Emacs. > > In the Emacs 29 pretest version (or the master version): > > (i) emacs -Q > > (ii) C-x b foo.el > > (iii) M-x emacs-lisp-mode > > Don't set lexical-binding in this buffer. > > (iv) Enter a function called foo: > > (defun foo () "foo doc string" > > (lambda (bar) "lambda doc string" (car bar))) > > (v) With point after the function, evaluate it with C-x C-e. > > (vi) M-: (native-compile 'foo) > > This signals an error, native-compiler-error-dyn-func. This is a bug. > > ######################################################################### > > The immediate cause of the bug is in the version of > > comp-spill-lap-function which processes named functions (comp.el). > > Unlike the other version of the cl-defmethod (which processes lambda > > functions), there is no code for dynamic functions here. > > If the intention is not to process dynamic functions, this should be > > indicated by an error message rather than a signal. Personally, I feel > > that dynamic functions ought to be handled in Emacs-29. > > Fixing this bug should be relatively straightforward, since it should > > only involve copying and adapting the corresponding code in the lambda > > version of comp-spill-lap-function. > Adding Andrea. > It is unlikely that this will be fixed in Emacs 29, unless the fix is > so simple that will surprise me. Here is a fix. Its simplicity probably doesn't surprise you (Eli), but the change is entirely within one function, and a lot of the patch is just whitespace changes. There are no problems running make bootstrap or make check with patch in place. It also solves the bug; unless there are good reasons dynamically bound functions weren't handled. Andrea? diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 322df0e86a1..3e0725cef4f 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -1274,33 +1274,45 @@ comp-spill-lap-function (make-temp-file (comp-c-func-name function-name "freefn-") nil ".eln"))) (let* ((f (symbol-function function-name)) + (byte-code (byte-compile function-name)) (c-name (comp-c-func-name function-name "F")) - (func (make-comp-func-l :name function-name - :c-name c-name - :doc (documentation f t) - :int-spec (interactive-form f) - :command-modes (command-modes f) - :speed (comp-spill-speed function-name) - :pure (comp-spill-decl-spec function-name - 'pure)))) + (func + (if (comp-lex-byte-func-p byte-code) + (make-comp-func-l :name function-name + :c-name c-name + :doc (documentation f t) + :int-spec (interactive-form f) + :command-modes (command-modes f) + :speed (comp-spill-speed function-name) + :pure (comp-spill-decl-spec function-name + 'pure)) + (make-comp-func-d :name function-name + :c-name c-name + :doc (documentation f t) + :int-spec (interactive-form f) + :command-modes (command-modes f) + :speed (comp-spill-speed function-name) + :pure (comp-spill-decl-spec function-name + 'pure))))) (when (byte-code-function-p f) (signal 'native-compiler-error "can't native compile an already byte-compiled function")) - (setf (comp-func-byte-func func) - (byte-compile (comp-func-name func))) + (setf (comp-func-byte-func func) byte-code) (let ((lap (byte-to-native-lambda-lap (gethash (aref (comp-func-byte-func func) 1) byte-to-native-lambdas-h)))) (cl-assert lap) (comp-log lap 2 t) - (let ((arg-list (aref (comp-func-byte-func func) 0))) - (setf (comp-func-l-args func) - (comp-decrypt-arg-list arg-list function-name) - (comp-func-lap func) - lap - (comp-func-frame-size func) - (comp-byte-frame-size (comp-func-byte-func func)))) - (setf (comp-ctxt-top-level-forms comp-ctxt) + (if (comp-func-l-p func) + (let ((arg-list (aref (comp-func-byte-func func) 0))) + (setf (comp-func-l-args func) + (comp-decrypt-arg-list arg-list function-name))) + (setf (comp-func-d-lambda-list func) (cadr f))) + (setf (comp-func-lap func) + lap + (comp-func-frame-size func) + (comp-byte-frame-size (comp-func-byte-func func)) + (comp-ctxt-top-level-forms comp-ctxt) (list (make-byte-to-native-func-def :name function-name :c-name c-name))) (comp-add-func-to-ctxt func)))) -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 09:42:40 2023 Received: (at 64642) by debbugs.gnu.org; 17 Jul 2023 13:42:40 +0000 Received: from localhost ([127.0.0.1]:49524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLOUq-0005hG-14 for submit@debbugs.gnu.org; Mon, 17 Jul 2023 09:42:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLOUn-0005h0-RC for 64642@debbugs.gnu.org; Mon, 17 Jul 2023 09:42:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLOUi-0000MQ-1u; Mon, 17 Jul 2023 09:42:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=EDg5cc7VatxtCy3gAj2MsTW/EolelNmwVM0gmH/G3qs=; b=ZIMVH9an+/iYd5DoPx5W /6qo5EbjuAMq6KBoOR37XB+FrhbsZdyZ7sEuDSgV/WiU6wbW2rihPZbFyhlvL6Pyb+pMtMZ0S7+My cLt603Cdj20YH7HAo/cu1StpW0Jde14PB6fU946PRjYgvAHphXK/e36Lq5RmRFcODK8FYCMBRPluz Gl/BnzjtGfSSSOeeWecJW7At+JyV7rqCBoO4gE4E7btZxTw54ZDOKsTpeDksJ9hvqsP6iwxEwpt33 gDrVJRQgL7lTJ3FsiMVHcysIww9WrVLnAcFLiLfNNvQdyToksuFzX2uNR4l0+SjA2zw4kpSJzLQsJ MjEDCh6O9MI65Q==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qLOUh-0002QT-Dx; Mon, 17 Jul 2023 09:42:31 -0400 From: Andrea Corallo To: Alan Mackenzie Subject: Re: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. In-Reply-To: (Alan Mackenzie's message of "Sat, 15 Jul 2023 15:17:20 +0000") References: <838rbhcxg0.fsf@gnu.org> Date: Mon, 17 Jul 2023 09:42:31 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64642 Cc: Eli Zaretskii , 64642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Alan Mackenzie writes: > Hello, Eli and Andrea. > > On Sat, Jul 15, 2023 at 12:53:51 +0300, Eli Zaretskii wrote: >> > Date: Sat, 15 Jul 2023 09:38:13 +0000 >> > From: Alan Mackenzie > >> > Hello, Emacs. > >> > In the Emacs 29 pretest version (or the master version): >> > (i) emacs -Q >> > (ii) C-x b foo.el >> > (iii) M-x emacs-lisp-mode >> > Don't set lexical-binding in this buffer. >> > (iv) Enter a function called foo: >> > (defun foo () "foo doc string" >> > (lambda (bar) "lambda doc string" (car bar))) >> > (v) With point after the function, evaluate it with C-x C-e. > >> > (vi) M-: (native-compile 'foo) >> > This signals an error, native-compiler-error-dyn-func. This is a bug. > >> > ######################################################################### > >> > The immediate cause of the bug is in the version of >> > comp-spill-lap-function which processes named functions (comp.el). >> > Unlike the other version of the cl-defmethod (which processes lambda >> > functions), there is no code for dynamic functions here. > >> > If the intention is not to process dynamic functions, this should be >> > indicated by an error message rather than a signal. Personally, I feel >> > that dynamic functions ought to be handled in Emacs-29. > >> > Fixing this bug should be relatively straightforward, since it should >> > only involve copying and adapting the corresponding code in the lambda >> > version of comp-spill-lap-function. > >> Adding Andrea. > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is >> so simple that will surprise me. > > Here is a fix. Its simplicity probably doesn't surprise you (Eli), but > the change is entirely within one function, and a lot of the patch is > just whitespace changes. > > There are no problems running make bootstrap or make check with patch in > place. It also solves the bug; unless there are good reasons dynamically > bound functions weren't handled. Andrea? Hi Alan, the fix LGTM thanks for the patch, I think we only need to add a test as well to exercise this code, something like the "free-fun" test in comp-tests.el. Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 12:06:44 2023 Received: (at 64642) by debbugs.gnu.org; 17 Jul 2023 16:06:44 +0000 Received: from localhost ([127.0.0.1]:50798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLQkG-0001JG-2G for submit@debbugs.gnu.org; Mon, 17 Jul 2023 12:06:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLQkB-0001Iw-Ha for 64642@debbugs.gnu.org; Mon, 17 Jul 2023 12:06:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLQk5-0004r5-0E; Mon, 17 Jul 2023 12:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0eWSVBlfbfnFKR5J8/ECDH9bD0AgUwx7C2xzc03ZUEE=; b=Rc/SJcCIu8sU 9MT9qcNkSTGeNh4WJtWcPdxggDq0drNhBn/rviC7G4/snLf6Y0EagCFE4UHxGQKyUsn0/PA4XD9wh rcLTJZvxt4c4miwYwetpgroeLWUaKBGzPDv1ClqYlqxsorFwMxRy9DSKSpvWD34S6sf5hNY8SO+KN Hbyetka/GX9zUAr4QJcDAQAi/QOA3o52sjQ3uKwHLXgF6brEWn6RYFjnn6yHI9uUdIeUoYia7qd0K QfWIdn8aiDhu/07itFrs8tFjgSWCVftc84i/waANeLFm0Py+bAdDSjQp/auozQBO6ZBObWg3SgM6S ftTUp6zw5e8x8OUopWfNWQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLQk3-0005Yk-Kn; Mon, 17 Jul 2023 12:06:32 -0400 Date: Mon, 17 Jul 2023 19:06:58 +0300 Message-Id: <83v8ei7c9p.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Mon, 17 Jul 2023 09:42:31 -0400) Subject: Re: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. References: <838rbhcxg0.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64642 Cc: acm@muc.de, 64642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: Eli Zaretskii , 64642@debbugs.gnu.org > Date: Mon, 17 Jul 2023 09:42:31 -0400 > > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is > >> so simple that will surprise me. > > > > Here is a fix. Its simplicity probably doesn't surprise you (Eli), but > > the change is entirely within one function, and a lot of the patch is > > just whitespace changes. > > > > There are no problems running make bootstrap or make check with patch in > > place. It also solves the bug; unless there are good reasons dynamically > > bound functions weren't handled. Andrea? > > Hi Alan, > > the fix LGTM thanks for the patch, I think we only need to add a test as > well to exercise this code, something like the "free-fun" test in > comp-tests.el. Alan, when the patch is ready, please install on master. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 13:43:37 2023 Received: (at 64642) by debbugs.gnu.org; 17 Jul 2023 17:43:37 +0000 Received: from localhost ([127.0.0.1]:50859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLSG0-0003n6-Oc for submit@debbugs.gnu.org; Mon, 17 Jul 2023 13:43:36 -0400 Received: from mx3.muc.de ([193.149.48.5]:19711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLSFx-0003mi-J2 for 64642@debbugs.gnu.org; Mon, 17 Jul 2023 13:43:35 -0400 Received: (qmail 39756 invoked by uid 3782); 17 Jul 2023 19:43:27 +0200 Received: from acm.muc.de (p4fe15519.dip0.t-ipconnect.de [79.225.85.25]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 17 Jul 2023 19:43:27 +0200 Received: (qmail 3268 invoked by uid 1000); 17 Jul 2023 17:43:26 -0000 Date: Mon, 17 Jul 2023 17:43:26 +0000 To: Eli Zaretskii Subject: Re: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. Message-ID: References: <838rbhcxg0.fsf@gnu.org> <83v8ei7c9p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83v8ei7c9p.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64642 Cc: Andrea Corallo , 64642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Mon, Jul 17, 2023 at 19:06:58 +0300, Eli Zaretskii wrote: > > From: Andrea Corallo > > Cc: Eli Zaretskii , 64642@debbugs.gnu.org > > Date: Mon, 17 Jul 2023 09:42:31 -0400 > > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is > > >> so simple that will surprise me. > > > Here is a fix. Its simplicity probably doesn't surprise you (Eli), but > > > the change is entirely within one function, and a lot of the patch is > > > just whitespace changes. > > > There are no problems running make bootstrap or make check with patch in > > > place. It also solves the bug; unless there are good reasons dynamically > > > bound functions weren't handled. Andrea? > > Hi Alan, > > the fix LGTM thanks for the patch, I think we only need to add a test as > > well to exercise this code, something like the "free-fun" test in > > comp-tests.el. > Alan, when the patch is ready, please install on master. I'll do that, "ready" meaning when I've written that test suggested by Andrea. Thanks! > Thanks. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 19 07:31:24 2023 Received: (at 64642-done) by debbugs.gnu.org; 19 Jul 2023 11:31:24 +0000 Received: from localhost ([127.0.0.1]:55084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qM5Ot-0005NE-Sk for submit@debbugs.gnu.org; Wed, 19 Jul 2023 07:31:24 -0400 Received: from mx3.muc.de ([193.149.48.5]:12483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qM5Oq-0005Mx-JF for 64642-done@debbugs.gnu.org; Wed, 19 Jul 2023 07:31:21 -0400 Received: (qmail 86323 invoked by uid 3782); 19 Jul 2023 13:31:14 +0200 Received: from acm.muc.de (p4fe159a7.dip0.t-ipconnect.de [79.225.89.167]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 19 Jul 2023 13:31:14 +0200 Received: (qmail 6039 invoked by uid 1000); 19 Jul 2023 11:31:14 -0000 Date: Wed, 19 Jul 2023 11:31:14 +0000 To: Eli Zaretskii Subject: Re: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. Message-ID: References: <838rbhcxg0.fsf@gnu.org> <83v8ei7c9p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83v8ei7c9p.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64642-done Cc: acm@muc.de, Andrea Corallo , 64642-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Mon, Jul 17, 2023 at 19:06:58 +0300, Eli Zaretskii wrote: > > From: Andrea Corallo > > Cc: Eli Zaretskii , 64642@debbugs.gnu.org > > Date: Mon, 17 Jul 2023 09:42:31 -0400 > > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is > > >> so simple that will surprise me. > > > Here is a fix. Its simplicity probably doesn't surprise you (Eli), but > > > the change is entirely within one function, and a lot of the patch is > > > just whitespace changes. > > > There are no problems running make bootstrap or make check with patch in > > > place. It also solves the bug; unless there are good reasons dynamically > > > bound functions weren't handled. Andrea? > > Hi Alan, > > the fix LGTM thanks for the patch, I think we only need to add a test as > > well to exercise this code, something like the "free-fun" test in > > comp-tests.el. > Alan, when the patch is ready, please install on master. DONE. I'm closing the bug with this post. > Thanks. -- Alan Mackenzie (Nuremberg, Germany). From unknown Sun Sep 07 21:36:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Aug 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator