GNU bug report logs - #64636
30.0.50; sgml-electric-tag-pair-before-change-function: Two calls to `message' should be removed

Previous Next

Package: emacs;

Reported by: Matt Beshara <m <at> mfa.pw>

Date: Sat, 15 Jul 2023 06:09:02 UTC

Severity: normal

Found in version 30.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64636 in the body.
You can then email your comments to 64636 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#64636; Package emacs. (Sat, 15 Jul 2023 06:09:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Matt Beshara <m <at> mfa.pw>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 15 Jul 2023 06:09:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Beshara <m <at> mfa.pw>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; sgml-electric-tag-pair-before-change-function: Two calls
 to `message' should be removed
Date: Sat, 15 Jul 2023 16:05:52 +1000

In the function `sgml-electric-tag-pair-before-change-function' in 
sgml-mode.el around line 1000, there are a couple of calls to 
`message' which seem like debugging code which was left in 
accidentally.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#64636; Package emacs. (Sat, 15 Jul 2023 08:46:02 GMT) Full text and rfc822 format available.

Message #8 received at 64636 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Matt Beshara <m <at> mfa.pw>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 64636 <at> debbugs.gnu.org
Subject: Re: bug#64636: 30.0.50;
 sgml-electric-tag-pair-before-change-function: Two calls to `message'
 should be removed
Date: Sat, 15 Jul 2023 11:45:32 +0300

> From: Matt Beshara <m <at> mfa.pw>
> Date: Sat, 15 Jul 2023 16:05:52 +1000
> 
> In the function `sgml-electric-tag-pair-before-change-function' in 
> sgml-mode.el around line 1000, there are a couple of calls to 
> `message' which seem like debugging code which was left in 
> accidentally.

Thanks.

Stefan, you added those calls 16 years ago: are they for debugging or
do they need to stay there?
Reply sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
You have taken responsibility. (Sat, 15 Jul 2023 15:43:02 GMT) Full text and rfc822 format available.
Notification sent to Matt Beshara <m <at> mfa.pw>:
bug acknowledged by developer. (Sat, 15 Jul 2023 15:43:02 GMT) Full text and rfc822 format available.

Message #13 received at 64636-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Matt Beshara <m <at> mfa.pw>, 64636-done <at> debbugs.gnu.org
Subject: Re: bug#64636: 30.0.50;
 sgml-electric-tag-pair-before-change-function: Two calls to `message'
 should be removed
Date: Sat, 15 Jul 2023 11:42:24 -0400

> Stefan, you added those calls 16 years ago: are they for debugging or
> do they need to stay there?

Oops.  Thanks, I just removed them.


        Stefan
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#64636; Package emacs. (Sat, 15 Jul 2023 15:56:01 GMT) Full text and rfc822 format available.

Message #16 received at 64636 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: m <at> mfa.pw, 64636 <at> debbugs.gnu.org
Subject: Re: bug#64636: 30.0.50;
 sgml-electric-tag-pair-before-change-function: Two calls to `message'
 should be removed
Date: Sat, 15 Jul 2023 18:55:03 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Matt Beshara <m <at> mfa.pw>,  64636-done <at> debbugs.gnu.org
> Date: Sat, 15 Jul 2023 11:42:24 -0400
> 
> > Stefan, you added those calls 16 years ago: are they for debugging or
> > do they need to stay there?
> 
> Oops.  Thanks, I just removed them.

Thanks!
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 13 Aug 2023 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 24 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.