GNU bug report logs - #64619
[PATCH] Add toggle-window-dedicated command

Previous Next

Full log

View this message in rfc822 format

From: Gregory Heytings <gregory <at> heytings.org>
To: sbaugh <at> catern.com
Cc: Spencer Baugh <sbaugh <at> janestreet.com>, Philip Kaludercic <philipk <at> posteo.net>, 64619 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>
Subject: bug#64619: [PATCH] Add toggle-window-dedicated command
Date: Sat, 19 Aug 2023 16:43:15 +0000

>> OK, this patch adds support for making the buffer strongly dedicated 
>> with a prefix argument, and also adds an indicator to the mode line of 
>> whether the current window is dedicated (which seems useful even if we 
>> don't apply the toggle part of this patch).
>
> Any thoughts on this patch?
>

Two thoughs:

1. I would simplify the body of toggle-window-dedicated, using

(set-window-dedicated-p window (not (window-dedicated-p)))

This makes the window "strongly" dedicated, which is more in line with 
what "Window will now display only its current buffer" promises (e.g. C-x 
b will refuse to switch to another buffer).

2. I would not bind it to the "d" key but to the "!" key: ISTM that 
toggling window dedication is not such a common action that it needs a 
letter key binding.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.