Subject: bug#64602: closed (Re: bug#64602: 28.2; [PATCH] Remove outdated FIXME)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 14 Jul 2023 05:34:02 +0000

Your bug report

#64602: 28.2; [PATCH] Remove outdated FIXME

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
64602: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64602
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#64602: 28.2; [PATCH] Remove outdated FIXME
From: Eli Zaretskii <[email-masked]>
To: YE <[email-masked]>
Cc: [email-masked]
Date: Fri, 14 Jul 2023 08:33:44 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> Date: Thu, 13 Jul 2023 23:02:52 +0300
> From:  YE via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> This removes FIXME that suggests to use 'define-derived-mode'. The
> latter has been in place for 2 years now (since b39b5647).

Thanks, installed on the emacs-29 branch, and closing the bug.

Subject: 28.2; [PATCH] Remove outdated FIXME
From: YE <[email-masked]>
To: [email-masked]
Date: Thu, 13 Jul 2023 23:02:52 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

This removes FIXME that suggests to use 'define-derived-mode'. The
latter has been in place for 2 years now (since b39b5647).

>From abc929437b8b96d3e8d8d1e7eba1bacefcd84e6e Mon Sep 17 00:00:00 2001
From: YugaEgo <[email-masked]>
Date: Thu, 13 Jul 2023 22:50:27 +0300
Subject: [PATCH] ; * lisp/progmodes/sql.el (sql-interactive-mode): Remove
 FIXME

---
 lisp/progmodes/sql.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index c6667c075f6..89d62ab3a61 100644
--- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -4200,7 +4200,7 @@ must tell Emacs.  Here's how to do that in your init file:
 
 (put 'sql-interactive-mode 'mode-class 'special)
 (put 'sql-interactive-mode 'custom-mode-group 'SQL)
-;; FIXME: Why not use `define-derived-mode'?
+
 (define-derived-mode sql-interactive-mode comint-mode "SQLi[?]"
   "Major mode to use a SQL interpreter interactively.
 
-- 
2.39.2 (Apple Git-143)