From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 13 16:03:35 2023 Received: (at submit) by debbugs.gnu.org; 13 Jul 2023 20:03:35 +0000 Received: from localhost ([127.0.0.1]:40910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK2XG-0004wB-Hr for submit@debbugs.gnu.org; Thu, 13 Jul 2023 16:03:35 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK2XA-0004vt-Gu for submit@debbugs.gnu.org; Thu, 13 Jul 2023 16:03:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK2X4-0005N2-7j for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 16:03:22 -0400 Received: from out-19.mta1.migadu.com ([2001:41d0:203:375::13]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK2X0-0000n3-TO for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 16:03:21 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ego.team; s=key1; t=1689278594; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=7rmrYyNKNMzCGMTBwMNW0LqMIGEqvL0cQUch/PIY56o=; b=T0NrvzHOcCZ3LKKcQNM13o3U2PtBheVlf0O8efcHHZRS0mNFDOEt2/MUhnRlqKXkuBy7gK 1ShaNuME2sZQ5vMWz3e4g5bFaFUpHb4XbeGqoGw73MSeuweCV3jJ8OxQkuw9YpWA0pYGuV vS/A8wVzx2v1e5gSJSUf9W9i/eVuWeo= From: YE To: bug-gnu-emacs@gnu.org Subject: 28.2; [PATCH] Remove outdated FIXME Date: Thu, 13 Jul 2023 23:02:52 +0300 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::13; envelope-from=yet@ego.team; helo=out-19.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: YE Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain This removes FIXME that suggests to use 'define-derived-mode'. The latter has been in place for 2 years now (since b39b5647). --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-progmodes-sql.el-sql-interactive-mode-Remove-FI.patch Content-Description: Remove outdated FIXME >From abc929437b8b96d3e8d8d1e7eba1bacefcd84e6e Mon Sep 17 00:00:00 2001 From: YugaEgo Date: Thu, 13 Jul 2023 22:50:27 +0300 Subject: [PATCH] ; * lisp/progmodes/sql.el (sql-interactive-mode): Remove FIXME --- lisp/progmodes/sql.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index c6667c075f6..89d62ab3a61 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -4200,7 +4200,7 @@ must tell Emacs. Here's how to do that in your init file: (put 'sql-interactive-mode 'mode-class 'special) (put 'sql-interactive-mode 'custom-mode-group 'SQL) -;; FIXME: Why not use `define-derived-mode'? + (define-derived-mode sql-interactive-mode comint-mode "SQLi[?]" "Major mode to use a SQL interpreter interactively. -- 2.39.2 (Apple Git-143) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 14 01:33:40 2023 Received: (at 64602-done) by debbugs.gnu.org; 14 Jul 2023 05:33:40 +0000 Received: from localhost ([127.0.0.1]:41336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKBQy-0000WI-7s for submit@debbugs.gnu.org; Fri, 14 Jul 2023 01:33:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKBQs-0000Vt-PV for 64602-done@debbugs.gnu.org; Fri, 14 Jul 2023 01:33:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKBQk-00066s-OD; Fri, 14 Jul 2023 01:33:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AprCZxUF1t3Eb875BVYpo+noClXiKErZfznayuo9DHk=; b=D5zwCjbWYlzI iCG+DDJ6OUC2X/FPuMBZXI/qgCRU7tBZgCpft4pIRM2HUu4qMkEtCCndJriuAMdQhSUW1UX89M5Wo Ne4e2eB6mtENPJspiZErHTOJPnbXJ70zp5kmFOTqOfVqi7R7KLwWZDjXa9/8zN29z0uN8Kn2NatYy qyfbsy1BtHQh7Y3Cc5Qum4jkPvoiU9uEP9WjC7GXDy8KLTGKC+4G8ADSfTosDag8Rdr9wJWUSZvUX KX5NSO/InUIMj4MPEkDlu22qQa1ReZb3ZPvy1yHWOpO8vZH+URV4iyO6AtZJsyNP5RZa3lrc61vzz gcteKHeA8AfJ/JIvQk6YxQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKBQk-00038x-6I; Fri, 14 Jul 2023 01:33:26 -0400 Date: Fri, 14 Jul 2023 08:33:44 +0300 Message-Id: <83ilan3vlz.fsf@gnu.org> From: Eli Zaretskii To: YE In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#64602: 28.2; [PATCH] Remove outdated FIXME References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64602-done Cc: 64602-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 13 Jul 2023 23:02:52 +0300 > From: YE via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This removes FIXME that suggests to use 'define-derived-mode'. The > latter has been in place for 2 years now (since b39b5647). Thanks, installed on the emacs-29 branch, and closing the bug. From unknown Mon Aug 18 04:43:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 11 Aug 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator