GNU bug report logs - #64596
30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update)

Previous Next

Full log

View this message in rfc822 format

From: Ihor Radchenko <yantar92 <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: monnier <at> iro.umontreal.ca, 64596 <at> debbugs.gnu.org
Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update)
Date: Sat, 15 Jul 2023 07:22:59 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

> What we do need is to make some better order out of these flags,
> understand better what does each one of them tell the display engine,
> and perhaps make some of them more selective.  And we need to document
> these understandings.

I agree.
From my recent reading of the commentary in xdisp.c, one apparently
missing summary is which window and frame components are considered by
the redisplay code.

"Glyph rows." section in the top comment talk about margins + text area,
but the real redisplay_internal appears to consider (1) title bars; (2)
menu bars; (3) header line; (4) tab line; (5) mode-line; (6) window
text; (7) echo area (which is treated specially).

> ....  But I will not agree to
> random poking at this or that particular flag, unless there's
> convincing evidence that it causes a display bug or a significant
> performance problem.  Because otherwise making changes in code that we
> don't sufficiently understand can only cause bugs, and guess who gets
> to work on fixing them.

That's understandable.
But the general idea of having some kind of "experimental" flag might be
still useful in other situations. Not necessarily redisplay.
Of course, such experiments should be still weighed carefully.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.