GNU bug report logs - #64596
30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update)

Previous Next

Full log

Message #164 received at 64596 <at> debbugs.gnu.org (full text, mbox):

From: Ihor Radchenko <yantar92 <at> posteo.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 64596 <at> debbugs.gnu.org
Subject: Re: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481
 (force-mode-line-update)
Date: Sun, 16 Jul 2023 10:38:14 +0000

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> -/* Non-zero if we should redraw the mode lines on the next redisplay.
> +/* Non-zero if we should redraw the mode line*s* on the next redisplay.
>     Usually set to a unique small integer so we can track the main causes of
> -   full redisplays in `redisplay--mode-lines-cause'.  */
> +   full redisplays in `redisplay--mode-lines-cause'.
> +   Here "mode lines" includes also header-lines and frame names, and
> +   apparently also menu-bars.  The link with header-lines is clear,
> +   but a bit less so for frame names and the menu-bar.  */

It would be even better if *-mode-lines functions were renamed to
something more explicit. It is very disorienting that "mode-line" may
mean actual mode-line, but sometimes more than that.
A clarifying comment is an improvement, but does not make the code in
other places more readable.

Maybe use a term like "info-lines" to avoid confusion of using the same
term for multiple different meanings?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.