GNU bug report logs - #64595
30.0.50; 13-years old commented code in src/data.c:1608 (set_internal)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ihor Radchenko <yantar92 <at> posteo.net>
Subject: bug#64595: closed (Re: bug#64595: 30.0.50; 13-years old commented
 code in src/data.c:1608 (set_internal))
Date: Tue, 05 Sep 2023 06:13:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#64595: 30.0.50; 13-years old commented code in src/data.c:1608 (set_internal)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 64595 <at> debbugs.gnu.org.

-- 
64595: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64595
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Ihor Radchenko <yantar92 <at> posteo.net>, 64595-done <at> debbugs.gnu.org
Subject: Re: bug#64595: 30.0.50; 13-years old commented code in
 src/data.c:1608 (set_internal)
Date: Mon, 4 Sep 2023 23:12:47 -0700

Version: 30.1

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

>>> I assume that after 13 years, it is safe to remove it.
>
> :-)
>
>> Stefan?
>
> Of course,

Thanks, done.

[Message part 3 (message/rfc822, inline)]

From: Ihor Radchenko <yantar92 <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; 13-years old commented code in src/data.c:1608 (set_internal)
Date: Thu, 13 Jul 2023 12:31:03 +0000

Hello,

While reading the sources, I found the following commented piece of
code in set_internal:

  /* If restoring in a dead buffer, do nothing.  */
  /* if (BUFFERP (where) && NILP (XBUFFER (where)->name))
      return; */

This code has been changed 13 years ago and also commented immediately
(in the same commit):

94b612ad880e0d6eab6659347cb66e3a5310f8be
Author:     Stefan Monnier <monnier <at> iro.umontreal.ca>
AuthorDate: Fri May 7 16:33:00 2010 -0400

Try and fix unbind_to when localness of binding has changed
* eval.c (unbind_to): Don't unbind a local binding into the global
binding when the local binding disappeared.  Inversely, don't unbind
a global binding into a newly created local binding.
* data.c (set_internal): Make its `buf' arg into a `where' arg so we
can specify the frame to use, when applicable.  Adjust callers.

-  if (buf == 0)
-    buf = current_buffer;
-
   /* If restoring in a dead buffer, do nothing.  */
-  if (NILP (buf->name))
-    return;
+  /* if (BUFFERP (where) && NILP (XBUFFER (where)->name))
+      return; */

I assume that after 13 years, it is safe to remove it.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-07-06 built on localhost
Repository revision: d97b77e6c66db46b198c696f83458aa141794727
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: Gentoo Linux

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.