From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 13 00:37:21 2023 Received: (at submit) by debbugs.gnu.org; 13 Jul 2023 04:37:21 +0000 Received: from localhost ([127.0.0.1]:53135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJo4v-0002FU-2o for submit@debbugs.gnu.org; Thu, 13 Jul 2023 00:37:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:38904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJo4s-0002FM-PW for submit@debbugs.gnu.org; Thu, 13 Jul 2023 00:37:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJo4s-0004Qw-An for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 00:37:18 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJo4j-0006Xb-WB for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 00:37:18 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b71ae5fa2fso3135531fa.0 for ; Wed, 12 Jul 2023 21:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689223027; x=1691815027; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=diMCLtSHPMM+m9pwwFL8VQZ5D4yxSFamuRE+jP/aFYs=; b=JC/9z5CZ8IfSQ20OHSeYUPCGq0NqT+SAO12SSsw3VdszA95Q1MP1QhUM2iqEi8wCPC YuB2V2tf5UGt/M/f3cMimS+Nkmpg5W+5fKEoNb5QcFLHROPiBaNC99O0pAN987LU4XjA tpiEegiHvhuqOOsSmO46V6UCXvkN+ZZKKFTkyyuSibBNYuGuWuc6TItoVZLIPGUWnWqD 67A0qhlqGhJycYmZjzLwsJIV31DxU5FMnqyYCi81dCWPKGSnGyxzBnTbzm+dJ8jiMyUX 0/+jf2Ms/YBit6hxEaA9F+kPjafNwHf3u5w35gnNSNMPBq6iLQ7PvTaMeM9f7nVpRiTi pVmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689223027; x=1691815027; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=diMCLtSHPMM+m9pwwFL8VQZ5D4yxSFamuRE+jP/aFYs=; b=BXwZPLRa/eTl2/gOuZZ1ZqOR0ePdK43iS1zyimprwM0/CfbedshGpia9xA5UgCMlge RhRzdghW6o6y2QUrDhySkUGdGsOVo+8jwX3ne+S/S1d5naV/twJbU5cu3Tq3yLTeO7de /IaYFH8tj1wDKvH1TcVufMaqAy07eQwYHoFTKeqyf9mkvvpVDuW4ZBkopwWrCyTbS9UE wxRZ5OCGAdFQJth1yKTWJSFhuE7FSn7j1cWrGKuG1gMt/aNgurlpqxKaA5ITvn3TpFtp ZWNjG27GMe4QoINd7WMRiyXosIQVCMih9S1OEmPTKRrA7lIe7XpmEftxSIOtjAqPT3fL xvlg== X-Gm-Message-State: ABy/qLYco9227qPiHzQgsauEMVatb4nWjh5d5+1roHTe9NR879K/FSOL waXULm3IuPGqs5XgEcKgJyKlmGjkyd9Bu9D5dKyofZfvpz//ttYF X-Google-Smtp-Source: APBJJlEYFHyzEpRqf+AfKvQSST7hi1Qq8OOOAWhWQ+gEE19vCb6dwltSObi1nsMHvH/ib7I980ld54zFSUl23nWdt08= X-Received: by 2002:a2e:3315:0:b0:2b6:fa8d:ff91 with SMTP id d21-20020a2e3315000000b002b6fa8dff91mr382246ljc.3.1689223027287; Wed, 12 Jul 2023 21:37:07 -0700 (PDT) MIME-Version: 1.0 From: Wang Diancheng Date: Thu, 13 Jul 2023 12:40:58 +0800 Message-ID: Subject: Patch: fix gud-go in gdb-mi.el To: bug-gnu-emacs Content-Type: multipart/mixed; boundary="0000000000007cff58060056e2d0" Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=dianchengwang@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000007cff58060056e2d0 Content-Type: text/plain; charset="UTF-8" Hi, document of gud-go says "Start or continue execution. Use a prefix to specify arguments." but it always prompts for program arguments regardless of whether "C-u" is pressed because arg is numeric prefix here. The attachment is a patch to change gud-go just prompts if prefix is not 1. --0000000000007cff58060056e2d0 Content-Type: text/x-patch; charset="US-ASCII"; name="gud-go.patch" Content-Disposition: attachment; filename="gud-go.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lk0nw5ct0 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2dkYi1taS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dk Yi1taS5lbAppbmRleCAxOTliZTMzMThhMS4uZTgxYzE0NTJjNTUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2dkYi1taS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nZGItbWkuZWwKQEAgLTk4 NywxNCArOTg3LDE0IEBAIGdkYgogCSAgICJcQy11IiAiQ29udGludWUgdG8gY3VycmVudCBsaW5l IG9yIGFkZHJlc3MuIikKICAgKGd1ZC1kZWYKICAgIGd1ZC1nbyAocHJvZ24KLSAgICAgICAgICAg ICh3aGVuIGFyZworICAgICAgICAgICAgKHdoZW4gKC89IGFyZyAxKQogICAgICAgICAgICAgICAo Z3VkLWNhbGwgKGNvbmNhdCAiLWV4ZWMtYXJndW1lbnRzICIKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKHJlYWQtc3RyaW5nICJBcmd1bWVudHMgdG8gZXhlYy1ydW46ICIpKSkpCiAg ICAgICAgICAgICAoZ3VkLWNhbGwKICAgICAgICAgICAgICAoaWYgZ2RiLWFjdGl2ZS1wcm9jZXNz CiAgICAgICAgICAgICAgICAgIChnZGItZ3VkLWNvbnRleHQtY29tbWFuZCAiLWV4ZWMtY29udGlu dWUiKQogICAgICAgICAgICAgICAgIi1leGVjLXJ1biIpKSkKLSAgICJcQy12IiAiU3RhcnQgb3Ig Y29udGludWUgZXhlY3V0aW9uLiAgVXNlIGEgcHJlZml4IHRvIHNwZWNpZnkgYXJndW1lbnRzLiIp CisgICAiXEMtdiIgIlN0YXJ0IG9yIGNvbnRpbnVlIGV4ZWN1dGlvbi4gIFVzZSBhIHByZWZpeCBv dGhlciB0aGFuIDEgdG8gc3BlY2lmeSBhcmd1bWVudHMuIikKIAogICA7OyBGb3IgZGVidWdnaW5n IEVtYWNzIG9ubHkuCiAgIChndWQtZGVmIGd1ZC1wcAo= --0000000000007cff58060056e2d0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 13 04:58:39 2023 Received: (at 64590) by debbugs.gnu.org; 13 Jul 2023 08:58:39 +0000 Received: from localhost ([127.0.0.1]:53382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJs9m-0003kt-Sz for submit@debbugs.gnu.org; Thu, 13 Jul 2023 04:58:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJs9k-0003kd-N0 for 64590@debbugs.gnu.org; Thu, 13 Jul 2023 04:58:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJs9f-0001xQ-B1; Thu, 13 Jul 2023 04:58:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ozb9r6QL/3xAUfNlqJQGi7Fiem2NOul8GjvtJH0+cAg=; b=A0IsjDVl4ydu hT5wGZWzQ1xIMlLoARymOPMquIn4wjQKNZAdEdRjV0UiPRDkJjQokNnBxs5lL3XoKaGRYH5unbL2R LRVocsGdmTgbirUx5+NMKhn1OFB48h1PWE1D20fMGKdAjdEVlp0SXmV67UvmVO3Cc99ZtuDM/75Vd Xxj8TV4SCm5IlKcbJ9MxOeg0E492nGtbJ/W/YesvK7SnodI+75yV9cSw8Lq+9oIq6/uHmZwRXazUH gVeFFdtB3ceZ6+W0R5AakeGgHx5o1s0hkbd7QcxMQwlpfgzO34M8UyejboudTht9+LOaqDvOlVBj2 Drlsqu6nfl5mkFyhFIhC/g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJs9c-0002xF-IX; Thu, 13 Jul 2023 04:58:31 -0400 Date: Thu, 13 Jul 2023 11:58:37 +0300 Message-Id: <834jm85gsi.fsf@gnu.org> From: Eli Zaretskii To: Wang Diancheng In-Reply-To: (message from Wang Diancheng on Thu, 13 Jul 2023 12:40:58 +0800) Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64590 Cc: 64590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Wang Diancheng > Date: Thu, 13 Jul 2023 12:40:58 +0800 > > document of gud-go says "Start or continue execution. Use a prefix to > specify arguments." but it always prompts for program arguments > regardless of whether "C-u" is pressed because arg is numeric prefix > here. Right, gud-def specifies '(interactive "p")'. > The attachment is a patch to change gud-go just prompts if > prefix is not 1. This will have the subtlety that "C-u 1 C-v" will fail to ask for program arguments. Shouldn't we instead look at current-prefix-arg? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 13 23:02:53 2023 Received: (at 64590) by debbugs.gnu.org; 14 Jul 2023 03:02:54 +0000 Received: from localhost ([127.0.0.1]:41178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK953-0004eR-Iy for submit@debbugs.gnu.org; Thu, 13 Jul 2023 23:02:53 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:55766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK94y-0004e4-Bw for 64590@debbugs.gnu.org; Thu, 13 Jul 2023 23:02:52 -0400 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b6f0508f54so21428631fa.3 for <64590@debbugs.gnu.org>; Thu, 13 Jul 2023 20:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689303761; x=1691895761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8Fd5ZVegXFV1dFBcN9a2OoKRqjBfgShQW4f/J1MlRG4=; b=Qt96MXxN3NUJ5qR8dSojKGt5uWufblvcpCNp7fvT+Owq+BDxjt4wbShTfxpxtj4t2k jw08rkxUjVorkGDCOxmLWl6lCaQ08OrIIEBZl1ZU+vvYhZGDLEc3VgsIyqRGIAFMd8T9 C32tlsVBhWLsMiPumZ2/0fxEHnvoAiY9y2izbPw3pzOrjVs/qB53xZtwQjX5ztFTeWWG GtgWKUuxlmmOCJjTaeTOlorniV1I+adDWxB9yCfVccSOFpHsm+lhUNcAIIZjOyebqa37 EMYclUAda52PJ0GePnoBKnveAnPnq78fh0UJYnfE2qjQ9K4LIbKnYfNoeWH/+tX52mDi nLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689303761; x=1691895761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Fd5ZVegXFV1dFBcN9a2OoKRqjBfgShQW4f/J1MlRG4=; b=TP8DbXFkn//zfNrRWo9L8s5Xn2b/IUVvWz8QpTe8qzG5W4PnrH0/rEfhyI6+ttYvZu sJnWSpaeokiSrkoe2WR/8cJYnTCEbQQomL/6J0OY/ZpUlvKoWIfsHsf4CbgAbyIYNDfm K9JQy+mtULnO/IHmxrMqPBnsZFXcm/gL+s5k9GywP0xVq9bLkIPFVbJ2mzwmM7vflz+D gPwiGRLg1VzwAoULacfaMrw8U+Cn8jRp+rl3pOB4AEIkfJaS484SOSB6DfD71HrovPsV vOcPlWaECq7qpa+blLtpioIBDmND0yJ3UJtg0OwNvhXOaytQ/kfZFBsrEGsPbRDdcOxm ongg== X-Gm-Message-State: ABy/qLbJhAY8FtHn8rdTm31cbyg4rHPV63jR8Pie0DrZtZcIQX2xo8lN KHgb1pmWwCSk86b6GhLY58dn+7/Rld0GwQeMXdg= X-Google-Smtp-Source: APBJJlGaLktUiTjreGnQlbgB+UhVT8HZI1DtMKvm67CJPRiMnkMLTBHMAf7PFAh32jwXRBf3XwMKQ0Rxmn7bKWbhL2k= X-Received: by 2002:a05:651c:d6:b0:2b7:310:65da with SMTP id 22-20020a05651c00d600b002b7031065damr2879647ljr.24.1689303760826; Thu, 13 Jul 2023 20:02:40 -0700 (PDT) MIME-Version: 1.0 References: <834jm85gsi.fsf@gnu.org> In-Reply-To: <834jm85gsi.fsf@gnu.org> From: Wang Diancheng Date: Fri, 14 Jul 2023 11:06:32 +0800 Message-ID: Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000950915060069ae37" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64590 Cc: 64590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000950915060069ae37 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii =E4=BA=8E2023=E5=B9=B47=E6=9C=8813=E6=97=A5=E5= =91=A8=E5=9B=9B 16:58=E5=86=99=E9=81=93=EF=BC=9A > > > From: Wang Diancheng > > Date: Thu, 13 Jul 2023 12:40:58 +0800 > > > > document of gud-go says "Start or continue execution. Use a prefix to > > specify arguments." but it always prompts for program arguments > > regardless of whether "C-u" is pressed because arg is numeric prefix > > here. > > Right, gud-def specifies '(interactive "p")'. > > > The attachment is a patch to change gud-go just prompts if > > prefix is not 1. > > This will have the subtlety that "C-u 1 C-v" will fail to ask for > program arguments. Shouldn't we instead look at current-prefix-arg? > Thanks. Yes, I think it's a good idea. the patch is updated as that. > Thanks. --000000000000950915060069ae37 Content-Type: text/x-patch; charset="US-ASCII"; name="gud-go-v2.patch" Content-Disposition: attachment; filename="gud-go-v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lk1zy0be0 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2dkYi1taS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dk Yi1taS5lbAppbmRleCAxOTliZTMzMThhMS4uYTEwOTFkZTQzZTkgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2dkYi1taS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nZGItbWkuZWwKQEAgLTk4 Nyw3ICs5ODcsNyBAQCBnZGIKIAkgICAiXEMtdSIgIkNvbnRpbnVlIHRvIGN1cnJlbnQgbGluZSBv ciBhZGRyZXNzLiIpCiAgIChndWQtZGVmCiAgICBndWQtZ28gKHByb2duCi0gICAgICAgICAgICAo d2hlbiBhcmcKKyAgICAgICAgICAgICh3aGVuIChhbmQgY3VycmVudC1wcmVmaXgtYXJnIGFyZykK ICAgICAgICAgICAgICAgKGd1ZC1jYWxsIChjb25jYXQgIi1leGVjLWFyZ3VtZW50cyAiCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZWFkLXN0cmluZyAiQXJndW1lbnRzIHRvIGV4 ZWMtcnVuOiAiKSkpKQogICAgICAgICAgICAgKGd1ZC1jYWxsCg== --000000000000950915060069ae37-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 04:42:22 2023 Received: (at 64590-done) by debbugs.gnu.org; 15 Jul 2023 08:42:22 +0000 Received: from localhost ([127.0.0.1]:44102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKar7-0002z5-UT for submit@debbugs.gnu.org; Sat, 15 Jul 2023 04:42:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKar6-0002yt-AD for 64590-done@debbugs.gnu.org; Sat, 15 Jul 2023 04:42:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKar1-000451-3L; Sat, 15 Jul 2023 04:42:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DD6/SFodJ/el17yWuqPA/I0TBhiRKdzHHy/KyrkUoRQ=; b=fpurdTCBDG8cp9D3BFRo lxk2jirPnKyrX9Xm2buMGyDJCiL/9xzGvsOlkEu1du5Y8L7EI0LNs3ZOWatNmoUL4ULULCrLQ/Tx0 a3vZBYAU+rT6oIB8jsJx+RZ4rxGn+wbOqdvHOQRSlFzZr/IX1NORqAEXlL85KQSObIUf+RlhSJGhl tvsPwgENgayHNPKCw7N4HpmmY5G/FYBenMpOQr8TZ0nQJ8pFrFcgQfC5BMwt5ebHiaojmpCzDpXzh sZ6fAoqry+qwSUfT1UObyKuAkb7y1M4EGMJ8TFBDtXqN4r6BiAZax9du7+Ag2tVW7Pk5/ssqMtSb9 0ckq7NEzFYToHw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKar0-0007VJ-B9; Sat, 15 Jul 2023 04:42:14 -0400 Date: Sat, 15 Jul 2023 11:42:36 +0300 Message-Id: <83lefhd0qr.fsf@gnu.org> From: Eli Zaretskii To: Wang Diancheng In-Reply-To: (message from Wang Diancheng on Fri, 14 Jul 2023 11:06:32 +0800) Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el References: <834jm85gsi.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64590-done Cc: 64590-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Wang Diancheng > Date: Fri, 14 Jul 2023 11:06:32 +0800 > Cc: 64590@debbugs.gnu.org > > Eli Zaretskii 于2023年7月13日周四 16:58写道： > > > > > From: Wang Diancheng > > > Date: Thu, 13 Jul 2023 12:40:58 +0800 > > > > > > document of gud-go says "Start or continue execution. Use a prefix to > > > specify arguments." but it always prompts for program arguments > > > regardless of whether "C-u" is pressed because arg is numeric prefix > > > here. > > > > Right, gud-def specifies '(interactive "p")'. > > > > > The attachment is a patch to change gud-go just prompts if > > > prefix is not 1. > > > > This will have the subtlety that "C-u 1 C-v" will fail to ask for > > program arguments. Shouldn't we instead look at current-prefix-arg? > > > > Thanks. > > Yes, I think it's a good idea. the patch is updated as that. Thanks, installed on the emacs-29 branch, and closing the bug. With this contribution, you have exhausted the amount of changes we can accept from you without a copyright assignment. Would you like to start the legal paperwork of assigning to the FSF the copyright for your changes, so that we could in the future accept more contributions from you without limitations? If yes, I will send you the form to fill. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 05:03:34 2023 Received: (at 64590-done) by debbugs.gnu.org; 17 Jul 2023 09:03:34 +0000 Received: from localhost ([127.0.0.1]:49073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLK8k-0001Cy-BL for submit@debbugs.gnu.org; Mon, 17 Jul 2023 05:03:34 -0400 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:58776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLK8i-0001Cl-Ov for 64590-done@debbugs.gnu.org; Mon, 17 Jul 2023 05:03:33 -0400 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b93fba1f62so11317761fa.1 for <64590-done@debbugs.gnu.org>; Mon, 17 Jul 2023 02:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689584607; x=1692176607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h0umwQaR0lzJ1wb5xFPSqkhFQGAYMNYNboo7RMwnFbE=; b=ex7zj2GRqVoa6sNC0IBcvcbxSDKPeukFeX7i4fEV/iiiqTvwSzf4pYh/v+6aiHFW0/ 9lALm76Rs6b+e9u9SVG66nFNpf3tUD8e29VktFLpD+yjYTS3adK1/mJT4xi1J41dQ4Yx cAE6oxTJQOslK/GZWd4752GYESanivj8rVRGyOlEPd7yz9AcJivTgIbaYIznMjRSQd2/ xMzktQ7itLqgNFHPYK/PDbjYafHozF7Lo9bIj+Br/455FiiM/0WauLdKI2dE0pZA5VID nMryxSQf3VZOyz2x/STR2IFXBm/wub641YzY/652xdZ/fJl1DS3fp5qZ0D8HI9lD+XcX vp3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689584607; x=1692176607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h0umwQaR0lzJ1wb5xFPSqkhFQGAYMNYNboo7RMwnFbE=; b=MVrH6SBJOSJ1rUUg9B3bWedONmJYjZ1vgGo2C0b67bmZx/5UvpaGw1GEqoCCg9Rqg1 0Mb/jb5dTu4tOk8q/Y8OYoaRZzDhBx2isvYKHfCcs4lGtnBw1OQg53zZ4rKQd0XYB8gg zEOlTxFFaWZYq/6DtT5sfpamfOce5gLf/fhwKBfzYnwVUe3O/xiwUx4uNYqu5IQO+by3 0XoIbnevHaX1qHpEGTgZGd3JUasCRuR9v07FqHoAJOsTUkDtopagPRIFAfp5l53ZE12I 8hccIwrtFdIFMUrxMKFsvFJkj9hbRVdQ06GOeVBMQtij4GHgvbUl33k+K5Dcw2A3YyW/ ypFw== X-Gm-Message-State: ABy/qLZrhG0GpNhX0mvzE+/B2bXxKzbKLXfa6xNdkvMTkQnqEP/t5Saz 8sZf35+ExHWB9Z1EMEj7ZBri7e8/7jSljJpqYSSrnvarf3a8yw== X-Google-Smtp-Source: APBJJlFKY7GhkSm7WyZmzZn3GRGR7W/hiwvR1X0blNlqWKd/l+9KOBZncc/jpgpZyy3Hh+dePldg6ziR845EnvF+hVs= X-Received: by 2002:a2e:9992:0:b0:2b6:d77b:92b8 with SMTP id w18-20020a2e9992000000b002b6d77b92b8mr7667568lji.16.1689584606269; Mon, 17 Jul 2023 02:03:26 -0700 (PDT) MIME-Version: 1.0 References: <834jm85gsi.fsf@gnu.org> <83lefhd0qr.fsf@gnu.org> In-Reply-To: <83lefhd0qr.fsf@gnu.org> From: Wang Diancheng Date: Mon, 17 Jul 2023 17:07:18 +0800 Message-ID: Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64590-done Cc: 64590-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii =E4=BA=8E2023=E5=B9=B47=E6=9C=8815=E6=97=A5=E5= =91=A8=E5=85=AD 16:42=E5=86=99=E9=81=93=EF=BC=9A > > > From: Wang Diancheng > > Date: Fri, 14 Jul 2023 11:06:32 +0800 > > Cc: 64590@debbugs.gnu.org > > > > Eli Zaretskii =E4=BA=8E2023=E5=B9=B47=E6=9C=8813=E6=97= =A5=E5=91=A8=E5=9B=9B 16:58=E5=86=99=E9=81=93=EF=BC=9A > > > > > > > From: Wang Diancheng > > > > Date: Thu, 13 Jul 2023 12:40:58 +0800 > > > > > > > > document of gud-go says "Start or continue execution. Use a prefix= to > > > > specify arguments." but it always prompts for program arguments > > > > regardless of whether "C-u" is pressed because arg is numeric prefi= x > > > > here. > > > > > > Right, gud-def specifies '(interactive "p")'. > > > > > > > The attachment is a patch to change gud-go just prompts if > > > > prefix is not 1. > > > > > > This will have the subtlety that "C-u 1 C-v" will fail to ask for > > > program arguments. Shouldn't we instead look at current-prefix-arg? > > > > > > > Thanks. > > > > Yes, I think it's a good idea. the patch is updated as that. > > Thanks, installed on the emacs-29 branch, and closing the bug. > Thanks. > With this contribution, you have exhausted the amount of changes we > can accept from you without a copyright assignment. Would you like to > start the legal paperwork of assigning to the FSF the copyright for > your changes, so that we could in the future accept more contributions > from you without limitations? If yes, I will send you the form to > fill. My copyright assignment has been in progress. From unknown Fri Sep 05 08:20:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Aug 2023 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator