GNU bug report logs - #64590
Patch: fix gud-go in gdb-mi.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64590 in the body.
You can then email your comments to 64590 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wang Diancheng <dianchengwang <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Patch: fix gud-go in gdb-mi.el
Date: Thu, 13 Jul 2023 12:40:58 +0800

[Message part 1 (text/plain, inline)]

Hi,
document of gud-go says "Start or continue execution.  Use a prefix to
specify arguments." but it always prompts for program arguments
regardless of whether "C-u" is pressed because arg is numeric prefix
here. The attachment is a patch to change gud-go just prompts if
prefix is not 1.

[gud-go.patch (text/x-patch, attachment)]

Message #8 received at 64590 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wang Diancheng <dianchengwang <at> gmail.com>
Cc: 64590 <at> debbugs.gnu.org
Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el
Date: Thu, 13 Jul 2023 11:58:37 +0300

> From: Wang Diancheng <dianchengwang <at> gmail.com>
> Date: Thu, 13 Jul 2023 12:40:58 +0800
> 
> document of gud-go says "Start or continue execution.  Use a prefix to
> specify arguments." but it always prompts for program arguments
> regardless of whether "C-u" is pressed because arg is numeric prefix
> here.

Right, gud-def specifies '(interactive "p")'.

> The attachment is a patch to change gud-go just prompts if
> prefix is not 1.

This will have the subtlety that "C-u 1 C-v" will fail to ask for
program arguments.  Shouldn't we instead look at current-prefix-arg?

Thanks.

Message #11 received at 64590 <at> debbugs.gnu.org (full text, mbox):

From: Wang Diancheng <dianchengwang <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64590 <at> debbugs.gnu.org
Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el
Date: Fri, 14 Jul 2023 11:06:32 +0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> 于2023年7月13日周四 16:58写道：
>
> > From: Wang Diancheng <dianchengwang <at> gmail.com>
> > Date: Thu, 13 Jul 2023 12:40:58 +0800
> >
> > document of gud-go says "Start or continue execution.  Use a prefix to
> > specify arguments." but it always prompts for program arguments
> > regardless of whether "C-u" is pressed because arg is numeric prefix
> > here.
>
> Right, gud-def specifies '(interactive "p")'.
>
> > The attachment is a patch to change gud-go just prompts if
> > prefix is not 1.
>
> This will have the subtlety that "C-u 1 C-v" will fail to ask for
> program arguments.  Shouldn't we instead look at current-prefix-arg?
>

Thanks.

Yes, I think it's a good idea. the patch is updated as that.

> Thanks.

[gud-go-v2.patch (text/x-patch, attachment)]

Message #16 received at 64590-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wang Diancheng <dianchengwang <at> gmail.com>
Cc: 64590-done <at> debbugs.gnu.org
Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el
Date: Sat, 15 Jul 2023 11:42:36 +0300

> From: Wang Diancheng <dianchengwang <at> gmail.com>
> Date: Fri, 14 Jul 2023 11:06:32 +0800
> Cc: 64590 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz <at> gnu.org> 于2023年7月13日周四 16:58写道：
> >
> > > From: Wang Diancheng <dianchengwang <at> gmail.com>
> > > Date: Thu, 13 Jul 2023 12:40:58 +0800
> > >
> > > document of gud-go says "Start or continue execution.  Use a prefix to
> > > specify arguments." but it always prompts for program arguments
> > > regardless of whether "C-u" is pressed because arg is numeric prefix
> > > here.
> >
> > Right, gud-def specifies '(interactive "p")'.
> >
> > > The attachment is a patch to change gud-go just prompts if
> > > prefix is not 1.
> >
> > This will have the subtlety that "C-u 1 C-v" will fail to ask for
> > program arguments.  Shouldn't we instead look at current-prefix-arg?
> >
> 
> Thanks.
> 
> Yes, I think it's a good idea. the patch is updated as that.

Thanks, installed on the emacs-29 branch, and closing the bug.

With this contribution, you have exhausted the amount of changes we
can accept from you without a copyright assignment.  Would you like to
start the legal paperwork of assigning to the FSF the copyright for
your changes, so that we could in the future accept more contributions
from you without limitations?  If yes, I will send you the form to
fill.

Message #19 received at 64590-done <at> debbugs.gnu.org (full text, mbox):

From: Wang Diancheng <dianchengwang <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64590-done <at> debbugs.gnu.org
Subject: Re: bug#64590: Patch: fix gud-go in gdb-mi.el
Date: Mon, 17 Jul 2023 17:07:18 +0800

Eli Zaretskii <eliz <at> gnu.org> 于2023年7月15日周六 16:42写道：
>
> > From: Wang Diancheng <dianchengwang <at> gmail.com>
> > Date: Fri, 14 Jul 2023 11:06:32 +0800
> > Cc: 64590 <at> debbugs.gnu.org
> >
> > Eli Zaretskii <eliz <at> gnu.org> 于2023年7月13日周四 16:58写道：
> > >
> > > > From: Wang Diancheng <dianchengwang <at> gmail.com>
> > > > Date: Thu, 13 Jul 2023 12:40:58 +0800
> > > >
> > > > document of gud-go says "Start or continue execution.  Use a prefix to
> > > > specify arguments." but it always prompts for program arguments
> > > > regardless of whether "C-u" is pressed because arg is numeric prefix
> > > > here.
> > >
> > > Right, gud-def specifies '(interactive "p")'.
> > >
> > > > The attachment is a patch to change gud-go just prompts if
> > > > prefix is not 1.
> > >
> > > This will have the subtlety that "C-u 1 C-v" will fail to ask for
> > > program arguments.  Shouldn't we instead look at current-prefix-arg?
> > >
> >
> > Thanks.
> >
> > Yes, I think it's a good idea. the patch is updated as that.
>
> Thanks, installed on the emacs-29 branch, and closing the bug.
>

Thanks.

> With this contribution, you have exhausted the amount of changes we
> can accept from you without a copyright assignment.  Would you like to
> start the legal paperwork of assigning to the FSF the copyright for
> your changes, so that we could in the future accept more contributions
> from you without limitations?  If yes, I will send you the form to
> fill.

My copyright assignment has been in progress.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.